Re: Review Request 60200: GEODE-3095: fix parameter type mismatch between the diskstore command and controller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60200/#review178313 --- Ship it! Ship It! - Ken Howe On June 19, 2017, 9:45 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60200/ > --- > > (Updated June 19, 2017, 9:45 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-3095: fix parameter type mismatch between the diskstore command and > controller > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/DiskStoreCommandsController.java > c613a8a1d5cca93ce7be785b58f6502d96752d8c > > geode-core/src/test/java/org/apache/geode/management/internal/security/TestCommand.java > ea4b60d4ec72def55129706d7e4d8f297d87ddcb > > > Diff: https://reviews.apache.org/r/60200/diff/3/ > > > Testing > --- > > GfshCommandOverHttpTest, GfshSecurityCommandOverHttpTest > > > Thanks, > > Jinmei Liao > >
Re: Review Request 60200: GEODE-3095: fix parameter type mismatch between the diskstore command and controller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60200/#review178306 --- Ship it! Ship It! - Emily Yeh On June 19, 2017, 9:12 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60200/ > --- > > (Updated June 19, 2017, 9:12 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-3095: fix parameter type mismatch between the diskstore command and > controller > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/DiskStoreCommandsController.java > c613a8a1d5cca93ce7be785b58f6502d96752d8c > > geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CreateDiskStoreOverHttpTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60200/diff/2/ > > > Testing > --- > > GfshCommandOverHttpTest, GfshSecurityCommandOverHttpTest > > > Thanks, > > Jinmei Liao > >
Re: Review Request 60200: GEODE-3095: fix parameter type mismatch between the diskstore command and controller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60200/#review178305 --- Ship it! Ship It! - Ken Howe On June 19, 2017, 9:12 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60200/ > --- > > (Updated June 19, 2017, 9:12 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-3095: fix parameter type mismatch between the diskstore command and > controller > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/DiskStoreCommandsController.java > c613a8a1d5cca93ce7be785b58f6502d96752d8c > > geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CreateDiskStoreOverHttpTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60200/diff/2/ > > > Testing > --- > > GfshCommandOverHttpTest, GfshSecurityCommandOverHttpTest > > > Thanks, > > Jinmei Liao > >
Re: Review Request 60200: GEODE-3095: fix parameter type mismatch between the diskstore command and controller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60200/ --- (Updated June 19, 2017, 9:12 p.m.) Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg. Changes --- add an integration test Repository: geode Description --- GEODE-3095: fix parameter type mismatch between the diskstore command and controller Diffs (updated) - geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/DiskStoreCommandsController.java c613a8a1d5cca93ce7be785b58f6502d96752d8c geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CreateDiskStoreOverHttpTest.java PRE-CREATION Diff: https://reviews.apache.org/r/60200/diff/2/ Changes: https://reviews.apache.org/r/60200/diff/1-2/ Testing --- GfshCommandOverHttpTest, GfshSecurityCommandOverHttpTest Thanks, Jinmei Liao
Re: Review Request 60200: GEODE-3095: fix parameter type mismatch between the diskstore command and controller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60200/#review178295 --- Ship it! Ship It! - Patrick Rhomberg On June 19, 2017, 6:04 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60200/ > --- > > (Updated June 19, 2017, 6:04 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-3095: fix parameter type mismatch between the diskstore command and > controller > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/DiskStoreCommandsController.java > c613a8a1d5cca93ce7be785b58f6502d96752d8c > > > Diff: https://reviews.apache.org/r/60200/diff/1/ > > > Testing > --- > > GfshCommandOverHttpTest, GfshSecurityCommandOverHttpTest > > > Thanks, > > Jinmei Liao > >
Review Request 60200: GEODE-3095: fix parameter type mismatch between the diskstore command and controller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60200/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg. Repository: geode Description --- GEODE-3095: fix parameter type mismatch between the diskstore command and controller Diffs - geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/DiskStoreCommandsController.java c613a8a1d5cca93ce7be785b58f6502d96752d8c Diff: https://reviews.apache.org/r/60200/diff/1/ Testing --- GfshCommandOverHttpTest, GfshSecurityCommandOverHttpTest Thanks, Jinmei Liao
