Re: Review Request 60924: GEODE-2920: added security tests for create diskstore and create persistent region.

[Patrick Rhomberg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60924/#review181380
---




geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java
Lines 135-152 (original), 129-145 (patched)


After the last few weeks, I agree that soft assertions were not a great 
choice when this was written.  On the other hand, we're still far from a 
single-assertion test here.

Maybe this would be a good test to try to use `@Parameterized`, to try to 
reach that one assertion per test ideal?


- Patrick Rhomberg


On July 17, 2017, 9:39 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60924/
> ---
> 
> (Updated July 17, 2017, 9:39 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2920: handle non-existent role in ExampleSecurityManager
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java
>  c1d7ebfa017ccc627e7d4da6db951d3f61e2461b 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java
>  c2be173f8844bcf25361edc9e5d428f62aa8761f 
>   
> geode-core/src/test/java/org/apache/geode/security/ExampleSecurityManagerTest.java
>  9093a7bc70835ae50c72a80739a3f8ab4789cacd 
>   
> geode-core/src/test/resources/org/apache/geode/security/templates/security.json
>  c1ee9fc22bad58642d814c5930eb2d02810dad0e 
> 
> 
> Diff: https://reviews.apache.org/r/60924/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 60924: GEODE-2920: added security tests for create diskstore and create persistent region.

[Emily Yeh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60924/#review181274
---


Ship it!




Ship It!

- Emily Yeh


On July 17, 2017, 9:39 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60924/
> ---
> 
> (Updated July 17, 2017, 9:39 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2920: handle non-existent role in ExampleSecurityManager
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java
>  c1d7ebfa017ccc627e7d4da6db951d3f61e2461b 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java
>  c2be173f8844bcf25361edc9e5d428f62aa8761f 
>   
> geode-core/src/test/java/org/apache/geode/security/ExampleSecurityManagerTest.java
>  9093a7bc70835ae50c72a80739a3f8ab4789cacd 
>   
> geode-core/src/test/resources/org/apache/geode/security/templates/security.json
>  c1ee9fc22bad58642d814c5930eb2d02810dad0e 
> 
> 
> Diff: https://reviews.apache.org/r/60924/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 60924: GEODE-2920: added security tests for create diskstore and create persistent region.

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60924/#review180938
---


Ship it!




+1

- Kirk Lund


On July 17, 2017, 9:39 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60924/
> ---
> 
> (Updated July 17, 2017, 9:39 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2920: handle non-existent role in ExampleSecurityManager
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java
>  c1d7ebfa017ccc627e7d4da6db951d3f61e2461b 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java
>  c2be173f8844bcf25361edc9e5d428f62aa8761f 
>   
> geode-core/src/test/java/org/apache/geode/security/ExampleSecurityManagerTest.java
>  9093a7bc70835ae50c72a80739a3f8ab4789cacd 
>   
> geode-core/src/test/resources/org/apache/geode/security/templates/security.json
>  c1ee9fc22bad58642d814c5930eb2d02810dad0e 
> 
> 
> Diff: https://reviews.apache.org/r/60924/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Review Request 60924: GEODE-2920: added security tests for create diskstore and create persistent region.

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60924/
---

Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

GEODE-2920: handle non-existent role in ExampleSecurityManager


Diffs
-

  
geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java
 c1d7ebfa017ccc627e7d4da6db951d3f61e2461b 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java
 c2be173f8844bcf25361edc9e5d428f62aa8761f 
  
geode-core/src/test/java/org/apache/geode/security/ExampleSecurityManagerTest.java
 9093a7bc70835ae50c72a80739a3f8ab4789cacd 
  
geode-core/src/test/resources/org/apache/geode/security/templates/security.json 
c1ee9fc22bad58642d814c5930eb2d02810dad0e 


Diff: https://reviews.apache.org/r/60924/diff/1/


Testing
---

precheckin running


Thanks,

Jinmei Liao