Re: Review Request 61627: GEODE-3437: Fix list and describe region tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61627/ --- (Updated Aug. 16, 2017, 8:44 p.m.) Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg. Changes --- Safe copy for locator props as well as server props Repository: geode Description --- GEODE-3437: Fix list and describe region tests Diffs (updated) - geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java ab8c69b geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java fc7966f Diff: https://reviews.apache.org/r/61627/diff/3/ Changes: https://reviews.apache.org/r/61627/diff/2-3/ Testing --- Precheckin running Thanks, Jared Stewart
Re: Review Request 61627: GEODE-3437: Fix list and describe region tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61627/#review183046 --- Ship it! Ship It! - Patrick Rhomberg On Aug. 16, 2017, 5:24 p.m., Jared Stewart wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61627/ > --- > > (Updated Aug. 16, 2017, 5:24 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-3437: Fix list and describe region tests > > > Diffs > - > > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java > ab8c69b > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > fc7966f > > > Diff: https://reviews.apache.org/r/61627/diff/2/ > > > Testing > --- > > Precheckin running > > > Thanks, > > Jared Stewart > >
Re: Review Request 61627: GEODE-3437: Fix list and describe region tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61627/#review183042 --- Ship it! Ship It! - Ken Howe On Aug. 16, 2017, 5:24 p.m., Jared Stewart wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61627/ > --- > > (Updated Aug. 16, 2017, 5:24 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-3437: Fix list and describe region tests > > > Diffs > - > > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java > ab8c69b > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > fc7966f > > > Diff: https://reviews.apache.org/r/61627/diff/2/ > > > Testing > --- > > Precheckin running > > > Thanks, > > Jared Stewart > >
Re: Review Request 61627: GEODE-3437: Fix list and describe region tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61627/ --- (Updated Aug. 16, 2017, 5:24 p.m.) Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg. Changes --- Safe copy of Properties before we add to it Repository: geode Description --- GEODE-3437: Fix list and describe region tests Diffs (updated) - geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java ab8c69b geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java fc7966f Diff: https://reviews.apache.org/r/61627/diff/2/ Changes: https://reviews.apache.org/r/61627/diff/1-2/ Testing --- Precheckin running Thanks, Jared Stewart
Re: Review Request 61627: GEODE-3437: Fix list and describe region tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61627/#review183037 --- Ship it! Ship It! - Ken Howe On Aug. 14, 2017, 10:40 p.m., Jared Stewart wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61627/ > --- > > (Updated Aug. 14, 2017, 10:40 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-3437: Fix list and describe region tests > > > Diffs > - > > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java > ab8c69b7cc99c88dd4e928efeb441d7d1a1d9b1b > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > fc7966f5eb2a9ca4c30369a20ce664d3929ecc22 > > > Diff: https://reviews.apache.org/r/61627/diff/1/ > > > Testing > --- > > Precheckin running > > > Thanks, > > Jared Stewart > >
Re: Review Request 61627: GEODE-3437: Fix list and describe region tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61627/#review183007 --- Ship it! Ship It! - Kirk Lund On Aug. 14, 2017, 10:40 p.m., Jared Stewart wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61627/ > --- > > (Updated Aug. 14, 2017, 10:40 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-3437: Fix list and describe region tests > > > Diffs > - > > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java > ab8c69b7cc99c88dd4e928efeb441d7d1a1d9b1b > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > fc7966f5eb2a9ca4c30369a20ce664d3929ecc22 > > > Diff: https://reviews.apache.org/r/61627/diff/1/ > > > Testing > --- > > Precheckin running > > > Thanks, > > Jared Stewart > >
Review Request 61627: GEODE-3437: Fix list and describe region tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61627/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg. Repository: geode Description --- GEODE-3437: Fix list and describe region tests Diffs - geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java ab8c69b7cc99c88dd4e928efeb441d7d1a1d9b1b geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java fc7966f5eb2a9ca4c30369a20ce664d3929ecc22 Diff: https://reviews.apache.org/r/61627/diff/1/ Testing --- Precheckin running Thanks, Jared Stewart
