Re: Review Request 61802: GEODE-3445: Add gfsh connect option --skip-ssl-validation

2017-08-21 Thread Jared Stewart

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61802/
---

(Updated Aug. 21, 2017, 10:09 p.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Changes
---

Update help text


Repository: geode


Description
---

GEODE-3445: Add gfsh connect option --skip-ssl-validation


Diffs (updated)
-

  
geode-assembly/src/test/java/org/apache/geode/management/GfshConnectToLocatorWithSSLAcceptanceTest.java
 PRE-CREATION 
  
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java
 fa25f14 
  
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshScript.java
 52ef0d3 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java
 274f61c 


Diff: https://reviews.apache.org/r/61802/diff/2/

Changes: https://reviews.apache.org/r/61802/diff/1-2/


Testing
---

Precheckin running


Thanks,

Jared Stewart



Re: Review Request 61802: GEODE-3445: Add gfsh connect option --skip-ssl-validation

2017-08-21 Thread Kirk Lund

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61802/#review183398
---


Ship it!




Ship It!

- Kirk Lund


On Aug. 21, 2017, 9:06 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61802/
> ---
> 
> (Updated Aug. 21, 2017, 9:06 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3445: Add gfsh connect option --skip-ssl-validation
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/management/GfshConnectToLocatorWithSSLAcceptanceTest.java
>  PRE-CREATION 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java
>  fa25f14328d2cc56b2e0b64d834ed88dde082e8f 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshScript.java
>  52ef0d35a176c6522664eb18449d1c4b635f16a6 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java
>  274f61c1f304576f8d8db1d5289875ecea706962 
> 
> 
> Diff: https://reviews.apache.org/r/61802/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>



Review Request 61802: GEODE-3445: Add gfsh connect option --skip-ssl-validation

2017-08-21 Thread Jared Stewart

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61802/
---

Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

GEODE-3445: Add gfsh connect option --skip-ssl-validation


Diffs
-

  
geode-assembly/src/test/java/org/apache/geode/management/GfshConnectToLocatorWithSSLAcceptanceTest.java
 PRE-CREATION 
  
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java
 fa25f14328d2cc56b2e0b64d834ed88dde082e8f 
  
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshScript.java
 52ef0d35a176c6522664eb18449d1c4b635f16a6 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java
 274f61c1f304576f8d8db1d5289875ecea706962 


Diff: https://reviews.apache.org/r/61802/diff/1/


Testing
---

Precheckin running


Thanks,

Jared Stewart