Re: Review Request 61974: GEODE-2859: Fix race condition in ShowDeadlockDUnitTest
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61974/#review184151 --- Ship it! Ship It! - Ken Howe On Aug. 29, 2017, 10:46 p.m., Jared Stewart wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61974/ > --- > > (Updated Aug. 29, 2017, 10:46 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, > and Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-2859: Fix race condition in ShowDeadlockDUnitTest > > > Diffs > - > > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowDeadlockDUnitTest.java > 4df0b96 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java > dc17d03 > geode-junit/build.gradle 7c533ad > > geode-junit/src/main/java/org/apache/geode/test/concurrent/FileBasedCountDownLatch.java > PRE-CREATION > > geode-junit/src/test/java/org/apache/geode/test/concurrent/FileBasedCountDownLatchTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/61974/diff/2/ > > > Testing > --- > > Precheckin running > > > Thanks, > > Jared Stewart > >
Re: Review Request 61974: GEODE-2859: Fix race condition in ShowDeadlockDUnitTest
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61974/ --- (Updated Aug. 29, 2017, 10:46 p.m.) Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg. Changes --- Geode-junit needs Awaitility Repository: geode Description --- GEODE-2859: Fix race condition in ShowDeadlockDUnitTest Diffs (updated) - geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowDeadlockDUnitTest.java 4df0b96 geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java dc17d03 geode-junit/build.gradle 7c533ad geode-junit/src/main/java/org/apache/geode/test/concurrent/FileBasedCountDownLatch.java PRE-CREATION geode-junit/src/test/java/org/apache/geode/test/concurrent/FileBasedCountDownLatchTest.java PRE-CREATION Diff: https://reviews.apache.org/r/61974/diff/2/ Changes: https://reviews.apache.org/r/61974/diff/1-2/ Testing --- Precheckin running Thanks, Jared Stewart
Re: Review Request 61974: GEODE-2859: Fix race condition in ShowDeadlockDUnitTest
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61974/#review184083 --- Ship it! Ship It! - Jinmei Liao On Aug. 29, 2017, 7:03 p.m., Jared Stewart wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61974/ > --- > > (Updated Aug. 29, 2017, 7:03 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, > and Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-2859: Fix race condition in ShowDeadlockDUnitTest > > > Diffs > - > > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowDeadlockDUnitTest.java > 4df0b96cb2b86e83f612b6b7d12009801c3704af > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java > dc17d036cd89ab248a7f2903647f013e6de09691 > > geode-junit/src/main/java/org/apache/geode/test/concurrent/FileBasedCountDownLatch.java > PRE-CREATION > > geode-junit/src/test/java/org/apache/geode/test/concurrent/FileBasedCountDownLatchTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/61974/diff/1/ > > > Testing > --- > > Precheckin running > > > Thanks, > > Jared Stewart > >
Review Request 61974: GEODE-2859: Fix race condition in ShowDeadlockDUnitTest
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61974/ --- Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg. Repository: geode Description --- GEODE-2859: Fix race condition in ShowDeadlockDUnitTest Diffs - geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowDeadlockDUnitTest.java 4df0b96cb2b86e83f612b6b7d12009801c3704af geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java dc17d036cd89ab248a7f2903647f013e6de09691 geode-junit/src/main/java/org/apache/geode/test/concurrent/FileBasedCountDownLatch.java PRE-CREATION geode-junit/src/test/java/org/apache/geode/test/concurrent/FileBasedCountDownLatchTest.java PRE-CREATION Diff: https://reviews.apache.org/r/61974/diff/1/ Testing --- Precheckin running Thanks, Jared Stewart
