RE: Update geode-native-build image as part of release process
Owen created a PR to automatically update the geode-native-build image ( https://github.com/apache/geode/pull/4315 ). I think it could be merged in 1.11 release branch too, so the script is used in the next release. And then I would remove the manual steps from the wiki. De: Alberto Bustamante Reyes Enviado: martes, 12 de noviembre de 2019 13:35 Para: Anthony Baker ; dev@geode.apache.org Cc: Dick Cavender Asunto: RE: Update geode-native-build image as part of release process update: It is not possible to create the geode-native-build image based on the geode image. Geode image is based on alpine, and geode-native-build needs Clang 6, which is not available yet for alpine. We will have to wait until it is released. De: Alberto Bustamante Reyes Enviado: martes, 12 de noviembre de 2019 10:30 Para: Anthony Baker ; dev@geode.apache.org Cc: Dick Cavender Asunto: RE: Update geode-native-build image as part of release process Good idea Anthony, I will investigate that. BTW, I have observed that geode/docker/Dockerfile is outdated. It is using "ENV GEODE_VERSION 1.9.0". I suspect that after the release of 1.10 the changes done in the Dockerfile were not merged back to develop, maybe the release branch was not merged back to develop. Anyway, the image tagged as 1.10.0 is using that version, so that means the promote_rc script works fine. De: Anthony Baker Enviado: lunes, 11 de noviembre de 2019 19:07 Para: dev@geode.apache.org Cc: Dick Cavender Asunto: Re: Update geode-native-build image as part of release process Thanks Alberto! Maybe as a future enhancement we should consider extending the geode-native-build image from the geode image to make this simpler. Anthony > On Nov 11, 2019, at 2:42 AM, Alberto Bustamante Reyes > wrote: > > Done! I have updated the wiki adding the steps to update the Docker image. > > https://cwiki.apache.org/confluence/display/GEODE/Releasing+Apache+Geode#ReleasingApacheGeode-Updategeode-native-buildDockerimage > > > > De: Dick Cavender > Enviado: jueves, 7 de noviembre de 2019 17:51 > Para: dev@geode.apache.org > Asunto: Re: Update geode-native-build image as part of release process > > +1 > > On Thu, Nov 7, 2019 at 8:38 AM Owen Nichols wrote: > >> +1 >> >> On Thu, Nov 7, 2019 at 6:46 AM Alberto Bustamante Reyes >> wrote: >> >>> Hi all, >>> >>> Some time ago I opened GEODE-7056 to update the Dockerfile of the >>> "geode-native-build", because I saw that it was using 1.6.0 although >> 1.9.0 >>> was available. After this change, other ticket was needed to build and >>> update the image in Dockerhub. >>> >>> I think this task (update file, build image and update image) should be >>> part of the release process. Otherwise, the image will be outdated once >>> there is a new release. And now that 1.11.0 is closer, I think its a good >>> moment to do it. >>> >>> What do you think? >>> >>> BR/ >>> >>> Alberto B. >>> >>
RE: Update geode-native-build image as part of release process
update: It is not possible to create the geode-native-build image based on the geode image. Geode image is based on alpine, and geode-native-build needs Clang 6, which is not available yet for alpine. We will have to wait until it is released. De: Alberto Bustamante Reyes Enviado: martes, 12 de noviembre de 2019 10:30 Para: Anthony Baker ; dev@geode.apache.org Cc: Dick Cavender Asunto: RE: Update geode-native-build image as part of release process Good idea Anthony, I will investigate that. BTW, I have observed that geode/docker/Dockerfile is outdated. It is using "ENV GEODE_VERSION 1.9.0". I suspect that after the release of 1.10 the changes done in the Dockerfile were not merged back to develop, maybe the release branch was not merged back to develop. Anyway, the image tagged as 1.10.0 is using that version, so that means the promote_rc script works fine. De: Anthony Baker Enviado: lunes, 11 de noviembre de 2019 19:07 Para: dev@geode.apache.org Cc: Dick Cavender Asunto: Re: Update geode-native-build image as part of release process Thanks Alberto! Maybe as a future enhancement we should consider extending the geode-native-build image from the geode image to make this simpler. Anthony > On Nov 11, 2019, at 2:42 AM, Alberto Bustamante Reyes > wrote: > > Done! I have updated the wiki adding the steps to update the Docker image. > > https://cwiki.apache.org/confluence/display/GEODE/Releasing+Apache+Geode#ReleasingApacheGeode-Updategeode-native-buildDockerimage > > > > De: Dick Cavender > Enviado: jueves, 7 de noviembre de 2019 17:51 > Para: dev@geode.apache.org > Asunto: Re: Update geode-native-build image as part of release process > > +1 > > On Thu, Nov 7, 2019 at 8:38 AM Owen Nichols wrote: > >> +1 >> >> On Thu, Nov 7, 2019 at 6:46 AM Alberto Bustamante Reyes >> wrote: >> >>> Hi all, >>> >>> Some time ago I opened GEODE-7056 to update the Dockerfile of the >>> "geode-native-build", because I saw that it was using 1.6.0 although >> 1.9.0 >>> was available. After this change, other ticket was needed to build and >>> update the image in Dockerhub. >>> >>> I think this task (update file, build image and update image) should be >>> part of the release process. Otherwise, the image will be outdated once >>> there is a new release. And now that 1.11.0 is closer, I think its a good >>> moment to do it. >>> >>> What do you think? >>> >>> BR/ >>> >>> Alberto B. >>> >>
RE: Update geode-native-build image as part of release process
Good idea Anthony, I will investigate that. BTW, I have observed that geode/docker/Dockerfile is outdated. It is using "ENV GEODE_VERSION 1.9.0". I suspect that after the release of 1.10 the changes done in the Dockerfile were not merged back to develop, maybe the release branch was not merged back to develop. Anyway, the image tagged as 1.10.0 is using that version, so that means the promote_rc script works fine. De: Anthony Baker Enviado: lunes, 11 de noviembre de 2019 19:07 Para: dev@geode.apache.org Cc: Dick Cavender Asunto: Re: Update geode-native-build image as part of release process Thanks Alberto! Maybe as a future enhancement we should consider extending the geode-native-build image from the geode image to make this simpler. Anthony > On Nov 11, 2019, at 2:42 AM, Alberto Bustamante Reyes > wrote: > > Done! I have updated the wiki adding the steps to update the Docker image. > > https://cwiki.apache.org/confluence/display/GEODE/Releasing+Apache+Geode#ReleasingApacheGeode-Updategeode-native-buildDockerimage > > > > De: Dick Cavender > Enviado: jueves, 7 de noviembre de 2019 17:51 > Para: dev@geode.apache.org > Asunto: Re: Update geode-native-build image as part of release process > > +1 > > On Thu, Nov 7, 2019 at 8:38 AM Owen Nichols wrote: > >> +1 >> >> On Thu, Nov 7, 2019 at 6:46 AM Alberto Bustamante Reyes >> wrote: >> >>> Hi all, >>> >>> Some time ago I opened GEODE-7056 to update the Dockerfile of the >>> "geode-native-build", because I saw that it was using 1.6.0 although >> 1.9.0 >>> was available. After this change, other ticket was needed to build and >>> update the image in Dockerhub. >>> >>> I think this task (update file, build image and update image) should be >>> part of the release process. Otherwise, the image will be outdated once >>> there is a new release. And now that 1.11.0 is closer, I think its a good >>> moment to do it. >>> >>> What do you think? >>> >>> BR/ >>> >>> Alberto B. >>> >>
Re: Update geode-native-build image as part of release process
Thanks Alberto! Maybe as a future enhancement we should consider extending the geode-native-build image from the geode image to make this simpler. Anthony > On Nov 11, 2019, at 2:42 AM, Alberto Bustamante Reyes > wrote: > > Done! I have updated the wiki adding the steps to update the Docker image. > > https://cwiki.apache.org/confluence/display/GEODE/Releasing+Apache+Geode#ReleasingApacheGeode-Updategeode-native-buildDockerimage > > > > De: Dick Cavender > Enviado: jueves, 7 de noviembre de 2019 17:51 > Para: dev@geode.apache.org > Asunto: Re: Update geode-native-build image as part of release process > > +1 > > On Thu, Nov 7, 2019 at 8:38 AM Owen Nichols wrote: > >> +1 >> >> On Thu, Nov 7, 2019 at 6:46 AM Alberto Bustamante Reyes >> wrote: >> >>> Hi all, >>> >>> Some time ago I opened GEODE-7056 to update the Dockerfile of the >>> "geode-native-build", because I saw that it was using 1.6.0 although >> 1.9.0 >>> was available. After this change, other ticket was needed to build and >>> update the image in Dockerhub. >>> >>> I think this task (update file, build image and update image) should be >>> part of the release process. Otherwise, the image will be outdated once >>> there is a new release. And now that 1.11.0 is closer, I think its a good >>> moment to do it. >>> >>> What do you think? >>> >>> BR/ >>> >>> Alberto B. >>> >>
RE: Update geode-native-build image as part of release process
Done! I have updated the wiki adding the steps to update the Docker image. https://cwiki.apache.org/confluence/display/GEODE/Releasing+Apache+Geode#ReleasingApacheGeode-Updategeode-native-buildDockerimage De: Dick Cavender Enviado: jueves, 7 de noviembre de 2019 17:51 Para: dev@geode.apache.org Asunto: Re: Update geode-native-build image as part of release process +1 On Thu, Nov 7, 2019 at 8:38 AM Owen Nichols wrote: > +1 > > On Thu, Nov 7, 2019 at 6:46 AM Alberto Bustamante Reyes > wrote: > > > Hi all, > > > > Some time ago I opened GEODE-7056 to update the Dockerfile of the > > "geode-native-build", because I saw that it was using 1.6.0 although > 1.9.0 > > was available. After this change, other ticket was needed to build and > > update the image in Dockerhub. > > > > I think this task (update file, build image and update image) should be > > part of the release process. Otherwise, the image will be outdated once > > there is a new release. And now that 1.11.0 is closer, I think its a good > > moment to do it. > > > > What do you think? > > > > BR/ > > > > Alberto B. > > >
Re: Update geode-native-build image as part of release process
+1 On Thu, Nov 7, 2019 at 8:38 AM Owen Nichols wrote: > +1 > > On Thu, Nov 7, 2019 at 6:46 AM Alberto Bustamante Reyes > wrote: > > > Hi all, > > > > Some time ago I opened GEODE-7056 to update the Dockerfile of the > > "geode-native-build", because I saw that it was using 1.6.0 although > 1.9.0 > > was available. After this change, other ticket was needed to build and > > update the image in Dockerhub. > > > > I think this task (update file, build image and update image) should be > > part of the release process. Otherwise, the image will be outdated once > > there is a new release. And now that 1.11.0 is closer, I think its a good > > moment to do it. > > > > What do you think? > > > > BR/ > > > > Alberto B. > > >
Re: Update geode-native-build image as part of release process
+1 On Thu, Nov 7, 2019 at 6:46 AM Alberto Bustamante Reyes wrote: > Hi all, > > Some time ago I opened GEODE-7056 to update the Dockerfile of the > "geode-native-build", because I saw that it was using 1.6.0 although 1.9.0 > was available. After this change, other ticket was needed to build and > update the image in Dockerhub. > > I think this task (update file, build image and update image) should be > part of the release process. Otherwise, the image will be outdated once > there is a new release. And now that 1.11.0 is closer, I think its a good > moment to do it. > > What do you think? > > BR/ > > Alberto B. >
Update geode-native-build image as part of release process
Hi all, Some time ago I opened GEODE-7056 to update the Dockerfile of the "geode-native-build", because I saw that it was using 1.6.0 although 1.9.0 was available. After this change, other ticket was needed to build and update the image in Dockerhub. I think this task (update file, build image and update image) should be part of the release process. Otherwise, the image will be outdated once there is a new release. And now that 1.11.0 is closer, I think its a good moment to do it. What do you think? BR/ Alberto B.
