Review Request 61084: GEODE-3231: withLogFile does not imply withWorkingDir anymore

2017-07-24 Thread Jinmei Liao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61084/
---

Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

More refactor of the rules
GEODE-3231: withLogFile does not imply withWorkingDir anymore


Diffs
-

  
geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderIntegrationTest.java
 721e5020ead8c93313008d11599195a0a0022f9e 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java
 492e304e43113877102be22304bab09025a36dbc 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java
 6726ede5e7a2e9237406d701e8d01c8cbb4adf8b 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOnServerManagerDUnit.java
 557fae7f58d5b7eb29818177c329de255eea75c1 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsStatsDUnitTest.java
 a1dff25990fcf1fd1c41e2e291d4ef277032ba36 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionIntegrationTest.java
 9669669c4fe103ddb21885eca5f23743f75ae005 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionTest.java
 4e72444d634ab37d39b3b01018d5f21c6ce67753 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionTest.java
 12410c79a3df1624e165ebecf1f97425e1ce08e6 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogExporterIntegrationTest.java
 0cd6d5af65aab3d286267b663418b798da362904 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/util/MergeLogsDUnitTest.java
 35d65a005198b981581bf7d02476ad79cd0eea9c 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
 872553efed290890708caaf98dc206b4735005d0 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
 d8753cf285388acabef91761a5043ee18f8475f3 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorStarterRule.java
 e1c14ce828d45d3777e9b31f4b7019e23d6a19ce 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java
 156236bae5cc1b5dc477b01e8b1955bf4aae64fb 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java
 0fd0e7759695d05071a4ade327b129107a9d9d0e 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/test/MemberStarterRuleTest.java
 4970cb5a6becfe259c70132adad949d34f7e2952 
  
geode-web/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java
 368d64dd9c2be3fb15d6d4563bb1c95d83733244 


Diff: https://reviews.apache.org/r/61084/diff/1/


Testing
---

precheckin running


Thanks,

Jinmei Liao

[GitHub] geode-native pull request #98: Test commit for Vince & Scott

2017-07-24 Thread echobravopapa 
Github user echobravopapa closed the pull request at:

https://github.com/apache/geode-native/pull/98


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61042: GEODE-3214: Remove support for multistep gfsh commands.

2017-07-24 Thread Emily Yeh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61042/#review181247
---


Ship it!




+1!

- Emily Yeh


On July 24, 2017, 5:50 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61042/
> ---
> 
> (Updated July 24, 2017, 5:50 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3214: Remove support for multistep gfsh commands.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
>  5621b2497050d6a1003078dc993861a90fad4000 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIMultiStepHelper.java
>  4eeb2279cc041adbd12127a5ad68e862a6e72871 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIRemoteStep.java
>  4c38a313f7b6b7244c092dd4363c778bb810e18c 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIStep.java
>  a037f518a89258bc5e6da00f42f6c7b102bc0e2c 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIStepExecption.java
>  389e72f4f91dd8a30e4086391d3c882e003943f3 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/MultiStepCommand.java
>  75925f782b54c5d55c8fb921b803cf7ae4443252 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java
>  89cb9adee00b72c3775896a5f553256205a0b7cb 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java
>  1cbdb157d2e65a5976edd906f9db82272caad4c4 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
>  5e502f55e781a5bf3a656d17d0156175088891b2 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/web/http/ClientHttpRequest.java
>  43657b9888d7e588d2d6e55584671478940c1d28 
> 
> 
> Diff: https://reviews.apache.org/r/61042/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin passed
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Re: Review Request 61084: GEODE-3231: withLogFile does not imply withWorkingDir anymore

2017-07-24 Thread Emily Yeh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61084/#review181249
---


Ship it!




Ship It!

- Emily Yeh


On July 24, 2017, 4:28 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61084/
> ---
> 
> (Updated July 24, 2017, 4:28 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> More refactor of the rules
> GEODE-3231: withLogFile does not imply withWorkingDir anymore
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderIntegrationTest.java
>  721e5020ead8c93313008d11599195a0a0022f9e 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java
>  492e304e43113877102be22304bab09025a36dbc 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java
>  6726ede5e7a2e9237406d701e8d01c8cbb4adf8b 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOnServerManagerDUnit.java
>  557fae7f58d5b7eb29818177c329de255eea75c1 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsStatsDUnitTest.java
>  a1dff25990fcf1fd1c41e2e291d4ef277032ba36 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionIntegrationTest.java
>  9669669c4fe103ddb21885eca5f23743f75ae005 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionTest.java
>  4e72444d634ab37d39b3b01018d5f21c6ce67753 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionTest.java
>  12410c79a3df1624e165ebecf1f97425e1ce08e6 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogExporterIntegrationTest.java
>  0cd6d5af65aab3d286267b663418b798da362904 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/MergeLogsDUnitTest.java
>  35d65a005198b981581bf7d02476ad79cd0eea9c 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
>  872553efed290890708caaf98dc206b4735005d0 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  d8753cf285388acabef91761a5043ee18f8475f3 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorStarterRule.java
>  e1c14ce828d45d3777e9b31f4b7019e23d6a19ce 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java
>  156236bae5cc1b5dc477b01e8b1955bf4aae64fb 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java
>  0fd0e7759695d05071a4ade327b129107a9d9d0e 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/test/MemberStarterRuleTest.java
>  4970cb5a6becfe259c70132adad949d34f7e2952 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java
>  368d64dd9c2be3fb15d6d4563bb1c95d83733244 
> 
> 
> Diff: https://reviews.apache.org/r/61084/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

2017-07-24 Thread Emily Yeh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60666/#review181245
---


Ship it!




+1!

- Emily Yeh


On July 17, 2017, 3:49 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60666/
> ---
> 
> (Updated July 17, 2017, 3:49 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> geode-3166: remove the uncalled getCredential method
> 
> I simply removed the call. Since the new method is never called, if we have 
> any users that's implementing this method, it's never used anyway. We will 
> not be breaking backward compatibility, I believe.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java 
> 6b0675a5629a3e057fd3d54841db740189007966 
> 
> 
> Diff: https://reviews.apache.org/r/60666/diff/3/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 60688: GEODE-1279: rename tests with old bug system numbers

2017-07-24 Thread Emily Yeh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60688/#review181251
---


Ship it!




Ship It!

- Emily Yeh


On July 6, 2017, 6:28 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60688/
> ---
> 
> (Updated July 6, 2017, 6:28 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-1279
> https://issues.apache.org/jira/browse/GEODE-1279
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1279: rename tests with old bug system numbers
> 
> * Bug34387DUnitTest -> CreateAndLocalDestroyInTXRegressionTest
> * Bug35214DUnitTest -> EntriesDoNotExpireDuringGIIRegressionTest
> * Bug38013DUnitTest -> RemotePRValuesAreNotDeserializedRegressionTest
> * Bug34948DUnitTest -> ValuesAreLazilyDeserializedRegressionTest
> 
> There are many more tests left to rename but here's 4 that are ready to merge.
> 
> 
> Diffs
> -
> 
>   geode-core/src/test/java/org/apache/geode/cache30/Bug34387DUnitTest.java 
> d43be83c1844a931d65ccdc992746a3fb44fd396 
>   geode-core/src/test/java/org/apache/geode/cache30/Bug34948DUnitTest.java 
> 8b98cd3dd66fce8220ea7fe14aa14f8e7738a774 
>   geode-core/src/test/java/org/apache/geode/cache30/Bug35214DUnitTest.java 
> ed25b267f33ea311142950dbca212f19046985b0 
>   geode-core/src/test/java/org/apache/geode/cache30/Bug38013DUnitTest.java 
> a0e8021e210c058c20c061305f4b1a64a27bca11 
>   
> geode-core/src/test/java/org/apache/geode/cache30/CreateAndLocalDestroyInTXRegressionTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/cache30/EntriesDoNotExpireDuringGIIRegressionTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/ConnectDisconnectDUnitTest.java
>  de6343304cefa39ac353e8b692f1f10b03ce0de3 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/internal/DistributedTestFixture.java
>  4175e8119d0652c6cc217ff21679d3c74e757cc9 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/internal/JUnit3DistributedTestCase.java
>  abdac89c35ae39480501d6c954cd169b86f4e29a 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/internal/JUnit4DistributedTestCase.java
>  110d649d8b8c77765de186ffbbe07af8cc16029b 
> 
> 
> Diff: https://reviews.apache.org/r/60688/diff/1/
> 
> 
> Testing
> ---
> 
> * CreateAndLocalDestroyInTXRegressionTest
> * EntriesDoNotExpireDuringGIIRegressionTest
> * RemotePRValuesAreNotDeserializedRegressionTest
> * ValuesAreLazilyDeserializedRegressionTest
> * precheckin
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 60688: GEODE-1279: rename tests with old bug system numbers

2017-07-24 Thread Patrick Rhomberg 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60688/#review181256
---


Ship it!




Ship It!

- Patrick Rhomberg


On July 6, 2017, 6:28 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60688/
> ---
> 
> (Updated July 6, 2017, 6:28 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-1279
> https://issues.apache.org/jira/browse/GEODE-1279
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1279: rename tests with old bug system numbers
> 
> * Bug34387DUnitTest -> CreateAndLocalDestroyInTXRegressionTest
> * Bug35214DUnitTest -> EntriesDoNotExpireDuringGIIRegressionTest
> * Bug38013DUnitTest -> RemotePRValuesAreNotDeserializedRegressionTest
> * Bug34948DUnitTest -> ValuesAreLazilyDeserializedRegressionTest
> 
> There are many more tests left to rename but here's 4 that are ready to merge.
> 
> 
> Diffs
> -
> 
>   geode-core/src/test/java/org/apache/geode/cache30/Bug34387DUnitTest.java 
> d43be83c1844a931d65ccdc992746a3fb44fd396 
>   geode-core/src/test/java/org/apache/geode/cache30/Bug34948DUnitTest.java 
> 8b98cd3dd66fce8220ea7fe14aa14f8e7738a774 
>   geode-core/src/test/java/org/apache/geode/cache30/Bug35214DUnitTest.java 
> ed25b267f33ea311142950dbca212f19046985b0 
>   geode-core/src/test/java/org/apache/geode/cache30/Bug38013DUnitTest.java 
> a0e8021e210c058c20c061305f4b1a64a27bca11 
>   
> geode-core/src/test/java/org/apache/geode/cache30/CreateAndLocalDestroyInTXRegressionTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/cache30/EntriesDoNotExpireDuringGIIRegressionTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/ConnectDisconnectDUnitTest.java
>  de6343304cefa39ac353e8b692f1f10b03ce0de3 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/internal/DistributedTestFixture.java
>  4175e8119d0652c6cc217ff21679d3c74e757cc9 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/internal/JUnit3DistributedTestCase.java
>  abdac89c35ae39480501d6c954cd169b86f4e29a 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/internal/JUnit4DistributedTestCase.java
>  110d649d8b8c77765de186ffbbe07af8cc16029b 
> 
> 
> Diff: https://reviews.apache.org/r/60688/diff/1/
> 
> 
> Testing
> ---
> 
> * CreateAndLocalDestroyInTXRegressionTest
> * EntriesDoNotExpireDuringGIIRegressionTest
> * RemotePRValuesAreNotDeserializedRegressionTest
> * ValuesAreLazilyDeserializedRegressionTest
> * precheckin
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 60935: GEODE-3115 Added changes to check for persistent region during pdx type registry.

2017-07-24 Thread Nick Reich 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60935/#review181270
---


Ship it!




Ship It!

- Nick Reich


On July 21, 2017, 7:18 p.m., anilkumar gingade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60935/
> ---
> 
> (Updated July 21, 2017, 7:18 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Eric Shu, Lynn Gallinat, and Nick 
> Reich.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The pdx registry needs to be persisted to use pdx with persistent region. 
> Currently while creating pdx the system checks, to see if there is a disk 
> store with data instead of looking for persistent region in the system. In 
> cases where persistent region is created and dropped, the system doesn't 
> allow creating pdx witout setting pdx persistence.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  de5fd88 
>   geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
> aed439c 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java
>  db5f7ca 
>   
> geode-core/src/main/java/org/apache/geode/pdx/internal/PeerTypeRegistration.java
>  065255b 
>   geode-core/src/test/java/org/apache/geode/pdx/PdxAttributesJUnitTest.java 
> ef15cd5 
> 
> 
> Diff: https://reviews.apache.org/r/60935/diff/2/
> 
> 
> Testing
> ---
> 
> Added new test.
> Precheckin started.
> 
> 
> Thanks,
> 
> anilkumar gingade
> 
>

Re: Review Request 60918: GEODE-3134: fix lucene command security

2017-07-24 Thread Patrick Rhomberg 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60918/#review181273
---




geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java
Lines 43 (patched)


Why is `LucenePermission` its own singleton class and not part of the 
`ResourcePermission.Target` enum?


- Patrick Rhomberg


On July 17, 2017, 6:34 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60918/
> ---
> 
> (Updated July 17, 2017, 6:34 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, 
> Patrick Rhomberg, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3108: update lucene security permission to use "LUCENE" target
> 
> * have lucene module define it's own target for plugability
> * added string based target support for SecurityService
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java
>  323ab67d7f948b739783b2fb3b6bcfac32f68f0a 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
>  b00e0f481f4b0cc92d163915c05822fb339fd158 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java
>  5b4f2c14545847d9a3fcfc501fdd9ff1e19771ba 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java
>  6ddacf134710da2f79a2d2e5e4ee866ef605674d 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/functions/LuceneCreateIndexFunction.java
>  2d3f8d2062b29b3ba11936ac07f67ac4af210640 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/security/LucenePermission.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneCommandsSecurityDUnitTest.java
>  71166017b7a16162e3f4201a9e76691329ab346a 
> 
> 
> Diff: https://reviews.apache.org/r/60918/diff/1/
> 
> 
> Testing
> ---
> 
> LuceneCommandsSecurityDUnitTest precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 61003: GEODE-393: GetRegionFunction uses the cache in the FunctionContext

2017-07-24 Thread Jared Stewart 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61003/#review181275
---


Ship it!




Ship It!

- Jared Stewart


On July 20, 2017, 5:40 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61003/
> ---
> 
> (Updated July 20, 2017, 5:40 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-393: GetRegionFunction uses the cache in the FunctionContext
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/GetRegionsFunction.java
>  d52492466d521fb25f410e7c03b3d9808aabe67c 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/GetRegionsFunctionTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61003/diff/1/
> 
> 
> Testing
> ---
> 
> added test and precheckin funning
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Failed: apache/geode#3248 (FunctionContext - 96e50e7)

2017-07-24 Thread Travis CI 
Build Update for apache/geode
-

Build: #3248
Status: Failed

Duration: 10 minutes and 16 seconds
Commit: 96e50e7 (FunctionContext)
Author: Kirk Lund
Message: Convert to use FunctionContext.getCache()

View the changeset: https://github.com/apache/geode/commit/96e50e7e3073

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/257033638?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Fixed: apache/geode#3249 (FunctionContext - cfa54f5)

2017-07-24 Thread Travis CI 
Build Update for apache/geode
-

Build: #3249
Status: Fixed

Duration: 9 minutes and 58 seconds
Commit: cfa54f5 (FunctionContext)
Author: Kirk Lund
Message: Fixup

View the changeset: 
https://github.com/apache/geode/compare/96e50e7e3073...cfa54f5ab17f

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/257041328?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

[GitHub] geode pull request #652: Geode-2971: Introduce ExitCode to resolve inconsist...

2017-07-24 Thread PurelyApplied 
GitHub user PurelyApplied opened a pull request:

https://github.com/apache/geode/pull/652

Geode-2971: Introduce ExitCode to resolve inconsistency of shell exit values

There are a few sections containing `// TODO PSRhomberg`.  Most are there 
to mark a specific request for feedback, and two are there to explain a change 
that counterintuitively respects existing behavior.

- [ ] Have you removed your `TODO` comments?
- [ ] Is your initial contribution a single, squashed commit?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PurelyApplied/geode geode-2971

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/652.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #652


commit f8b1685dcecd023bbaa17fec8024dc32af648f33
Author: Patrick Rhomberg 
Date:   2017-07-20T19:36:36Z

Added ExitCode to handle all System.exit calls.

* Significant refactoring of Launcher.java and its use of exit states.

commit 60a1bcd93fe3c4e67d0735b3fce6c9d3bed0d9f6
Author: Patrick Rhomberg 
Date:   2017-07-20T19:40:34Z

All System.exit calls replaced by an appropriate call of 
ExitCode.[code].doSystemExit();

commit 57df2484d9a1fc6001dc5ef12522a24483f126f6
Author: Patrick Rhomberg 
Date:   2017-07-20T22:54:06Z

Added AcceptanceTest for gfsh member status commands

commit c82b0115099b98bbbfca1eb6e3539a82e6fe054b
Author: Patrick Rhomberg 
Date:   2017-07-20T19:42:18Z

Correction of inconsistency in exit status of member status commands.

commit 92da642dcf1b5039def0ecf3d0f317c652a48515
Author: Patrick Rhomberg 
Date:   2017-07-21T22:05:48Z

Removed dead code and many needless asides from touched file 
SystemFailure.java

commit 830d3ee0af16c765b99271e231377439cd659b26
Author: Patrick Rhomberg 
Date:   2017-07-21T22:15:27Z

Removed redundant declarations and much dead code from touched file 
StatArchiveReader.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #653: GEODE-3290: Removed effectively-dead classes Filter...

2017-07-24 Thread PurelyApplied 
GitHub user PurelyApplied opened a pull request:

https://github.com/apache/geode/pull/653

GEODE-3290: Removed effectively-dead classes FilterChain, et al

Removed `FilterChain`, `LocalFilterChain`, and `RemoteFilterChain`.

Minor cleanup of touched files.

Precheckin running.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PurelyApplied/geode geode-3290

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/653.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #653


commit 2bd128e784de07b558a5a438b1de8eea6cb9fd24
Author: Patrick Rhomberg 
Date:   2017-07-24T21:00:43Z

GEODE-3290: Removed effectively-dead classes FilterChain, LocalFilterChain, 
and RemoteFilterChain.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60924: GEODE-2920: added security tests for create diskstore and create persistent region.

2017-07-24 Thread Emily Yeh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60924/#review181274
---


Ship it!




Ship It!

- Emily Yeh


On July 17, 2017, 9:39 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60924/
> ---
> 
> (Updated July 17, 2017, 9:39 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2920: handle non-existent role in ExampleSecurityManager
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java
>  c1d7ebfa017ccc627e7d4da6db951d3f61e2461b 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java
>  c2be173f8844bcf25361edc9e5d428f62aa8761f 
>   
> geode-core/src/test/java/org/apache/geode/security/ExampleSecurityManagerTest.java
>  9093a7bc70835ae50c72a80739a3f8ab4789cacd 
>   
> geode-core/src/test/resources/org/apache/geode/security/templates/security.json
>  c1ee9fc22bad58642d814c5930eb2d02810dad0e 
> 
> 
> Diff: https://reviews.apache.org/r/60924/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

[GitHub] geode pull request #654: GEODE-3291: add soundex analyzer into lucene query

2017-07-24 Thread gesterzhou 
GitHub user gesterzhou opened a pull request:

https://github.com/apache/geode/pull/654

GEODE-3291: add soundex analyzer into lucene query

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-3291

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/654.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #654


commit 70f9afba836cec48fb1953e93d94460940c05574
Author: zhouxh 
Date:   2017-07-24T21:27:42Z

GEODE-3291: add soundex analyzer into lucene query




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60918: GEODE-3134: fix lucene command security

2017-07-24 Thread Emily Yeh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60918/#review181267
---


Ship it!




Ship It!

- Emily Yeh


On July 17, 2017, 6:34 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60918/
> ---
> 
> (Updated July 17, 2017, 6:34 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, 
> Patrick Rhomberg, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3108: update lucene security permission to use "LUCENE" target
> 
> * have lucene module define it's own target for plugability
> * added string based target support for SecurityService
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java
>  323ab67d7f948b739783b2fb3b6bcfac32f68f0a 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
>  b00e0f481f4b0cc92d163915c05822fb339fd158 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java
>  5b4f2c14545847d9a3fcfc501fdd9ff1e19771ba 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java
>  6ddacf134710da2f79a2d2e5e4ee866ef605674d 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/functions/LuceneCreateIndexFunction.java
>  2d3f8d2062b29b3ba11936ac07f67ac4af210640 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/security/LucenePermission.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneCommandsSecurityDUnitTest.java
>  71166017b7a16162e3f4201a9e76691329ab346a 
> 
> 
> Diff: https://reviews.apache.org/r/60918/diff/1/
> 
> 
> Testing
> ---
> 
> LuceneCommandsSecurityDUnitTest precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 60935: GEODE-3115 Added changes to check for persistent region during pdx type registry.

2017-07-24 Thread Darrel Schneider 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60935/#review181283
---


Ship it!




Ship It!

- Darrel Schneider


On July 21, 2017, 12:18 p.m., anilkumar gingade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60935/
> ---
> 
> (Updated July 21, 2017, 12:18 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Eric Shu, Lynn Gallinat, and Nick 
> Reich.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The pdx registry needs to be persisted to use pdx with persistent region. 
> Currently while creating pdx the system checks, to see if there is a disk 
> store with data instead of looking for persistent region in the system. In 
> cases where persistent region is created and dropped, the system doesn't 
> allow creating pdx witout setting pdx persistence.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  de5fd88 
>   geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
> aed439c 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java
>  db5f7ca 
>   
> geode-core/src/main/java/org/apache/geode/pdx/internal/PeerTypeRegistration.java
>  065255b 
>   geode-core/src/test/java/org/apache/geode/pdx/PdxAttributesJUnitTest.java 
> ef15cd5 
> 
> 
> Diff: https://reviews.apache.org/r/60935/diff/2/
> 
> 
> Testing
> ---
> 
> Added new test.
> Precheckin started.
> 
> 
> Thanks,
> 
> anilkumar gingade
> 
>

Re: Review Request 61003: GEODE-393: GetRegionFunction uses the cache in the FunctionContext

2017-07-24 Thread Patrick Rhomberg 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61003/#review181272
---


Ship it!




Ship It!

- Patrick Rhomberg


On July 20, 2017, 5:40 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61003/
> ---
> 
> (Updated July 20, 2017, 5:40 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-393: GetRegionFunction uses the cache in the FunctionContext
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/GetRegionsFunction.java
>  d52492466d521fb25f410e7c03b3d9808aabe67c 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/GetRegionsFunctionTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61003/diff/1/
> 
> 
> Testing
> ---
> 
> added test and precheckin funning
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #626 was SUCCESSFUL (with 1986 tests). Change made by John Blum.

2017-07-24 Thread Spring CI 

---
Spring Data GemFire > Nightly-ApacheGeode > #626 was successful.
---
Scheduled with changes by John Blum.
1989 tests in total.

https://build.spring.io/browse/SGF-NAG-626/




--
Code Changes
--
John Blum (ddfe30adde189476b519e73d25e121879bc4):

>DATAGEODE-20 - Comment out reference to Apache Maven Snapshots Repository.

John Blum (5149f1e2bd4bc9147e862dfe2ae5a79558c00ace):

>DATAGEODE-24 - Enhance @EnableSecurity to provide a default implementation of 
>the Geode AuthInitialize interface.

John Blum (36eed1fa606815894c4cbeb3d9c455d954715036):

>DATAGEODE-25 - Add EnableBeanFactoryLocator annotation to enable the 
>GemfireBeanFactoryLocator on Cache creation.



--
This message is automatically generated by Atlassian Bamboo

[GitHub] geode issue #652: Geode-2971: Introduce ExitCode to resolve inconsistency of...

2017-07-24 Thread PurelyApplied 
Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/652
  
Precheckin running.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61003: GEODE-393: GetRegionFunction uses the cache in the FunctionContext

2017-07-24 Thread Emily Yeh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61003/#review181266
---


Ship it!




Ship It!

- Emily Yeh


On July 20, 2017, 5:40 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61003/
> ---
> 
> (Updated July 20, 2017, 5:40 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-393: GetRegionFunction uses the cache in the FunctionContext
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/GetRegionsFunction.java
>  d52492466d521fb25f410e7c03b3d9808aabe67c 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/GetRegionsFunctionTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61003/diff/1/
> 
> 
> Testing
> ---
> 
> added test and precheckin funning
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 60918: GEODE-3134: fix lucene command security

2017-07-24 Thread Patrick Rhomberg 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60918/#review181269
---




geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java
Line 135 (original), 129 (patched)


Forgot to uncomment this.


- Patrick Rhomberg


On July 17, 2017, 6:34 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60918/
> ---
> 
> (Updated July 17, 2017, 6:34 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, 
> Patrick Rhomberg, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3108: update lucene security permission to use "LUCENE" target
> 
> * have lucene module define it's own target for plugability
> * added string based target support for SecurityService
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java
>  323ab67d7f948b739783b2fb3b6bcfac32f68f0a 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
>  b00e0f481f4b0cc92d163915c05822fb339fd158 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java
>  5b4f2c14545847d9a3fcfc501fdd9ff1e19771ba 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java
>  6ddacf134710da2f79a2d2e5e4ee866ef605674d 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/functions/LuceneCreateIndexFunction.java
>  2d3f8d2062b29b3ba11936ac07f67ac4af210640 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/security/LucenePermission.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneCommandsSecurityDUnitTest.java
>  71166017b7a16162e3f4201a9e76691329ab346a 
> 
> 
> Diff: https://reviews.apache.org/r/60918/diff/1/
> 
> 
> Testing
> ---
> 
> LuceneCommandsSecurityDUnitTest precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

[GitHub] geode-native pull request #111: Just a test PR

2017-07-24 Thread pivotal-jbarrett 
GitHub user pivotal-jbarrett opened a pull request:

https://github.com/apache/geode-native/pull/111

Just a test PR

Please ignore this while we test PR CI

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pivotal-jbarrett/geode-native wip/test-pr

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #111


commit 6cb38062168e5d3ec92c67ea29cf50447e2b2966
Author: Ernie Burghardt 
Date:   2017-07-24T16:39:19Z

Just a test




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61042: GEODE-3214: Remove support for multistep gfsh commands.

2017-07-24 Thread Jinmei Liao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61042/#review181244
---


Ship it!




Ship It!

- Jinmei Liao


On July 24, 2017, 5:50 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61042/
> ---
> 
> (Updated July 24, 2017, 5:50 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3214: Remove support for multistep gfsh commands.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
>  5621b2497050d6a1003078dc993861a90fad4000 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIMultiStepHelper.java
>  4eeb2279cc041adbd12127a5ad68e862a6e72871 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIRemoteStep.java
>  4c38a313f7b6b7244c092dd4363c778bb810e18c 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIStep.java
>  a037f518a89258bc5e6da00f42f6c7b102bc0e2c 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIStepExecption.java
>  389e72f4f91dd8a30e4086391d3c882e003943f3 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/MultiStepCommand.java
>  75925f782b54c5d55c8fb921b803cf7ae4443252 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java
>  89cb9adee00b72c3775896a5f553256205a0b7cb 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java
>  1cbdb157d2e65a5976edd906f9db82272caad4c4 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
>  5e502f55e781a5bf3a656d17d0156175088891b2 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/web/http/ClientHttpRequest.java
>  43657b9888d7e588d2d6e55584671478940c1d28 
> 
> 
> Diff: https://reviews.apache.org/r/61042/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin passed
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

2017-07-24 Thread YehEmily 
GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/651

GEODE-3230: Cleaning up unused (Cli)Strings

[View the JIRA ticket 
here.](https://issues.apache.org/jira/browse/GEODE-3230)

`CliStrings.java` contained a lot of Strings that were not used anywhere in 
the code. In this PR, each of these seemingly unused Strings were examined to 
find potential uses of them in the code. Strings that did seem useful were 
inserted into the code as needed. Strings that didn't seem to be useful were 
deleted. Strings that don't seem to be used, but are used in the closed side, 
were preserved and tagged as such.

(Note: An attempt was made to use all Strings that weren't currently being 
used in parts of the code that seemed appropriate, but most of these were 
removed because they broke tests.)

**Testing Status**: **Precheckin running**

### For all changes:
- [x] JIRA ticket

- [x] PR rebased

- [x] Initial commit is squashed and single

- [x] `gradlew build` runs cleanly

- [x] Tests updated to verify changes

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-3230

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/651.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #651


commit 06dcd340a33c83cab7b4700a3c56e8fe780d0964
Author: YehEmily 
Date:   2017-07-21T21:29:55Z

GEODE-3230: Cleaning up unused (Cli)Strings




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61084: GEODE-3231: withLogFile does not imply withWorkingDir anymore

2017-07-24 Thread Jared Stewart 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61084/#review181240
---


Ship it!




Ship It!

- Jared Stewart


On July 24, 2017, 4:28 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61084/
> ---
> 
> (Updated July 24, 2017, 4:28 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> More refactor of the rules
> GEODE-3231: withLogFile does not imply withWorkingDir anymore
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderIntegrationTest.java
>  721e5020ead8c93313008d11599195a0a0022f9e 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java
>  492e304e43113877102be22304bab09025a36dbc 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java
>  6726ede5e7a2e9237406d701e8d01c8cbb4adf8b 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOnServerManagerDUnit.java
>  557fae7f58d5b7eb29818177c329de255eea75c1 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsStatsDUnitTest.java
>  a1dff25990fcf1fd1c41e2e291d4ef277032ba36 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionIntegrationTest.java
>  9669669c4fe103ddb21885eca5f23743f75ae005 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionTest.java
>  4e72444d634ab37d39b3b01018d5f21c6ce67753 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionTest.java
>  12410c79a3df1624e165ebecf1f97425e1ce08e6 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogExporterIntegrationTest.java
>  0cd6d5af65aab3d286267b663418b798da362904 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/MergeLogsDUnitTest.java
>  35d65a005198b981581bf7d02476ad79cd0eea9c 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
>  872553efed290890708caaf98dc206b4735005d0 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  d8753cf285388acabef91761a5043ee18f8475f3 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorStarterRule.java
>  e1c14ce828d45d3777e9b31f4b7019e23d6a19ce 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java
>  156236bae5cc1b5dc477b01e8b1955bf4aae64fb 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java
>  0fd0e7759695d05071a4ade327b129107a9d9d0e 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/test/MemberStarterRuleTest.java
>  4970cb5a6becfe259c70132adad949d34f7e2952 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java
>  368d64dd9c2be3fb15d6d4563bb1c95d83733244 
> 
> 
> Diff: https://reviews.apache.org/r/61084/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Question regarding node failure scenario

2017-07-24 Thread Michael Stolz 
Without subscription-redundancy you are running the risk that some of the
data isn't being pushed to you in the event of a server failure.


--
Mike Stolz
Principal Engineer, GemFire Product Manager
Mobile: +1-631-835-4771

On Sun, Jul 23, 2017 at 10:06 PM, Akihiro Kitada  wrote:

> Hello Roi,
>
> I want to confirm actual your configuration.
>
> >- I have a replicated Node, say N1 and its replicated N2 (N2 gets
> activated when N1 is down) and they are configured to send updates via
> continuous query to my process which then reports on these updates.
>
> Do node N1 and N2 replicate each data based on the same Replicated region
> configuration in the same distributed system? If not, how do N1 and N2
> replicated data? Could you attach actual cache configuration (such as
> cache.xml) for N1 and N2?
>
> Who update the data, some specific Geode client application or Geode peer
> (cache server internally)?
>
> Thanks.
>
>
>
>
> --
> Akihiro Kitada  |  Staff Customer Engineer |  +81 80 3716 3736
> Support.Pivotal.io   |  Mon-Fri  9:00am to
> 5:30pm JST  |  1-877-477-2269
> [image: support]  [image: twitter]
>  [image: linkedin]
>  [image: facebook]
>  [image: google plus]
>  [image: youtube]
> 
>
>
> 2017-07-23 22:04 GMT+09:00 Roi Apelker :
>
> > Hi,  (Bear with me I am a bit new here :))
> >
> > I have the following scenario, I wonder if anyone can comment on it - is
> > it a known issue, maybe it was solved already in later version, etc. (I
> am
> > using version 1.0.0)
> > Or maybe you can point me to somewhere in the code.
> > I have posted this question once before (thanks Dan S. for relating to
> > it), however I was away for 3 weeks therefore posting again.
> >
> > - I have a replicated Node, say N1 and its replicated N2 (N2 gets
> > activated when N1 is down) and they are configured to send updates via
> > continuous query to my process which then reports on these updates.
> >
> > - N1 is working all the time and serves as a server, and data is written
> > to it continuously from external clients. If 1000 events are written to
> N1,
> > the final report I am referring to will indicate 1000.
> >
> > - When N1 gets killed for any reason, the client connects to N2 which
> > continues to send the continuous query results.
> >
> > - But sometimes, the report is inaccurate, e.g. after running 1000
> events,
> > my report says 950, as if some events of the continuous query do not
> reach
> > the client (the actual data does arrive its destination, just the report
> is
> > qrong)
> >
> > The fact is, that the report is not accurate, and I only assume that
> > something is wrong in the update mechanism, somewhere in the area of
> > continuous query, or somewhere in the replication between the nodes.
> >
> > Right now, the parameter of subscription-redundancy is not configured.
> But
> > subscription-enabled="true" .
> >
> > What is the significance of not configuring the subscription-redundancy ?
> > does it mean that client disconnection may cause continuous query events
> to
> > be discarded?
> > And if so, is it "may be discarded" or "will be discarded", meaning, will
> > the result be always the same or not?
> >
> >
> > Thanks,
> >
> > Roi
> > This message and the information contained herein is proprietary and
> > confidential and subject to the Amdocs policy statement,
> >
> > you may review at https://www.amdocs.com/about/email-disclaimer <
> > https://www.amdocs.com/about/email-disclaimer>
> >
> >
>

Build failed in Jenkins: Geode-nightly #905

2017-07-24 Thread Apache Jenkins Server 
See 

--
[...truncated 132.79 KB...]
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:acceptanceTest
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:integrationTest
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:acceptanceTest
:geode-lucene:assemble
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:integrationTest
:geode-old-client-support:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:acceptanceTest
:geode-old-client-support:assemble
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:integrationTest
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:acceptanceTest UP-TO-DATE
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-protobuf:extractIncludeTestProto
:geode-protobuf:extractTestProto UP-TO-DATE
:geode-protobuf:generateTestProto UP-TO-DATE
:geode-protobuf:compileTestJavaNote: Some input files use unchecked or unsafe 
operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-protobuf:processTestResources
:geode-protobuf:testClasses
:geode-protobuf:acceptanceTest
:geode-protobuf:assemble
:geode-protobuf:checkMissedTests
:geode-protobuf:spotlessJavaCheck
:geode-protobuf:spotlessCheck
:geode-protobuf:test
:geode-protobuf:check
:geode-protobuf:build
:geode-protobuf:distributedTest
:geode-protobuf:integrationTest
:geode-pulse:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:acceptanceTest
:geode-pulse:assemble
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:integrationTest
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:acceptanceTest
:geode-rebalancer:assemble
:geode-rebalancer:checkMissedTests
:geode-rebalancer:spotlessJavaCheck
:geode-rebalancer:spotlessCheck
:geode-rebalancer:test
:geode-rebalancer:check
:geode-rebalancer:build
:geode-rebalancer:distributedTest
:geode-rebalancer:integrationTest
:geode-wan:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-wan:processTestResources
:geode-wan:testClasses
:geode-wan:acceptanceTest
:geode-wan:assemble
:geode-wan:checkMissedTests
:geode-wan:spotlessJavaCheck
:geode-wan:spotlessCheck
:geode-wan:test
:geode-wan:check
:geode-wan:build
:geode-wan:distributedTest
:geode-wan:integrationTest
:geode-web:compileTestJavaNote: Some

[GitHub] geode issue #535: GEODE-2986: Remove redundant log message

2017-07-24 Thread AkihiroKitada 
Github user AkihiroKitada commented on the issue:

https://github.com/apache/geode/pull/535
  
Hello folks,

Thank you for paying your attention to this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #577: Feature/geode 3049

2017-07-24 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/577


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-nightly #906

2017-07-24 Thread Apache Jenkins Server 
See 


Changes:

[jiliao] GEODE-393: GetRegionFunction uses the cache in the FunctionContext

[jstewart] GEODE-3214: Remove support for multistep gfsh commands.

[dbarnes] (no ticket) Update OSX to macOS

[dschneider] GEODE-3049: Add warning on loss of all buckets in region

--
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on mxnet-win1 (mxnet mxnetwindows) in workspace 

Cloning the remote Git repository
Cloning repository https://git-wip-us.apache.org/repos/asf/geode.git
 > git init  # timeout=10
Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/geode.git
 > git --version # timeout=10
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/geode.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/geode.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/geode.git # timeout=10
Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/geode.git
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/geode.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse "refs/remotes/origin/develop^{commit}" # timeout=10
 > git rev-parse "refs/remotes/origin/origin/develop^{commit}" # timeout=10
Checking out Revision b7db727ad8477806e7884d16624cd72bd6ba26e0 
(refs/remotes/origin/develop)
Commit message: "GEODE-3049: Add warning on loss of all buckets in region"
 > git config core.sparsecheckout # timeout=10
 > git checkout -f b7db727ad8477806e7884d16624cd72bd6ba26e0
 > git branch -a -v --no-abbrev # timeout=10
 > git checkout -b develop b7db727ad8477806e7884d16624cd72bd6ba26e0
 > git rev-list acdf2e80184edf9c3ba934a6f0fa760a83020953 # timeout=10
[Geode-nightly] $ /bin/bash -xe 
C:\Users\jenkins\AppData\Local\Temp\3\jenkins4737677690115327858.sh
The system cannot find the file specified
FATAL: command execution failed
java.io.IOException: CreateProcess error=2, The system cannot find the file 
specified
at java.lang.ProcessImpl.create(Native Method)
at java.lang.ProcessImpl.(Unknown Source)
at java.lang.ProcessImpl.start(Unknown Source)
at java.lang.ProcessBuilder.start(Unknown Source)
at hudson.Proc$LocalProc.(Proc.java:245)
at hudson.Proc$LocalProc.(Proc.java:214)
at hudson.Launcher$LocalLauncher.launch(Launcher.java:850)
at hudson.Launcher$ProcStarter.start(Launcher.java:384)
at hudson.Launcher$RemoteLaunchCallable.call(Launcher.java:1195)
at hudson.Launcher$RemoteLaunchCallable.call(Launcher.java:1160)
at hudson.remoting.UserRequest.perform(UserRequest.java:153)
at hudson.remoting.UserRequest.perform(UserRequest.java:50)
at hudson.remoting.Request$2.run(Request.java:336)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at hudson.remoting.Engine$1$1.run(Engine.java:94)
at java.lang.Thread.run(Unknown Source)
Caused: java.io.IOException: Cannot run program "/bin/bash" (in directory 
": CreateProcess error=2, 
The system cannot find the file specified
at java.lang.ProcessBuilder.start(Unknown Source)
at hudson.Proc$LocalProc.(Proc.java:245)
at hudson.Proc$LocalProc.(Proc.java:214)
at hudson.Launcher$LocalLauncher.launch(Launcher.java:850)
at hudson.Launcher$ProcStarter.start(Launcher.java:384)
at hudson.Launcher$RemoteLaunchCallable.call(Launcher.java:1195)
at hudson.Launcher$RemoteLaunchCallable.call(Launcher.java:1160)
at hudson.remoting.UserRequest.perform(UserRequest.java:153)
at hudson.remoting.UserRequest.perform(UserRequest.java:50)
at hudson.remoting.Request$2.run(Request.java:336)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at hudson.remoting.Engine$1$1.run(Engine.java:94)
at java.lang.Thread.run(Unknown Source)
at ..remote call to JNLP4-connect connection from 
ec2-34-212-75-172.us-west-2.compute.amazonaws.com/34.212.75.172:51548(Native 
Method)
at