Review Request 37119: GEODE-187:AsyncEventQueue with Event Filter test log shows IllegalStateException -AbstractGatewaySenderEventProcessor#processqueue iterates events to get filtered. While iterat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37119/ --- Review request for geode, suranjan kumar and Yogesh Mahajan. Repository: geode Description --- GEODE-187:AsyncEventQueue with Event Filter test log shows IllegalStateException -AbstractGatewaySenderEventProcessor#processqueue iterates events to get filtered. While iterating 2 consditions are checked and event is removed in thses both condition. for single itr.next() when itr.remove is called second time, it causes IllegalStateException. -Added 'continue' after first itr.remove is called Diffs - gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java 67b38948a8fe4b347f3ed3e9035a76e4cd834716 Diff: https://reviews.apache.org/r/37119/diff/ Testing --- This is verified on 82 branch Also ran newWan/serial/filters/hctBeforeTransmitEventFilterHA.conf with and without changes to verify fix. Thanks, Kishor Bachhav
Re: Review Request 37119: GEODE-187:AsyncEventQueue with Event Filter test log shows IllegalStateException -AbstractGatewaySenderEventProcessor#processqueue iterates events to get filtered. While it
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37119/#review94199 --- Ship it! Ship It! - suranjan kumar On Aug. 5, 2015, 7:11 a.m., Kishor Bachhav wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37119/ --- (Updated Aug. 5, 2015, 7:11 a.m.) Review request for geode, suranjan kumar and Yogesh Mahajan. Repository: geode Description --- GEODE-187:AsyncEventQueue with Event Filter test log shows IllegalStateException -AbstractGatewaySenderEventProcessor#processqueue iterates events to get filtered. While iterating 2 consditions are checked and event is removed in thses both condition. for single itr.next() when itr.remove is called second time, it causes IllegalStateException. -Added 'continue' after first itr.remove is called Diffs - gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java 67b38948a8fe4b347f3ed3e9035a76e4cd834716 Diff: https://reviews.apache.org/r/37119/diff/ Testing --- This is verified on 82 branch Also ran newWan/serial/filters/hctBeforeTransmitEventFilterHA.conf with and without changes to verify fix. Thanks, Kishor Bachhav
Re: Review Request 37098: fix GEODE-186
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37098/#review94241 --- Ship it! Ship It! - Swapnil Bawaskar On Aug. 4, 2015, 9:31 p.m., Darrel Schneider wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37098/ --- (Updated Aug. 4, 2015, 9:31 p.m.) Review request for geode and Swapnil Bawaskar. Bugs: GEODE-186 https://issues.apache.org/jira/browse/GEODE-186 Repository: geode Description --- testSuspendTimeout now schedules the expiration to happen after 1 ms (instead of 1 minute). Most sleeps not needed since the operation it was waiting for is synchronous. For the sleeps that were needed, they now use a wait. I think the only sleep that was needed was on a client since the server will push events to it async. Diffs - gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java 88714b02385a9282d57eb6be9bddb2175b7b130d gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/ClientServerTransactionDUnitTest.java 3ce8cec00738e5a2ac813c42c0c4e4916e0f6451 gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/RemoteTransactionDUnitTest.java 0daaafb6b11edf07f5e3a38e3f23e701c230dc62 Diff: https://reviews.apache.org/r/37098/diff/ Testing --- ran all RemoteTransactionDUnitTest subclasses. Thanks, Darrel Schneider
Review Request 37143: fix races in testRegionIdleInvalidate
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37143/ --- Review request for geode and Kirk Lund. Bugs: GEODE-185 https://issues.apache.org/jira/browse/GEODE-185 Repository: geode Description --- The test code is now careful to wait for the expiration clock to advance. A different assertion will be triggered if the expiration clock goes back in time. Fixed two places in the product expiration code that did not use the expiration clock. Diffs - gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/ExpiryTask.java 95cd3a807ef54d66aaa9f257f6a3720738377a83 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionIdleExpiryTask.java fbcb12c8284e8f8829f48be5a18cecd48dc7d711 gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 69eeec03016b98bb7b420e2d41e15e53053d43e8 gemfire-core/src/test/java/dunit/DistributedTestCase.java 564e7efb947e4dd77b8cb3fa40e1ac9491d75afa Diff: https://reviews.apache.org/r/37143/diff/ Testing --- All RegionTestCase subclass dunits. Thanks, Darrel Schneider
Re: Review Request 37143: fix races in testRegionIdleInvalidate
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37143/ --- (Updated Aug. 5, 2015, 2:22 p.m.) Review request for geode and Kirk Lund. Bugs: GEODE-185 https://issues.apache.org/jira/browse/GEODE-185 Repository: geode Description --- The test code is now careful to wait for the expiration clock to advance. A different assertion will be triggered if the expiration clock goes back in time. Fixed two places in the product expiration code that did not use the expiration clock. Diffs - gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/ExpiryTask.java 95cd3a807ef54d66aaa9f257f6a3720738377a83 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionIdleExpiryTask.java fbcb12c8284e8f8829f48be5a18cecd48dc7d711 gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 69eeec03016b98bb7b420e2d41e15e53053d43e8 gemfire-core/src/test/java/dunit/DistributedTestCase.java 564e7efb947e4dd77b8cb3fa40e1ac9491d75afa Diff: https://reviews.apache.org/r/37143/diff/ Testing (updated) --- precheckin Thanks, Darrel Schneider
Re: Review Request 37143: fix races in testRegionIdleInvalidate
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37143/#review94316 --- Ship it! Ship It! - Kirk Lund On Aug. 5, 2015, 9:22 p.m., Darrel Schneider wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37143/ --- (Updated Aug. 5, 2015, 9:22 p.m.) Review request for geode and Kirk Lund. Bugs: GEODE-185 https://issues.apache.org/jira/browse/GEODE-185 Repository: geode Description --- The test code is now careful to wait for the expiration clock to advance. A different assertion will be triggered if the expiration clock goes back in time. Fixed two places in the product expiration code that did not use the expiration clock. Diffs - gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/ExpiryTask.java 95cd3a807ef54d66aaa9f257f6a3720738377a83 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionIdleExpiryTask.java fbcb12c8284e8f8829f48be5a18cecd48dc7d711 gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 69eeec03016b98bb7b420e2d41e15e53053d43e8 gemfire-core/src/test/java/dunit/DistributedTestCase.java 564e7efb947e4dd77b8cb3fa40e1ac9491d75afa Diff: https://reviews.apache.org/r/37143/diff/ Testing --- precheckin Thanks, Darrel Schneider
Re: git commit messages
+1 On Thu, Aug 6, 2015 at 9:15 AM, William Markito wmark...@pivotal.io wrote: +1 On Wed, Aug 5, 2015 at 4:49 PM, Vincent Ford vf...@pivotal.io wrote: +1 *Vince Ford* GemFire Sustenance Engineering Beaverton, OR USA 503-533-3726 (office) http://www.pivotal.io Open Source Project Geode https://geode.incubator.apache.org/ https://network.pivotal.io/products/project-geode On Wed, Aug 5, 2015 at 3:59 PM, Anthony Baker aba...@pivotal.io wrote: +1 Anthony On Aug 5, 2015, at 3:18 PM, Kirk Lund kl...@pivotal.io wrote: Several of us were discussing http://chris.beams.io/posts/git-commit/ -- there are a couple other really good articles about git commit messages and below is the message style I've been trying to follow. http://chris.beams.io/posts/git-commit/ http://www.laurencegellert.com/2013/07/how-to-write-a-proper-commit-message/ http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html GEODE-nn: Begin capitalized and 50 chars or less More detailed explanation with linefeeds to wrap at 72 characters after a blank line following the summary. Further paragraphs come after blank lines. - Bullet points are okay, too - Typically a hyphen or asterisk is used for the bullet, followed by a single space, with blank lines in between, but conventions vary here - Use a hanging indent -- William Markito Oliveira Enterprise Architect -- For questions about Apache Geode, please write to *dev@geode.incubator.apache.org dev@geode.incubator.apache.org*
Re: git commit messages
+1 On Wed, Aug 5, 2015 at 4:49 PM, Vincent Ford vf...@pivotal.io wrote: +1 *Vince Ford* GemFire Sustenance Engineering Beaverton, OR USA 503-533-3726 (office) http://www.pivotal.io Open Source Project Geode https://geode.incubator.apache.org/ https://network.pivotal.io/products/project-geode On Wed, Aug 5, 2015 at 3:59 PM, Anthony Baker aba...@pivotal.io wrote: +1 Anthony On Aug 5, 2015, at 3:18 PM, Kirk Lund kl...@pivotal.io wrote: Several of us were discussing http://chris.beams.io/posts/git-commit/ -- there are a couple other really good articles about git commit messages and below is the message style I've been trying to follow. http://chris.beams.io/posts/git-commit/ http://www.laurencegellert.com/2013/07/how-to-write-a-proper-commit-message/ http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html GEODE-nn: Begin capitalized and 50 chars or less More detailed explanation with linefeeds to wrap at 72 characters after a blank line following the summary. Further paragraphs come after blank lines. - Bullet points are okay, too - Typically a hyphen or asterisk is used for the bullet, followed by a single space, with blank lines in between, but conventions vary here - Use a hanging indent -- William Markito Oliveira Enterprise Architect -- For questions about Apache Geode, please write to *dev@geode.incubator.apache.org dev@geode.incubator.apache.org*
[Spring CI] Spring Data GemFire Nightly-ApacheGeode #26 was SUCCESSFUL (with 1000 tests)
--- Spring Data GemFire Nightly-ApacheGeode #26 was successful. --- Scheduled 1004 tests in total. https://build.spring.io/browse/SGF-NAG-26/ -- This message is automatically generated by Atlassian Bamboo
Re: git commit messages
+1 *Vince Ford* GemFire Sustenance Engineering Beaverton, OR USA 503-533-3726 (office) http://www.pivotal.io Open Source Project Geode https://geode.incubator.apache.org/ https://network.pivotal.io/products/project-geode On Wed, Aug 5, 2015 at 3:59 PM, Anthony Baker aba...@pivotal.io wrote: +1 Anthony On Aug 5, 2015, at 3:18 PM, Kirk Lund kl...@pivotal.io wrote: Several of us were discussing http://chris.beams.io/posts/git-commit/ -- there are a couple other really good articles about git commit messages and below is the message style I've been trying to follow. http://chris.beams.io/posts/git-commit/ http://www.laurencegellert.com/2013/07/how-to-write-a-proper-commit-message/ http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html GEODE-nn: Begin capitalized and 50 chars or less More detailed explanation with linefeeds to wrap at 72 characters after a blank line following the summary. Further paragraphs come after blank lines. - Bullet points are okay, too - Typically a hyphen or asterisk is used for the bullet, followed by a single space, with blank lines in between, but conventions vary here - Use a hanging indent
