Build failed in Jenkins: Geode-nightly #258

2015-10-26 Thread Apache Jenkins Server
See 

Changes:

[dschneider] GEODE-410: fix race in testEntryTtlLocalDestroy

[jhuynh] [GEODE-116] CopyOnReadIndexDUnitTest.testPRQueryOnLocalNode fails

[upthewaterspout] GEODE-399: Fixing race with stats in testNetSearchNormals

[upthewaterspout] Fixing compile failures under JDK 7

[klund] GEODE-103: Increase timeout and improve assertion message

[dschneider] GEODE-398: fix race in TXExpiryJUnitTest

[upthewaterspout] GEODE-426: Making PartitionedRegionRedundancyZoneDUnitTest 
clean up

[dschneider] GEODE-427: fix race in testEventDelivery

[klund] GEODE-164: Improve reliability of launcher integration tests

[eshu] Fixes GEODE-444 by closing client cache before closing server cache.

[upthewaterspout] GEODE-407, GEODE-349: Fixing race in 
testDatastoreCommitsWithPutAllAndRI

[dschneider] GEODE-441: fix broken test loop condition and remove index

[jhuynh] [GEODE-440] RangeIndexAPIJUnitTest.testQueryMethod_2 Added a flag to

[dschneider] GEODE-450: fix race in unit test

[klund] GEODE-346: Split into UnitTests and IntegrationTests

[dschneider] GEODE-376: fix intermittent fail of testNoDataSerializer

[upthewaterspout] GEODE-244: Adding debug logging for

[ashvin] GEODE-429: Remove HDFS RegionShortcuts

[ashvin] GEODE-429: Remove RegionFactory.setHdfsStore

[ashvin] GEODE-429: Remove hdfsStore gfsh commands

[ashvin] GEODE-429: Remove HdfsStore parser in cache xml

[ashvin] GEODE-429: Remove HDFS persistence DataPolicy

[ashvin] GEODE-429: Remove HdfsStore Junit and Dunits

[ashvin] GEODE-429: Remove Cache.createHdfsStoreFactory method

[ashvin] GEODE-429: Remove test category HoplogTests

[ashvin] GEODE-429: Remove api for setting HdfsStore in Attributes

[upthewaterspout] GEODE-392: Removing catch Throwable from 
CacheTestCase.closeCache

[wmarkito] [GEODE-409] - Fixing CacheXml41DUnitTest.testBridgeServers test by 
using

[upthewaterspout] GEODE-453, GEODE-458: Ignoring suspect string in

[dbarnes] GEODE-465 changed 2 occurrences of PartionedResolver to

[jdeppe] GEODE-408: Fixed race condition in tests

[dschneider] GEODE-445: fix race in unit test

[upthewaterspout] GEODE-370: Using SerialDistributionMessage for serializers

[upthewaterspout] GEODE-468: Using 1.8 generated files for 
AnalyzeSerializablesJUnitTest

[ashvin] GEODE-464: Fix Auto-Rebalancer test race condition

[huynhja] [GEODE-140]:

[jdeppe] Adding some debug code to log registered serializer's id

[eshu] [fixes GEODE-414] Add a retry so that PRMetaData will be updated with

[jhuynh] [GEODE-338] Disable FDDUnitTest for now, due to invalid test

[hkhamesra] fixed GEODE-412.

[eshu] [fixes GEODE-456] Fixes a race condition in the test by waiting for the

[upthewaterspout] GEODE-392: Using CacheTestCase.cache in DistTXDebugDUnitTest

[upthewaterspout] GEODE-392: Some enhancements to 
GemFireDeadlockDetectorDUnitTest

[dschneider] GEODE-376: fix race in waiting for serializer

[jhuynh] [GEODE-480] ConcurrentIndexUpdateWithoutWLDUnitTest.testRangeIndex Stat

[dschneider] GEODE-96: fix race in unit test

[dschneider] GEODE-471: figure out why entry is not expiring

[mbretl] GEODE-474: Upgrade Gradle version in wrapper to 2.8

[dschneider] removed debug logging accidently checked in

[wmarkito] GEODE-479 - Closing PR #23 bumping language level to Java 8

--
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on ubuntu-6 (docker Ubuntu ubuntu) in workspace 

Cloning the remote Git repository
Cloning repository https://git-wip-us.apache.org/repos/asf/incubator-geode.git
 > git init  # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/incubator-geode.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/incubator-geode.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/incubator-geode.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/incubator-geode.git # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/incubator-geode.git
 > git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/incubator-geode.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/develop^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/develop^{commit} # timeout=10
Checking out Revision 28eb3090bf42928eefe88bfae83355fa7258f96b 
(refs/remotes/origin/develop)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 28eb3090bf42928eefe88bfae83355fa7258f96b # timeout=10
 > git branch -a # timeout=10
 > git rev-parse remotes

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #107 was SUCCESSFUL (with 1214 tests)

2015-10-26 Thread Spring CI

---
Spring Data GemFire > Nightly-ApacheGeode > #107 was successful.
---
Scheduled
1218 tests in total.

https://build.spring.io/browse/SGF-NAG-107/





--
This message is automatically generated by Atlassian Bamboo

[GitHub] incubator-geode pull request: GEODE-465 changed 2 occurrences of P...

2015-10-26 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/22


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-geode pull request: GEODE-479 - Updating build.gradle to...

2015-10-26 Thread markito
Github user markito closed the pull request at:

https://github.com/apache/incubator-geode/pull/23


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Bump language level to 1.8

2015-10-26 Thread William Markito
Thanks guys!

I'm moving ahead and merge PR 23.


On Mon, Oct 26, 2015 at 3:06 PM, Kirk Lund  wrote:

> +1
>
> On Fri, Oct 23, 2015 at 9:27 AM, William Markito 
> wrote:
>
> > Folks,
> >
> > We had some discussions around this in the past but I guess we have not
> yet
> > made the decision to move forward and change the language level.
> >
> > Just opened GEODE-479 and would like to propose to do this change before
> > our Alpha release.
> >
> > Any thoughts ?
> > --
> > William Markito Oliveira
> > Enterprise Architect
> > -- For questions about Apache Geode, please write to
> > *dev@geode.incubator.apache.org
> > *
> >
>



-- 

William Markito Oliveira
-- For questions about Apache Geode, please write to
*dev@geode.incubator.apache.org
*


Re: Review Request 39664: GEODE-487: Remove integrationTest and distributedTest from build task.

2015-10-26 Thread Kirk Lund

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39664/#review104108
---

Ship it!


Ship It!

- Kirk Lund


On Oct. 26, 2015, 11:04 p.m., Mark Bretl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39664/
> ---
> 
> (Updated Oct. 26, 2015, 11:04 p.m.)
> 
> 
> Review request for geode, Kirk Lund and Dan Smith.
> 
> 
> Bugs: GEODE-487
> https://issues.apache.org/jira/browse/GEODE-487
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This commit removes integrationTest and distributedTest tasks from the
> build task lifecycle. The tasks were associated with the 'check' task,
> which is in the 'build' lifecycle. After removing the tasks, only the
> 'test' task is run when build task is executed.
> 
> 
> Diffs
> -
> 
>   build.gradle d8da7dee271af2d9c8334b3c3b1b6b2066abb3db 
> 
> Diff: https://reviews.apache.org/r/39664/diff/
> 
> 
> Testing
> ---
> 
> Tested by running 'clean build'
> 
> Build now runs in about 5 minutes
> 
> 
> Thanks,
> 
> Mark Bretl
> 
>



Re: Review Request 39664: GEODE-487: Remove integrationTest and distributedTest from build task.

2015-10-26 Thread Dan Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39664/#review104107
---

Ship it!


Might want to update the description for precheckin. Otherwise, looks good!

- Dan Smith


On Oct. 26, 2015, 11:04 p.m., Mark Bretl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39664/
> ---
> 
> (Updated Oct. 26, 2015, 11:04 p.m.)
> 
> 
> Review request for geode, Kirk Lund and Dan Smith.
> 
> 
> Bugs: GEODE-487
> https://issues.apache.org/jira/browse/GEODE-487
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This commit removes integrationTest and distributedTest tasks from the
> build task lifecycle. The tasks were associated with the 'check' task,
> which is in the 'build' lifecycle. After removing the tasks, only the
> 'test' task is run when build task is executed.
> 
> 
> Diffs
> -
> 
>   build.gradle d8da7dee271af2d9c8334b3c3b1b6b2066abb3db 
> 
> Diff: https://reviews.apache.org/r/39664/diff/
> 
> 
> Testing
> ---
> 
> Tested by running 'clean build'
> 
> Build now runs in about 5 minutes
> 
> 
> Thanks,
> 
> Mark Bretl
> 
>



Re: Review Request 39664: GEODE-487: Remove integrationTest and distributedTest from build task.

2015-10-26 Thread Mark Bretl

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39664/
---

(Updated Oct. 26, 2015, 11:04 p.m.)


Review request for geode, Kirk Lund and Dan Smith.


Bugs: GEODE-487
https://issues.apache.org/jira/browse/GEODE-487


Repository: geode


Description
---

This commit removes integrationTest and distributedTest tasks from the
build task lifecycle. The tasks were associated with the 'check' task,
which is in the 'build' lifecycle. After removing the tasks, only the
'test' task is run when build task is executed.


Diffs (updated)
-

  build.gradle d8da7dee271af2d9c8334b3c3b1b6b2066abb3db 

Diff: https://reviews.apache.org/r/39664/diff/


Testing
---

Tested by running 'clean build'

Build now runs in about 5 minutes


Thanks,

Mark Bretl



Re: Review Request 39664: GEODE-487: Remove integrationTest and distributedTest from build task.

2015-10-26 Thread Mark Bretl


> On Oct. 26, 2015, 9:58 p.m., Dan Smith wrote:
> > build.gradle, line 412
> > 
> >
> > I'm not sure this covers everything the build task used to do. I think 
> > the build task also ran some other tasks like assemble, installDist, etc.

You can view the lifecycle by ./gradlew clean precheckin -Dskip.tests=true


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39664/#review104093
---


On Oct. 26, 2015, 9:53 p.m., Mark Bretl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39664/
> ---
> 
> (Updated Oct. 26, 2015, 9:53 p.m.)
> 
> 
> Review request for geode, Kirk Lund and Dan Smith.
> 
> 
> Bugs: GEODE-487
> https://issues.apache.org/jira/browse/GEODE-487
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This commit removes integrationTest and distributedTest tasks from the
> build task lifecycle. The tasks were associated with the 'check' task,
> which is in the 'build' lifecycle. After removing the tasks, only the
> 'test' task is run when build task is executed.
> 
> 
> Diffs
> -
> 
>   build.gradle d8da7dee271af2d9c8334b3c3b1b6b2066abb3db 
> 
> Diff: https://reviews.apache.org/r/39664/diff/
> 
> 
> Testing
> ---
> 
> Tested by running 'clean build'
> 
> Build now runs in about 5 minutes
> 
> 
> Thanks,
> 
> Mark Bretl
> 
>



Re: Bump language level to 1.8

2015-10-26 Thread Kirk Lund
+1

On Fri, Oct 23, 2015 at 9:27 AM, William Markito 
wrote:

> Folks,
>
> We had some discussions around this in the past but I guess we have not yet
> made the decision to move forward and change the language level.
>
> Just opened GEODE-479 and would like to propose to do this change before
> our Alpha release.
>
> Any thoughts ?
> --
> William Markito Oliveira
> Enterprise Architect
> -- For questions about Apache Geode, please write to
> *dev@geode.incubator.apache.org
> *
>


Re: Review Request 39664: GEODE-487: Remove integrationTest and distributedTest from build task.

2015-10-26 Thread Dan Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39664/#review104093
---



build.gradle (line 412)


I'm not sure this covers everything the build task used to do. I think the 
build task also ran some other tasks like assemble, installDist, etc.


- Dan Smith


On Oct. 26, 2015, 9:53 p.m., Mark Bretl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39664/
> ---
> 
> (Updated Oct. 26, 2015, 9:53 p.m.)
> 
> 
> Review request for geode, Kirk Lund and Dan Smith.
> 
> 
> Bugs: GEODE-487
> https://issues.apache.org/jira/browse/GEODE-487
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This commit removes integrationTest and distributedTest tasks from the
> build task lifecycle. The tasks were associated with the 'check' task,
> which is in the 'build' lifecycle. After removing the tasks, only the
> 'test' task is run when build task is executed.
> 
> 
> Diffs
> -
> 
>   build.gradle d8da7dee271af2d9c8334b3c3b1b6b2066abb3db 
> 
> Diff: https://reviews.apache.org/r/39664/diff/
> 
> 
> Testing
> ---
> 
> Tested by running 'clean build'
> 
> Build now runs in about 5 minutes
> 
> 
> Thanks,
> 
> Mark Bretl
> 
>



Re: Review Request 39664: GEODE-487: Remove integrationTest and distributedTest from build task.

2015-10-26 Thread Mark Bretl

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39664/
---

(Updated Oct. 26, 2015, 9:53 p.m.)


Review request for geode, Kirk Lund and Dan Smith.


Changes
---

Add precheckin task for running all tests


Bugs: GEODE-487
https://issues.apache.org/jira/browse/GEODE-487


Repository: geode


Description
---

This commit removes integrationTest and distributedTest tasks from the
build task lifecycle. The tasks were associated with the 'check' task,
which is in the 'build' lifecycle. After removing the tasks, only the
'test' task is run when build task is executed.


Diffs (updated)
-

  build.gradle d8da7dee271af2d9c8334b3c3b1b6b2066abb3db 

Diff: https://reviews.apache.org/r/39664/diff/


Testing
---

Tested by running 'clean build'

Build now runs in about 5 minutes


Thanks,

Mark Bretl



Re: Review Request 39659: squash-a-thon week 1 fixes

2015-10-26 Thread Dan Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39659/#review104075
---

Ship it!


Ship It!

- Dan Smith


On Oct. 26, 2015, 5:29 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39659/
> ---
> 
> (Updated Oct. 26, 2015, 5:29 p.m.)
> 
> 
> Review request for geode, Kirk Lund and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> [GEODE-116] CopyOnReadIndexDUnitTest.testPRQueryOnLocalNode fails assertion 
> Modified test to not use mcast port Test will not spawn up multiple servers 
> for each test run, fixed to only start up servers once per test. Test now 
> runs in less time than before
> 
> 
> GEODE-399: Fixing race with stats in testNetSearchNormals
> 
> Some messages may not be done processing when the get completes. The
> test already had code to wait for one of the messages to show up, I've
> applied that wait to the rest of the assertions.
> 
> Fixing compile failures under JDK 7
> 
> NetSerachMessagingDUnitTest was not declaring fields as final that were
> used in an anonymous class.
> 
> GEODE-103: Increase timeout and improve assertion message
> 
> Increase timeout waiting for process start. Improve assertion message
> to include tiemout in milliseconds.
> 
> GEODE-398: fix race in TXExpiryJUnitTest
> 
> 
> GEODE-426: Making PartitionedRegionRedundancyZoneDUnitTest clean up
> 
> This test had a method called "caseTearDown" which I don't believe was
> actually getting run. It's really important for the tearDown code to
> happen, because otherwise the test leaves members configured with
> redundancy zones.
> 
> After changing caseTearDown to tearDown,
> PartitionedRegionTestUtilsDUnitTest now passes when it is run after this
> test.
> 
> GEODE-427: fix race in testEventDelivery
> 
> 
> GEODE-164: Improve reliability of launcher integration tests
> 
> 
> Fixes GEODE-444 by closing client cache before closing server cache.
> 
> 
> GEODE-407, GEODE-349: Fixing race in testDatastoreCommitsWithPutAllAndRI
> 
> This test performed and operation on the server and then asserted that
> an update happened on the client. But clients are notified
> asynchronously, so the client needs to wait until the update arrives.
> 
> GEODE-441: fix broken test loop condition and remove index
> 
> 
> [GEODE-440] RangeIndexAPIJUnitTest.testQueryMethod_2 Added a flag to ignore 
> the update in progress calculation for querying
> 
> 
> GEODE-450: fix race in unit test
> 
> The test now waits 30 seconds instead of 3.
> Also when it fails it will print info about when it
> thought the entry that is not expiring is scheduled to expire.
> 
> GEODE-346: Split into UnitTests and IntegrationTests
> 
> Extract IntegrationTests from AutoBalancerJUnitTest and move some
> common code to setup and teardown methods. Fix GEODE-346 by making
> teardown wait for HostStatSampler statThread to terminate.
> 
> Isolate test with sleep to its own test class and document. The next
> step should involve refactoring of AutoBalancer to break dependencies
> to allow for correct mocking.
> 
> Add Awaitility version 1.6.5 to dependencies (GEODE-217).
> 
> Add check to see if HostStatSampler statThread is alive or not.
> 
> GEODE-376: fix intermittent fail of testNoDataSerializer
> 
> 
> GEODE-244: Adding debug logging for 
> testRecoverRedundancyParallelAsyncEventQueueSimulation
> 
> This failure does not reproduce. I've enabled debug logging just for
> this one test case so that if it does fail again, I can track down what
> happened.
> 
> GEODE-429: Remove HDFS RegionShortcuts
> 
> 
> GEODE-429: Remove RegionFactory.setHdfsStore
> 
> 
> GEODE-429: Remove hdfsStore gfsh commands
> 
> 
> GEODE-429: Remove HdfsStore parser in cache xml
> 
> 
> GEODE-429: Remove HDFS persistence DataPolicy
> 
> 
> GEODE-429: Remove HdfsStore Junit and Dunits
> 
> 
> GEODE-429: Remove Cache.createHdfsStoreFactory method
> 
> 
> GEODE-429: Remove test category HoplogTests
> 
> 
> GEODE-429: Remove api for setting HdfsStore in Attributes
> 
> 
> GEODE-392: Removing catch Throwable from CacheTestCase.closeCache
> 
> I'm fairly certain that GEODE-392 was caused by cache.close throwing an
> exception in this method. Later on, we delete the disk store files, and
> then end up calling cache.close again in DistributedTestCase. The
> failure we are seeing is because the disk store files are deleted but
> the cache is still open.
> 
> Unfortunately, this catch throwable was swallowing all errors, so we
> were not seeing failures that happened when closing the cache.
> 
> [GEODE-409] - Fixing CacheXml41DUnitTest.testBridgeServers test by using 
> InetSocketAddress ephemeral port set to 0 and changing the cacheServe

Re: GEODE-188 Gfsh uses the wrong name for the gateway substitution filter in 'create async-event-queue' command

2015-10-26 Thread Dave Barnes
Following up with info provided by Dan Smith, and another question for the
community:

Answer to (1.):
Comment for Interface GatewayEventSubstitutionFilter: ..."provides a
way to specify
a substitute value to be stored in the GatewayQueueEvent and enqueued in
the RegionQueue."

Answer to (2.):
The attribute gateway-event-substitution-listener does not exist.

Followup question:
Under what circumstances would a person want to use this capability -- that
is, why slip a substitute value into the gateway event queue?
Thanks,
-Dave

On Wed, Oct 21, 2015 at 11:22 AM, Dave Barnes  wrote:

> GEODE-188 has been fixed in code, so I'd like to update the docs.
> The code fix was to replace "gateway-event-substitution-listener" with "
> gateway-event-substitution-filter".
> My questions:
> 1. Can someone please explain the purpose of 
> gateway-event-substitution-filter?
> I need to add a definition to the cache.xml documentation.
> 2. Is gateway-event-substitution-listener also a valid setting, which was
> simply out of place in this case, or is it a totally bogus name? If valid,
> can someone please explain this as well, so I can create a definition for
> cache.xml purposes?
> Thanks,
> Dave Barnes
> Sr. Content Dev, Pivotal
>


Re: Review Request 39664: GEODE-487: Remove integrationTest and distributedTest from build task.

2015-10-26 Thread Dan Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39664/#review104065
---


What is the target for completely building and testing the product now?

- Dan Smith


On Oct. 26, 2015, 6:35 p.m., Mark Bretl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39664/
> ---
> 
> (Updated Oct. 26, 2015, 6:35 p.m.)
> 
> 
> Review request for geode, Kirk Lund and Dan Smith.
> 
> 
> Bugs: GEODE-487
> https://issues.apache.org/jira/browse/GEODE-487
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This commit removes integrationTest and distributedTest tasks from the
> build task lifecycle. The tasks were associated with the 'check' task,
> which is in the 'build' lifecycle. After removing the tasks, only the
> 'test' task is run when build task is executed.
> 
> 
> Diffs
> -
> 
>   build.gradle d8da7dee271af2d9c8334b3c3b1b6b2066abb3db 
> 
> Diff: https://reviews.apache.org/r/39664/diff/
> 
> 
> Testing
> ---
> 
> Tested by running 'clean build'
> 
> Build now runs in about 5 minutes
> 
> 
> Thanks,
> 
> Mark Bretl
> 
>



Re: Review Request 39659: squash-a-thon week 1 fixes

2015-10-26 Thread Kirk Lund

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39659/#review104059
---

Ship it!



gemfire-core/src/main/java/com/gemstone/gemfire/cache/DataPolicy.java (line 245)


delete this line



gemfire-core/src/main/java/com/gemstone/gemfire/cache/DataPolicy.java (line 246)


fix the indentation on this line



gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionedRegionRebalanceOp.java
 (line 80)


the disadvantage of using this technique is that you cannot enable 
debugging via log4j2



gemfire-core/src/test/java/com/gemstone/gemfire/internal/FDDUnitTest.java (line 
77)


add comment pointing at GEODE-338 and saying test is disabled because 
failing assertion is invalid



gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionSingleHopDUnitTest.java
 (line 109)


delete this commented block



gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/RemoteTransactionDUnitTest.java
 (line 4087)


is this newly declared variable used?



gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/OnGroupsFunctionExecutionDUnitTest.java
 (line 80)


indentation inside this block appears to be wrong



gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/OnGroupsFunctionExecutionDUnitTest.java
 (line 143)


indentation inside this block appears to be wrong



gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/OnGroupsFunctionExecutionDUnitTest.java
 (line 158)


indentation inside this block appears to be wrong



gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/OnGroupsFunctionExecutionDUnitTest.java
 (line 173)


indentation inside this block appears to be wrong



gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/OnGroupsFunctionExecutionDUnitTest.java
 (line 188)


indentation inside this block appears to be wrong


- Kirk Lund


On Oct. 26, 2015, 5:29 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39659/
> ---
> 
> (Updated Oct. 26, 2015, 5:29 p.m.)
> 
> 
> Review request for geode, Kirk Lund and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> [GEODE-116] CopyOnReadIndexDUnitTest.testPRQueryOnLocalNode fails assertion 
> Modified test to not use mcast port Test will not spawn up multiple servers 
> for each test run, fixed to only start up servers once per test. Test now 
> runs in less time than before
> 
> 
> GEODE-399: Fixing race with stats in testNetSearchNormals
> 
> Some messages may not be done processing when the get completes. The
> test already had code to wait for one of the messages to show up, I've
> applied that wait to the rest of the assertions.
> 
> Fixing compile failures under JDK 7
> 
> NetSerachMessagingDUnitTest was not declaring fields as final that were
> used in an anonymous class.
> 
> GEODE-103: Increase timeout and improve assertion message
> 
> Increase timeout waiting for process start. Improve assertion message
> to include tiemout in milliseconds.
> 
> GEODE-398: fix race in TXExpiryJUnitTest
> 
> 
> GEODE-426: Making PartitionedRegionRedundancyZoneDUnitTest clean up
> 
> This test had a method called "caseTearDown" which I don't believe was
> actually getting run. It's really important for the tearDown code to
> happen, because otherwise the test leaves members configured with
> redundancy zones.
> 
> After changing caseTearDown to tearDown,
> PartitionedRegionTestUtilsDUnitTest now passes when it is run after this
> test.
> 
> GEODE-427: fix race in testEventDelivery
> 
> 
> GEODE-164: Improve reliability of launcher integration tests
> 
> 
> Fixes GEODE-444 by closing client cache before closing server cache.
> 
> 
> GEODE-407, GEODE-349: Fixing race in testDatastoreCommitsWithPutAllAndRI
> 
> This test performed and operation on the server and then asserted that
> an update happened on the client. But clients are notified
> asynchronously, so the client needs to wait until the update arrives.
> 
> GEODE-441: fix broken test loop condition and remove inde

Re: Review Request 39659: squash-a-thon week 1 fixes

2015-10-26 Thread Darrel Schneider

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39659/#review104062
---

Ship it!



gemfire-core/src/test/java/com/gemstone/gemfire/disttx/DistTXPersistentDebugDUnitTest.java
 (line 11)


All these imports that were added are unused and will be removed.


- Darrel Schneider


On Oct. 26, 2015, 10:29 a.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39659/
> ---
> 
> (Updated Oct. 26, 2015, 10:29 a.m.)
> 
> 
> Review request for geode, Kirk Lund and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> [GEODE-116] CopyOnReadIndexDUnitTest.testPRQueryOnLocalNode fails assertion 
> Modified test to not use mcast port Test will not spawn up multiple servers 
> for each test run, fixed to only start up servers once per test. Test now 
> runs in less time than before
> 
> 
> GEODE-399: Fixing race with stats in testNetSearchNormals
> 
> Some messages may not be done processing when the get completes. The
> test already had code to wait for one of the messages to show up, I've
> applied that wait to the rest of the assertions.
> 
> Fixing compile failures under JDK 7
> 
> NetSerachMessagingDUnitTest was not declaring fields as final that were
> used in an anonymous class.
> 
> GEODE-103: Increase timeout and improve assertion message
> 
> Increase timeout waiting for process start. Improve assertion message
> to include tiemout in milliseconds.
> 
> GEODE-398: fix race in TXExpiryJUnitTest
> 
> 
> GEODE-426: Making PartitionedRegionRedundancyZoneDUnitTest clean up
> 
> This test had a method called "caseTearDown" which I don't believe was
> actually getting run. It's really important for the tearDown code to
> happen, because otherwise the test leaves members configured with
> redundancy zones.
> 
> After changing caseTearDown to tearDown,
> PartitionedRegionTestUtilsDUnitTest now passes when it is run after this
> test.
> 
> GEODE-427: fix race in testEventDelivery
> 
> 
> GEODE-164: Improve reliability of launcher integration tests
> 
> 
> Fixes GEODE-444 by closing client cache before closing server cache.
> 
> 
> GEODE-407, GEODE-349: Fixing race in testDatastoreCommitsWithPutAllAndRI
> 
> This test performed and operation on the server and then asserted that
> an update happened on the client. But clients are notified
> asynchronously, so the client needs to wait until the update arrives.
> 
> GEODE-441: fix broken test loop condition and remove index
> 
> 
> [GEODE-440] RangeIndexAPIJUnitTest.testQueryMethod_2 Added a flag to ignore 
> the update in progress calculation for querying
> 
> 
> GEODE-450: fix race in unit test
> 
> The test now waits 30 seconds instead of 3.
> Also when it fails it will print info about when it
> thought the entry that is not expiring is scheduled to expire.
> 
> GEODE-346: Split into UnitTests and IntegrationTests
> 
> Extract IntegrationTests from AutoBalancerJUnitTest and move some
> common code to setup and teardown methods. Fix GEODE-346 by making
> teardown wait for HostStatSampler statThread to terminate.
> 
> Isolate test with sleep to its own test class and document. The next
> step should involve refactoring of AutoBalancer to break dependencies
> to allow for correct mocking.
> 
> Add Awaitility version 1.6.5 to dependencies (GEODE-217).
> 
> Add check to see if HostStatSampler statThread is alive or not.
> 
> GEODE-376: fix intermittent fail of testNoDataSerializer
> 
> 
> GEODE-244: Adding debug logging for 
> testRecoverRedundancyParallelAsyncEventQueueSimulation
> 
> This failure does not reproduce. I've enabled debug logging just for
> this one test case so that if it does fail again, I can track down what
> happened.
> 
> GEODE-429: Remove HDFS RegionShortcuts
> 
> 
> GEODE-429: Remove RegionFactory.setHdfsStore
> 
> 
> GEODE-429: Remove hdfsStore gfsh commands
> 
> 
> GEODE-429: Remove HdfsStore parser in cache xml
> 
> 
> GEODE-429: Remove HDFS persistence DataPolicy
> 
> 
> GEODE-429: Remove HdfsStore Junit and Dunits
> 
> 
> GEODE-429: Remove Cache.createHdfsStoreFactory method
> 
> 
> GEODE-429: Remove test category HoplogTests
> 
> 
> GEODE-429: Remove api for setting HdfsStore in Attributes
> 
> 
> GEODE-392: Removing catch Throwable from CacheTestCase.closeCache
> 
> I'm fairly certain that GEODE-392 was caused by cache.close throwing an
> exception in this method. Later on, we delete the disk store files, and
> then end up calling cache.close again in DistributedTestCase. The
> failure we are seeing is because the disk store files are deleted but
> the cache is still open.
> 
> Unfortunately, this catch throwable was swallowing all er

Review Request 39664: GEODE-487: Remove integrationTest and distributedTest from build task.

2015-10-26 Thread Mark Bretl

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39664/
---

Review request for geode, Kirk Lund and Dan Smith.


Bugs: GEODE-487
https://issues.apache.org/jira/browse/GEODE-487


Repository: geode


Description
---

This commit removes integrationTest and distributedTest tasks from the
build task lifecycle. The tasks were associated with the 'check' task,
which is in the 'build' lifecycle. After removing the tasks, only the
'test' task is run when build task is executed.


Diffs
-

  build.gradle d8da7dee271af2d9c8334b3c3b1b6b2066abb3db 

Diff: https://reviews.apache.org/r/39664/diff/


Testing
---

Tested by running 'clean build'

Build now runs in about 5 minutes


Thanks,

Mark Bretl



Review Request 39659: squash-a-thon week 1 fixes

2015-10-26 Thread Darrel Schneider

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39659/
---

Review request for geode, Kirk Lund and Dan Smith.


Repository: geode


Description
---

[GEODE-116] CopyOnReadIndexDUnitTest.testPRQueryOnLocalNode fails assertion 
Modified test to not use mcast port Test will not spawn up multiple servers for 
each test run, fixed to only start up servers once per test. Test now runs in 
less time than before


GEODE-399: Fixing race with stats in testNetSearchNormals

Some messages may not be done processing when the get completes. The
test already had code to wait for one of the messages to show up, I've
applied that wait to the rest of the assertions.

Fixing compile failures under JDK 7

NetSerachMessagingDUnitTest was not declaring fields as final that were
used in an anonymous class.

GEODE-103: Increase timeout and improve assertion message

Increase timeout waiting for process start. Improve assertion message
to include tiemout in milliseconds.

GEODE-398: fix race in TXExpiryJUnitTest


GEODE-426: Making PartitionedRegionRedundancyZoneDUnitTest clean up

This test had a method called "caseTearDown" which I don't believe was
actually getting run. It's really important for the tearDown code to
happen, because otherwise the test leaves members configured with
redundancy zones.

After changing caseTearDown to tearDown,
PartitionedRegionTestUtilsDUnitTest now passes when it is run after this
test.

GEODE-427: fix race in testEventDelivery


GEODE-164: Improve reliability of launcher integration tests


Fixes GEODE-444 by closing client cache before closing server cache.


GEODE-407, GEODE-349: Fixing race in testDatastoreCommitsWithPutAllAndRI

This test performed and operation on the server and then asserted that
an update happened on the client. But clients are notified
asynchronously, so the client needs to wait until the update arrives.

GEODE-441: fix broken test loop condition and remove index


[GEODE-440] RangeIndexAPIJUnitTest.testQueryMethod_2 Added a flag to ignore the 
update in progress calculation for querying


GEODE-450: fix race in unit test

The test now waits 30 seconds instead of 3.
Also when it fails it will print info about when it
thought the entry that is not expiring is scheduled to expire.

GEODE-346: Split into UnitTests and IntegrationTests

Extract IntegrationTests from AutoBalancerJUnitTest and move some
common code to setup and teardown methods. Fix GEODE-346 by making
teardown wait for HostStatSampler statThread to terminate.

Isolate test with sleep to its own test class and document. The next
step should involve refactoring of AutoBalancer to break dependencies
to allow for correct mocking.

Add Awaitility version 1.6.5 to dependencies (GEODE-217).

Add check to see if HostStatSampler statThread is alive or not.

GEODE-376: fix intermittent fail of testNoDataSerializer


GEODE-244: Adding debug logging for 
testRecoverRedundancyParallelAsyncEventQueueSimulation

This failure does not reproduce. I've enabled debug logging just for
this one test case so that if it does fail again, I can track down what
happened.

GEODE-429: Remove HDFS RegionShortcuts


GEODE-429: Remove RegionFactory.setHdfsStore


GEODE-429: Remove hdfsStore gfsh commands


GEODE-429: Remove HdfsStore parser in cache xml


GEODE-429: Remove HDFS persistence DataPolicy


GEODE-429: Remove HdfsStore Junit and Dunits


GEODE-429: Remove Cache.createHdfsStoreFactory method


GEODE-429: Remove test category HoplogTests


GEODE-429: Remove api for setting HdfsStore in Attributes


GEODE-392: Removing catch Throwable from CacheTestCase.closeCache

I'm fairly certain that GEODE-392 was caused by cache.close throwing an
exception in this method. Later on, we delete the disk store files, and
then end up calling cache.close again in DistributedTestCase. The
failure we are seeing is because the disk store files are deleted but
the cache is still open.

Unfortunately, this catch throwable was swallowing all errors, so we
were not seeing failures that happened when closing the cache.

[GEODE-409] - Fixing CacheXml41DUnitTest.testBridgeServers test by using 
InetSocketAddress ephemeral port set to 0 and changing the cacheServer 
comparison to ignore port check if it's configured to 0.


Previous commit message should be GEODE-449 instead of GEODE-409


GEODE-453, GEODE-458: Ignoring suspect string in 
testRegisterInterestNoDataStores


GEODE-408: Fixed race condition in tests

- For local functions stats might be checked before they are actually
  updated.

GEODE-445: fix race in unit test

The test now uses a WaitCriteria when checking
member and profile count.

GEODE-370: Using SerialDistributionMessage for serializers

DataSerializers were being sent using PooledDistributionMessage. That
meant they could  be processed out of order. When DataSerializers were
a

Re: GEODE-474: Update Gradle Wrapper to Gradle Version 2.8

2015-10-26 Thread Mark Bretl
This is now checked in on develop.

--Mark

On Thu, Oct 22, 2015 at 6:38 PM, Anthony Baker  wrote:

> Tested and works for me.
>
> > On Oct 22, 2015, at 5:46 PM, Udo Kohlmeyer 
> wrote:
> >
> > +1
> >
> > On 10/23/2015 11:44 AM, William Markito wrote:
> >> +1
> >>
> >> On Thu, Oct 22, 2015 at 5:30 PM, Dan Smith  wrote:
> >>
> >>> +1
> >>>
> >>> -Dan
> >>>
> >>> On Thu, Oct 22, 2015 at 4:42 PM, Mark Bretl  wrote:
> >>>
>  Hi,
> 
>  I would like to discuss GEODE-474,
>  https://issues.apache.org/jira/browse/GEODE-474. We have not updated
> our
>  Gradle version since starting incubation, which is using 2.3, and
> there
>  have been Gradle releases with some useful features.
> 
>  Features of 2.8 include:
> 
> - Faster configuration
> - Continuous builds
> - Incremental builds
> - Faster builds
> - Improved IDE support
> 
> 
>  As for build time, the following is execution time for running the
> tasks
>  'clean build -Dskip.tests=true':
>  Gradle 2.3: 1 mins 55.045 secs
>  Gradle 2.8: 1 mins 21.865 secs
> 
>  For those using their own Gradle installation, the minimum version
> would
>  still be 2.3.
> 
>  Comments, Questions, Concerns?
> 
>  --Mark
> 
> >>
> >>
> >
>
>


-- 
Mark Bretl
Software Build Engineer
Pivotal
503-533-3869
www.pivotal.io


Build failed in Jenkins: Geode-nightly #257

2015-10-26 Thread Apache Jenkins Server
See 

--
[...truncated 176 lines...]
Field f = sun.misc.Unsafe.class.getDeclaredField("theUnsafe");
  ^
:2152:
 warning: Unsafe is internal proprietary API and may be removed in a future 
release
U = (sun.misc.Unsafe) f.get(null);
 ^
:2473:
 warning: Unsafe is internal proprietary API and may be removed in a future 
release
private static final sun.misc.Unsafe U;
 ^
:2484:
 warning: Unsafe is internal proprietary API and may be removed in a future 
release
Field f = sun.misc.Unsafe.class.getDeclaredField("theUnsafe");
  ^
:2486:
 warning: Unsafe is internal proprietary API and may be removed in a future 
release
U = (sun.misc.Unsafe) f.get(null);
 ^
:43:
 warning: SignalHandler is internal proprietary API and may be removed in a 
future release
  private final Map originalSignalHandlers = 
Collections.synchronizedMap(
^
:44:
 warning: SignalHandler is internal proprietary API and may be removed in a 
future release
new Hashtable(Signal.values().length));
  ^
:54:
 warning: Signal is internal proprietary API and may be removed in a future 
release
originalSignalHandlers.put(signal, sun.misc.Signal.handle(new 
sun.misc.Signal(signal.getName()), this));
  ^
:54:
 warning: Signal is internal proprietary API and may be removed in a future 
release
originalSignalHandlers.put(signal, sun.misc.Signal.handle(new 
sun.misc.Signal(signal.getName()), this));
   ^
:60:
 warning: Signal is internal proprietary API and may be removed in a future 
release
  public void handle(final sun.misc.Signal sig) {
   ^
:67:
 warning: Signal is internal proprietary API and may be removed in a future 
release
  protected void handleDefault(final sun.misc.Signal sig) {
 ^
:73:
 warning: SignalHandler is internal proprietary API and may be removed in a 
future release
final SignalHandler handler = getOriginalSignalHandler(signal);
  ^
:80:
 warning: SignalHandler is internal proprietary API and may be removed in a 
future release
  protected SignalHandler getOriginalSignalHandler(final Signal signal) {
^
:81:
 warning: SignalHandler is internal proprietary API and may be removed in a 
future release
final SignalHandler handler = originalSignalHandlers.get(signal);
  ^
:82:
 warning: SignalHandler is internal proprietary API and may