Review Request 41044: Update process stream handling in tests that fork JVMs

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41044/
---

Review request for geode, Darrel Schneider and Jens Deppe.


Bugs: GEODE-291
https://issues.apache.org/jira/browse/GEODE-291


Repository: geode


Description
---

Add build dependencies for testing frameworks Awaitility and Catch-Exception. 
Upgrade AssertJ build dependency.

Refactor DistributedSystem PROPERTY_FILE constants, system property and APIs to 
facilitate automated testing. Create UnitTest and IntegrationTest for 
DistributedSystem.

Tighten up ProcessWrapper, ProcessStreamReader and ProcessOutputReader to 
eliminate intermittent failures and unwanted stderr output in Jenkins.

Extract integration tests from launcher UnitTests to new IntegrationTests.

Convert tests in LocatorLauncherIntegrationJUnitTest and 
ServerLauncherIntegrationJUnitTest to follow BDD style.

I will delete Geode291TestSuite before merging to develop.


Diffs
-

  build.gradle b5465b8 
  
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/AbstractLauncher.java
 bfd3de7 
  
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/DistributedSystem.java
 e2fccd9 
  
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherIntegrationJUnitTest.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherJUnitTest.java
 399c78f 
  
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/CommonLauncherTestSuite.java
 94ba320 
  
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemIntegrationJUnitTest.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemJUnitTest.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherIntegrationJUnitTest.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherJUnitTest.java
 003a098 
  
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherIntegrationJUnitTest.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherJUnitTest.java
 6884e58 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/process/Geode291TestSuite.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/process/ProcessOutputReader.java
 e99dceb 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/process/ProcessStreamReader.java
 f99f5f9 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/process/ProcessWrapper.java
 2847b34 
  gradle/dependency-versions.properties 3e6b6a5 

Diff: https://reviews.apache.org/r/41044/diff/


Testing
---

new tests and precheckin


Thanks,

Kirk Lund

Licenses on XML files

[Anthony Baker]

I was adding licenses to XML files this weekend and noticed a problem.  This 
code expects a certain structure to the xml doc that doesn’t allow for a 
comment:

 /**
   * Build cache element map for given doc's
   * schemaLocation for {@link CacheXml#NAMESPACE}.
   *
   * @param doc
   *  {@link Document} to parse schema for.
   * @return Element map
   * @throws IOException
   * @throws ParserConfigurationException
   * @throws SAXException
   * @throws XPathExpressionException
   * @since 8.1
   */
  public static LinkedHashMap buildElementMap(final 
Document doc) throws IOException, XPathExpressionException, SAXException, 
ParserConfigurationException {
final Map schemaLocationMap = 
XmlUtils.buildSchemaLocationMap(
getAttribute(doc.getFirstChild(), 
W3C_XML_SCHEMA_INSTANCE_ATTRIBUTE_SCHEMA_LOCATION, 
W3C_XML_SCHEMA_INSTANCE_NS_URI));

final LinkedHashMap elementMap = new 
LinkedHashMap();

buildElementMapCacheType(elementMap, resolveSchema(schemaLocationMap, 
CacheXml.NAMESPACE));

// if we are ever concerned with the order of extensions or children 
process them here.

return elementMap;
  }

If you add a license header to CacheElementJUnitTest.xml and run 
CacheElementJUnitTest you will get an NPE.


So two questions:

1) Do all of our test xml files need license headers (it does make the 
exclusion list for RAT simple)?
2) Is the code above correct?

Thanks,
Anthony



signature.asc
Description: Message signed with OpenPGP using GPGMail

[GitHub] incubator-geode pull request: GEODE-341: Refactor Java packages to...

[jujoramos]

Github user jujoramos closed the pull request at:

https://github.com/apache/incubator-geode/pull/46


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-nightly #304

[Apache Jenkins Server]

See 

--
[...truncated 260 lines...]
:gemfire-web:jar
:gemfire-web:war
:gemfire-web-api:compileJavaNote: Some input files use unchecked or unsafe 
operations.
Note: Recompile with -Xlint:unchecked for details.

:gemfire-web-api:processResources UP-TO-DATE
:gemfire-web-api:classes
:gemfire-web-api:jar
:gemfire-web-api:war
:gemfire-assembly:distTar
:gemfire-assembly:distZip
:gemfire-assembly:jar SKIPPED
:gemfire-assembly:assemble
:gemfire-core:compileTestJava:22:
 warning: Unsafe is internal proprietary API and may be removed in a future 
release
import sun.misc.Unsafe;
   ^
:22:
 warning: Unsafe is internal proprietary API and may be removed in a future 
release
import sun.misc.Unsafe;
   ^
:22:
 warning: Unsafe is internal proprietary API and may be removed in a future 
release
import sun.misc.Unsafe;
   ^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
3 warnings

:gemfire-core:processTestResources
:gemfire-core:testClasses
:gemfire-core:jarTest
:gemfire-assembly:compileTestJava
:gemfire-assembly:processTestResources UP-TO-DATE
:gemfire-assembly:testClasses
:gemfire-assembly:checkMissedTests
:gemfire-assembly:installDist
:gemfire-assembly:test
Build file ': 
line 70
AvailablePortFinder has been deprecated and is scheduled to be removed in 
Gradle 3.0
:gemfire-assembly:check
:gemfire-assembly:build
:gemfire-assembly:distributedTest UP-TO-DATE
:gemfire-assembly:integrationTest
:gemfire-common:assemble
:gemfire-common:compileTestJava
:gemfire-common:processTestResources UP-TO-DATE
:gemfire-common:testClasses
:gemfire-common:checkMissedTests
:gemfire-common:test
:gemfire-common:check
:gemfire-common:build
:gemfire-common:distributedTest UP-TO-DATE
:gemfire-common:integrationTest
:gemfire-core:assemble
:gemfire-core:checkMissedTests
:gemfire-core:test

com.gemstone.gemfire.distributed.internal.membership.gms.locator.GMSLocatorRecoveryJUnitTest
 > testRecoverFromOther FAILED
com.gemstone.gemfire.GemFireConfigException: This process is attempting to 
join with a loopback address (localhost/127.0.0.1) using a locator that does 
not have a local address (asf905.gq1.ygridcore.net/67.195.81.149:22765).  On 
Unix this usually means that /etc/hosts is misconfigured.
at 
com.gemstone.gemfire.distributed.internal.membership.gms.GMSUtil.parseLocators(GMSUtil.java:82)
at 
com.gemstone.gemfire.distributed.internal.membership.gms.GMSUtil.parseLocators(GMSUtil.java:47)
at 
com.gemstone.gemfire.distributed.internal.membership.gms.membership.GMSJoinLeave.init(GMSJoinLeave.java:1429)
at 
com.gemstone.gemfire.distributed.internal.membership.gms.Services.init(Services.java:129)
at 
com.gemstone.gemfire.distributed.internal.membership.gms.GMSMemberFactory.newMembershipManager(GMSMemberFactory.java:104)
at 
com.gemstone.gemfire.distributed.internal.membership.MemberFactory.newMembershipManager(MemberFactory.java:93)
at 
com.gemstone.gemfire.distributed.internal.membership.gms.locator.GMSLocatorRecoveryJUnitTest.testRecoverFromOther(GMSLocatorRecoveryJUnitTest.java:164)

1548 tests completed, 1 failed, 35 skipped
:gemfire-core:test FAILED
:gemfire-core:distributedTest
:gemfire-core:integrationTest
:gemfire-joptsimple:assemble
:gemfire-joptsimple:compileTestJava UP-TO-DATE
:gemfire-joptsimple:processTestResources UP-TO-DATE
:gemfire-joptsimple:testClasses UP-TO-DATE
:gemfire-joptsimple:checkMissedTests UP-TO-DATE
:gemfire-joptsimple:test UP-TO-DATE
:gemfire-joptsimple:check
:gemfire-joptsimple:build
:gemfire-joptsimple:distributedTest UP-TO-DATE
:gemfire-joptsimple:integrationTest UP-TO-DATE
:gemfire-json:assemble
:gemfire-json:compileTestJava UP-TO-DATE
:gemfire-json:processTestResources UP-TO-DATE
:gemfire-json:testClasses UP-TO-DATE
:gemfire-json:checkMissedTests UP-TO-DATE
:gemfire-json:test UP-TO-DATE
:gemfire-json:check
:gemfire-json:build
:gemfire-json:distributedTest UP-TO-DATE
:gemfire-json:integrationTest UP-TO-DATE
:gemfire-junit:jar
:gemfire-junit:assemble
:gemfire-junit:checkMissedTests
:gemfire-junit:test
:gemfire-junit:check
:gemfire-junit:build
:gemfire-junit:distributedTest UP-TO-DATE
:gemfire-junit:integrationTest
:gemfire-lucene:assemble
:gemfire-lucene:compileTestJavaNote: 

Re: Review Request 41058: GEODE-637: Additional tests for AsyncEventQueues

[Ashvin A]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41058/#review109221
---

Ship it!


Ship It!


gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/AsyncEventQueueTestBase.java
 (line 75)


Do these test classes need to be put in a test category?


- Ashvin A


On Dec. 7, 2015, 11:24 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41058/
> ---
> 
> (Updated Dec. 7, 2015, 11:24 p.m.)
> 
> 
> Review request for geode, Ashvin A and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-637: Additional tests for AsyncEventQueues
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/AsyncEventQueueTestBase.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerOffHeapDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventQueueStatsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentAsyncEventQueueDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentAsyncEventQueueOffHeapDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/CommonParallelAsyncEventQueueDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/CommonParallelAsyncEventQueueOffHeapDUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41058/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

[GitHub] incubator-geode pull request: Feature/geode 623

[gemzdude]

GitHub user gemzdude opened a pull request:

https://github.com/apache/incubator-geode/pull/48

Feature/geode 623

Added new method cleanStackTrace to RefCountChangeInfo to generate stack 
trace 
prior to offheap frames.
Modified RefCountChangeInfo to use new method when saving to change info
as well as when generating toString string.
Removed private from getStackTraceString to allow use by unit test.

Created new unit test RefCountChangeInfoJUnitTest. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gemzdude/incubator-geode feature/GEODE-623

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #48


commit 602c354cd00541ee00c5ec7774a7cd5564035483
Author: Scott Jewell 
Date:   2015-12-04T21:06:58Z

New unit test for RefCountChangeInfo

commit 4815d83f178fc3797f9fbcfb0725bf6f4ddde463
Author: Scott Jewell 
Date:   2015-12-04T21:09:44Z

Modified format of stack trace maintained within RefCountChangeInfo




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Include templates in the binary distribution?

[Dan Smith]

At the very least, it seems like this code should move somewhere that
indicates it's an example, rather than test code. Maybe we should create a
new gradle module gemfire-examples? Or at least move this to a different
source folder like gemfire-core/src/example?

-Dan

On Mon, Dec 7, 2015 at 1:06 PM, Mark Bretl  wrote:

> Initial plan was to scrap the binary distribution of the examples and have
> it all 'online' so they can be managed all in one place, as well as kept
> up-to-date better. Once we have a place for docs on Apache resources, this
> might become clearer.
>
> --Mark
>
> On Mon, Dec 7, 2015 at 12:52 PM, Michael Stolz  wrote:
>
> > Seems to me they should be. All the examples for that matter.
> >
> > --
> > Mike Stolz
> > Principal Engineer, GemFire Product Manager
> > Mobile: 631-835-4771
> >
> > On Mon, Dec 7, 2015 at 2:56 PM, Dan Smith  wrote:
> >
> > > Hi,
> > >
> > > Gemfire used to ship with some examples of security authenticators and
> > > initializers. In geode, that example code is sitting under
> > > gemfire-core/src/test/java/templates.
> > >
> > > Should those examples be distributed as part of the binary tarball for
> > > geode?
> > >
> > > -Dan
> > >
> >
>
>
>
> --
> Mark Bretl
> Software Build Engineer
> Pivotal
> 503-533-3869
> www.pivotal.io
>

Re: Licenses on XML files

[Niall Pemberton]

On Mon, Dec 7, 2015 at 5:35 PM, Anthony Baker  wrote:

> I was adding licenses to XML files this weekend and noticed a problem.
> This code expects a certain structure to the xml doc that doesn’t allow for
> a comment:
>
>  /**
>* Build cache element map for given doc's
>* schemaLocation for {@link CacheXml#NAMESPACE}.
>*
>* *@param* doc
>*  {@link Document} to parse schema for.
>* *@return* Element map
>* *@throws* IOException
>* *@throws* ParserConfigurationException
>* *@throws* SAXException
>* *@throws* XPathExpressionException
>* *@since* 8.1
>*/
>   *public* *static* LinkedHashMap buildElementMap(
> *final* Document doc) *throws* IOException, XPathExpressionException,
> SAXException, ParserConfigurationException {
> *final* Map schemaLocationMap = XmlUtils.
> *buildSchemaLocationMap*(
> *getAttribute*(doc.getFirstChild(),
> *W3C_XML_SCHEMA_INSTANCE_ATTRIBUTE_SCHEMA_LOCATION*,
> *W3C_XML_SCHEMA_INSTANCE_NS_URI*));
>
> *final* LinkedHashMap elementMap = *new*
> LinkedHashMap();
>
> *buildElementMapCacheType*(elementMap, *resolveSchema*(
> schemaLocationMap, CacheXml.*NAMESPACE*));
>
> // if we are ever concerned with the order of extensions or children
> process them here.
>
> *return* elementMap;
>   }
>
> If you add a license header to CacheElementJUnitTest.xml and run
> CacheElementJUnitTest you will get an NPE.
>
>
> So two questions:
>
> 1) Do all of our test xml files need license headers (it does make the
> exclusion list for RAT simple)?
>

It *reduces* the noise level if the RAT exclusion list is as small as
possible - so where it makes no difference, then I would say yes add them.
But I wouldn't get hung up on every little test file that can easily be
justified under the "contains no creative content" category.

Niall



> 2) Is the code above correct?
>
> Thanks,
> Anthony
>
>

Re: Include templates in the binary distribution?

[Nitin Lamba]

+1

If these examples can span modules (using core and another module), then having 
a separate module (geode-examples) makes sense.

-Nitin


From: Dan Smith 
Sent: Monday, December 7, 2015 1:55 PM
To: geode
Subject: Re: Include templates in the binary distribution?

At the very least, it seems like this code should move somewhere that
indicates it's an example, rather than test code. Maybe we should create a
new gradle module gemfire-examples? Or at least move this to a different
source folder like gemfire-core/src/example?

-Dan

On Mon, Dec 7, 2015 at 1:06 PM, Mark Bretl  wrote:

> Initial plan was to scrap the binary distribution of the examples and have
> it all 'online' so they can be managed all in one place, as well as kept
> up-to-date better. Once we have a place for docs on Apache resources, this
> might become clearer.
>
> --Mark
>
> On Mon, Dec 7, 2015 at 12:52 PM, Michael Stolz  wrote:
>
> > Seems to me they should be. All the examples for that matter.
> >
> > --
> > Mike Stolz
> > Principal Engineer, GemFire Product Manager
> > Mobile: 631-835-4771
> >
> > On Mon, Dec 7, 2015 at 2:56 PM, Dan Smith  wrote:
> >
> > > Hi,
> > >
> > > Gemfire used to ship with some examples of security authenticators and
> > > initializers. In geode, that example code is sitting under
> > > gemfire-core/src/test/java/templates.
> > >
> > > Should those examples be distributed as part of the binary tarball for
> > > geode?
> > >
> > > -Dan
> > >
> >
>
>
>
> --
> Mark Bretl
> Software Build Engineer
> Pivotal
> 503-533-3869
> www.pivotal.io
>

Re: Include templates in the binary distribution?

[Roman Shaposhnik]

On Mon, Dec 7, 2015 at 1:55 PM, Dan Smith  wrote:
> At the very least, it seems like this code should move somewhere that
> indicates it's an example, rather than test code. Maybe we should create a
> new gradle module gemfire-examples? Or at least move this to a different
> source folder like gemfire-core/src/example?

Also, remember that if you make your examples available as part of the
build it'll simplify downstream packaging (think Linux distros) quite a bit.

Thanks,
Roman.

Re: Licenses on XML files

[Dan Smith]

> 2) Is the code above correct?
>

So, the NPE is because doc.getFirstChild() will return the comment.

It looks like this code is used within the context of extracting elements
from an xml file we generate. So with the current geode code it will never
see a comment, but it might still be worth just fixing the code to be more
flexible. We do allow xml generating extensions to be registered, so this
code could potentially cause NPEs if an extension generates xml with a
comment.

-Dan

Re: Include templates in the binary distribution?

[William Markito]

Please check https://issues.apache.org/jira/browse/GEODE-33 - "Create
project examples." which was tracking that work although I've not actually
started.

On Mon, Dec 7, 2015 at 2:24 PM, Roman Shaposhnik 
wrote:

> On Mon, Dec 7, 2015 at 1:55 PM, Dan Smith  wrote:
> > At the very least, it seems like this code should move somewhere that
> > indicates it's an example, rather than test code. Maybe we should create
> a
> > new gradle module gemfire-examples? Or at least move this to a different
> > source folder like gemfire-core/src/example?
>
> Also, remember that if you make your examples available as part of the
> build it'll simplify downstream packaging (think Linux distros) quite a
> bit.
>
> Thanks,
> Roman.
>



-- 

William Markito Oliveira
-- For questions about Apache Geode, please write to
*dev@geode.incubator.apache.org
*

Re: Review Request 41059: GEODE-638: Add build task to allow for custom set of tests to be run

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41059/#review109225
---

Ship it!


I think for some other things we've used gradle properties (Specified on the 
command line with -P). For example buildRoot. I'm not sure if it would be 
better to use a system property or a gradle property for this.

- Dan Smith


On Dec. 7, 2015, 11:28 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41059/
> ---
> 
> (Updated Dec. 7, 2015, 11:28 p.m.)
> 
> 
> Review request for geode, Mark Bretl and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-638: Add build task to allow for custom set of tests to be run
> 
> 
> Diffs
> -
> 
>   build.gradle b5465b8eeb14408bae1624c8ffe7f25b4863e2b2 
> 
> Diff: https://reviews.apache.org/r/41059/diff/
> 
> 
> Testing
> ---
> 
> Manual testing
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>

Re: Review Request 40977: GEODE-563: Moving gfsh tests from closed

[Anthony Baker]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40977/#review109227
---

Ship it!


Ship It!

- Anthony Baker


On Dec. 4, 2015, 6:36 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40977/
> ---
> 
> (Updated Dec. 4, 2015, 6:36 p.m.)
> 
> 
> Review request for geode.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-563: Moving gfsh tests from closed
> 
> Other than some relevant Gradle changes, this work is only moving test 
> classes from closed to open.
> 
> 
> Diffs
> -
> 
>   gemfire-assembly/build.gradle 8de6d4e74720c7cae4d3d5cbbcd8bfc054924262 
>   
> gemfire-assembly/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-assembly/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommandsJUnitTest.java
>  PRE-CREATION 
>   
> gemfire-assembly/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/HeadlessGfsh.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/HeadlessGfshJUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/ResultHandler.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/TableBuilderJUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/FunctionCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GetCommandOnRegionWithCacheLoaderDuringCacheMissDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeDiskStoreCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListIndexCommandDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MemberCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart1DUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart2DUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart3DUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart4DUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/QueueCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowDeadlockDUnitTest.java
>  PRE-CREATION 
>   
> 

Re: New Geode website - Latest changes

[Roman Shaposhnik]

On Mon, Dec 7, 2015 at 4:47 PM, Dave Barnes  wrote:
> change "karma" to "good karma".

Good point! I guess you know your samsara well ;-)

Thanks,
Roman.

Re: New Geode website - Latest changes

[Dave Barnes]

Total immersion ;)

> On Dec 7, 2015, at 7:46 PM, Roman Shaposhnik  wrote:
> 
>> On Mon, Dec 7, 2015 at 4:47 PM, Dave Barnes  wrote:
>> change "karma" to "good karma".
> 
> Good point! I guess you know your samsara well ;-)
> 
> Thanks,
> Roman.

Re: New Geode website - Latest changes

[William Markito]

Sure, I've changed here locally, will just not push to GitHub pages to
avoid the work of replacing urls that I have to do in order to publish
there.  Thanks Dave!

On Mon, Dec 7, 2015 at 4:47 PM, Dave Barnes  wrote:

> Can I request one more tweak through this informal channel? Will submit a
> PR if you insist...here's my request:
>
> On the community/index.html page, where it says "Helping users learn best
> practices also earns karma in our community," change "karma" to "good
> karma".
>
>
>
>
> On Mon, Dec 7, 2015 at 4:34 PM, William Markito 
> wrote:
>
> > Folks,
> >
> > I've just applied and pushed the latest changes and they're live here:
> > http://markito.github.io/geode-website/
> >
> > IHMO it's ready to be merged to develop/master and replace our current
> > website.  Minor fixes or new errors could be tackled and fixed there.
> >
> > Thanks everyone for the help on reviewing this, specially Dave, Niall and
> > Greg.
> >
> > Summary of latest changes:
> >
> > - Moving mailing lists to top-level menu and up in the community page
> >  - Removed logos and Tools section
> >  - Changed mailing list archive link from ASF to markmail (better UI)
> >  - Merged fixes from PR #47 <
> > https://github.com/apache/incubator-geode/pull/47>
> >
> >
> > I've also added a link to the Apache Incubator.
> >
> > If there are no -1's until EOD tomorrow I'll proceed with the work and
> > merge.
> >
> > Thanks,
> > --
> >
> > William Markito Oliveira
> > -- For questions about Apache Geode, please write to
> > *dev@geode.incubator.apache.org
> > *
> >
>



-- 

William Markito Oliveira
-- For questions about Apache Geode, please write to
*dev@geode.incubator.apache.org
*

Re: Review Request 40977: GEODE-563: Moving gfsh tests from closed

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40977/#review109250
---

Ship it!


Ship It!

- Dan Smith


On Dec. 4, 2015, 6:36 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40977/
> ---
> 
> (Updated Dec. 4, 2015, 6:36 p.m.)
> 
> 
> Review request for geode.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-563: Moving gfsh tests from closed
> 
> Other than some relevant Gradle changes, this work is only moving test 
> classes from closed to open.
> 
> 
> Diffs
> -
> 
>   gemfire-assembly/build.gradle 8de6d4e74720c7cae4d3d5cbbcd8bfc054924262 
>   
> gemfire-assembly/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-assembly/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommandsJUnitTest.java
>  PRE-CREATION 
>   
> gemfire-assembly/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/HeadlessGfsh.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/HeadlessGfshJUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/ResultHandler.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/TableBuilderJUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/FunctionCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GetCommandOnRegionWithCacheLoaderDuringCacheMissDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeDiskStoreCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListIndexCommandDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MemberCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart1DUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart2DUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart3DUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart4DUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/QueueCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommandsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowDeadlockDUnitTest.java
>  PRE-CREATION 
>   
> 

New Geode website - Latest changes

[William Markito]

Folks,

I've just applied and pushed the latest changes and they're live here:
http://markito.github.io/geode-website/

IHMO it's ready to be merged to develop/master and replace our current
website.  Minor fixes or new errors could be tackled and fixed there.

Thanks everyone for the help on reviewing this, specially Dave, Niall and
Greg.

Summary of latest changes:

- Moving mailing lists to top-level menu and up in the community page
 - Removed logos and Tools section
 - Changed mailing list archive link from ASF to markmail (better UI)
 - Merged fixes from PR #47 


I've also added a link to the Apache Incubator.

If there are no -1's until EOD tomorrow I'll proceed with the work and
merge.

Thanks,
-- 

William Markito Oliveira
-- For questions about Apache Geode, please write to
*dev@geode.incubator.apache.org
*