geode for specific usecase

2016-02-23 Thread steve mathew
Hello I am new to the apache geode and exploring a possibility to store
data sorted into regions.

I need to store data sorted for the scan(startkey, endkey) operation.
Simple looking at the APIs it looks geode is not designed for this. Is
there any way to achieve this?

Thanks in advance.

Kindly advise.

-Steve.


[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #230 was SUCCESSFUL (with 1245 tests)

2016-02-23 Thread Spring CI

---
Spring Data GemFire > Nightly-ApacheGeode > #230 was successful.
---
Scheduled
1249 tests in total.

https://build.spring.io/browse/SGF-NAG-230/





--
This message is automatically generated by Atlassian Bamboo

Re: [DISCUSS] JIRA components

2016-02-23 Thread Darrel Schneider
Seems like they could just leave component unset if they don't know which
one it belongs to.

On Tue, Feb 23, 2016 at 5:20 PM, Kirk Lund  wrote:

> +1 which component do you foresee people using when they have no idea what
> to select? I think we should consider having a clear default to use when
> the person filing a ticket has no idea what to select. General seemed to
> server this purpose but you've marked it with an "*"
>
>
> On Tue, Feb 23, 2016 at 3:36 PM, Anthony Baker  wrote:
>
> > Here are the JIRA components we currently have defined:
> >
> > build
> > client/server
> > core [*]
> > docs
> > extensions
> > functions
> > general [*]
> > hdfs
> > management [*]
> > membership
> > offheap
> > persistence
> > querying
> > serialization
> > subscriptions [*]
> > tests
> > tools
> > transactions
> > wan
> > web-content
> >
> >
> > I would like to remove the components marked with [*] and add more
> > detailed entries like so:
> >
> > build
> > client queues [renamed from subscriptions]
> > client/server
> > compression
> > configuration
> > cq
> > distributed lock service
> > core
> > docs
> > eviction
> > expiration
> > functions
> > gfsh
> > hibernate
> > http session (tomcat)
> > jmx
> > locator
> > logging
> > lucene
> > membership
> > memcached
> > messaging
> > offheap
> > persistence
> > pulse
> > querying
> > redis
> > regions
> > rest (admin)
> > rest (dev)
> > security
> > serialization
> > snapshot
> > statistics
> > transactions
> > wan
> > web-content
> >
> >
> > Thoughts?
> >
> > Anthony
> >
> >
> >
>


Re: [DISCUSS] JIRA components

2016-02-23 Thread Kirk Lund
+1 which component do you foresee people using when they have no idea what
to select? I think we should consider having a clear default to use when
the person filing a ticket has no idea what to select. General seemed to
server this purpose but you've marked it with an "*"


On Tue, Feb 23, 2016 at 3:36 PM, Anthony Baker  wrote:

> Here are the JIRA components we currently have defined:
>
> build
> client/server
> core [*]
> docs
> extensions
> functions
> general [*]
> hdfs
> management [*]
> membership
> offheap
> persistence
> querying
> serialization
> subscriptions [*]
> tests
> tools
> transactions
> wan
> web-content
>
>
> I would like to remove the components marked with [*] and add more
> detailed entries like so:
>
> build
> client queues [renamed from subscriptions]
> client/server
> compression
> configuration
> cq
> distributed lock service
> core
> docs
> eviction
> expiration
> functions
> gfsh
> hibernate
> http session (tomcat)
> jmx
> locator
> logging
> lucene
> membership
> memcached
> messaging
> offheap
> persistence
> pulse
> querying
> redis
> regions
> rest (admin)
> rest (dev)
> security
> serialization
> snapshot
> statistics
> transactions
> wan
> web-content
>
>
> Thoughts?
>
> Anthony
>
>
>


Re: Review Request 43725: Fix GEODE-944: ServerLauncherJUnitTest fails when ISP redirects DNS failures

2016-02-23 Thread Dan Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43725/#review120424
---


Ship it!




Ship It!

- Dan Smith


On Feb. 24, 2016, 12:31 a.m., Jianxia Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43725/
> ---
> 
> (Updated Feb. 24, 2016, 12:31 a.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jens Deppe, 
> Jinmei Liao, Kirk Lund, Udo Kohlmeyer, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Remove the expected exception since the DNS lookup result is 
> non-deterministic due to ISP DNS hijacking. Do not re-throw the exception in 
> the catch block.
> 
> Do the same for LocatorLauncherJUnitTest as well.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/LocatorLauncher.java
>  b0be89f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java 
> f13bb73 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java 
> 9a74abd 
> 
> Diff: https://reviews.apache.org/r/43725/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jianxia Chen
> 
>



Re: Review Request 43725: Fix GEODE-944: ServerLauncherJUnitTest fails when ISP redirects DNS failures

2016-02-23 Thread Bruce Schuchardt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43725/#review120423
---


Ship it!




Ship It!

- Bruce Schuchardt


On Feb. 24, 2016, 12:31 a.m., Jianxia Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43725/
> ---
> 
> (Updated Feb. 24, 2016, 12:31 a.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jens Deppe, 
> Jinmei Liao, Kirk Lund, Udo Kohlmeyer, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Remove the expected exception since the DNS lookup result is 
> non-deterministic due to ISP DNS hijacking. Do not re-throw the exception in 
> the catch block.
> 
> Do the same for LocatorLauncherJUnitTest as well.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/LocatorLauncher.java
>  b0be89f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java 
> f13bb73 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java 
> 9a74abd 
> 
> Diff: https://reviews.apache.org/r/43725/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jianxia Chen
> 
>



Re: Review Request 43725: Fix GEODE-944: ServerLauncherJUnitTest fails when ISP redirects DNS failures

2016-02-23 Thread Jianxia Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43725/
---

(Updated Feb. 24, 2016, 12:31 a.m.)


Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jens Deppe, Jinmei 
Liao, Kirk Lund, Udo Kohlmeyer, and Dan Smith.


Changes
---

Also check the loopback address, esp for ubuntu.


Repository: geode


Description
---

Remove the expected exception since the DNS lookup result is non-deterministic 
due to ISP DNS hijacking. Do not re-throw the exception in the catch block.

Do the same for LocatorLauncherJUnitTest as well.


Diffs (updated)
-

  
geode-core/src/main/java/com/gemstone/gemfire/distributed/LocatorLauncher.java 
b0be89f 
  geode-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java 
f13bb73 
  geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java 
9a74abd 

Diff: https://reviews.apache.org/r/43725/diff/


Testing
---


Thanks,

Jianxia Chen



[GitHub] incubator-geode pull request: GEODE-906: Clean up source header / ...

2016-02-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/101


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-geode pull request: GEODE-906: Clean up source header / ...

2016-02-23 Thread sboorlagadda
Github user sboorlagadda commented on the pull request:

https://github.com/apache/incubator-geode/pull/101#issuecomment-187977053
  
RBT url: https://reviews.apache.org/r/43919/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Review Request 43919: GEODE-906: Clean up source header / modification text

2016-02-23 Thread Anthony Baker

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43919/#review120414
---


Ship it!




Ship It!

- Anthony Baker


On Feb. 23, 2016, 11:41 p.m., Sai Boorlagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43919/
> ---
> 
> (Updated Feb. 23, 2016, 11:41 p.m.)
> 
> 
> Review request for geode and Anthony Baker.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * HashIndexSet to use the standard Apache source header with a separate 
> modification statement
> * IdentityArrayList to use the original license header with a separate 
> modificaiton statement
> * Added fastutil copyright to the NOTICE
> 
> 
> Diffs
> -
> 
>   NOTICE dfc539089cfc3c3a21fefe91c23e4a89e052e163 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/HashIndexSet.java
>  2fa72d15cf63494ff54f0d3c38a00acf05f3b784 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/IdentityArrayList.java
>  3b546872040aa3a7d08bc0332d542869a0b8ce0f 
> 
> Diff: https://reviews.apache.org/r/43919/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sai Boorlagadda
> 
>



Re: Review Request 43918: GEODE-876: Add a README file to the binary distribution

2016-02-23 Thread Anthony Baker

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43918/#review120413
---


Ship it!




Ship It!

- Anthony Baker


On Feb. 23, 2016, 11:39 p.m., Sai Boorlagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43918/
> ---
> 
> (Updated Feb. 23, 2016, 11:39 p.m.)
> 
> 
> Review request for geode, Anthony Baker and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * included both README.md into the binary distribution
> * removed docker instructions to wiki page
> 
> 
> Diffs
> -
> 
>   README.md 495a02c2c4a9635a546034d9154fc3aec11acac7 
>   geode-assembly/build.gradle 2a46147c04061a709bc5ae7b2ff596a6083ec5a6 
> 
> Diff: https://reviews.apache.org/r/43918/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sai Boorlagadda
> 
>



Review Request 43919: GEODE-906: Clean up source header / modification text

2016-02-23 Thread Sai Boorlagadda

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43919/
---

Review request for geode and Anthony Baker.


Repository: geode


Description
---

* HashIndexSet to use the standard Apache source header with a separate 
modification statement
* IdentityArrayList to use the original license header with a separate 
modificaiton statement
* Added fastutil copyright to the NOTICE


Diffs
-

  NOTICE dfc539089cfc3c3a21fefe91c23e4a89e052e163 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/HashIndexSet.java
 2fa72d15cf63494ff54f0d3c38a00acf05f3b784 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/IdentityArrayList.java
 3b546872040aa3a7d08bc0332d542869a0b8ce0f 

Diff: https://reviews.apache.org/r/43919/diff/


Testing
---


Thanks,

Sai Boorlagadda



Review Request 43918: GEODE-876: Add a README file to the binary distribution

2016-02-23 Thread Sai Boorlagadda

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43918/
---

Review request for geode, Anthony Baker and Swapnil Bawaskar.


Repository: geode


Description
---

* included both README.md into the binary distribution
* removed docker instructions to wiki page


Diffs
-

  README.md 495a02c2c4a9635a546034d9154fc3aec11acac7 
  geode-assembly/build.gradle 2a46147c04061a709bc5ae7b2ff596a6083ec5a6 

Diff: https://reviews.apache.org/r/43918/diff/


Testing
---


Thanks,

Sai Boorlagadda



[DISCUSS] JIRA components

2016-02-23 Thread Anthony Baker
Here are the JIRA components we currently have defined:

build
client/server
core [*]
docs
extensions
functions
general [*]
hdfs
management [*]
membership
offheap
persistence
querying
serialization
subscriptions [*]
tests
tools
transactions
wan
web-content


I would like to remove the components marked with [*] and add more detailed 
entries like so:

build
client queues [renamed from subscriptions]
client/server
compression
configuration
cq
distributed lock service
core
docs
eviction
expiration
functions
gfsh
hibernate
http session (tomcat)
jmx
locator
logging
lucene
membership
memcached
messaging
offheap
persistence
pulse
querying
redis
regions
rest (admin)
rest (dev)
security
serialization
snapshot
statistics
transactions
wan
web-content


Thoughts?

Anthony




signature.asc
Description: Message signed with OpenPGP using GPGMail


[GitHub] incubator-geode pull request: Applied pr #105 : update compiled co...

2016-02-23 Thread sboorlagadda
Github user sboorlagadda commented on the pull request:

https://github.com/apache/incubator-geode/pull/105#issuecomment-187964060
  
This PR is to asf-site branch. I will take care of this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-geode pull request: Applied pr #105 : update compiled co...

2016-02-23 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/incubator-geode/pull/105

Applied pr #105 : update compiled community page



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/incubator-geode asf-site

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/105.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #105


commit 3958a6ed9e8602f6a0366eab3ad8d7526f6554bc
Author: Dave Barnes 
Date:   2016-02-23T23:05:26Z

Applied pr #105 : update compiled community page




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Review Request 43894: GEODE-912: FileUtil would throw a more detailed stack trace if unable to delete a file

2016-02-23 Thread Jens Deppe

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43894/#review120403
---


Ship it!




Ship It!

- Jens Deppe


On Feb. 23, 2016, 7:52 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43894/
> ---
> 
> (Updated Feb. 23, 2016, 7:52 p.m.)
> 
> 
> Review request for geode, Jens Deppe and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-912: FileUtil would throw a more detailed stack trace if unable to 
> delete a file.
> 
> The test failed with a message saying "java.io.IOException: Could not delete 
> /latvia1/users/build/jenkins/blds/workspace/Geode_develop_DistributedTests/gemfire-core/build/distributedTest/controllerDiskDir",
>  but it provides no insights on why. This change would make future failures 
> provide more information as to why the deletion failed.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/FileUtil.java 
> b06b5031dc94e28b6d8f42b9a2c76e6f2685a8a3 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/FileUtilJUnitTest.java 
> 2c9b0c81e379ec41a766fb2eac18e4e75a4a3260 
> 
> Diff: https://reviews.apache.org/r/43894/diff/
> 
> 
> Testing
> ---
> 
> FileUtilJUnitTest, DiskStoreCommandsDUnitTest, BackupDUnitTest
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>



Re: Review Request 43898: GEODE-998: Fix javadoc warning in LogConfig

2016-02-23 Thread Jens Deppe

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43898/#review120404
---


Ship it!




Ship It!

- Jens Deppe


On Feb. 23, 2016, 9:12 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43898/
> ---
> 
> (Updated Feb. 23, 2016, 9:12 p.m.)
> 
> 
> Review request for geode, Jens Deppe and Jinmei Liao.
> 
> 
> Bugs: GEODE-998
> https://issues.apache.org/jira/browse/GEODE-998
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-998: Fix javadoc warning in LogConfig
> 
> LogConfig is a subset of the DistributionConfig interface used by internal 
> logging. The javadoc error was probably introduced when LogConfig.java was 
> created.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/LogConfig.java 
> 3e4fbc6 
> 
> Diff: https://reviews.apache.org/r/43898/diff/
> 
> 
> Testing
> ---
> 
> build javadocs
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>



[GitHub] incubator-geode pull request: Add Sai Boorlagadda to committers' l...

2016-02-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/104


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-geode pull request: GEODE-856: New unit test class for c...

2016-02-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/103


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Review Request 43899: GEODE-953: cleanup geode-junit

2016-02-23 Thread Kirk Lund

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43899/
---

Review request for geode, Jens Deppe and Jinmei Liao.


Bugs: GEODE-953
https://issues.apache.org/jira/browse/GEODE-953


Repository: geode


Description
---

GEODE-953: cleanup geode-junit

* cleanup geode-junit usage of JUnit Rules to ensure JUnit code is always 
extended rather than copied
* change CRLF to LF
* remove @author tags
* fix all javadocs
* fix formatting
* add new tests
* remove ExpectedException and ExpectedExceptionTest (they were dupes of 
ExpectedExceptionRule and ExpectedExceptionRuleTest)
* use serialization by reflection for serializable subclasses of JUnit rules 
that lack sufficient ability to subclass
* repackage rule tests to same package as rules
* repackage serializable rules into serializable sub-package


Diffs
-

  
geode-core/src/test/java/com/gemstone/gemfire/internal/process/PidFileJUnitTest.java
 5f81c2b 
  
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/DistributedDisconnectRule.java
 125fc06 
  
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/DistributedExternalResource.java
 d3b7319 
  
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/DistributedRestoreSystemProperties.java
 1711b21 
  
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/RemoteInvoker.java
 9e3c5b2 
  geode-junit/build.gradle 112d112 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/ConditionalIgnore.java
 b409cb1 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/IgnoreCondition.java 
0caa959 
  geode-junit/src/main/java/com/gemstone/gemfire/test/junit/IgnoreUntil.java 
5910d10 
  geode-junit/src/main/java/com/gemstone/gemfire/test/junit/Repeat.java 5cfa321 
  geode-junit/src/main/java/com/gemstone/gemfire/test/junit/Retry.java 65f3cf6 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/ContainerTest.java
 8eec738 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/DistributedTest.java
 6aa538b 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/DistributedTransactionsTest.java
 1892ddd 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/HydraTest.java
 4fe535b 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/IntegrationTest.java
 1be6e45 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/PerformanceTest.java
 ad952be 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/UITest.java
 834931a 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/UnitTest.java
 d5be9e8 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/WanTest.java
 9abf15b 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/ConditionalIgnoreRule.java
 80898b5 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/ExpectedTimeout.java
 2f53811 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/ExpectedTimeoutRule.java
 7b6d345 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/IgnoreUntilRule.java
 bf4ec3f 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/RepeatRule.java 
7bfe538 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/RetryRule.java 
c885aec 
  geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/RuleList.java 
PRE-CREATION 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/SerializableExternalResource.java
 37d8eb5 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/SerializableRuleChain.java
 936345e 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/SerializableTemporaryFolder.java
 0e796b3 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/SerializableTestName.java
 1fd255f 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/SerializableTestRule.java
 354c38a 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/SerializableTestWatcher.java
 5bcf686 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/SerializableTimeout.java
 3136a1c 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/serializable/FieldSerializationUtils.java
 PRE-CREATION 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/serializable/FieldsOfTemporaryFolder.java
 PRE-CREATION 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/serializable/FieldsOfTestName.java
 PRE-CREATION 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/serializable/FieldsOfTimeout.java
 PRE-CREATION 
  
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/serializable/SerializableExternalResource.java
 PRE-CREATION 
  

Re: Review Request 43843: GEODE-856: Create unit test class for MemoryBlockNode class

2016-02-23 Thread Sai Boorlagadda

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43843/#review120389
---


Ship it!




Ship It!

- Sai Boorlagadda


On Feb. 23, 2016, 6:34 p.m., Ken Howe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43843/
> ---
> 
> (Updated Feb. 23, 2016, 6:34 p.m.)
> 
> 
> Review request for geode, Darrel Schneider and Sai Boorlagadda.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> New unit test class to provide coverage of 
> com.gemstone.gemfire.internal.offheadp.MemoryBlockNode
> 
> Refactoring in SimpleMemoryAllocatorImpl:
> Added resetForTesting() static method with package access. Free any offheap 
> memory and set the singleton to null so that tests can create a new memory 
> allocator.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/MemoryBlockNodeJUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43843/diff/
> 
> 
> Testing
> ---
> 
> Precheckin is in progress
> 
> 
> Thanks,
> 
> Ken Howe
> 
>



Review Request 43902: GEODE-979: CI Failure: ParameterBindingJUnitTest.testMultithreadedBindUsingSameQueryObject failed with NullPointerException

2016-02-23 Thread Jason Huynh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43902/
---

Review request for geode, anilkumar gingade, Barry Oglesby, Dan Smith, and 
xiaojian zhou.


Repository: geode


Description
---

LinkedList should not be added to concurrently.
Minor change in counting down the latch.


Diffs
-

  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/MultithreadedTester.java
 3142566 

Diff: https://reviews.apache.org/r/43902/diff/


Testing
---


Thanks,

Jason Huynh



Review Request 43898: GEODE-998: Fix javadoc warning in LogConfig

2016-02-23 Thread Kirk Lund

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43898/
---

Review request for geode, Jens Deppe and Jinmei Liao.


Bugs: GEODE-998
https://issues.apache.org/jira/browse/GEODE-998


Repository: geode


Description
---

GEODE-998: Fix javadoc warning in LogConfig

LogConfig is a subset of the DistributionConfig interface used by internal 
logging. The javadoc error was probably introduced when LogConfig.java was 
created.


Diffs
-

  geode-core/src/main/java/com/gemstone/gemfire/internal/logging/LogConfig.java 
3e4fbc6 

Diff: https://reviews.apache.org/r/43898/diff/


Testing
---

build javadocs


Thanks,

Kirk Lund



Re: Review Request 43894: GEODE-912: FileUtil would throw a more detailed stack trace if unable to delete a file

2016-02-23 Thread Dan Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43894/#review120385
---


Ship it!




Ship It!

- Dan Smith


On Feb. 23, 2016, 7:52 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43894/
> ---
> 
> (Updated Feb. 23, 2016, 7:52 p.m.)
> 
> 
> Review request for geode, Jens Deppe and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-912: FileUtil would throw a more detailed stack trace if unable to 
> delete a file.
> 
> The test failed with a message saying "java.io.IOException: Could not delete 
> /latvia1/users/build/jenkins/blds/workspace/Geode_develop_DistributedTests/gemfire-core/build/distributedTest/controllerDiskDir",
>  but it provides no insights on why. This change would make future failures 
> provide more information as to why the deletion failed.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/FileUtil.java 
> b06b5031dc94e28b6d8f42b9a2c76e6f2685a8a3 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/FileUtilJUnitTest.java 
> 2c9b0c81e379ec41a766fb2eac18e4e75a4a3260 
> 
> Diff: https://reviews.apache.org/r/43894/diff/
> 
> 
> Testing
> ---
> 
> FileUtilJUnitTest, DiskStoreCommandsDUnitTest, BackupDUnitTest
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>



Re: Review Request 43856: GEODE-997: Update Pulse build to reduce bundled jars

2016-02-23 Thread Kirk Lund

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43856/#review120384
---


Ship it!




Ship It!

- Kirk Lund


On Feb. 23, 2016, 12:11 a.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43856/
> ---
> 
> (Updated Feb. 23, 2016, 12:11 a.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-997: Update Pulse build to reduce bundled jars
> 
> This review is related to the story to ensure that all Pulse dependencies are 
> reflected in the NOTICE and LICENSE files. From that POV I believe we are 
> good and have all our 3rd party libs covered.
> 
> While checking artifacts, etc. I noticed that some jars were duplicated in 
> the war and some are not required by Pulse (specifically jars related to 
> findbugs and cdi-api). This review address that.
> 
> 
> Diffs
> -
> 
>   geode-pulse/build.gradle ebd851a70fea6448f1efc6207c5e0a83ec61 
> 
> Diff: https://reviews.apache.org/r/43856/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>



[GitHub] incubator-geode pull request: GEODE-856: New unit test class for c...

2016-02-23 Thread pdxrunner
GitHub user pdxrunner opened a pull request:

https://github.com/apache/incubator-geode/pull/103

GEODE-856: New unit test class for covering MemoryBlockNode

New unit test class to give coverage for MemoryBlockNode.
See reviews: https://reviews.apache.org/r/43681/

This PR supersedes closed PR #102. The multiple commits on the original 
branch have been squashed to make a single clean commit for this PR.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pdxrunner/incubator-geode feature/GEODE-856.3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/103.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #103


commit 814268806eb25c6aa33013651f8c81e8d34a765e
Author: Ken Howe 
Date:   2016-02-23T19:53:29Z

GEODE-856: New unit test class for covering MemoryBlockNode




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-geode pull request: Feature/geode 856

2016-02-23 Thread pdxrunner
Github user pdxrunner commented on the pull request:

https://github.com/apache/incubator-geode/pull/102#issuecomment-187877454
  
Closing this PR so that I can squash all the intermediate commits and 
generate a clean branch for a new PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-geode pull request: Feature/geode 856

2016-02-23 Thread pdxrunner
Github user pdxrunner closed the pull request at:

https://github.com/apache/incubator-geode/pull/102


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-geode pull request: Feature/geode 856

2016-02-23 Thread pdxrunner
GitHub user pdxrunner opened a pull request:

https://github.com/apache/incubator-geode/pull/102

Feature/geode 856

New unit test class to give coverage for MemoryBlockNode.
See reviews: https://reviews.apache.org/r/43681/

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pdxrunner/incubator-geode feature/GEODE-856

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/102.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #102


commit 20724ab01f2b90e280c511925d934ab249d42ffa
Author: Ken Howe 
Date:   2016-01-26T22:11:16Z

GEODE-855: Create unit test class for Fragment class

commit 16ad1a4ef52f426af9b3ff6c7290ca30882ad42c
Author: Ken Howe 
Date:   2016-01-28T23:48:22Z

GEODE-855: Adding more unit tests for Fragment class

commit aa1d1af6221f9a3a6abcbe7c8ba189ed5209ee8b
Author: Ken Howe 
Date:   2016-02-02T19:27:30Z

GEODE-855: more unit tests for complete coverage of Fragment class

commit a9c5d89a8000d39d9a39980b98d71daa6eb9a2d5
Author: Ken Howe 
Date:   2016-02-03T16:49:58Z

GEODE-855: Checking system property in unit test

commit a74f0776cfae58a53784a7c53b366793ae94488f
Author: Ken Howe 
Date:   2016-02-16T17:28:24Z

GEODE-855: Refacotring in SimpleMemoryAllocatorImpl to allow resetting
the singleton allocator for testing. Updated tests to use the memory
allocator reset capability.

commit c7c57dd629a0bf3c1f3431717edd4f44e6c561f6
Author: Ken Howe 
Date:   2016-02-17T15:47:44Z

GEODE-856: New unit tests for MemoryBlockNode

commit dd99d2d2100ee3b133d858672470829fe90e8519
Author: Ken Howe 
Date:   2016-01-26T22:11:16Z

GEODE-855: Create unit test class for Fragment class

commit 4e219f652cc28fc6d7ba09206eaf577ae5e31418
Author: Ken Howe 
Date:   2016-01-28T23:48:22Z

GEODE-855: Adding more unit tests for Fragment class

commit 8b775afe4efd6e171ed0253dfe05e7f95575da2e
Author: Ken Howe 
Date:   2016-02-02T19:27:30Z

GEODE-855: more unit tests for complete coverage of Fragment class

commit 70e52ad0e4a0c19a7267c6a744e6dff49436ee4d
Author: Ken Howe 
Date:   2016-02-03T16:49:58Z

GEODE-855: Checking system property in unit test

commit 7bb94a9d6ed196090b5cfe616eecc18469530f79
Author: Ken Howe 
Date:   2016-02-16T17:28:24Z

GEODE-855: Refacotring in SimpleMemoryAllocatorImpl to allow resetting
the singleton allocator for testing. Updated tests to use the memory
allocator reset capability.

commit aeb08945a952e8cbe6f82489a720732dc2628449
Author: Ken Howe 
Date:   2016-02-17T21:24:22Z

Revert "GEODE-855: Refacotring in SimpleMemoryAllocatorImpl to allow 
resetting"

This reverts commit 7bb94a9d6ed196090b5cfe616eecc18469530f79.

commit c294ae96bf75c3e329523fdfe74eaeab3959a0b3
Author: Ken Howe 
Date:   2016-02-17T21:58:14Z

GEODE-855: Removed a test that didn't add coverage for Fragment

commit c12c1f0ae0b54665a46ef45aa07d0965cf095e1c
Author: Ken Howe 
Date:   2016-02-17T22:33:38Z

Merge branch 'feature/GEODE-855' into feature/GEODE-856

commit 984748d692194203a8cca213c687c1c2fb344a44
Author: Ken Howe 
Date:   2016-02-18T15:37:52Z

Merge branch 'develop' into feature/GEODE-856

commit 48bdda057a53b44218e42e31a3342f068cc962b2
Author: Ken Howe 
Date:   2016-02-19T23:49:57Z

Merge branch 'develop' into feature/GEODE-856

commit eec45689d8f123c8a450dc89033433ea5ab34710
Author: Ken Howe 
Date:   2016-02-22T16:33:03Z

GEODE-856: Updated unit tests after the FreeListManager and Chunk class
hierarchies refactoring

commit cd7db898f08895634c237a683c054bbd478454c9
Author: Ken Howe 
Date:   2016-02-22T16:36:08Z

Merge branch 'develop' into feature/GEODE-856

commit 7ffc9d41da9cb33d9d28b331b32625721d4e82f4
Author: Ken Howe 
Date:   2016-02-22T16:47:07Z

GEODFE-856: removed unused code

commit 28c7e96f95560d1c0e3de9688fd7eb936c68fbbc
Author: Ken Howe 
Date:   2016-02-22T16:54:00Z

GEODE-856: Remove some comments

commit 03653de32fde8dccb1bc2692d8d5b8879da19e1b
Author: Ken Howe 
Date:   2016-02-22T18:18:30Z

GEODE-856: Clean up SimpleMemoryAllocatorImpl refactoring

commit 138320830f166146242b5c1cdec487a4762f283b
Author: Ken Howe 
Date:   2016-02-22T18:35:17Z

GEODE-856: Make sure memory is released prior to resetting
SimpleMemoryAllocatorImpl

commit 994789f0cfa2bce4d75de1a570e8149e658c0687
Author: Ken Howe 
Date:   2016-02-23T01:46:10Z

GEODE-856: Reverted the 

Re: Review Request 43843: GEODE-856: Create unit test class for MemoryBlockNode class

2016-02-23 Thread Darrel Schneider

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43843/#review120358
---


Ship it!




Ship It!

- Darrel Schneider


On Feb. 23, 2016, 10:34 a.m., Ken Howe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43843/
> ---
> 
> (Updated Feb. 23, 2016, 10:34 a.m.)
> 
> 
> Review request for geode, Darrel Schneider and Sai Boorlagadda.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> New unit test class to provide coverage of 
> com.gemstone.gemfire.internal.offheadp.MemoryBlockNode
> 
> Refactoring in SimpleMemoryAllocatorImpl:
> Added resetForTesting() static method with package access. Free any offheap 
> memory and set the singleton to null so that tests can create a new memory 
> allocator.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/MemoryBlockNodeJUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43843/diff/
> 
> 
> Testing
> ---
> 
> Precheckin is in progress
> 
> 
> Thanks,
> 
> Ken Howe
> 
>



Re: Review Request 43843: GEODE-856: Create unit test class for MemoryBlockNode class

2016-02-23 Thread Ken Howe

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43843/
---

(Updated Feb. 23, 2016, 6:34 p.m.)


Review request for geode, Darrel Schneider and Sai Boorlagadda.


Changes
---

Removed the line in question from Darrel's review. The additional memory 
allocator creation is not needed with the new slab allocations.


Repository: geode


Description
---

New unit test class to provide coverage of 
com.gemstone.gemfire.internal.offheadp.MemoryBlockNode

Refactoring in SimpleMemoryAllocatorImpl:
Added resetForTesting() static method with package access. Free any offheap 
memory and set the singleton to null so that tests can create a new memory 
allocator.


Diffs (updated)
-

  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/MemoryBlockNodeJUnitTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/43843/diff/


Testing
---

Precheckin is in progress


Thanks,

Ken Howe



Re: Review Request 43788: Now we do send heartbeat request while doing tcp check

2016-02-23 Thread Hitesh Khamesra

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43788/
---

(Updated Feb. 23, 2016, 5:41 p.m.)


Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.


Repository: geode


Description
---

While doing tcp check, now we do request heartbeat from unresponsive member. 
This is udp call and we don't wait for response. It is processed by another 
thread. Current thread continue with tcp check and if it fails, then it look 
for heartbeat.

Added unit test


Diffs (updated)
-

  
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
 beb781d 
  
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java
 9562e41 

Diff: https://reviews.apache.org/r/43788/diff/


Testing
---

testing


Thanks,

Hitesh Khamesra



Re: Proposal: Move Events to a non-Repo website

2016-02-23 Thread Dave Barnes
One month out, naught but crickets to be heard...
Guess we'll continue to update Events on the Community index page.
Please contribute! A dynamic Events listing conveys vitality, a stale one
conveys lethargy.
If you're not comfortable making an update, you can send your event to me
and I'll post it for you.

On Wed, Jan 27, 2016 at 10:22 AM, Dave Barnes  wrote:

> This question (does the external site idea play well with our community
> policies?) is an important one. My proposal comes from efficiency
> considerations - let's hear from the community: if consensus is that the
> proposal conflicts with policy, I'll certainly withdraw it.
> -Dave
>
> On Wed, Jan 27, 2016 at 9:57 AM, Anthony Baker  wrote:
>
>> Is hosting the data on a site external to ASF infrastructure in accord
>> with our community policies?
>>
>> Anthony
>>
>> > On Jan 27, 2016, at 9:44 AM, Gregory Chase  wrote:
>> >
>> > Pivotal Data Communities maintains this public calendar:
>> >
>> https://calendar.google.com/calendar/embed?src=pivotal.io_u8kgvuahjkboh1gnfhv5ts2v9c%40group.calendar.google.com=America/Los_Angeles
>> >
>> > However not sure we can sort out the Geode events.
>> >
>> > We can create an additional calendar to host on behalf of Apache Geode,
>> as
>> > much as I don't like double entry :)
>> >
>> > -Greg
>> >
>> > On Wed, Jan 27, 2016 at 9:40 AM, Dave Barnes 
>> wrote:
>> >
>> >> If we choose to proceed in this direction, we'll need a
>> >> community-accessible site that hosts a public Google calendar. Does
>> this
>> >> already exist, or do we need to create one?
>> >>
>> >>
>> >> On Tue, Jan 26, 2016 at 10:28 PM, William Markito > >
>> >> wrote:
>> >>
>> >>> The javascript integration you did looks really good to me...
>> Although
>> >> the
>> >>> Brazilian calendar might be too much given the number of holidays...
>> :P
>> >>>
>> >>> A separate website would be a bit confusing since it would not be
>> handled
>> >>> or managed within the project or by committers of the project, which
>> >> might
>> >>> be a similar problem for a google calendar but might more doable...
>> >>>
>> >>> About your second question the calendar widget would take of it once
>> the
>> >>> events pass.  For now, I'm not sure we need to be much concerned since
>> >> it's
>> >>> also good for people to see events that already happened so they can
>> find
>> >>> content...
>> >>>
>> >>> Just my 2 cents.
>> >>>
>> >>> On Tue, Jan 26, 2016 at 5:13 PM Dave Barnes 
>> wrote:
>> >>>
>>  This was a proof-of-concept, but the redesign needs more thought. I
>> >>> think a
>>  separate site will allow more flexibility in presentation and design.
>> 
>>  I'm not sure how much information most publicly-visible Google
>> >> calendars
>>  provide, but this example's pretty slim. Doesn't begin to rival the
>>  appearance or level of detail of the existing implementation.
>> 
>>  Those of us who care need to come up with a design. My first question
>> >> has
>>  to do with existing resources:
>>  Is there a website already in existence that could serve as a host
>> for
>>  calendar postings from the community?
>> 
>>  Second question: In the meantime, how shall we handle updates to the
>>  existing site? The Jan 31 event will go 'stale' in less than a week.
>> 
>>  On Tue, Jan 26, 2016 at 4:47 PM, Dan Smith 
>> wrote:
>> 
>> > +1 Good idea!
>> >
>> > -Dan
>> >
>> > On Tue, Jan 26, 2016 at 3:44 PM, Greg Chase 
>> >>> wrote:
>> >
>> >> +1 for supporting Brazilian Holidays
>> >>
>> >> +1 for a calendar service that makes it easier for the community to
>> >> contribute events.
>> >>
>> >> On Tue, Jan 26, 2016 at 3:26 PM, Dave Barnes 
>>  wrote:
>> >>
>> >>> First pass, using the calendar of Brazilian Holidays - look just
>>  below
>> >> the
>> >>> Pivotal events:
>> >>>
>> >>>
>> >>> http://ec2-52-33-216-127.us-west-2.compute.amazonaws.com/community/
>> >>>
>> >>> On Tue, Jan 26, 2016 at 7:43 AM, Nitin Lamba 
>>  wrote:
>> >>>
>>  +1 for data-driven event calendar! William's suggested solution
>> >>> is
>>  available as a jQuery plugin [1].
>> 
>>  Nitin
>> 
>>  [1]
>> 
>> >>>
>> >>
>> >
>> 
>> >>>
>> >>
>> http://www.jqueryscript.net/social-media/jQuery-Plugin-To-Display-Google-Calendar-Feeds-On-Your-Website.html
>> 
>>  
>>  From: William Markito 
>>  Sent: Tuesday, January 26, 2016 12:00 AM
>>  To: dev@geode.incubator.apache.org
>>  Subject: Re: Proposal: Move Events to a non-Repo website
>> 
>>  Hi Dave,  I think it's 

Re: API Cleanup with GEODE-37?

2016-02-23 Thread Michael Stolz
We are working on figuring out a way to still support the old packaging for
existing enterprise customers when we switch to org.apache packaging.

Let's not make the packaging the reason for making a bunch of other
breaking changes.

+1 for dumping deprecated API's.

--
Mike Stolz
Principal Engineer, GemFire Product Manager
Mobile: 631-835-4771

On Tue, Feb 23, 2016 at 10:45 AM, Swapnil Bawaskar 
wrote:

> Since we are going to rename packages from com.gemstone -> org.apache for
> GEODE-37 https://issues.apache.org/jira/browse/GEODE-37>, and break
> any existing applications, I think we should take time to clean-up the API
> a little bit. Below are a few things that I would like to suggest.
>
> Region has some methods that are only supported on clients (like
> RegisterInterest). We can break region interface into two, one for
> Peer-to-Peer and one for client.
>
> We may be able to make some of the changes mentioned in the function
> service improvements document
> <
> https://cwiki.apache.org/confluence/display/GEODE/Function+Service+Usability+Improvments
> >
> (GEODE-728,
> 336, 641).
>
> Get rid of all the deprecated API.
>
> Thanks!
> Swapnil.
>


Re: Review Request 43843: GEODE-856: Create unit test class for MemoryBlockNode class

2016-02-23 Thread Darrel Schneider

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43843/#review120335
---




gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/MemoryBlockNodeJUnitTest.java
 (line 429)


Is this create call still needed or can you just use the "ma" from setup?


- Darrel Schneider


On Feb. 22, 2016, 6:06 p.m., Ken Howe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43843/
> ---
> 
> (Updated Feb. 22, 2016, 6:06 p.m.)
> 
> 
> Review request for geode, Darrel Schneider and Sai Boorlagadda.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> New unit test class to provide coverage of 
> com.gemstone.gemfire.internal.offheadp.MemoryBlockNode
> 
> Refactoring in SimpleMemoryAllocatorImpl:
> Added resetForTesting() static method with package access. Free any offheap 
> memory and set the singleton to null so that tests can create a new memory 
> allocator.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/MemoryBlockNodeJUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43843/diff/
> 
> 
> Testing
> ---
> 
> Precheckin is in progress
> 
> 
> Thanks,
> 
> Ken Howe
> 
>



Re: Review Request 43853: GEODE-930: add capability in the DistributedTestCase to wait until all vms are disconnected from the DS.

2016-02-23 Thread Jinmei Liao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43853/
---

(Updated Feb. 23, 2016, 4:45 p.m.)


Review request for geode, Jens Deppe, Kirk Lund, and Dan Smith.


Repository: geode


Description (updated)
---

GEODE-930: the test failed because the VM has received a DisconnectFromDS 
command unexpectedly while executing the commands specified in the test. Remove 
the that call from the beginning of the test since it's already called in the 
teardown


Diffs (updated)
-

  
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java
 21e44b262d44c5db082833aa75e35982ecdfe0b4 

Diff: https://reviews.apache.org/r/43853/diff/


Testing
---

the failed test since the change only affects that test only


Thanks,

Jinmei Liao