Re: [GitHub] incubator-geode pull request: GEODE-1163 Fix branding in Swagger U...

[Nitin Lamba]

Hi Dan,

I tried that first (without https) but got a permission denied (pubkey)
error - will try your suggested URL again next time.

Thanks @Anthony!
Nitin

On Friday, April 8, 2016, Dan Smith  wrote:

> Hi Nitin,
>
> Github is just a mirror, you need to push your changes to the apache
> repository. Use this url and your apache credentials:
>
> https://git-wip-us.apache.org/repos/asf/incubator-geode.git
>
> -Dan
>
> On Fri, Apr 8, 2016 at 7:35 PM, Nitin Lamba  > wrote:
>
> > I tried but get the following error:
> >
> > Pushing to https://nitin-...@github.com/apache/incubator-geode.git
> > remote: Permission to apache/incubator-geode.git denied to nitin-amp.
> >
> > Perhaps, it was not enabled last month OR I may be doing something wrong.
> >
> > Any help is appreciated. Thanks
> >
> >
> > On Fri, Apr 8, 2016 at 3:42 PM, Swapnil Bawaskar  >
> > wrote:
> >
> > > I have merged-in my pull requests in the past. So, I think you can too.
> > > Just follow the instructions in "Accepting the Pull-request" section on
> > > https://cwiki.apache.org/confluence/display/GEODE/Code+contributions
> > >
> > > On Fri, Apr 8, 2016 at 3:34 PM, Nitin Lamba  > wrote:
> > >
> > > > Any takers for merging this in? Don't think I could as I created the
> > pull
> > > > request :)
> > > >
> > > > Thanks,
> > > > Nitin
> > > >
> > > > On Thu, Apr 7, 2016 at 10:19 AM, sboorlagadda  >
> > > wrote:
> > > >
> > > > > Github user sboorlagadda commented on the pull request:
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/incubator-geode/pull/122#issuecomment-207004440
> > > > >
> > > > > +1
> > > > >
> > > > >
> > > > > ---
> > > > > If your project is set up for it, you can reply to this email and
> > have
> > > > your
> > > > > reply appear on GitHub as well. If your project does not have this
> > > > feature
> > > > > enabled and wishes so, or if the feature is enabled but not
> working,
> > > > please
> > > > > contact infrastructure at infrastruct...@apache.org 
> or file a JIRA
> > > > ticket
> > > > > with INFRA.
> > > > > ---
> > > > >
> > > >
> > >
> >
>

Re: Review Request 45938: GEODE-1062: Undoing reduction in wait time

[Nabarun Nag]

As per Jason's advice I will open a new ticket for rewriting the test case
design as tests are not suppose to wait for 4 min.
Also, while running all the WAN tests on IntelliJ I was able to find more
tests with timing issue which Jason and me solved earlier. (Running two
IntelliJ instances simultaneously )
Will create the ticket and push in the changes.
On Fri, Apr 8, 2016 at 1:45 PM Barry Oglesby  wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45938/
>
> Ship it!
>
> Ship It!
>
>
> - Barry Oglesby
>
> On April 8th, 2016, 8:26 p.m. UTC, Jason Huynh wrote:
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag,
> Dan Smith, and xiaojian zhou.
> By Jason Huynh.
>
> *Updated April 8, 2016, 8:26 p.m.*
> *Repository: * geode
> Description
>
> Some tests with overflow require the full 24 millisecond timeout...
>
> Diffs
>
>- 
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
>(130f960)
>
> View Diff 
>

Re: [GitHub] incubator-geode pull request: GEODE-1163 Fix branding in Swagger U...

[Anthony Baker]

Done.

Anthony

> On Apr 8, 2016, at 9:07 PM, Dan Smith  wrote:
> 
> Hi Nitin,
> 
> Github is just a mirror, you need to push your changes to the apache
> repository. Use this url and your apache credentials:
> 
> https://git-wip-us.apache.org/repos/asf/incubator-geode.git
> 
> -Dan
> 
> On Fri, Apr 8, 2016 at 7:35 PM, Nitin Lamba  wrote:
> 
>> I tried but get the following error:
>> 
>> Pushing to https://nitin-...@github.com/apache/incubator-geode.git
>> remote: Permission to apache/incubator-geode.git denied to nitin-amp.
>> 
>> Perhaps, it was not enabled last month OR I may be doing something wrong.
>> 
>> Any help is appreciated. Thanks
>> 
>> 
>> On Fri, Apr 8, 2016 at 3:42 PM, Swapnil Bawaskar 
>> wrote:
>> 
>>> I have merged-in my pull requests in the past. So, I think you can too.
>>> Just follow the instructions in "Accepting the Pull-request" section on
>>> https://cwiki.apache.org/confluence/display/GEODE/Code+contributions
>>> 
>>> On Fri, Apr 8, 2016 at 3:34 PM, Nitin Lamba  wrote:
>>> 
 Any takers for merging this in? Don't think I could as I created the
>> pull
 request :)
 
 Thanks,
 Nitin
 
 On Thu, Apr 7, 2016 at 10:19 AM, sboorlagadda 
>>> wrote:
 
> Github user sboorlagadda commented on the pull request:
> 
> 
> 
 
>>> 
>> https://github.com/apache/incubator-geode/pull/122#issuecomment-207004440
> 
>+1
> 
> 
> ---
> If your project is set up for it, you can reply to this email and
>> have
 your
> reply appear on GitHub as well. If your project does not have this
 feature
> enabled and wishes so, or if the feature is enabled but not working,
 please
> contact infrastructure at infrastruct...@apache.org or file a JIRA
 ticket
> with INFRA.
> ---
> 
 
>>> 
>> 



signature.asc
Description: Message signed with OpenPGP using GPGMail

[GitHub] incubator-geode pull request: GEODE-1163 Fix branding in Swagger U...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/122


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] incubator-geode pull request: GEODE-1163 Fix branding in Swagger U...

[Dan Smith]

Hi Nitin,

Github is just a mirror, you need to push your changes to the apache
repository. Use this url and your apache credentials:

https://git-wip-us.apache.org/repos/asf/incubator-geode.git

-Dan

On Fri, Apr 8, 2016 at 7:35 PM, Nitin Lamba  wrote:

> I tried but get the following error:
>
> Pushing to https://nitin-...@github.com/apache/incubator-geode.git
> remote: Permission to apache/incubator-geode.git denied to nitin-amp.
>
> Perhaps, it was not enabled last month OR I may be doing something wrong.
>
> Any help is appreciated. Thanks
>
>
> On Fri, Apr 8, 2016 at 3:42 PM, Swapnil Bawaskar 
> wrote:
>
> > I have merged-in my pull requests in the past. So, I think you can too.
> > Just follow the instructions in "Accepting the Pull-request" section on
> > https://cwiki.apache.org/confluence/display/GEODE/Code+contributions
> >
> > On Fri, Apr 8, 2016 at 3:34 PM, Nitin Lamba  wrote:
> >
> > > Any takers for merging this in? Don't think I could as I created the
> pull
> > > request :)
> > >
> > > Thanks,
> > > Nitin
> > >
> > > On Thu, Apr 7, 2016 at 10:19 AM, sboorlagadda 
> > wrote:
> > >
> > > > Github user sboorlagadda commented on the pull request:
> > > >
> > > >
> > > >
> > >
> >
> https://github.com/apache/incubator-geode/pull/122#issuecomment-207004440
> > > >
> > > > +1
> > > >
> > > >
> > > > ---
> > > > If your project is set up for it, you can reply to this email and
> have
> > > your
> > > > reply appear on GitHub as well. If your project does not have this
> > > feature
> > > > enabled and wishes so, or if the feature is enabled but not working,
> > > please
> > > > contact infrastructure at infrastruct...@apache.org or file a JIRA
> > > ticket
> > > > with INFRA.
> > > > ---
> > > >
> > >
> >
>

Re: [GitHub] incubator-geode pull request: GEODE-1163 Fix branding in Swagger U...

[Nitin Lamba]

I tried but get the following error:

Pushing to https://nitin-...@github.com/apache/incubator-geode.git
remote: Permission to apache/incubator-geode.git denied to nitin-amp.

Perhaps, it was not enabled last month OR I may be doing something wrong.

Any help is appreciated. Thanks


On Fri, Apr 8, 2016 at 3:42 PM, Swapnil Bawaskar 
wrote:

> I have merged-in my pull requests in the past. So, I think you can too.
> Just follow the instructions in "Accepting the Pull-request" section on
> https://cwiki.apache.org/confluence/display/GEODE/Code+contributions
>
> On Fri, Apr 8, 2016 at 3:34 PM, Nitin Lamba  wrote:
>
> > Any takers for merging this in? Don't think I could as I created the pull
> > request :)
> >
> > Thanks,
> > Nitin
> >
> > On Thu, Apr 7, 2016 at 10:19 AM, sboorlagadda 
> wrote:
> >
> > > Github user sboorlagadda commented on the pull request:
> > >
> > >
> > >
> >
> https://github.com/apache/incubator-geode/pull/122#issuecomment-207004440
> > >
> > > +1
> > >
> > >
> > > ---
> > > If your project is set up for it, you can reply to this email and have
> > your
> > > reply appear on GitHub as well. If your project does not have this
> > feature
> > > enabled and wishes so, or if the feature is enabled but not working,
> > please
> > > contact infrastructure at infrastruct...@apache.org or file a JIRA
> > ticket
> > > with INFRA.
> > > ---
> > >
> >
>

Review Request 45971: GEODE-1204 modified conditionals and opacity to make logo visible on Releases page.

[Dave Barnes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45971/
---

Review request for geode.


Repository: geode


Description
---

GEODE-1204 modified conditionals and opacity to make logo visible on Releases 
page.


Diffs
-

  geode-site/website/Rules 5369385483369d0fee30786733f8692959bcbf4a 
  geode-site/website/layouts/default.html 
2e3e2cd61917eb75be982c4ca6edac110e435846 
  geode-site/website/layouts/header.html 
6edaec80653cf8b99065e7c559ee4b13c8041101 
  geode-site/website/layouts/releases.html PRE-CREATION 

Diff: https://reviews.apache.org/r/45971/diff/


Testing
---


Thanks,

Dave Barnes

Review Request 45947: Update lucene version to 6.0.0

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45947/
---

Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
Smith, and xiaojian zhou.


Repository: geode


Description
---

Updated version to 6.0.0
Made modifications to use DoublePoint instead of LegacyDoubleField, IntPoint 
instead of LegacyIntField, etc
Added a temporary file to FileSystem.  This can be discussed as to how we want 
to handle this method.  Currently it creates a temporary, non distributed file.
SearcherManager creation now will pass in true for force deletes... This can 
also be discussed on what we want to pass in

Sorting the fileList due to new Lucene based test that requires the list 
returned to be sorted


Diffs
-

  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/RegionDirectory.java
 e25dc77 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystem.java
 b84dc92 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImpl.java
 a9c463e 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/SerializerUtil.java
 7ffc5db 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplPerformanceTest.java
 74f3742 
  gradle/dependency-versions.properties 7a5054b 

Diff: https://reviews.apache.org/r/45947/diff/


Testing
---

geode-lucene:precheckin
running precheckin


Thanks,

Jason Huynh

Re: [GitHub] incubator-geode pull request: GEODE-1163 Fix branding in Swagger U...

[Swapnil Bawaskar]

I have merged-in my pull requests in the past. So, I think you can too.
Just follow the instructions in "Accepting the Pull-request" section on
https://cwiki.apache.org/confluence/display/GEODE/Code+contributions

On Fri, Apr 8, 2016 at 3:34 PM, Nitin Lamba  wrote:

> Any takers for merging this in? Don't think I could as I created the pull
> request :)
>
> Thanks,
> Nitin
>
> On Thu, Apr 7, 2016 at 10:19 AM, sboorlagadda  wrote:
>
> > Github user sboorlagadda commented on the pull request:
> >
> >
> >
> https://github.com/apache/incubator-geode/pull/122#issuecomment-207004440
> >
> > +1
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastruct...@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
> >
>

Re: Incubator status report on wiki?

[Swapnil Bawaskar]

I have added the April 2016 report:
https://cwiki.apache.org/confluence/display/GEODE/Community+development

On Fri, Apr 8, 2016 at 2:50 PM, Swapnil Bawaskar 
wrote:

> Sure! I will add it to the geode wiki too.
>
> On Fri, Apr 8, 2016 at 2:29 PM, William Markito 
> wrote:
>
>> Yup, all the reports usually are stored in the Community Development page
>> as well as in the Incubator wiki -
>> https://cwiki.apache.org/confluence/display/GEODE/Community+development
>>
>> On Fri, Apr 8, 2016 at 1:07 PM Greg Chase  wrote:
>>
>> > Yes please 
>> >
>> > This email encrypted by tiny buttons & fat thumbs, beta voice
>> recognition,
>> > and autocorrect on my iPhone.
>> >
>> > > On Apr 8, 2016, at 1:05 PM, Michael Stolz  wrote:
>> > >
>> > > Should the geode incubator status report be posted on the geode wiki
>> > under
>> > > "Incubation Status Reports"?
>> > >
>> > > --
>> > > Mike Stolz
>> > > Principal Engineer, GemFire Product Manager
>> > > Mobile: 631-835-4771
>> >
>> --
>> ~/William
>>
>
>

Re: Incubator status report on wiki?

[Swapnil Bawaskar]

Sure! I will add it to the geode wiki too.

On Fri, Apr 8, 2016 at 2:29 PM, William Markito  wrote:

> Yup, all the reports usually are stored in the Community Development page
> as well as in the Incubator wiki -
> https://cwiki.apache.org/confluence/display/GEODE/Community+development
>
> On Fri, Apr 8, 2016 at 1:07 PM Greg Chase  wrote:
>
> > Yes please 
> >
> > This email encrypted by tiny buttons & fat thumbs, beta voice
> recognition,
> > and autocorrect on my iPhone.
> >
> > > On Apr 8, 2016, at 1:05 PM, Michael Stolz  wrote:
> > >
> > > Should the geode incubator status report be posted on the geode wiki
> > under
> > > "Incubation Status Reports"?
> > >
> > > --
> > > Mike Stolz
> > > Principal Engineer, GemFire Product Manager
> > > Mobile: 631-835-4771
> >
> --
> ~/William
>

Re: Incubator status report on wiki?

[William Markito]

Yup, all the reports usually are stored in the Community Development page
as well as in the Incubator wiki -
https://cwiki.apache.org/confluence/display/GEODE/Community+development

On Fri, Apr 8, 2016 at 1:07 PM Greg Chase  wrote:

> Yes please 
>
> This email encrypted by tiny buttons & fat thumbs, beta voice recognition,
> and autocorrect on my iPhone.
>
> > On Apr 8, 2016, at 1:05 PM, Michael Stolz  wrote:
> >
> > Should the geode incubator status report be posted on the geode wiki
> under
> > "Incubation Status Reports"?
> >
> > --
> > Mike Stolz
> > Principal Engineer, GemFire Product Manager
> > Mobile: 631-835-4771
>
-- 
~/William

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #273 was SUCCESSFUL (with 1379 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #273 was successful.
---
Scheduled
1383 tests in total.

https://build.spring.io/browse/SGF-NAG-273/





--
This message is automatically generated by Atlassian Bamboo

Re: Review Request 45938: GEODE-1062: Undoing reduction in wait time

[Barry Oglesby]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45938/#review127879
---


Ship it!




Ship It!

- Barry Oglesby


On April 8, 2016, 8:26 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45938/
> ---
> 
> (Updated April 8, 2016, 8:26 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Some tests with overflow require the full 24 millisecond timeout...
> 
> 
> Diffs
> -
> 
>   
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
>  130f960 
> 
> Diff: https://reviews.apache.org/r/45938/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Bundled jar dependencies

[Dan Smith]

I think these gfsh failures were caused by my changes for GEODE-1025. By
removing the rest of the spring jars from the geode-core depencies, we
reverted to using the version of spring-core that spring-shell depends on.

I have a fix to force the version of spring core to be 4.2.4:
https://reviews.apache.org/r/45945/

-Dan

On Fri, Apr 8, 2016 at 11:52 AM, Swapnil Bawaskar 
wrote:

> With the latest revision: dd9e5af4b4324e5511d170238f6532217384e15b
> I can't even start gfsh. I get this message:
>
> $ ./bin/gfsh
> Required (Spring Core) libraries not found in the classpath. gfsh can't
> start.
>
> On Fri, Apr 8, 2016 at 11:00 AM, Jinmei Liao  wrote:
>
> > Looks like the error is due to the fact that geode-dependencies.jar and
> > gfsh-dependencies.jar includes both spring-core versions in it's
> classpath,
> > and it fails to find ResolvableTypeProvider.java which only exists in the
> > later version. I tried turning off the transitive dependency of
> > spring-shell, and only include the spring-core-4.2.4.RELEASE in the
> > classpath, then the locator started with no errors.
> >
> > On Fri, Apr 8, 2016 at 10:00 AM, Jinmei Liao  wrote:
> >
> > > On a similar note, I just did a pull from develop and ran a clean
> > > installDist.  When I tried to start a locator in GFSH, I got the
> > following
> > > error in the log file:
> > >
> > > [error 2016/04/08 09:53:12.979 PDT locator1 
> > > tid=0x27] Jmx manager could not be started because HTTP service failed
> to
> > > start
> > >
> > > com.gemstone.gemfire.management.ManagementException: HTTP service
> failed
> > > to start
> > >
> > > at
> > >
> >
> com.gemstone.gemfire.management.internal.ManagementAgent.startHttpService(ManagementAgent.java:279)
> > >
> > > at
> > >
> >
> com.gemstone.gemfire.management.internal.ManagementAgent.startAgent(ManagementAgent.java:125)
> > >
> > > at
> > >
> >
> com.gemstone.gemfire.management.internal.SystemManagementService.startManager(SystemManagementService.java:475)
> > >
> > > at
> > >
> >
> com.gemstone.gemfire.management.internal.JmxManagerLocator.findJmxManager(JmxManagerLocator.java:104)
> > >
> > > at
> > >
> >
> com.gemstone.gemfire.management.internal.JmxManagerLocator.processRequest(JmxManagerLocator.java:57)
> > >
> > > at
> > >
> >
> com.gemstone.gemfire.distributed.internal.InternalLocator$PrimaryHandler.processRequest(InternalLocator.java:1328)
> > >
> > > at
> > >
> >
> com.gemstone.gemfire.distributed.internal.tcpserver.TcpServer$3.run(TcpServer.java:386)
> > >
> > > at
> > >
> >
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> > >
> > > at
> > >
> >
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> > >
> > > at java.lang.Thread.run(Thread.java:745)
> > >
> > > Caused by: MultiException[java.lang.NoClassDefFoundError:
> > > org/springframework/core/ResolvableTypeProvider,
> java.net.BindException:
> > > Address already in use]
> > >
> > > at org.eclipse.jetty.server.Server.doStart(Server.java:347)
> > >
> > > at
> > >
> >
> org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
> > >
> > > at
> > >
> >
> com.gemstone.gemfire.management.internal.JettyHelper.startJetty(JettyHelper.java:147)
> > >
> > > at
> > >
> >
> com.gemstone.gemfire.management.internal.ManagementAgent.startHttpService(ManagementAgent.java:251)
> > >
> > > ... 9 more
> > >
> > > Suppressed: java.net.BindException: Address already in use
> > >
> > > at sun.nio.ch.Net.bind0(Native Method)
> > >
> > > at sun.nio.ch.Net.bind(Net.java:433)
> > >
> > > at sun.nio.ch.Net.bind(Net.java:425)
> > >
> > > at
> > >
> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223)
> > >
> > > at
> > > sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
> > >
> > > at
> > > org.eclipse.jetty.server.ServerConnector.open(ServerConnector.java:326)
> > >
> > > at
> > >
> >
> org.eclipse.jetty.server.AbstractNetworkConnector.doStart(AbstractNetworkConnector.java:80)
> > >
> > > at
> > >
> >
> org.eclipse.jetty.server.ServerConnector.doStart(ServerConnector.java:244)
> > >
> > > at
> > >
> >
> org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
> > >
> > > at
> > org.eclipse.jetty.server.Server.doStart(Server.java:384)
> > >
> > > ... 12 more
> > >
> > > Caused by: java.lang.NoClassDefFoundError:
> > > org/springframework/core/ResolvableTypeProvider
> > >
> > > at java.lang.ClassLoader.defineClass1(Native Method)
> > >
> > > at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
> > >
> > > at
> > > 

Re: Review Request 45945: GEODE-1025: Force the version of spring core we use

[Anthony Baker]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45945/#review127878
---


Ship it!




Ship It!

- Anthony Baker


On April 8, 2016, 8:42 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45945/
> ---
> 
> (Updated April 8, 2016, 8:42 p.m.)
> 
> 
> Review request for geode and Anthony Baker.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Spring shell depends on an old version of spring-core. Once all of the
> rest of the spring dependencies were removed from geode-core, the spring
> shell dependency won and caused us to bundle the older version of spring
> core in the lib directory.
> 
> With this change, we all always use the desired version of spring-core.
> 
> 
> Diffs
> -
> 
>   gradle/dependency-resolution.gradle 
> dc247d275530512825a49e7acfd63f7e9ec7e430 
> 
> Diff: https://reviews.apache.org/r/45945/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: [discuss] Install Google Analytics for tracking activity on geode.incubator.apache.org

[Gregory Chase]

Amazing! We've had the largest spike of traffic on
geode.incubator.apache.org that I've seen in 3 months.  Or, our analytics
are working again!

Thanks Dave!

If anyone is interested in having access, please email your request to
priv...@geode.incubator.apache.org, or apachege...@gmail.com.  Please
provide your Google ID since access is administered from our project GMail
account.

Regards,

-Greg

On Tue, Apr 5, 2016 at 9:45 AM, Mark Bretl  wrote:

> +1
>
> --Mark
>
> On Tuesday, April 5, 2016, Dan Smith  wrote:
>
> > +1
> >
> > Sounds like good data to have!
> >
> > -Dan
> >
> > On Tue, Apr 5, 2016 at 9:27 AM, Jianxia Chen  > > wrote:
> >
> > > +1
> > >
> > > On Fri, Apr 1, 2016 at 10:11 AM, Gregory Chase  > > wrote:
> > >
> > > > Dear Geode contributors,
> > > > In the community marketing world, awareness tracking through
> analytics
> > > such
> > > > as website traffic are very important.
> > > >
> > > > We are currently flying blind on geode.incubator.apache.org.
> > > >
> > > > We don't know answers to questions like:
> > > > How many people are hitting our site
> > > > Whether they are new or returning
> > > > If they are potentially subscribing to email list or downloading
> > software
> > > > Where they are coming from
> > > > What they're most interested in next
> > > >
> > > > I had access to such information from the private Geode Summit site,
> > and
> > > > would really appreciate if we can make this available to the project.
> > > >
> > > > The account access would administered through the project Google
> > account,
> > > > which the PPMC currently manages for social media. Similar to how we
> > > handle
> > > > Twitter, access can be granted to interested individuals at their
> > request
> > > > through their personal Google accounts.
> > > >
> > > >  I will also commit to posting public quarterly graphs to dev, or on
> > the
> > > > wiki.
> > > >
> > > > Are there any objections to my installing Google Analytics tracking
> > tags
> > > > into the Geode website, and setting up this account as described?
> > > >
> > > > Regards,
> > > >
> > > > -Greg
> > > >
> > > > --
> > > > Greg Chase
> > > >
> > > > Global Head, Big Data Communities
> > > > http://www.pivotal.io/big-data
> > > >
> > > > Pivotal Software
> > > > http://www.pivotal.io/
> > > >
> > > > 650-215-0477
> > > > @GregChase
> > > > Blog: http://geekmarketing.biz/
> > > >
> > >
> >
>



-- 
Greg Chase

Global Head, Big Data Communities
http://www.pivotal.io/big-data

Pivotal Software
http://www.pivotal.io/

650-215-0477
@GregChase
Blog: http://geekmarketing.biz/

Review Request 45945: GEODE-1025: Force the version of spring core we use

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45945/
---

Review request for geode and Anthony Baker.


Repository: geode


Description
---

Spring shell depends on an old version of spring-core. Once all of the
rest of the spring dependencies were removed from geode-core, the spring
shell dependency won and caused us to bundle the older version of spring
core in the lib directory.

With this change, we all always use the desired version of spring-core.


Diffs
-

  gradle/dependency-resolution.gradle dc247d275530512825a49e7acfd63f7e9ec7e430 

Diff: https://reviews.apache.org/r/45945/diff/


Testing
---


Thanks,

Dan Smith

Re: Review Request 45938: GEODE-1062: Undoing reduction in wait time

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45938/
---

(Updated April 8, 2016, 8:26 p.m.)


Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
Smith, and xiaojian zhou.


Changes
---

Updated diff to add a new method signature.  Any tests that are failing due to 
the defaulted 30 seconds can now be changed on a per test basis to wait for 
however long the test thinks it needs.


Repository: geode


Description
---

Some tests with overflow require the full 24 millisecond timeout...


Diffs (updated)
-

  
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
 130f960 

Diff: https://reviews.apache.org/r/45938/diff/


Testing
---


Thanks,

Jason Huynh

Re: Review Request 45938: GEODE-1062: Undoing reduction in wait time

[Barry Oglesby]

> On April 8, 2016, 8:02 p.m., Barry Oglesby wrote:
> > Maybe that timeout should be configurable? Most times 4 minutes might as 
> > well be forever.
> 
> Jason Huynh wrote:
> Yes, that would be a good idea.  I'm trying to revert this one change in 
> the big refactoring I did earlier for GEODE-1062.  I didn't think anything 
> would need to wait 4 minutes but Naba found a test that fails for him on his 
> machine.  Most of the properly passing tests will actually complete before 
> the 4 minutes due to this being a wait criterion.
> 
> Barry Oglesby wrote:
> Right, but if it isn't a "properly passing test," then you're stuck 
> waiting for 4 minutes for it to fail. I'm sure all our tests will pass from 
> now on, so we don't have to worry about this wait time.
> 
> Jason Huynh wrote:
> Or maybe I can leave this change at 30 seconds and any test that fails 
> from this can be rewritten to not rely on the full 4 minutes?

Thats a good idea. I guess it depends on why the test needs 4 minutes to 
validateRegionSize. I wouldn't worry about it too much. Your change is just 
fine.


- Barry


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45938/#review127865
---


On April 8, 2016, 6:37 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45938/
> ---
> 
> (Updated April 8, 2016, 6:37 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Some tests with overflow require the full 24 millisecond timeout...
> 
> 
> Diffs
> -
> 
>   
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
>  130f960 
> 
> Diff: https://reviews.apache.org/r/45938/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 45938: GEODE-1062: Undoing reduction in wait time

[Jason Huynh]

> On April 8, 2016, 8:02 p.m., Barry Oglesby wrote:
> > Maybe that timeout should be configurable? Most times 4 minutes might as 
> > well be forever.
> 
> Jason Huynh wrote:
> Yes, that would be a good idea.  I'm trying to revert this one change in 
> the big refactoring I did earlier for GEODE-1062.  I didn't think anything 
> would need to wait 4 minutes but Naba found a test that fails for him on his 
> machine.  Most of the properly passing tests will actually complete before 
> the 4 minutes due to this being a wait criterion.
> 
> Barry Oglesby wrote:
> Right, but if it isn't a "properly passing test," then you're stuck 
> waiting for 4 minutes for it to fail. I'm sure all our tests will pass from 
> now on, so we don't have to worry about this wait time.

Or maybe I can leave this change at 30 seconds and any test that fails from 
this can be rewritten to not rely on the full 4 minutes?


- Jason


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45938/#review127865
---


On April 8, 2016, 6:37 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45938/
> ---
> 
> (Updated April 8, 2016, 6:37 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Some tests with overflow require the full 24 millisecond timeout...
> 
> 
> Diffs
> -
> 
>   
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
>  130f960 
> 
> Diff: https://reviews.apache.org/r/45938/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 45938: GEODE-1062: Undoing reduction in wait time

[Barry Oglesby]

> On April 8, 2016, 8:02 p.m., Barry Oglesby wrote:
> > Maybe that timeout should be configurable? Most times 4 minutes might as 
> > well be forever.
> 
> Jason Huynh wrote:
> Yes, that would be a good idea.  I'm trying to revert this one change in 
> the big refactoring I did earlier for GEODE-1062.  I didn't think anything 
> would need to wait 4 minutes but Naba found a test that fails for him on his 
> machine.  Most of the properly passing tests will actually complete before 
> the 4 minutes due to this being a wait criterion.

Right, but if it isn't a "properly passing test," then you're stuck waiting for 
4 minutes for it to fail. I'm sure all our tests will pass from now on, so we 
don't have to worry about this wait time.


- Barry


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45938/#review127865
---


On April 8, 2016, 6:37 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45938/
> ---
> 
> (Updated April 8, 2016, 6:37 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Some tests with overflow require the full 24 millisecond timeout...
> 
> 
> Diffs
> -
> 
>   
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
>  130f960 
> 
> Diff: https://reviews.apache.org/r/45938/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 45938: GEODE-1062: Undoing reduction in wait time

[Barry Oglesby]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45938/#review127870
---


Ship it!




Ship It!

- Barry Oglesby


On April 8, 2016, 6:37 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45938/
> ---
> 
> (Updated April 8, 2016, 6:37 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Some tests with overflow require the full 24 millisecond timeout...
> 
> 
> Diffs
> -
> 
>   
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
>  130f960 
> 
> Diff: https://reviews.apache.org/r/45938/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 45938: GEODE-1062: Undoing reduction in wait time

[Jason Huynh]

> On April 8, 2016, 8:02 p.m., Barry Oglesby wrote:
> > Maybe that timeout should be configurable? Most times 4 minutes might as 
> > well be forever.

Yes, that would be a good idea.  I'm trying to revert this one change in the 
big refactoring I did earlier for GEODE-1062.  I didn't think anything would 
need to wait 4 minutes but Naba found a test that fails for him on his machine. 
 Most of the properly passing tests will actually complete before the 4 minutes 
due to this being a wait criterion.


- Jason


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45938/#review127865
---


On April 8, 2016, 6:37 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45938/
> ---
> 
> (Updated April 8, 2016, 6:37 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Some tests with overflow require the full 24 millisecond timeout...
> 
> 
> Diffs
> -
> 
>   
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
>  130f960 
> 
> Diff: https://reviews.apache.org/r/45938/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Incubator status report on wiki?

[Greg Chase]

Yes please 

This email encrypted by tiny buttons & fat thumbs, beta voice recognition, and 
autocorrect on my iPhone.

> On Apr 8, 2016, at 1:05 PM, Michael Stolz  wrote:
> 
> Should the geode incubator status report be posted on the geode wiki under
> "Incubation Status Reports"?
> 
> --
> Mike Stolz
> Principal Engineer, GemFire Product Manager
> Mobile: 631-835-4771

Incubator status report on wiki?

[Michael Stolz]

Should the geode incubator status report be posted on the geode wiki under
"Incubation Status Reports"?

--
Mike Stolz
Principal Engineer, GemFire Product Manager
Mobile: 631-835-4771

Re: Review Request 45938: GEODE-1062: Undoing reduction in wait time

[Barry Oglesby]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45938/#review127865
---



Maybe that timeout should be configurable? Most times 4 minutes might as well 
be forever.

- Barry Oglesby


On April 8, 2016, 6:37 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45938/
> ---
> 
> (Updated April 8, 2016, 6:37 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Some tests with overflow require the full 24 millisecond timeout...
> 
> 
> Diffs
> -
> 
>   
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
>  130f960 
> 
> Diff: https://reviews.apache.org/r/45938/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

[GitHub] incubator-geode pull request: Feature/geode 904

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/126


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[VIDEO] Posted! Geode Clubhouse 4/6/16 - Security in Geode

[Gregory Chase]

Greetings Geode community,

We've just posted the recording for last Wednesday's Geode Clubhouse.

Please enjoy: https://www.youtube.com/watch?v=so7AJWgHnvA=youtu.be

-Greg


On Tue, Apr 5, 2016 at 8:39 AM, Gregory Chase  wrote:

> It's time for the next Apache Geode Clubhouse Meeting on April 6th!
>
> Each meeting starts with a 20-minute user technology discussion topic,
> followed by a contributor & committer discussion of open JIRA issues,
> release coordination, and open Q
>
> 20-minute User Tech Talk: Security in Apache Geode
>
> Apache Geode Committer, Jens Deppe will discuss:
>
> • Securing communications in Geode
> • Authenticating users
> • Authorizing users
> • Future work
>
> About the speaker: Jens Deppe is an Apache Geode Commiter and Enterprise
> Architect at Pivotal.
>
> Standing agenda:
>
> -Open Jiras, and ways to contribute
> -Next release coordination
> -Open Q
>
> Please join us on April 6th, 2016 at:
> https://pivotalcommunity.adobeconnect.com/clubhouse/
>
> 4/6 San Francisco, CA 9:00 AM PDT UTC-8 hours
> 4/6 New York, NY 12:00 PM EDT UTC-5 hours
>
> As always, this meeting will be recorded and posted.
>
> 
> Adobe Connect tips: For issues with Chrome.  A little icon appears in the
> address bar.  It's EASY to miss. You click it and it allows Adobe to use
> the mic, even if you select 'allow' in the popup, it doesn't work until you
> change it in address bar too.
>
> Also, preload as much content as is possible to help bandwidth issues.
> 
> If you have never attended an Adobe Connect meeting before:
>
> Test your connection:
> https://pivotalcommunity.adobeconnect.com/common/help/en/support/meeting_test.htm
>
> Get a quick overview: http://www.adobe.com/products/adobeconnect.html
>
> --
> Greg Chase
>
> Global Head, Big Data Communities
> http://www.pivotal.io/big-data
>
> Pivotal Software
> http://www.pivotal.io/
>
> 650-215-0477
> @GregChase
> Blog: http://geekmarketing.biz/
>
>


-- 
Greg Chase

Global Head, Big Data Communities
http://www.pivotal.io/big-data

Pivotal Software
http://www.pivotal.io/

650-215-0477
@GregChase
Blog: http://geekmarketing.biz/

Re: Review Request 45827: GEODE-902: Remove incorrect src header; update LICENSE and NOTICE

[Joey McAllister]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45827/#review127851
---


Ship it!




Ship It!

- Joey McAllister


On April 6, 2016, 6:07 p.m., Anthony Baker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45827/
> ---
> 
> (Updated April 6, 2016, 6:07 p.m.)
> 
> 
> Review request for geode, Joey McAllister and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-902: Remove incorrect src header
> 
> GEODE-902: Update LICENSE / NOTICE for MX4JModelMBean.java
> 
> Added a pointer to the MX4J license and an entry in the NOTICE
> file for both the source and binary distributions. This update
> is an interim change as we are reworking the files for the M2
> release.
> 
> 
> Diffs
> -
> 
>   LICENSE 31f4473161272ff3e1aa01f2ed9eecbee013531c 
>   NOTICE 5396eaa37a8ab5e54f689b60d28292604c2b3a88 
>   geode-assembly/src/main/dist/LICENSE 
> 2f1374b190fa2fd9d42610ad597c0980e22d5b24 
>   geode-assembly/src/main/dist/NOTICE 
> b42971539456ffb5778c60d124c9fe17e7152b31 
>   
> geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/MX4JModelMBean.java
>  1add1ecc56912991f23d441b6677b85e5f2867db 
> 
> Diff: https://reviews.apache.org/r/45827/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Baker
> 
>

Re: Review Request 45919: Updates to NOTICE

[Joey McAllister]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45919/#review127849
---


Ship it!




Ship It!

- Joey McAllister


On April 8, 2016, 12:21 p.m., Anthony Baker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45919/
> ---
> 
> (Updated April 8, 2016, 12:21 p.m.)
> 
> 
> Review request for geode, Joey McAllister, Swapnil Bawaskar, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-914: Remove log4j from NOTICE
> 
> Commit 5342935d301a4026b289637885e9236414feeb78 cleaned up log4j
> code so this no longer needs to be declared in NOTICE.
> 
> GEODE-914: Removed unnecessary declarations from NOTICE
> 
> Removed spring-petclinic, Apache MyFaces, and fastutil from
> NOTICE.  None of these project contain a NOTICE with content
> that needs to be propagated.
> 
> GEODE-914: Reworked NOTICE for binary distribution
> 
> Update binary NOTICE to match changes to bundled jar files.
> 
> 
> Diffs
> -
> 
>   NOTICE 8e7485fe5d8da0548cdb7d4d958bb612ea2c501a 
>   geode-assembly/src/main/dist/NOTICE 
> ec14cdaf4677c47032bf4840eca9d07da7ef4475 
> 
> Diff: https://reviews.apache.org/r/45919/diff/
> 
> 
> Testing
> ---
> 
> I should point out the NOTICE was semi-mechanically generated by:
> 
> 1) exploding the binary distribution
> 2) exploding the embedded archives, wars, and jars
> 3) concatenating the notice file (if any) from each dependency
> 
> After that I removed duplicate entries and extraneous lines.
> 
> Still to come: specific notices for geode-web, geode-web-api, geode-pulse as 
> these generate war files that are distributed via maven.
> 
> 
> Thanks,
> 
> Anthony Baker
> 
>

Re: Review Request 45931: GEODE-914: Added specific NOTICE files for war projects

[Joey McAllister]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45931/#review127850
---


Ship it!




Ship It!

- Joey McAllister


On April 8, 2016, 3:26 p.m., Anthony Baker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45931/
> ---
> 
> (Updated April 8, 2016, 3:26 p.m.)
> 
> 
> Review request for geode, Jens Deppe, Joey McAllister, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Since the war projects (geode-web, geode-web-api, geode-pulse)
> are distributed on Maven, added a NOTICE file specific to each
> war based on the bundled jars.
> 
> Also added the source LICENSE to all jar-type artifacts.
> 
> 
> Diffs
> -
> 
>   geode-pulse/src/main/webapp/META-INF/MANIFEST.MF 
> 5e9495128c0376427420c4189993b3851770b702 
>   geode-pulse/src/main/webapp/META-INF/NOTICE PRE-CREATION 
>   geode-web-api/src/main/webapp/META-INF/NOTICE PRE-CREATION 
>   geode-web/src/main/webapp/META-INF/NOTICE PRE-CREATION 
>   gradle/java.gradle 85e18d879f3179e8f779e88ca9ba8f8a2842d41a 
> 
> Diff: https://reviews.apache.org/r/45931/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Baker
> 
>

[GitHub] incubator-geode pull request: Feature/geode 904

[metatype]

Github user metatype commented on the pull request:

https://github.com/apache/incubator-geode/pull/126#issuecomment-207566042
  
+1 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Geode Nightly

[William Markito]

I've just added a timeout (24h) to our builds to avoid it getting stuck for
such long periods and we're now going to archive progress test files as
well.

Hope that helps

On Fri, Apr 8, 2016 at 8:37 AM Anthony Baker  wrote:

> The last task was :geode-wan:distributedTest.  Without the full contents
> of the build dirs it’s hard to tell what test hung.
>
> We don’t have a way to detect a hung DUnit, dump stacks, and move on right?
>
> Anthony
>
>
> > On Apr 8, 2016, at 7:55 AM, Jinmei Liao  wrote:
> >
> > FYI: The last geode nightly has been running for more than 3 days.
> William
> > killed it this morning. The log doesn't say much (at least not to me and
> > William :)).
> >
> > https://builds.apache.org/job/Geode-nightly/431/
> >
> >
> >
> > --
> > Cheers
> >
> > Jinmei
>
> --
~/William

[GitHub] incubator-geode pull request: Feature/geode 904

[metatype]

Github user metatype commented on the pull request:

https://github.com/apache/incubator-geode/pull/126#issuecomment-207558046
  
This looks awesome!!  Only change I would make is to add this to the CDDL 
license for the javax* dependencies:

```
   NOTICE PURSUANT TO SECTION 9 OF THE COMMON DEVELOPMENT AND DISTRIBUTION 
LICENSE (CDDL)

   The code released under the CDDL shall be governed by the laws of the 
State of California (excluding conflict-of-law provisions). Any litigation 
relating to this License shall be subject to the jurisdiction of the Federal 
Courts of the Northern District of California and the state courts of the State 
of California, with venue lying in Santa Clara County, California.
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Bundled jar dependencies

[Swapnil Bawaskar]

With the latest revision: dd9e5af4b4324e5511d170238f6532217384e15b
I can't even start gfsh. I get this message:

$ ./bin/gfsh
Required (Spring Core) libraries not found in the classpath. gfsh can't
start.

On Fri, Apr 8, 2016 at 11:00 AM, Jinmei Liao  wrote:

> Looks like the error is due to the fact that geode-dependencies.jar and
> gfsh-dependencies.jar includes both spring-core versions in it's classpath,
> and it fails to find ResolvableTypeProvider.java which only exists in the
> later version. I tried turning off the transitive dependency of
> spring-shell, and only include the spring-core-4.2.4.RELEASE in the
> classpath, then the locator started with no errors.
>
> On Fri, Apr 8, 2016 at 10:00 AM, Jinmei Liao  wrote:
>
> > On a similar note, I just did a pull from develop and ran a clean
> > installDist.  When I tried to start a locator in GFSH, I got the
> following
> > error in the log file:
> >
> > [error 2016/04/08 09:53:12.979 PDT locator1 
> > tid=0x27] Jmx manager could not be started because HTTP service failed to
> > start
> >
> > com.gemstone.gemfire.management.ManagementException: HTTP service failed
> > to start
> >
> > at
> >
> com.gemstone.gemfire.management.internal.ManagementAgent.startHttpService(ManagementAgent.java:279)
> >
> > at
> >
> com.gemstone.gemfire.management.internal.ManagementAgent.startAgent(ManagementAgent.java:125)
> >
> > at
> >
> com.gemstone.gemfire.management.internal.SystemManagementService.startManager(SystemManagementService.java:475)
> >
> > at
> >
> com.gemstone.gemfire.management.internal.JmxManagerLocator.findJmxManager(JmxManagerLocator.java:104)
> >
> > at
> >
> com.gemstone.gemfire.management.internal.JmxManagerLocator.processRequest(JmxManagerLocator.java:57)
> >
> > at
> >
> com.gemstone.gemfire.distributed.internal.InternalLocator$PrimaryHandler.processRequest(InternalLocator.java:1328)
> >
> > at
> >
> com.gemstone.gemfire.distributed.internal.tcpserver.TcpServer$3.run(TcpServer.java:386)
> >
> > at
> >
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> >
> > at
> >
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> >
> > at java.lang.Thread.run(Thread.java:745)
> >
> > Caused by: MultiException[java.lang.NoClassDefFoundError:
> > org/springframework/core/ResolvableTypeProvider, java.net.BindException:
> > Address already in use]
> >
> > at org.eclipse.jetty.server.Server.doStart(Server.java:347)
> >
> > at
> >
> org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
> >
> > at
> >
> com.gemstone.gemfire.management.internal.JettyHelper.startJetty(JettyHelper.java:147)
> >
> > at
> >
> com.gemstone.gemfire.management.internal.ManagementAgent.startHttpService(ManagementAgent.java:251)
> >
> > ... 9 more
> >
> > Suppressed: java.net.BindException: Address already in use
> >
> > at sun.nio.ch.Net.bind0(Native Method)
> >
> > at sun.nio.ch.Net.bind(Net.java:433)
> >
> > at sun.nio.ch.Net.bind(Net.java:425)
> >
> > at
> > sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223)
> >
> > at
> > sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
> >
> > at
> > org.eclipse.jetty.server.ServerConnector.open(ServerConnector.java:326)
> >
> > at
> >
> org.eclipse.jetty.server.AbstractNetworkConnector.doStart(AbstractNetworkConnector.java:80)
> >
> > at
> >
> org.eclipse.jetty.server.ServerConnector.doStart(ServerConnector.java:244)
> >
> > at
> >
> org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
> >
> > at
> org.eclipse.jetty.server.Server.doStart(Server.java:384)
> >
> > ... 12 more
> >
> > Caused by: java.lang.NoClassDefFoundError:
> > org/springframework/core/ResolvableTypeProvider
> >
> > at java.lang.ClassLoader.defineClass1(Native Method)
> >
> > at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
> >
> > at
> > java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
> >
> > at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
> >
> > at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
> >
> > at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
> >
> > at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
> >
> > at java.security.AccessController.doPrivileged(Native Method)
> >
> > at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
> >
> > at
> >
> org.eclipse.jetty.webapp.WebAppClassLoader.findClass(WebAppClassLoader.java:549)
> >
> > at
> >
> 

Review Request 45938: GEODE-1062: Undoing reduction in wait time

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45938/
---

Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
Smith, and xiaojian zhou.


Repository: geode


Description
---

Some tests with overflow require the full 24 millisecond timeout...


Diffs
-

  
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
 130f960 

Diff: https://reviews.apache.org/r/45938/diff/


Testing
---


Thanks,

Jason Huynh

Re: Bundled jar dependencies

[Jinmei Liao]

Looks like the error is due to the fact that geode-dependencies.jar and
gfsh-dependencies.jar includes both spring-core versions in it's classpath,
and it fails to find ResolvableTypeProvider.java which only exists in the
later version. I tried turning off the transitive dependency of
spring-shell, and only include the spring-core-4.2.4.RELEASE in the
classpath, then the locator started with no errors.

On Fri, Apr 8, 2016 at 10:00 AM, Jinmei Liao  wrote:

> On a similar note, I just did a pull from develop and ran a clean
> installDist.  When I tried to start a locator in GFSH, I got the following
> error in the log file:
>
> [error 2016/04/08 09:53:12.979 PDT locator1 
> tid=0x27] Jmx manager could not be started because HTTP service failed to
> start
>
> com.gemstone.gemfire.management.ManagementException: HTTP service failed
> to start
>
> at
> com.gemstone.gemfire.management.internal.ManagementAgent.startHttpService(ManagementAgent.java:279)
>
> at
> com.gemstone.gemfire.management.internal.ManagementAgent.startAgent(ManagementAgent.java:125)
>
> at
> com.gemstone.gemfire.management.internal.SystemManagementService.startManager(SystemManagementService.java:475)
>
> at
> com.gemstone.gemfire.management.internal.JmxManagerLocator.findJmxManager(JmxManagerLocator.java:104)
>
> at
> com.gemstone.gemfire.management.internal.JmxManagerLocator.processRequest(JmxManagerLocator.java:57)
>
> at
> com.gemstone.gemfire.distributed.internal.InternalLocator$PrimaryHandler.processRequest(InternalLocator.java:1328)
>
> at
> com.gemstone.gemfire.distributed.internal.tcpserver.TcpServer$3.run(TcpServer.java:386)
>
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>
> at java.lang.Thread.run(Thread.java:745)
>
> Caused by: MultiException[java.lang.NoClassDefFoundError:
> org/springframework/core/ResolvableTypeProvider, java.net.BindException:
> Address already in use]
>
> at org.eclipse.jetty.server.Server.doStart(Server.java:347)
>
> at
> org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
>
> at
> com.gemstone.gemfire.management.internal.JettyHelper.startJetty(JettyHelper.java:147)
>
> at
> com.gemstone.gemfire.management.internal.ManagementAgent.startHttpService(ManagementAgent.java:251)
>
> ... 9 more
>
> Suppressed: java.net.BindException: Address already in use
>
> at sun.nio.ch.Net.bind0(Native Method)
>
> at sun.nio.ch.Net.bind(Net.java:433)
>
> at sun.nio.ch.Net.bind(Net.java:425)
>
> at
> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223)
>
> at
> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
>
> at
> org.eclipse.jetty.server.ServerConnector.open(ServerConnector.java:326)
>
> at
> org.eclipse.jetty.server.AbstractNetworkConnector.doStart(AbstractNetworkConnector.java:80)
>
> at
> org.eclipse.jetty.server.ServerConnector.doStart(ServerConnector.java:244)
>
> at
> org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
>
> at org.eclipse.jetty.server.Server.doStart(Server.java:384)
>
> ... 12 more
>
> Caused by: java.lang.NoClassDefFoundError:
> org/springframework/core/ResolvableTypeProvider
>
> at java.lang.ClassLoader.defineClass1(Native Method)
>
> at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
>
> at
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
>
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
>
> at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
>
> at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
>
> at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
>
> at java.security.AccessController.doPrivileged(Native Method)
>
> at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
>
> at
> org.eclipse.jetty.webapp.WebAppClassLoader.findClass(WebAppClassLoader.java:549)
>
> at
> org.eclipse.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:475)
>
> at
> org.eclipse.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:428)
>
> at java.lang.Class.getDeclaredConstructors0(Native Method)
>
> at java.lang.Class.privateGetDeclaredConstructors(Class.java:2671)
>
> at java.lang.Class.getConstructor0(Class.java:3075)
>
> at java.lang.Class.getDeclaredConstructor(Class.java:2178)
>
> at
> org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:104)
>
> at
> 

Re: Bundled jar dependencies

[Jinmei Liao]

On a similar note, I just did a pull from develop and ran a clean
installDist.  When I tried to start a locator in GFSH, I got the following
error in the log file:

[error 2016/04/08 09:53:12.979 PDT locator1 
tid=0x27] Jmx manager could not be started because HTTP service failed to
start

com.gemstone.gemfire.management.ManagementException: HTTP service failed to
start

at
com.gemstone.gemfire.management.internal.ManagementAgent.startHttpService(ManagementAgent.java:279)

at
com.gemstone.gemfire.management.internal.ManagementAgent.startAgent(ManagementAgent.java:125)

at
com.gemstone.gemfire.management.internal.SystemManagementService.startManager(SystemManagementService.java:475)

at
com.gemstone.gemfire.management.internal.JmxManagerLocator.findJmxManager(JmxManagerLocator.java:104)

at
com.gemstone.gemfire.management.internal.JmxManagerLocator.processRequest(JmxManagerLocator.java:57)

at
com.gemstone.gemfire.distributed.internal.InternalLocator$PrimaryHandler.processRequest(InternalLocator.java:1328)

at
com.gemstone.gemfire.distributed.internal.tcpserver.TcpServer$3.run(TcpServer.java:386)

at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)

at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)

at java.lang.Thread.run(Thread.java:745)

Caused by: MultiException[java.lang.NoClassDefFoundError:
org/springframework/core/ResolvableTypeProvider, java.net.BindException:
Address already in use]

at org.eclipse.jetty.server.Server.doStart(Server.java:347)

at
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)

at
com.gemstone.gemfire.management.internal.JettyHelper.startJetty(JettyHelper.java:147)

at
com.gemstone.gemfire.management.internal.ManagementAgent.startHttpService(ManagementAgent.java:251)

... 9 more

Suppressed: java.net.BindException: Address already in use

at sun.nio.ch.Net.bind0(Native Method)

at sun.nio.ch.Net.bind(Net.java:433)

at sun.nio.ch.Net.bind(Net.java:425)

at
sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223)

at
sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)

at
org.eclipse.jetty.server.ServerConnector.open(ServerConnector.java:326)

at
org.eclipse.jetty.server.AbstractNetworkConnector.doStart(AbstractNetworkConnector.java:80)

at
org.eclipse.jetty.server.ServerConnector.doStart(ServerConnector.java:244)

at
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)

at org.eclipse.jetty.server.Server.doStart(Server.java:384)

... 12 more

Caused by: java.lang.NoClassDefFoundError:
org/springframework/core/ResolvableTypeProvider

at java.lang.ClassLoader.defineClass1(Native Method)

at java.lang.ClassLoader.defineClass(ClassLoader.java:760)

at
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)

at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)

at java.net.URLClassLoader.access$100(URLClassLoader.java:73)

at java.net.URLClassLoader$1.run(URLClassLoader.java:368)

at java.net.URLClassLoader$1.run(URLClassLoader.java:362)

at java.security.AccessController.doPrivileged(Native Method)

at java.net.URLClassLoader.findClass(URLClassLoader.java:361)

at
org.eclipse.jetty.webapp.WebAppClassLoader.findClass(WebAppClassLoader.java:549)

at
org.eclipse.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:475)

at
org.eclipse.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:428)

at java.lang.Class.getDeclaredConstructors0(Native Method)

at java.lang.Class.privateGetDeclaredConstructors(Class.java:2671)

at java.lang.Class.getConstructor0(Class.java:3075)

at java.lang.Class.getDeclaredConstructor(Class.java:2178)

at
org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:104)

at
org.springframework.web.servlet.FrameworkServlet.createWebApplicationContext(FrameworkServlet.java:628)

at
org.springframework.web.servlet.FrameworkServlet.createWebApplicationContext(FrameworkServlet.java:682)

at
org.springframework.web.servlet.FrameworkServlet.initWebApplicationContext(FrameworkServlet.java:553)

at
org.springframework.web.servlet.FrameworkServlet.initServletBean(FrameworkServlet.java:494)

at
org.springframework.web.servlet.HttpServletBean.init(HttpServletBean.java:136)

at javax.servlet.GenericServlet.init(GenericServlet.java:244)

at
org.eclipse.jetty.servlet.ServletHolder.initServlet(ServletHolder.java:626)

at

Re: Geode Nightly

[Anthony Baker]

The last task was :geode-wan:distributedTest.  Without the full contents of the 
build dirs it’s hard to tell what test hung.

We don’t have a way to detect a hung DUnit, dump stacks, and move on right?

Anthony


> On Apr 8, 2016, at 7:55 AM, Jinmei Liao  wrote:
> 
> FYI: The last geode nightly has been running for more than 3 days. William
> killed it this morning. The log doesn't say much (at least not to me and
> William :)).
> 
> https://builds.apache.org/job/Geode-nightly/431/
> 
> 
> 
> --
> Cheers
> 
> Jinmei



signature.asc
Description: Message signed with OpenPGP using GPGMail

Review Request 45931: GEODE-914: Added specific NOTICE files for war projects

[Anthony Baker]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45931/
---

Review request for geode, Jens Deppe, Joey McAllister, and Dan Smith.


Repository: geode


Description
---

Since the war projects (geode-web, geode-web-api, geode-pulse)
are distributed on Maven, added a NOTICE file specific to each
war based on the bundled jars.

Also added the source LICENSE to all jar-type artifacts.


Diffs
-

  geode-pulse/src/main/webapp/META-INF/MANIFEST.MF 
5e9495128c0376427420c4189993b3851770b702 
  geode-pulse/src/main/webapp/META-INF/NOTICE PRE-CREATION 
  geode-web-api/src/main/webapp/META-INF/NOTICE PRE-CREATION 
  geode-web/src/main/webapp/META-INF/NOTICE PRE-CREATION 
  gradle/java.gradle 85e18d879f3179e8f779e88ca9ba8f8a2842d41a 

Diff: https://reviews.apache.org/r/45931/diff/


Testing
---


Thanks,

Anthony Baker

Geode Nightly

[Jinmei Liao]

FYI: The last geode nightly has been running for more than 3 days. William
killed it this morning. The log doesn't say much (at least not to me and
William :)).

https://builds.apache.org/job/Geode-nightly/431/



-- 
Cheers

Jinmei

Re: Bundled jar dependencies

[Anthony Baker]

After an update I’m seeing a conflict on spring-core.  Here’s the 
geode-dependencies classpath with both versions of spring-core:

Class-Path: geode-common-1.0.0-incubating.M2-SNAPSHOT.jar geode-json-1
 .0.0-incubating.M2-SNAPSHOT.jar geode-joptsimple-1.0.0-incubating.M2-
 SNAPSHOT.jar geode-core-1.0.0-incubating.M2-SNAPSHOT.jar geode-lucene
 -1.0.0-incubating.M2-SNAPSHOT.jar geode-pulse-1.0.0-incubating.M2-SNA
 PSHOT.jar geode-wan-1.0.0-incubating.M2-SNAPSHOT.jar geode-cq-1.0.0-i
 ncubating.M2-SNAPSHOT.jar jgroups-3.6.7.Final.jar antlr-2.7.7.jar jac
 kson-databind-2.2.0.jar commons-io-2.3.jar commons-lang-2.5.jar netty
 -all-4.0.4.Final.jar fastutil-7.0.2.jar javax.resource-api-1.7.jar jn
 a-4.0.0.jar log4j-api-2.5.jar log4j-core-2.5.jar jetty-webapp-9.3.6.v
 20151106.jar spring-shell-1.1.0.RELEASE.jar snappy-java-1.1.1.6.jar j
 ansi-1.8.jar log4j-slf4j-impl-2.5.jar log4j-jcl-2.5.jar log4j-jul-2.5
 .jar jackson-annotations-2.2.0.jar jackson-core-2.2.0.jar javax.trans
 action-api-1.2.jar jetty-xml-9.3.6.v20151106.jar jetty-servlet-9.3.6.
 v20151106.jar jline-2.12.jar spring-core-4.0.3.RELEASE.jar slf4j-api-
 1.7.12.jar commons-logging-1.2.jar jetty-util-9.3.6.v20151106.jar jet
 ty-security-9.3.6.v20151106.jar jetty-server-9.3.6.v20151106.jar java
 x.servlet-api-3.1.0.jar jetty-http-9.3.6.v20151106.jar jetty-io-9.3.6
 .v20151106.jar lucene-analyzers-common-5.3.0.jar lucene-core-5.3.0.ja
 r lucene-queries-5.3.0.jar lucene-queryparser-5.3.0.jar spring-core-4
 .2.4.RELEASE.jar

The older version is pulled in transitively:

Anthony-Baker-MacBook-Pro:geode-core abaker$ gradle dependencyInsight 
--dependency spring-core
:geode-core:dependencyInsight
org.springframework:spring-core:4.0.3.RELEASE
\--- org.springframework.shell:spring-shell:1.1.0.RELEASE
 \— compile

Here’s at least subproject that uses the version from 
dependency-versions.properties:

Anthony-Baker-MacBook-Pro:geode-rebalancer abaker$ gradle dependencyInsight 
--dependency spring-core
:geode-rebalancer:dependencyInsight
org.springframework:spring-core:4.2.4.RELEASE
+--- org.springframework:spring-aop:4.2.4.RELEASE
|\--- org.springframework:spring-context:4.2.4.RELEASE
| \--- compile
+--- org.springframework:spring-beans:4.2.4.RELEASE
|+--- org.springframework:spring-context:4.2.4.RELEASE (*)
|\--- org.springframework:spring-aop:4.2.4.RELEASE (*)
+--- org.springframework:spring-context:4.2.4.RELEASE (*)
\--- org.springframework:spring-expression:4.2.4.RELEASE
 \--- org.springframework:spring-context:4.2.4.RELEASE (*)

Anthony


> On Apr 7, 2016, at 4:13 PM, Dan Smith  wrote:
> 
> 3 of these dependencies should now be gone with the changes for GEODE-1025.
> spring-context-support
> spring-data-gemfire
> spring-data-commons
> 
> BTW, if you want to see the list of jars we ship, there's a handy gradle
> task I added. It will show you what is in each war file as well as the lib
> directory:
> 
> ./gradlew dumpInstalledJars
> 
> On Thu, Apr 7, 2016 at 10:50 AM, Anthony Baker  wrote:
> 
>> Added JIRA:
>> https://issues.apache.org/jira/browse/GEODE-1193
>> 
>> Anthony
>> 
>>> On Apr 7, 2016, at 9:44 AM, Jens Deppe  wrote:
>>> 
>>> The reason that the servlet API jar is included is because it gets used
>> on
>>> the server classpath (where the sessions are stored). I'm going through
>> the
>>> Modules docs now, so we should be able to direct users to use the servlet
>>> jar provided by the container. We should be OK not to ship it.
>>> 
>>> --Jens
>>> 
>>> On Thu, Apr 7, 2016 at 8:33 AM, John Blum  wrote:
>>> 
 I would not include the (javax.)servlet-api JAR with Geode. It will be a
 significant pain point for web applications (and frameworks, e.g.
>> *Spring
 Session*) that expect a specific version of the Servlet API and then
 suddenly encounter conflicting versions.
 
 Also, FYI, the latest release of the core *Spring Framework
 * [1] is now
>> 4.2.5.RELEASE.
 The latest *Spring Security >> *
 [2]
 release is 4.0.4.RELEASE.  The latest in the 3.x line is 3.2.9; the
>> *Spring
 Security* version used by Geode (3.1.x) is not even supported any more.
 
 
 [1] http://projects.spring.io/spring-framework/
 [2] http://projects.spring.io/spring-security/
 
 
 On Thu, Apr 7, 2016 at 8:21 AM, Anthony Baker 
>> wrote:
 
> You can’t tell from the diff below but it turns out we’re including two
> versions of servlet-api:
> 
> servlet-api-2.5.jar
> javax.servlet-api-3.1.0.jar
> 
> Version 3.1.0 is from the geode/lib while the older jar is from the app
> server module.  Do we need to ship these at all since they are only
 needed
> for compiling?
> 
> Anthony
> 
> 
>> On Apr 6, 2016, at 10:51 PM, Anthony Baker 

Re: Review Request 45919: Updates to NOTICE

[Anthony Baker]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45919/
---

(Updated April 8, 2016, 12:21 p.m.)


Review request for geode, Joey McAllister, Swapnil Bawaskar, and Dan Smith.


Repository: geode


Description
---

GEODE-914: Remove log4j from NOTICE

Commit 5342935d301a4026b289637885e9236414feeb78 cleaned up log4j
code so this no longer needs to be declared in NOTICE.

GEODE-914: Removed unnecessary declarations from NOTICE

Removed spring-petclinic, Apache MyFaces, and fastutil from
NOTICE.  None of these project contain a NOTICE with content
that needs to be propagated.

GEODE-914: Reworked NOTICE for binary distribution

Update binary NOTICE to match changes to bundled jar files.


Diffs
-

  NOTICE 8e7485fe5d8da0548cdb7d4d958bb612ea2c501a 
  geode-assembly/src/main/dist/NOTICE ec14cdaf4677c47032bf4840eca9d07da7ef4475 

Diff: https://reviews.apache.org/r/45919/diff/


Testing (updated)
---

I should point out the NOTICE was semi-mechanically generated by:

1) exploding the binary distribution
2) exploding the embedded archives, wars, and jars
3) concatenating the notice file (if any) from each dependency

After that I removed duplicate entries and extraneous lines.

Still to come: specific notices for geode-web, geode-web-api, geode-pulse as 
these generate war files that are distributed via maven.


Thanks,

Anthony Baker