Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC7

2016-08-08 Thread Dan Smith 
The mcast-address in gemfire.properties is actually the default
mcast-address used by geode; it's also hardcoded in the source.

I think this came up before when we were talking about a previous release
because we were including both the release manager's username and that ip
address in the gemfire.properties file - GEODE-1493. Before fixing that
issue the address could have been an IPv4 or IPv6 address depending on the
release managers machine.

https://issues.apache.org/jira/browse/GEODE-1493
https://github.com/apache/incubator-geode/search?q=%22239.192.81.1%22=Code

-Dan

On Mon, Aug 8, 2016 at 5:20 PM, Brian Dunlap  wrote:

> In M3 RC7, the config/gemfire.properties contains an IP address:
> mcast-address=239.192.81.1
>
> :(
>
> Not sure if this is something to defer or fix now - thoughts?
>
>
> Brian -
>
>
> On Thu, Aug 4, 2016 at 8:02 PM, William Markito 
> wrote:
>
> > All,
> >
> > This is the seventh release candidate Apache Geode, version
> > 1.0.0-incubating.M3.
> >
> > We're including the feedback received in RC6 including a fix
> > (83f97ceef52febf92ef7737726548aa0865c1a59) to run REST API tests.
> >
> > Thanks to all the community members to drive towards this milestone!
> >
> > It fixes the following issues:
> >https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12318420=12335358
> >
> > *** Please download, test and vote by Monday, August 8, 0800 hrs US
> > Pacific.
> >
> > Note that we are voting upon the source (tag):
> >rel/v1.0.0-incubating.M3.RC7
> >
> > https://git-wip-us.apache.org/repos/asf?p=incubator-geode.
> > git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7
> >  > geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7>
> >
> > Commit ID: 83f97ceef52febf92ef7737726548aa0865c1a59
> >
> > https://git-wip-us.apache.org/repos/asf?p=incubator-geode.
> git;a=commit;h=
> > 83f97ceef52febf92ef7737726548aa0865c1a59
> >
> > Source and binary files:
> > https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.
> > 0-incubating.M3.RC7
> >
> > For this release the documentation on how to install and use Apache Geode
> > are hosted
> > on pivotal.io:
> >http://geode.docs.pivotal.io
> >
> > Maven staging repo:
> > https://repository.apache.org/content/repositories/orgapachegeode-1011
> >
> > Geode's KEYS file containing PGP keys we use to sign the release:
> >https://github.com/apache/incubator-geode/blob/release/
> > 1.0.0-incubating.M3/KEYS
> >
> > Release Key: pub  4096R/7AAED8BB 2016-07-13
> > Fingerprint: 8E06 B711 DB13 3AE7 0CC1  ABDE 6A14 F0BC 7AAE D8BB
> >
> > Thanks,
> >
> > --
> > ~/William
> >
>

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC7

2016-08-08 Thread Barry Oglesby 
+1

Thanks,
Barry Oglesby


On Mon, Aug 8, 2016 at 4:08 PM, William Markito  wrote:

> Guys, I'll leave the voting open until tomorrow, but please vote so we can
> close and release M3.
>
> Thanks,
>
> On Fri, Aug 5, 2016 at 4:24 PM, Anthony Baker  wrote:
>
> > +1
> >
> > * Verified she’s
> > * Verified signatures
> > * Verified tag signature
> > * Build from tag
> > * Build and run from src distro
> > * Checked src distro for binaries
> > * Run from binary distro
> > * Run some examples from mvn repo
> >
> > Anthony
> >
> > > On Aug 5, 2016, at 10:34 AM, Jason Huynh  wrote:
> > >
> > > +1
> > >
> > > - built from source distribution
> > > - started locator, server, listed members and created regions in gfsh
> > from
> > > binary
> > > - started locator and server from source built gfsh
> > >
> > >
> > > On Fri, Aug 5, 2016 at 9:58 AM Dan Smith  wrote:
> > >
> > >> +1
> > >>
> > >> Verified
> > >> * Successful precheckin run of this release -
> > >> https://builds.apache.org/job/
> > >> Geode-release/24/ 
> > >> * Signatures
> > >> * Basic gfsh commands with binary dist
> > >> * Built from source dist
> > >> * Basic CRUD test with maven artifacts
> > >> * No jars in source dist
> > >>
> > >> -Dan
> > >>
> > >> On Thu, Aug 4, 2016 at 6:02 PM, William Markito 
> > >> wrote:
> > >>
> > >>> All,
> > >>>
> > >>> This is the seventh release candidate Apache Geode, version
> > >>> 1.0.0-incubating.M3.
> > >>>
> > >>> We're including the feedback received in RC6 including a fix
> > >>> (83f97ceef52febf92ef7737726548aa0865c1a59) to run REST API tests.
> > >>>
> > >>> Thanks to all the community members to drive towards this milestone!
> > >>>
> > >>> It fixes the following issues:
> > >>>   https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > >>> projectId=12318420=12335358
> > >>>
> > >>> *** Please download, test and vote by Monday, August 8, 0800 hrs US
> > >>> Pacific.
> > >>>
> > >>> Note that we are voting upon the source (tag):
> > >>>   rel/v1.0.0-incubating.M3.RC7
> > >>>
> > >>> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.gi
> > >>> t;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7
> > >>>  > >>> git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7>
> > >>>
> > >>> Commit ID: 83f97ceef52febf92ef7737726548aa0865c1a59
> > >>>
> > >>> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.gi
> > >>> t;a=commit;h=83f97ceef52febf92ef7737726548aa0865c1a59
> > >>>
> > >>> Source and binary files:
> > >>> https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.0
> > >>> -incubating.M3.RC7
> > >>>
> > >>> For this release the documentation on how to install and use Apache
> > Geode
> > >>> are hosted
> > >>> on pivotal.io:
> > >>>   http://geode.docs.pivotal.io
> > >>>
> > >>> Maven staging repo:
> > >>> https://repository.apache.org/content/repositories/
> orgapachegeode-1011
> > >>>
> > >>> Geode's KEYS file containing PGP keys we use to sign the release:
> > >>>   https://github.com/apache/incubator-geode/blob/release/
> > >>> 1.0.0-incubating.M3/KEYS
> > >>>
> > >>> Release Key: pub  4096R/7AAED8BB 2016-07-13
> > >>> Fingerprint: 8E06 B711 DB13 3AE7 0CC1  ABDE 6A14 F0BC 7AAE D8BB
> > >>>
> > >>> Thanks,
> > >>>
> > >>> --
> > >>> ~/William
> > >>>
> > >>
> >
> >
>
>
> --
>
> ~/William
>

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC7

2016-08-08 Thread Anilkumar Gingade 
+1

On Mon, Aug 8, 2016 at 5:12 PM, Kirk Lund  wrote:

> +1
>
> - built and ran unit tests
> - started GFSH
> - launched Locator and Server
>
> -Kirk
>
> On Monday, August 8, 2016, Swapnil Bawaskar  wrote:
>
> > +1
> >
> > - compiled from source
> > - started a distributed system with servers from both source and binary
> > distributions
> > - exercised a sample application
> >
> > On Mon, Aug 8, 2016 at 5:00 PM, Darrel Schneider  > >
> > wrote:
> >
> > > +1
> > >
> > >
> > > On Mon, Aug 8, 2016 at 4:51 PM, Michael Stolz  > > wrote:
> > >
> > > > +1
> > > >
> > > > All indications are this attempt is correct
> > > >
> > > > --
> > > > Mike Stolz
> > > > Principal Engineer - Gemfire Product Manager
> > > > Mobile: 631-835-4771
> > > > On Aug 8, 2016 6:09 PM, "William Markito"  > > wrote:
> > > >
> > > > > Guys, I'll leave the voting open until tomorrow, but please vote so
> > we
> > > > can
> > > > > close and release M3.
> > > > >
> > > > > Thanks,
> > > > >
> > > > > On Fri, Aug 5, 2016 at 4:24 PM, Anthony Baker  > >
> > > wrote:
> > > > >
> > > > > > +1
> > > > > >
> > > > > > * Verified she’s
> > > > > > * Verified signatures
> > > > > > * Verified tag signature
> > > > > > * Build from tag
> > > > > > * Build and run from src distro
> > > > > > * Checked src distro for binaries
> > > > > > * Run from binary distro
> > > > > > * Run some examples from mvn repo
> > > > > >
> > > > > > Anthony
> > > > > >
> > > > > > > On Aug 5, 2016, at 10:34 AM, Jason Huynh  > >
> > > wrote:
> > > > > > >
> > > > > > > +1
> > > > > > >
> > > > > > > - built from source distribution
> > > > > > > - started locator, server, listed members and created regions
> in
> > > gfsh
> > > > > > from
> > > > > > > binary
> > > > > > > - started locator and server from source built gfsh
> > > > > > >
> > > > > > >
> > > > > > > On Fri, Aug 5, 2016 at 9:58 AM Dan Smith  > >
> > > wrote:
> > > > > > >
> > > > > > >> +1
> > > > > > >>
> > > > > > >> Verified
> > > > > > >> * Successful precheckin run of this release -
> > > > > > >> https://builds.apache.org/job/
> > > > > > >> Geode-release/24/  > > job/Geode-release/24/>
> > > > > > >> * Signatures
> > > > > > >> * Basic gfsh commands with binary dist
> > > > > > >> * Built from source dist
> > > > > > >> * Basic CRUD test with maven artifacts
> > > > > > >> * No jars in source dist
> > > > > > >>
> > > > > > >> -Dan
> > > > > > >>
> > > > > > >> On Thu, Aug 4, 2016 at 6:02 PM, William Markito <
> > > > wmark...@pivotal.io >
> > > > > > >> wrote:
> > > > > > >>
> > > > > > >>> All,
> > > > > > >>>
> > > > > > >>> This is the seventh release candidate Apache Geode, version
> > > > > > >>> 1.0.0-incubating.M3.
> > > > > > >>>
> > > > > > >>> We're including the feedback received in RC6 including a fix
> > > > > > >>> (83f97ceef52febf92ef7737726548aa0865c1a59) to run REST API
> > > tests.
> > > > > > >>>
> > > > > > >>> Thanks to all the community members to drive towards this
> > > > milestone!
> > > > > > >>>
> > > > > > >>> It fixes the following issues:
> > > > > > >>>   https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > > > > >>> projectId=12318420=12335358
> > > > > > >>>
> > > > > > >>> *** Please download, test and vote by Monday, August 8, 0800
> > hrs
> > > US
> > > > > > >>> Pacific.
> > > > > > >>>
> > > > > > >>> Note that we are voting upon the source (tag):
> > > > > > >>>   rel/v1.0.0-incubating.M3.RC7
> > > > > > >>>
> > > > > > >>> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.gi
> > > > > > >>> t;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7
> > > > > > >>>  > > > > > >>> git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7>
> > > > > > >>>
> > > > > > >>> Commit ID: 83f97ceef52febf92ef7737726548aa0865c1a59
> > > > > > >>>
> > > > > > >>> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.gi
> > > > > > >>> t;a=commit;h=83f97ceef52febf92ef7737726548aa0865c1a59
> > > > > > >>>
> > > > > > >>> Source and binary files:
> > > > > > >>> https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.0
> > > > > > >>> -incubating.M3.RC7
> > > > > > >>>
> > > > > > >>> For this release the documentation on how to install and use
> > > Apache
> > > > > > Geode
> > > > > > >>> are hosted
> > > > > > >>> on pivotal.io:
> > > > > > >>>   http://geode.docs.pivotal.io
> > > > > > >>>
> > > > > > >>> Maven staging repo:
> > > > > > >>> https://repository.apache.org/content/repositories/
> > > > > orgapachegeode-1011
> > > > > > >>>
> > > > > > >>> Geode's KEYS file containing PGP keys we use to sign the
> > release:
> > > > > > >>>   https://github.com/apache/incubator-geode/blob/release/
> > > > > > >>>

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC7

2016-08-08 Thread Kirk Lund 
That config dir is for reference only and isn't actually used. We can
probably let this go for M3 and fix it in the next release.

-Kirk

On Monday, August 8, 2016, Brian Dunlap  wrote:

> In M3 RC7, the config/gemfire.properties contains an IP address:
> mcast-address=239.192.81.1
>
> :(
>
> Not sure if this is something to defer or fix now - thoughts?
>
>
> Brian -
>
>
> On Thu, Aug 4, 2016 at 8:02 PM, William Markito  > wrote:
>
> > All,
> >
> > This is the seventh release candidate Apache Geode, version
> > 1.0.0-incubating.M3.
> >
> > We're including the feedback received in RC6 including a fix
> > (83f97ceef52febf92ef7737726548aa0865c1a59) to run REST API tests.
> >
> > Thanks to all the community members to drive towards this milestone!
> >
> > It fixes the following issues:
> >https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12318420=12335358
> >
> > *** Please download, test and vote by Monday, August 8, 0800 hrs US
> > Pacific.
> >
> > Note that we are voting upon the source (tag):
> >rel/v1.0.0-incubating.M3.RC7
> >
> > https://git-wip-us.apache.org/repos/asf?p=incubator-geode.
> > git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7
> >  > geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7>
> >
> > Commit ID: 83f97ceef52febf92ef7737726548aa0865c1a59
> >
> > https://git-wip-us.apache.org/repos/asf?p=incubator-geode.
> git;a=commit;h=
> > 83f97ceef52febf92ef7737726548aa0865c1a59
> >
> > Source and binary files:
> > https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.
> > 0-incubating.M3.RC7
> >
> > For this release the documentation on how to install and use Apache Geode
> > are hosted
> > on pivotal.io:
> >http://geode.docs.pivotal.io
> >
> > Maven staging repo:
> > https://repository.apache.org/content/repositories/orgapachegeode-1011
> >
> > Geode's KEYS file containing PGP keys we use to sign the release:
> >https://github.com/apache/incubator-geode/blob/release/
> > 1.0.0-incubating.M3/KEYS
> >
> > Release Key: pub  4096R/7AAED8BB 2016-07-13
> > Fingerprint: 8E06 B711 DB13 3AE7 0CC1  ABDE 6A14 F0BC 7AAE D8BB
> >
> > Thanks,
> >
> > --
> > ~/William
> >
>

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC7

2016-08-08 Thread Brian Dunlap 
In M3 RC7, the config/gemfire.properties contains an IP address:
mcast-address=239.192.81.1

:(

Not sure if this is something to defer or fix now - thoughts?


Brian -


On Thu, Aug 4, 2016 at 8:02 PM, William Markito  wrote:

> All,
>
> This is the seventh release candidate Apache Geode, version
> 1.0.0-incubating.M3.
>
> We're including the feedback received in RC6 including a fix
> (83f97ceef52febf92ef7737726548aa0865c1a59) to run REST API tests.
>
> Thanks to all the community members to drive towards this milestone!
>
> It fixes the following issues:
>https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12318420=12335358
>
> *** Please download, test and vote by Monday, August 8, 0800 hrs US
> Pacific.
>
> Note that we are voting upon the source (tag):
>rel/v1.0.0-incubating.M3.RC7
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.
> git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7
>  geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7>
>
> Commit ID: 83f97ceef52febf92ef7737726548aa0865c1a59
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=commit;h=
> 83f97ceef52febf92ef7737726548aa0865c1a59
>
> Source and binary files:
> https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.
> 0-incubating.M3.RC7
>
> For this release the documentation on how to install and use Apache Geode
> are hosted
> on pivotal.io:
>http://geode.docs.pivotal.io
>
> Maven staging repo:
> https://repository.apache.org/content/repositories/orgapachegeode-1011
>
> Geode's KEYS file containing PGP keys we use to sign the release:
>https://github.com/apache/incubator-geode/blob/release/
> 1.0.0-incubating.M3/KEYS
>
> Release Key: pub  4096R/7AAED8BB 2016-07-13
> Fingerprint: 8E06 B711 DB13 3AE7 0CC1  ABDE 6A14 F0BC 7AAE D8BB
>
> Thanks,
>
> --
> ~/William
>

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC7

2016-08-08 Thread Kirk Lund 
+1

- built and ran unit tests
- started GFSH
- launched Locator and Server

-Kirk

On Monday, August 8, 2016, Swapnil Bawaskar  wrote:

> +1
>
> - compiled from source
> - started a distributed system with servers from both source and binary
> distributions
> - exercised a sample application
>
> On Mon, Aug 8, 2016 at 5:00 PM, Darrel Schneider  >
> wrote:
>
> > +1
> >
> >
> > On Mon, Aug 8, 2016 at 4:51 PM, Michael Stolz  > wrote:
> >
> > > +1
> > >
> > > All indications are this attempt is correct
> > >
> > > --
> > > Mike Stolz
> > > Principal Engineer - Gemfire Product Manager
> > > Mobile: 631-835-4771
> > > On Aug 8, 2016 6:09 PM, "William Markito"  > wrote:
> > >
> > > > Guys, I'll leave the voting open until tomorrow, but please vote so
> we
> > > can
> > > > close and release M3.
> > > >
> > > > Thanks,
> > > >
> > > > On Fri, Aug 5, 2016 at 4:24 PM, Anthony Baker  >
> > wrote:
> > > >
> > > > > +1
> > > > >
> > > > > * Verified she’s
> > > > > * Verified signatures
> > > > > * Verified tag signature
> > > > > * Build from tag
> > > > > * Build and run from src distro
> > > > > * Checked src distro for binaries
> > > > > * Run from binary distro
> > > > > * Run some examples from mvn repo
> > > > >
> > > > > Anthony
> > > > >
> > > > > > On Aug 5, 2016, at 10:34 AM, Jason Huynh  >
> > wrote:
> > > > > >
> > > > > > +1
> > > > > >
> > > > > > - built from source distribution
> > > > > > - started locator, server, listed members and created regions in
> > gfsh
> > > > > from
> > > > > > binary
> > > > > > - started locator and server from source built gfsh
> > > > > >
> > > > > >
> > > > > > On Fri, Aug 5, 2016 at 9:58 AM Dan Smith  >
> > wrote:
> > > > > >
> > > > > >> +1
> > > > > >>
> > > > > >> Verified
> > > > > >> * Successful precheckin run of this release -
> > > > > >> https://builds.apache.org/job/
> > > > > >> Geode-release/24/  > job/Geode-release/24/>
> > > > > >> * Signatures
> > > > > >> * Basic gfsh commands with binary dist
> > > > > >> * Built from source dist
> > > > > >> * Basic CRUD test with maven artifacts
> > > > > >> * No jars in source dist
> > > > > >>
> > > > > >> -Dan
> > > > > >>
> > > > > >> On Thu, Aug 4, 2016 at 6:02 PM, William Markito <
> > > wmark...@pivotal.io >
> > > > > >> wrote:
> > > > > >>
> > > > > >>> All,
> > > > > >>>
> > > > > >>> This is the seventh release candidate Apache Geode, version
> > > > > >>> 1.0.0-incubating.M3.
> > > > > >>>
> > > > > >>> We're including the feedback received in RC6 including a fix
> > > > > >>> (83f97ceef52febf92ef7737726548aa0865c1a59) to run REST API
> > tests.
> > > > > >>>
> > > > > >>> Thanks to all the community members to drive towards this
> > > milestone!
> > > > > >>>
> > > > > >>> It fixes the following issues:
> > > > > >>>   https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > > > >>> projectId=12318420=12335358
> > > > > >>>
> > > > > >>> *** Please download, test and vote by Monday, August 8, 0800
> hrs
> > US
> > > > > >>> Pacific.
> > > > > >>>
> > > > > >>> Note that we are voting upon the source (tag):
> > > > > >>>   rel/v1.0.0-incubating.M3.RC7
> > > > > >>>
> > > > > >>> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.gi
> > > > > >>> t;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7
> > > > > >>>  > > > > >>> git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7>
> > > > > >>>
> > > > > >>> Commit ID: 83f97ceef52febf92ef7737726548aa0865c1a59
> > > > > >>>
> > > > > >>> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.gi
> > > > > >>> t;a=commit;h=83f97ceef52febf92ef7737726548aa0865c1a59
> > > > > >>>
> > > > > >>> Source and binary files:
> > > > > >>> https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.0
> > > > > >>> -incubating.M3.RC7
> > > > > >>>
> > > > > >>> For this release the documentation on how to install and use
> > Apache
> > > > > Geode
> > > > > >>> are hosted
> > > > > >>> on pivotal.io:
> > > > > >>>   http://geode.docs.pivotal.io
> > > > > >>>
> > > > > >>> Maven staging repo:
> > > > > >>> https://repository.apache.org/content/repositories/
> > > > orgapachegeode-1011
> > > > > >>>
> > > > > >>> Geode's KEYS file containing PGP keys we use to sign the
> release:
> > > > > >>>   https://github.com/apache/incubator-geode/blob/release/
> > > > > >>> 1.0.0-incubating.M3/KEYS
> > > > > >>>
> > > > > >>> Release Key: pub  4096R/7AAED8BB 2016-07-13
> > > > > >>> Fingerprint: 8E06 B711 DB13 3AE7 0CC1  ABDE 6A14 F0BC 7AAE D8BB
> > > > > >>>
> > > > > >>> Thanks,
> > > > > >>>
> > > > > >>> --
> > > > > >>> ~/William
> > > > > >>>
> > > > > >>
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > >
> > > > ~/William
> > > >
> > >

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC7

2016-08-08 Thread Swapnil Bawaskar 
+1

- compiled from source
- started a distributed system with servers from both source and binary
distributions
- exercised a sample application

On Mon, Aug 8, 2016 at 5:00 PM, Darrel Schneider 
wrote:

> +1
>
>
> On Mon, Aug 8, 2016 at 4:51 PM, Michael Stolz  wrote:
>
> > +1
> >
> > All indications are this attempt is correct
> >
> > --
> > Mike Stolz
> > Principal Engineer - Gemfire Product Manager
> > Mobile: 631-835-4771
> > On Aug 8, 2016 6:09 PM, "William Markito"  wrote:
> >
> > > Guys, I'll leave the voting open until tomorrow, but please vote so we
> > can
> > > close and release M3.
> > >
> > > Thanks,
> > >
> > > On Fri, Aug 5, 2016 at 4:24 PM, Anthony Baker 
> wrote:
> > >
> > > > +1
> > > >
> > > > * Verified she’s
> > > > * Verified signatures
> > > > * Verified tag signature
> > > > * Build from tag
> > > > * Build and run from src distro
> > > > * Checked src distro for binaries
> > > > * Run from binary distro
> > > > * Run some examples from mvn repo
> > > >
> > > > Anthony
> > > >
> > > > > On Aug 5, 2016, at 10:34 AM, Jason Huynh 
> wrote:
> > > > >
> > > > > +1
> > > > >
> > > > > - built from source distribution
> > > > > - started locator, server, listed members and created regions in
> gfsh
> > > > from
> > > > > binary
> > > > > - started locator and server from source built gfsh
> > > > >
> > > > >
> > > > > On Fri, Aug 5, 2016 at 9:58 AM Dan Smith 
> wrote:
> > > > >
> > > > >> +1
> > > > >>
> > > > >> Verified
> > > > >> * Successful precheckin run of this release -
> > > > >> https://builds.apache.org/job/
> > > > >> Geode-release/24/  job/Geode-release/24/>
> > > > >> * Signatures
> > > > >> * Basic gfsh commands with binary dist
> > > > >> * Built from source dist
> > > > >> * Basic CRUD test with maven artifacts
> > > > >> * No jars in source dist
> > > > >>
> > > > >> -Dan
> > > > >>
> > > > >> On Thu, Aug 4, 2016 at 6:02 PM, William Markito <
> > wmark...@pivotal.io>
> > > > >> wrote:
> > > > >>
> > > > >>> All,
> > > > >>>
> > > > >>> This is the seventh release candidate Apache Geode, version
> > > > >>> 1.0.0-incubating.M3.
> > > > >>>
> > > > >>> We're including the feedback received in RC6 including a fix
> > > > >>> (83f97ceef52febf92ef7737726548aa0865c1a59) to run REST API
> tests.
> > > > >>>
> > > > >>> Thanks to all the community members to drive towards this
> > milestone!
> > > > >>>
> > > > >>> It fixes the following issues:
> > > > >>>   https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > > >>> projectId=12318420=12335358
> > > > >>>
> > > > >>> *** Please download, test and vote by Monday, August 8, 0800 hrs
> US
> > > > >>> Pacific.
> > > > >>>
> > > > >>> Note that we are voting upon the source (tag):
> > > > >>>   rel/v1.0.0-incubating.M3.RC7
> > > > >>>
> > > > >>> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.gi
> > > > >>> t;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7
> > > > >>>  > > > >>> git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7>
> > > > >>>
> > > > >>> Commit ID: 83f97ceef52febf92ef7737726548aa0865c1a59
> > > > >>>
> > > > >>> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.gi
> > > > >>> t;a=commit;h=83f97ceef52febf92ef7737726548aa0865c1a59
> > > > >>>
> > > > >>> Source and binary files:
> > > > >>> https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.0
> > > > >>> -incubating.M3.RC7
> > > > >>>
> > > > >>> For this release the documentation on how to install and use
> Apache
> > > > Geode
> > > > >>> are hosted
> > > > >>> on pivotal.io:
> > > > >>>   http://geode.docs.pivotal.io
> > > > >>>
> > > > >>> Maven staging repo:
> > > > >>> https://repository.apache.org/content/repositories/
> > > orgapachegeode-1011
> > > > >>>
> > > > >>> Geode's KEYS file containing PGP keys we use to sign the release:
> > > > >>>   https://github.com/apache/incubator-geode/blob/release/
> > > > >>> 1.0.0-incubating.M3/KEYS
> > > > >>>
> > > > >>> Release Key: pub  4096R/7AAED8BB 2016-07-13
> > > > >>> Fingerprint: 8E06 B711 DB13 3AE7 0CC1  ABDE 6A14 F0BC 7AAE D8BB
> > > > >>>
> > > > >>> Thanks,
> > > > >>>
> > > > >>> --
> > > > >>> ~/William
> > > > >>>
> > > > >>
> > > >
> > > >
> > >
> > >
> > > --
> > >
> > > ~/William
> > >
> >
>

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC7

2016-08-08 Thread Darrel Schneider 
+1


On Mon, Aug 8, 2016 at 4:51 PM, Michael Stolz  wrote:

> +1
>
> All indications are this attempt is correct
>
> --
> Mike Stolz
> Principal Engineer - Gemfire Product Manager
> Mobile: 631-835-4771
> On Aug 8, 2016 6:09 PM, "William Markito"  wrote:
>
> > Guys, I'll leave the voting open until tomorrow, but please vote so we
> can
> > close and release M3.
> >
> > Thanks,
> >
> > On Fri, Aug 5, 2016 at 4:24 PM, Anthony Baker  wrote:
> >
> > > +1
> > >
> > > * Verified she’s
> > > * Verified signatures
> > > * Verified tag signature
> > > * Build from tag
> > > * Build and run from src distro
> > > * Checked src distro for binaries
> > > * Run from binary distro
> > > * Run some examples from mvn repo
> > >
> > > Anthony
> > >
> > > > On Aug 5, 2016, at 10:34 AM, Jason Huynh  wrote:
> > > >
> > > > +1
> > > >
> > > > - built from source distribution
> > > > - started locator, server, listed members and created regions in gfsh
> > > from
> > > > binary
> > > > - started locator and server from source built gfsh
> > > >
> > > >
> > > > On Fri, Aug 5, 2016 at 9:58 AM Dan Smith  wrote:
> > > >
> > > >> +1
> > > >>
> > > >> Verified
> > > >> * Successful precheckin run of this release -
> > > >> https://builds.apache.org/job/
> > > >> Geode-release/24/ 
> > > >> * Signatures
> > > >> * Basic gfsh commands with binary dist
> > > >> * Built from source dist
> > > >> * Basic CRUD test with maven artifacts
> > > >> * No jars in source dist
> > > >>
> > > >> -Dan
> > > >>
> > > >> On Thu, Aug 4, 2016 at 6:02 PM, William Markito <
> wmark...@pivotal.io>
> > > >> wrote:
> > > >>
> > > >>> All,
> > > >>>
> > > >>> This is the seventh release candidate Apache Geode, version
> > > >>> 1.0.0-incubating.M3.
> > > >>>
> > > >>> We're including the feedback received in RC6 including a fix
> > > >>> (83f97ceef52febf92ef7737726548aa0865c1a59) to run REST API tests.
> > > >>>
> > > >>> Thanks to all the community members to drive towards this
> milestone!
> > > >>>
> > > >>> It fixes the following issues:
> > > >>>   https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > >>> projectId=12318420=12335358
> > > >>>
> > > >>> *** Please download, test and vote by Monday, August 8, 0800 hrs US
> > > >>> Pacific.
> > > >>>
> > > >>> Note that we are voting upon the source (tag):
> > > >>>   rel/v1.0.0-incubating.M3.RC7
> > > >>>
> > > >>> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.gi
> > > >>> t;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7
> > > >>>  > > >>> git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7>
> > > >>>
> > > >>> Commit ID: 83f97ceef52febf92ef7737726548aa0865c1a59
> > > >>>
> > > >>> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.gi
> > > >>> t;a=commit;h=83f97ceef52febf92ef7737726548aa0865c1a59
> > > >>>
> > > >>> Source and binary files:
> > > >>> https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.0
> > > >>> -incubating.M3.RC7
> > > >>>
> > > >>> For this release the documentation on how to install and use Apache
> > > Geode
> > > >>> are hosted
> > > >>> on pivotal.io:
> > > >>>   http://geode.docs.pivotal.io
> > > >>>
> > > >>> Maven staging repo:
> > > >>> https://repository.apache.org/content/repositories/
> > orgapachegeode-1011
> > > >>>
> > > >>> Geode's KEYS file containing PGP keys we use to sign the release:
> > > >>>   https://github.com/apache/incubator-geode/blob/release/
> > > >>> 1.0.0-incubating.M3/KEYS
> > > >>>
> > > >>> Release Key: pub  4096R/7AAED8BB 2016-07-13
> > > >>> Fingerprint: 8E06 B711 DB13 3AE7 0CC1  ABDE 6A14 F0BC 7AAE D8BB
> > > >>>
> > > >>> Thanks,
> > > >>>
> > > >>> --
> > > >>> ~/William
> > > >>>
> > > >>
> > >
> > >
> >
> >
> > --
> >
> > ~/William
> >
>

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC7

2016-08-08 Thread Michael Stolz 
+1

All indications are this attempt is correct

--
Mike Stolz
Principal Engineer - Gemfire Product Manager
Mobile: 631-835-4771
On Aug 8, 2016 6:09 PM, "William Markito"  wrote:

> Guys, I'll leave the voting open until tomorrow, but please vote so we can
> close and release M3.
>
> Thanks,
>
> On Fri, Aug 5, 2016 at 4:24 PM, Anthony Baker  wrote:
>
> > +1
> >
> > * Verified she’s
> > * Verified signatures
> > * Verified tag signature
> > * Build from tag
> > * Build and run from src distro
> > * Checked src distro for binaries
> > * Run from binary distro
> > * Run some examples from mvn repo
> >
> > Anthony
> >
> > > On Aug 5, 2016, at 10:34 AM, Jason Huynh  wrote:
> > >
> > > +1
> > >
> > > - built from source distribution
> > > - started locator, server, listed members and created regions in gfsh
> > from
> > > binary
> > > - started locator and server from source built gfsh
> > >
> > >
> > > On Fri, Aug 5, 2016 at 9:58 AM Dan Smith  wrote:
> > >
> > >> +1
> > >>
> > >> Verified
> > >> * Successful precheckin run of this release -
> > >> https://builds.apache.org/job/
> > >> Geode-release/24/ 
> > >> * Signatures
> > >> * Basic gfsh commands with binary dist
> > >> * Built from source dist
> > >> * Basic CRUD test with maven artifacts
> > >> * No jars in source dist
> > >>
> > >> -Dan
> > >>
> > >> On Thu, Aug 4, 2016 at 6:02 PM, William Markito 
> > >> wrote:
> > >>
> > >>> All,
> > >>>
> > >>> This is the seventh release candidate Apache Geode, version
> > >>> 1.0.0-incubating.M3.
> > >>>
> > >>> We're including the feedback received in RC6 including a fix
> > >>> (83f97ceef52febf92ef7737726548aa0865c1a59) to run REST API tests.
> > >>>
> > >>> Thanks to all the community members to drive towards this milestone!
> > >>>
> > >>> It fixes the following issues:
> > >>>   https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > >>> projectId=12318420=12335358
> > >>>
> > >>> *** Please download, test and vote by Monday, August 8, 0800 hrs US
> > >>> Pacific.
> > >>>
> > >>> Note that we are voting upon the source (tag):
> > >>>   rel/v1.0.0-incubating.M3.RC7
> > >>>
> > >>> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.gi
> > >>> t;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7
> > >>>  > >>> git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7>
> > >>>
> > >>> Commit ID: 83f97ceef52febf92ef7737726548aa0865c1a59
> > >>>
> > >>> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.gi
> > >>> t;a=commit;h=83f97ceef52febf92ef7737726548aa0865c1a59
> > >>>
> > >>> Source and binary files:
> > >>> https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.0
> > >>> -incubating.M3.RC7
> > >>>
> > >>> For this release the documentation on how to install and use Apache
> > Geode
> > >>> are hosted
> > >>> on pivotal.io:
> > >>>   http://geode.docs.pivotal.io
> > >>>
> > >>> Maven staging repo:
> > >>> https://repository.apache.org/content/repositories/
> orgapachegeode-1011
> > >>>
> > >>> Geode's KEYS file containing PGP keys we use to sign the release:
> > >>>   https://github.com/apache/incubator-geode/blob/release/
> > >>> 1.0.0-incubating.M3/KEYS
> > >>>
> > >>> Release Key: pub  4096R/7AAED8BB 2016-07-13
> > >>> Fingerprint: 8E06 B711 DB13 3AE7 0CC1  ABDE 6A14 F0BC 7AAE D8BB
> > >>>
> > >>> Thanks,
> > >>>
> > >>> --
> > >>> ~/William
> > >>>
> > >>
> >
> >
>
>
> --
>
> ~/William
>

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC7

2016-08-08 Thread William Markito 
Guys, I'll leave the voting open until tomorrow, but please vote so we can
close and release M3.

Thanks,

On Fri, Aug 5, 2016 at 4:24 PM, Anthony Baker  wrote:

> +1
>
> * Verified she’s
> * Verified signatures
> * Verified tag signature
> * Build from tag
> * Build and run from src distro
> * Checked src distro for binaries
> * Run from binary distro
> * Run some examples from mvn repo
>
> Anthony
>
> > On Aug 5, 2016, at 10:34 AM, Jason Huynh  wrote:
> >
> > +1
> >
> > - built from source distribution
> > - started locator, server, listed members and created regions in gfsh
> from
> > binary
> > - started locator and server from source built gfsh
> >
> >
> > On Fri, Aug 5, 2016 at 9:58 AM Dan Smith  wrote:
> >
> >> +1
> >>
> >> Verified
> >> * Successful precheckin run of this release -
> >> https://builds.apache.org/job/
> >> Geode-release/24/ 
> >> * Signatures
> >> * Basic gfsh commands with binary dist
> >> * Built from source dist
> >> * Basic CRUD test with maven artifacts
> >> * No jars in source dist
> >>
> >> -Dan
> >>
> >> On Thu, Aug 4, 2016 at 6:02 PM, William Markito 
> >> wrote:
> >>
> >>> All,
> >>>
> >>> This is the seventh release candidate Apache Geode, version
> >>> 1.0.0-incubating.M3.
> >>>
> >>> We're including the feedback received in RC6 including a fix
> >>> (83f97ceef52febf92ef7737726548aa0865c1a59) to run REST API tests.
> >>>
> >>> Thanks to all the community members to drive towards this milestone!
> >>>
> >>> It fixes the following issues:
> >>>   https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> >>> projectId=12318420=12335358
> >>>
> >>> *** Please download, test and vote by Monday, August 8, 0800 hrs US
> >>> Pacific.
> >>>
> >>> Note that we are voting upon the source (tag):
> >>>   rel/v1.0.0-incubating.M3.RC7
> >>>
> >>> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.gi
> >>> t;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7
> >>>  >>> git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7>
> >>>
> >>> Commit ID: 83f97ceef52febf92ef7737726548aa0865c1a59
> >>>
> >>> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.gi
> >>> t;a=commit;h=83f97ceef52febf92ef7737726548aa0865c1a59
> >>>
> >>> Source and binary files:
> >>> https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.0
> >>> -incubating.M3.RC7
> >>>
> >>> For this release the documentation on how to install and use Apache
> Geode
> >>> are hosted
> >>> on pivotal.io:
> >>>   http://geode.docs.pivotal.io
> >>>
> >>> Maven staging repo:
> >>> https://repository.apache.org/content/repositories/orgapachegeode-1011
> >>>
> >>> Geode's KEYS file containing PGP keys we use to sign the release:
> >>>   https://github.com/apache/incubator-geode/blob/release/
> >>> 1.0.0-incubating.M3/KEYS
> >>>
> >>> Release Key: pub  4096R/7AAED8BB 2016-07-13
> >>> Fingerprint: 8E06 B711 DB13 3AE7 0CC1  ABDE 6A14 F0BC 7AAE D8BB
> >>>
> >>> Thanks,
> >>>
> >>> --
> >>> ~/William
> >>>
> >>
>
>


-- 

~/William

Fixed: apache/incubator-geode#988 (develop - affb504)

2016-08-08 Thread Travis CI 
Build Update for apache/incubator-geode
-

Build: #988
Status: Fixed

Duration: 14 minutes and 55 seconds
Commit: affb504 (develop)
Author: Dan Smith
Message: Fixing types on Statistics supplier javadocs

View the changeset: 
https://github.com/apache/incubator-geode/compare/01567b2c4000...affb50495fc4

View the full build log and details: 
https://travis-ci.org/apache/incubator-geode/builds/150761557

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #395 was SUCCESSFUL (with 1423 tests)

2016-08-08 Thread Spring CI 

---
Spring Data GemFire > Nightly-ApacheGeode > #395 was successful.
---
Scheduled
1425 tests in total.

https://build.spring.io/browse/SGF-NAG-395/





--
This message is automatically generated by Atlassian Bamboo

[GitHub] incubator-geode pull request #221: GEODE-1715: Add socket-buffer-size and me...

2016-08-08 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/221


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 49962: Removed extra fields from distributedmember while serialization/de

2016-08-08 Thread Bruce Schuchardt 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49962/#review145138
---


Ship it!




Ship It!

- Bruce Schuchardt


On août 5, 2016, 4:52 après-midi, Hitesh Khamesra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49962/
> ---
> 
> (Updated août 5, 2016, 4:52 après-midi)
> 
> 
> Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Removed extra fields from distributedmember while serialization/de. Planning 
> to do this in udp-security branch.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java
>  067b71b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMember.java
>  d5d0b8e 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java
>  5c0a327 
>   
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMemberJUnitTest.java
>  7eef594 
> 
> Diff: https://reviews.apache.org/r/49962/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>

Geode M3 docs: Review opportunity

2016-08-08 Thread Dave Barnes 
I've posted the Geode User docs for the upcoming M3 release here:

http://geode-review.cfapps.io/

Please have a look at the section(s) describing the features you've
implemented and send me any suggestions or corrections.
Deadline is Code Release or this Friday, Aug 12, whichever comes first.
Thanks,
-Dave

Re: Review Request 50903: GEODE-1583: Always pass the keep alive flag when destroying a connection

2016-08-08 Thread anilkumar gingade 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50903/#review145126
---




geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/QueueConnectionImpl.java
 (line 90)


This is also called when the end point is crashed...Not sure if its still 
true, when a close is called on destroyed connection, it used to take long time 
(or used to hang); i believe the reason why destroy is called here...If thats 
not the case (the close doesn;t take long time) then its fine...


- anilkumar gingade


On Aug. 8, 2016, 6:02 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50903/
> ---
> 
> (Updated Aug. 8, 2016, 6:02 p.m.)
> 
> 
> Review request for geode and Barry Oglesby.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The queue manager was closing connections without sending the
> CloseConnectionOp to the server. Changing the code to call close instead
> of destroy and passing the keepAlive flag along with the close. Also,
> changing the cache to set keepAlive *before* marking the cache as
> closed.
> 
> This should prevent any races where cache closure triggers the cache
> client updater to destroy connections or close them with the wrong
> keepAlive setting while the cache is being closed.
> 
> Note that I changed the default value for keepAlive in the cache and the
> pool to be true. I did this because the DurableClientNetDown test forces
> the connections to be closed without closing the cache, so it uses the default
> value, but also because I think this is probably safer for cases of abnormal
> termination that connections are closed by default with keepAlive=true until
> the cache is actually closing.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/InternalPool.java
>  fcb0ae8358a1ec2394bf74bd7929867dd5e6f77e 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/PoolImpl.java
>  65a4dd13c25f5363f4d5a6bc2d4da1f7806596a0 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/QueueConnectionImpl.java
>  40cf58b4093282dd15842e672dbd158638b24f9e 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/QueueManagerImpl.java
>  7c9b187c6bc7ed6db64ac5670eb1daa3c594372f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java
>  05bc83837032c95114da118e197c01ca2b3cd4f4 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
>  8deedc18491c6308cc1628e006098ec22640fe5d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/QueueManagerJUnitTest.java
>  c2872e798cec373b6fba4a07a3ce8608cf235c37 
> 
> Diff: https://reviews.apache.org/r/50903/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Review Request 50903: GEODE-1583: Always pass the keep alive flag when destroying a connection

2016-08-08 Thread Dan Smith 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50903/
---

Review request for geode and Barry Oglesby.


Repository: geode


Description
---

The queue manager was closing connections without sending the
CloseConnectionOp to the server. Changing the code to call close instead
of destroy and passing the keepAlive flag along with the close. Also,
changing the cache to set keepAlive *before* marking the cache as
closed.

This should prevent any races where cache closure triggers the cache
client updater to destroy connections or close them with the wrong
keepAlive setting while the cache is being closed.

Note that I changed the default value for keepAlive in the cache and the
pool to be true. I did this because the DurableClientNetDown test forces
the connections to be closed without closing the cache, so it uses the default
value, but also because I think this is probably safer for cases of abnormal
termination that connections are closed by default with keepAlive=true until
the cache is actually closing.


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/InternalPool.java
 fcb0ae8358a1ec2394bf74bd7929867dd5e6f77e 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/PoolImpl.java
 65a4dd13c25f5363f4d5a6bc2d4da1f7806596a0 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/QueueConnectionImpl.java
 40cf58b4093282dd15842e672dbd158638b24f9e 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/QueueManagerImpl.java
 7c9b187c6bc7ed6db64ac5670eb1daa3c594372f 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java
 05bc83837032c95114da118e197c01ca2b3cd4f4 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
 8deedc18491c6308cc1628e006098ec22640fe5d 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/QueueManagerJUnitTest.java
 c2872e798cec373b6fba4a07a3ce8608cf235c37 

Diff: https://reviews.apache.org/r/50903/diff/


Testing
---


Thanks,

Dan Smith

[GitHub] incubator-geode pull request #228: GEODE-1673: Use security.json as default

2016-08-08 Thread jinmeiliao 
Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/228#discussion_r73898883
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/security/templates/SampleSecurityManagerTest.java
 ---
@@ -65,6 +65,16 @@ public void setUp() throws Exception {
   }
 
   @Test
+  public void shouldDefaultToSecurityJsonInClasspathIfNullProperties() 
throws Exception {
+this.sampleSecurityManager.init(null);
+  }
+
+  @Test
+  public void shouldDefaultToSecurityJsonInClasspathIfEmptyProperties() 
throws Exception {
+this.sampleSecurityManager.init(new Properties());
--- End diff --

add some asserts here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #228: GEODE-1673: Use security.json as default

2016-08-08 Thread jinmeiliao 
Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/228#discussion_r73898764
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/security/templates/SampleSecurityManager.java
 ---
@@ -126,26 +126,33 @@ public boolean authorize(final Principal principal, 
final ResourcePermission con
 
   @Override
   public void init(final Properties securityProperties) throws 
NotAuthorizedException {
-String jsonPropertyValue = 
securityProperties.getProperty(SECURITY_JSON);
+boolean initialized = false;
+
+String jsonPropertyValue = securityProperties != null ? 
securityProperties.getProperty(SECURITY_JSON) : null;
 if (jsonPropertyValue == null) {
-  throw new AuthenticationFailedException("SampleSecurityManager: 
property [" + SECURITY_JSON + "] must be set.");
-}
+  initialized = initializeFromJsonResource(DEFAULT_JSON_FILE_NAME);
+} else {
 
-// 1st try to load value as a json resource
-boolean initialized = initializeFromJsonResource(jsonPropertyValue);
+  // 1st try to load value as a json resource
+  initialized = initializeFromJsonResource(jsonPropertyValue);
 
-// 2nd try to load value as a json file
-if (!initialized) {
-  initialized = initializeFromJsonFile(new File(jsonPropertyValue));
-}
+  // 2nd try to load value as a json file
--- End diff --

Do we really need the 2nd try and 3rd try? We don't use 
SampleSeucurityManager this way. If we can get rid these additional tries, then 
the init could be simple as this:

String jsonPropertyValue = securityProperties.getProperty(SECURITY_JSON);
if(jsonPropertyValue == null) jsonPropertyValue = DEFAULT_JSON_FILE_NAME;
if(!initializeFromJsonResource(jsonPropertyValue)){
  // throw exception
}



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #228: GEODE-1673: Use security.json as default

2016-08-08 Thread jinmeiliao 
Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/228#discussion_r73898847
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/security/templates/SampleSecurityManagerTest.java
 ---
@@ -65,6 +65,16 @@ public void setUp() throws Exception {
   }
 
   @Test
+  public void shouldDefaultToSecurityJsonInClasspathIfNullProperties() 
throws Exception {
+this.sampleSecurityManager.init(null);
--- End diff --

should we add some asserts here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---