[GitHub] incubator-geode pull request #264: Feature/geode 538

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/264


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 53034: GEODE-1927 backward compatibility support

[Hitesh Khamesra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53034/#review153312
---


Ship it!




Ship It!

- Hitesh Khamesra


On Oct. 19, 2016, 9:16 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53034/
> ---
> 
> (Updated Oct. 19, 2016, 9:16 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> adding a new unit-test category for backward-compatibility tests
> 
> 
> Diffs
> -
> 
>   
> geode-junit/src/main/java/org/apache/geode/test/junit/categories/BackwardCompatibilityTest.java
>  PRE-CREATION 
>   gradle/test.gradle 5b895ba07a37740165c2dca45179493615d613f5 
> 
> Diff: https://reviews.apache.org/r/53034/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: IntelliJ and Eclipse formatters

[Kirk Lund]

Sounds good!


On Wed, Oct 19, 2016 at 4:04 PM, Jared Stewart  wrote:

> I will submit a pr later this week to enable spotless and switch to these
> templates. The intellij one needs to be updated however. It's give years
> old and doesnt work with recent versions of intellij. Multiple PRs have
> been made to update to fix this, but Google has not yet accepted one. I'd
> like to compare the options submitted and choose one of those.
>
> On Oct 19, 2016 3:55 PM, "Kirk Lund"  wrote:
>
> > Should we be using these formatters instead of the formatters under /etc
> in
> > Geode?
> >
> > Google Java Style Eclipse Formatter...
> > https://github.com/google/styleguide/blob/gh-pages/
> > eclipse-java-google-style.xml
> >
> > Google Java Style IntelliJ Formatter...
> > https://github.com/google/styleguide/blob/gh-pages/
> > intellij-java-google-style.xml
> >
> > -Kirk
> >
>

Re: Nightly geode build?

[Kirk Lund]

Hah, no need to make any changes. Thanks!


On Wed, Oct 19, 2016 at 4:31 PM, Mark Bretl  wrote:

> Nope, its just running successfully :) Last build was 627
>
> The email plugin being used states the following: E-mail will be sent when
> a build fails, becomes unstable or returns to stable.
>
> There is another email plugin which has more options, including sending
> every job. I can set it up if that is what people want.
>
> --Mark
>
> On Wed, Oct 19, 2016 at 3:48 PM, Kirk Lund  wrote:
>
> > Last email I got from Apache Jenkins Server was for Geode-nightly #624 on
> > Oct. 16. Did our nightly job die in some way?
> >
> > -Kirk
> >
>

Re: Nightly geode build?

[Mark Bretl]

Nope, its just running successfully :) Last build was 627

The email plugin being used states the following: E-mail will be sent when
a build fails, becomes unstable or returns to stable.

There is another email plugin which has more options, including sending
every job. I can set it up if that is what people want.

--Mark

On Wed, Oct 19, 2016 at 3:48 PM, Kirk Lund  wrote:

> Last email I got from Apache Jenkins Server was for Geode-nightly #624 on
> Oct. 16. Did our nightly job die in some way?
>
> -Kirk
>

IntelliJ and Eclipse formatters

[Kirk Lund]

Should we be using these formatters instead of the formatters under /etc in
Geode?

Google Java Style Eclipse Formatter...
https://github.com/google/styleguide/blob/gh-pages/eclipse-java-google-style.xml

Google Java Style IntelliJ Formatter...
https://github.com/google/styleguide/blob/gh-pages/intellij-java-google-style.xml

-Kirk

Re: Review Request 52994: GEODE-1959: prompt for password when starting a server if username is specified

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52994/#review153314
---


Ship it!




Ship It!

- Kirk Lund


On Oct. 19, 2016, 12:11 a.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52994/
> ---
> 
> (Updated Oct. 19, 2016, 12:11 a.m.)
> 
> 
> Review request for geode, John Blum, Kevin Duling, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1959: prompt for password when starting a server if username is 
> specified
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java
>  490e309dad7ee5100a2c39fc8ec3b13bc9c30737 
>   geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 
> a3d3845bf218cd04500a336e65d6143277433f7f 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  89a9a37d917eb29eddd12676621417c5e3eadd25 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
>  4ffe08271d0e06919f45769f200b71ef0978d879 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java
>  792a8abed97dcff8c15f678a4cd12e0d1656568d 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
>  51887cf500f6aed00f79c10b22f708b03a13d178 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java
>  467682d9b931e0bdd03c8dd3a739b686a6ace1c3 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/golden-help-offline.properties
>  28083f3058655b46c027c23dd64225f449ddb84e 
> 
> Diff: https://reviews.apache.org/r/52994/diff/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Removal of nonSingleHopCount stat from client

[Kirk Lund]

+1

FYI: I know of one customer that uses the old "gemfire stats" command,
polling repeatedly for certain stat values written to a gfs file from a
native client as a crude form of monitoring, so some folks do make use of
client stats (we should give them a better way to monitor clients tho)


On Wed, Oct 19, 2016 at 2:56 PM, Bruce Schuchardt 
wrote:

> +1 for removing it
>
> It's redundant, we've rarely used client statistics and I hear that people
> generally have stats turned off in clients anyway.
>
>
> Le 10/19/2016 à 12:55 PM, Udo Kohlmeyer a écrit :
>
>> Hi there Guys,
>>
>> I've created https://issues.apache.org/jira/browse/GEODE-2017 to track
>> the removal of the nonSingleHopCount stat from the client, as it is
>> potentially a redundant stat.
>>
>> From the implementation it only increments on "singleHop" enabled pools
>> when an operation requires more than one hop to complete. This exact same
>> metric is tracked in "metaDataRefreshCount", which tracks the amount of
>> meta data refreshes on the client. Which is automatically  refreshed when
>> an operation requires more than one hop.
>>
>> Does anyone have any objection in the removal of this stat?
>>
>> --Udo
>>
>>
>

Re: Removal of nonSingleHopCount stat from client

[Bruce Schuchardt]

+1 for removing it

It's redundant, we've rarely used client statistics and I hear that 
people generally have stats turned off in clients anyway.


Le 10/19/2016 à 12:55 PM, Udo Kohlmeyer a écrit :

Hi there Guys,

I've created https://issues.apache.org/jira/browse/GEODE-2017 to track 
the removal of the nonSingleHopCount stat from the client, as it is 
potentially a redundant stat.


From the implementation it only increments on "singleHop" enabled 
pools when an operation requires more than one hop to complete. This 
exact same metric is tracked in "metaDataRefreshCount", which tracks 
the amount of meta data refreshes on the client. Which is 
automatically  refreshed when an operation requires more than one hop.


Does anyone have any objection in the removal of this stat?

--Udo

Re: Review Request 53034: GEODE-1927 backward compatibility support

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53034/#review153309
---


Ship it!




If this is the only thing that is required to add a new category, then awesome!

- Udo Kohlmeyer


On Oct. 19, 2016, 9:16 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53034/
> ---
> 
> (Updated Oct. 19, 2016, 9:16 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> adding a new unit-test category for backward-compatibility tests
> 
> 
> Diffs
> -
> 
>   
> geode-junit/src/main/java/org/apache/geode/test/junit/categories/BackwardCompatibilityTest.java
>  PRE-CREATION 
>   gradle/test.gradle 5b895ba07a37740165c2dca45179493615d613f5 
> 
> Diff: https://reviews.apache.org/r/53034/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Review Request 53034: GEODE-1927 backward compatibility support

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53034/
---

Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.


Repository: geode


Description
---

adding a new unit-test category for backward-compatibility tests


Diffs
-

  
geode-junit/src/main/java/org/apache/geode/test/junit/categories/BackwardCompatibilityTest.java
 PRE-CREATION 
  gradle/test.gradle 5b895ba07a37740165c2dca45179493615d613f5 

Diff: https://reviews.apache.org/r/53034/diff/


Testing
---


Thanks,

Bruce Schuchardt

[GitHub] incubator-geode pull request #263: GEODE-1983: Swagger is broken with integr...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/263


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Removal of nonSingleHopCount stat from client

[Udo Kohlmeyer]

Hi there Guys,

I've created https://issues.apache.org/jira/browse/GEODE-2017 to track 
the removal of the nonSingleHopCount stat from the client, as it is 
potentially a redundant stat.


From the implementation it only increments on "singleHop" enabled pools 
when an operation requires more than one hop to complete. This exact 
same metric is tracked in "metaDataRefreshCount", which tracks the 
amount of meta data refreshes on the client. Which is automatically  
refreshed when an operation requires more than one hop.


Does anyone have any objection in the removal of this stat?

--Udo

[GitHub] incubator-geode pull request #265: GEODE-2014: Upgrade Swagger libraries

[metatype]

Github user metatype commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/265#discussion_r84112416
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java
 ---
@@ -94,7 +94,7 @@ public static void before() throws Exception {
   @Test
   public void testFunctions() throws Exception {
 String json = "{\"@type\":\"double\",\"@value\":210}";
-
+Thread.sleep(50);
--- End diff --

This seems like a really long pause for an integration test.  Is there 
another way to do this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #265: GEODE-2014: Upgrade Swagger libraries

[metatype]

Github user metatype commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/265#discussion_r84111969
  
--- Diff: gradle/dependency-versions.properties ---
@@ -100,8 +100,8 @@ spring-tx.version = 4.3.2.RELEASE
 springframework.version = 4.3.2.RELEASE
 stephenc-findbugs.version = 1.3.9-1
 spymemcached.version = 2.9.0
-swagger.version = 1.3.2
-swagger-springmvc.version = 0.8.2
+swagger.version=1.3.13
--- End diff --

Verified that the license is still ASL 2.0 so no changes to LICENSE.  Also 
does not include a NOTICE file so we do not need to propagate anything in our 
NOTICE.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #265: GEODE-2014: Upgrade Swagger libraries

[kjduling]

GitHub user kjduling opened a pull request:

https://github.com/apache/incubator-geode/pull/265

GEODE-2014: Upgrade Swagger libraries



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-2014

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #265


commit c2b15f22886431588e8a21a80e7ff13ea69a7ec2
Author: Kevin Duling 
Date:   2016-10-18T22:54:55Z

GEODE-2014: Upgrade Swagger libraries




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: jvsd

[Dave Barnes]

Hi Dor,
JVSD is in the Geode Repo on a feature branch, feature/GEODE-78.
See http://geode.docs.pivotal.io/docs/tools_modules/jvsd.html for details.
-Dave


On Wed, Oct 19, 2016 at 1:43 AM, Dor Ben Dov  wrote:

> Hi,
>
> Where can I get the latest version of it ?
>
>
> Regards,
> Dor
>
> This message and the information contained herein is proprietary and
> confidential and subject to the Amdocs policy statement,
> you may review at http://www.amdocs.com/email_disclaimer.asp
>

[GitHub] incubator-geode pull request #264: Feature/geode 538

[pdxrunner]

GitHub user pdxrunner opened a pull request:

https://github.com/apache/incubator-geode/pull/264

Feature/geode 538

Changes have been reviewed at https://reviews.apache.org/r/52891/

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pdxrunner/incubator-geode feature/GEODE-538

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/264.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #264


commit 6ed78b4f5e44c1f3b4847dfdaa5c10a8df886ae9
Author: Ken Howe 
Date:   2016-10-06T22:02:24Z

GEODE-538: Add check for persistent data recovery

PartitionedRegion.getNodeForBucketReadOrLoad can return an invalid node
if persistent data recovery is in process and a get() targets a bucket
that
hasn't been recoverd yet. This can result in returning an incorrect
value (null) or throwing ConflictingPersistentDataException from a get()
or put() on the region.

This change adds a check for persistent recovery to be completed
before creating the new bucket. If recovery isn't complete then the
operation on the region will fail with a PartitionOfflineException.

Queries on a region while persistent recovery is in progress can also
result in incorrect results so a similar check is added to
DefaultQuery.checkQueryOnPR.

commit 2f8cfbaf10fcefb8f14eab6bbedef090d88a96dd
Author: Ken Howe 
Date:   2016-10-17T23:03:50Z

GEODE-538: Refactored check for persistent recovery

Moved the recovery check to a new method in PartitionedRegion instead of
having duplicated code in PRHARedundancyProvider and DefaultQuery.

Added throws declaration to javadoc in the Query Interface

commit 77768628ba59f8a4b7d3bdb6738a9c1dcd91a4ac
Author: Ken Howe 
Date:   2016-10-18T17:11:24Z

GEODE-538: Added PartitionOfflineException to javadocs

Added the exception declaration to the javadocs for other execute
methods.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VIRTUAL] Geode Clubhouse TODAY, 10/19 9AM Pacific - New Security Framework for Apache Geode

[Gregory Chase]

Final reminder. The next Geode Clubhouse about the new security framework
starts in just over 30 minutes.

Join the meeting 

On Tue, Oct 18, 2016 at 12:59 PM, Gregory Chase  wrote:

> Greetings Geode Community,
> This is just a friendly reminder of our virtual meet up tomorrow, 9AM,
> where Jinmei will discuss her work implementing the new security framework
> for Apache Geode!
>
> Add to calendar
> 
>  | Join the meeting 
>
>
> On Wed, Oct 12, 2016 at 4:45 PM, Gregory Chase  wrote:
>
>> Dear Geode Community,
>>
>> Ok, its back to APIs this month as we explore the new security framework
>> with Jinmei Liao this next Weds, October 19, at 9AM Pacific.
>>
>> Add to calendar
>> 
>> | Join the meeting 
>>
>> With the recent release of Apache Geode 1.0 M3, Apache Geode has had a
>> major revision of its security capabilities with the inclusion of Apache
>> Shiro.
>>
>> In this talk, Jinmei Liao, committer with Apache Geode, will talk about
>> the new capabilities, how they unify role-based access for all
>> communication channels, and discuss what the future roadmap may look like.
>>
>> She'll review Geode's prior security implementation, give a
>> demonstration of the new paradigm, and describe how these were implemented
>> using Apache Shiro.
>>
>> *About the speaker*
>> Jinmei Liao is a software engineer with a decade and a half experience
>> working working with Java, Spring, distributed systems, and security 
>> technology.
>> Most recently Jinmei has been leading development of security capabilities
>> for the Apache Geode in-memory data grid, and is a committer for the Apache
>> Geode project.  Jinmei is the mother of two teenage boys and enjoys cooking
>> and painting.
>>
>> See you next Weds!
>>
>> Add to calendar
>> 
>>  | Join the meeting 
>>
>> --
>> Greg Chase
>>
>> Global Head, Big Data Communities
>> http://www.pivotal.io/big-data
>>
>> Pivotal Software
>> http://www.pivotal.io/
>>
>> 650-215-0477
>> @GregChase
>> Blog: http://geekmarketing.biz/
>>
>>
>
>
> --
> Greg Chase
>
> Global Head, Big Data Communities
> http://www.pivotal.io/big-data
>
> Pivotal Software
> http://www.pivotal.io/
>
> 650-215-0477
> @GregChase
> Blog: http://geekmarketing.biz/
>
>


-- 
Greg Chase

Global Head, Big Data Communities
http://www.pivotal.io/big-data

Pivotal Software
http://www.pivotal.io/

650-215-0477
@GregChase
Blog: http://geekmarketing.biz/

Re: jvsd

[Dan Smith]

Hi Dor,

jvsd hasn't yet been merged to develop, so for now you still have to check
out the feature/GEODE-78 branch and build it from source. Here are some
instructions:

https://github.com/apache/incubator-geode/blob/feature/GEODE-78/geode-jvsd/README.md

0-Dan


On Wed, Oct 19, 2016 at 1:43 AM, Dor Ben Dov  wrote:

> Hi,
>
> Where can I get the latest version of it ?
>
>
> Regards,
> Dor
>
> This message and the information contained herein is proprietary and
> confidential and subject to the Amdocs policy statement,
> you may review at http://www.amdocs.com/email_disclaimer.asp
>

jvsd

[Dor Ben Dov]

Hi, 

Where can I get the latest version of it ? 


Regards,
Dor

This message and the information contained herein is proprietary and 
confidential and subject to the Amdocs policy statement,
you may review at http://www.amdocs.com/email_disclaimer.asp