Review Request 53335: GEODE-2028: Fix license issues from 1.0.0-incubating release

2016-10-31 Thread Anthony Baker 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53335/
---

Review request for geode and Dick Cavender.


Repository: geode


Description
---

Remove bootstrap from LICENSE as v3.0.0 that we bundle is Apache
licensed.


Diffs
-

  LICENSE 231239b0670f4832004ebba2e0e030078ee8b17e 
  geode-assembly/src/main/dist/LICENSE 92e95b3a502def0bed99911ec530116baac039bd 
  gradle/rat.gradle e9fc70f6fff85dc2492dd46f18f05e2a100ffbff 

Diff: https://reviews.apache.org/r/53335/diff/


Testing
---


Thanks,

Anthony Baker

Re: Review Request 53331: GEODE-2047 Document change to enable-network-partition-detection

2016-10-31 Thread Joey McAllister 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53331/#review154352
---




geode-docs/managing/troubleshooting/recovering_conflicting_data_exceptions.html.md.erb
 (line 49)


I recommend something like "is set to the default value of true" or "has 
the default value of true" here, to avoid conflating the definition of the 
property (what it is) and its value (what it is assigned).



geode-docs/managing/troubleshooting/recovering_from_network_outages.html.md.erb 
(line 58)


"must be set to true if"



geode-docs/reference/topics/gemfire_properties.html.md.erb (line 163)


"this property must be set to true if"


- Joey McAllister


On Oct. 31, 2016, 11:57 p.m., Karen Miller wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53331/
> ---
> 
> (Updated Oct. 31, 2016, 11:57 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Dave Barnes, and Joey McAllister.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - This is a subtask of GEODE-762.
> - The default value of property enable-network-partition-detection
> changed from false to true, enabling partition detection by
> default, so all documentation that discusses partition detection
> also needs to change.
> - Fixed a minor typo or two encountered in the files that were
> being updated.
> 
> 
> Diffs
> -
> 
>   
> geode-docs/managing/network_partitioning/handling_network_partitioning.html.md.erb
>  61a25760265771ba3e53c271731af6e44f5e72ee 
>   
> geode-docs/managing/network_partitioning/how_network_partitioning_management_works.html.md.erb
>  e97163401f967f672eea8e7889f8991d971b4145 
>   
> geode-docs/managing/troubleshooting/recovering_conflicting_data_exceptions.html.md.erb
>  38375aea1e5742d878d1e7dbaf3c92d67320d17f 
>   
> geode-docs/managing/troubleshooting/recovering_from_network_outages.html.md.erb
>  8c23beac365af0f8f917b13447c2ae6382ad2525 
>   geode-docs/managing/troubleshooting/system_failure_and_recovery.html.md.erb 
> d94ea604cdbe1f3ea1e41b8b7172bb825fdb7b38 
>   geode-docs/reference/topics/gemfire_properties.html.md.erb 
> 988256840a084cac56a4e38723415a4c4ea2d99f 
> 
> Diff: https://reviews.apache.org/r/53331/diff/
> 
> 
> Testing
> ---
> 
> gradle rat check passes
> 
> 
> Thanks,
> 
> Karen Miller
> 
>

Re: Review Request 53108: GEODE-2012: always write stat types to archive

2016-10-31 Thread Kirk Lund 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53108/#review154350
---




geode-core/src/main/java/org/apache/geode/internal/logging/ManagerLogWriter.java
 (line 317)


This method must remain static for the caller for now. We could extract 
this method to its own class. The only two callers are:

(geode-core main)
org.apache.geode.internal.logging.log4j.LogWriterAppenders

(geode-core test)
org.apache.geode.internal.logging.TestLogWriterFactory


- Kirk Lund


On Oct. 31, 2016, 11:54 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53108/
> ---
> 
> (Updated Oct. 31, 2016, 11:54 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Darrel Schneider, Jinmei Liao, Kevin 
> Duling, Swapnil Bawaskar, and Dan Smith.
> 
> 
> Bugs: GEODE-2012
> https://issues.apache.org/jira/browse/GEODE-2012
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2012: always write stat types to archive
> 
> * alter NanoTimer and its use to make testing easier
> * remove extra spaces in localized string
> * import SuppressWarnings to make use of annotation cleaner
> * new test for rolling stat files: FileSizeLimitIntegrationTest
> * new test for rolling and deleting old stat files: 
> DiskSpaceLimitIntegrationTest
> * new test to expose GEODE-2012 and confirm its fix: 
> StatTypesAreRolledOverRegressionTest
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/NanoTimer.java 
> 12e91f8e05ee93370f56d0af171558e7741eb0f2 
>   
> geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java 
> 210539bf33896259d56a41d05546101c996ac553 
>   
> geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/io/RollingFileHandler.java 
> PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/logging/ManagerLogWriter.java
>  a000d2c01008730dcf2a0faab0ae7f5ade5fcae1 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/HostStatSampler.java
>  6d7b9670385babdbe0f829e70b960dd379259d62 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/SampleCollector.java
>  610e848b3185baca0852efef085502e6d33ca2aa 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/SimpleStatSampler.java
>  7eaa1e0a914fd9ef01d1e7cfbd110329c43de493 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveHandler.java
>  5520936ba9835354a4225ff52f3bdcaf0ccb616a 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveWriter.java
>  a4c15d13401f20ca6717fdddff040cf29bc26bf5 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java
>  a2b0ae4d5cf5c40bed392292180a8987952e80a9 
>   
> geode-core/src/main/java/org/apache/geode/internal/util/concurrent/StoppableCountDownLatch.java
>  740fd7fdc98928de0054ca83d11716033225e373 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/DiskSpaceLimitIntegrationTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/FileSizeLimitIntegrationTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/SampleCollectorTest.java
>  ab84ea4355df17b93c75487fb01fbb59f943bafc 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/StatMonitorHandlerTest.java
>  85e6f6d4a943989a129d7a752fc70a5330a3428f 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/StatMonitorHandlerWithEnabledMonitorThreadTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/StatTypesAreRolledOverRegressionTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/StatisticsMonitorTest.java
>  b570db2e0094326f30dd47935a1558d9d1b01d48 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/ValueMonitorIntegrationTest.java
>  cef5977bfbc86e956e79e9d50b1a9b99fdab55e6 
> 
> Diff: https://reviews.apache.org/r/53108/diff/
> 
> 
> Testing
> ---
> 
> precheckin passed everything!
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Review Request 53331: GEODE-2047 Document change to enable-network-partition-detection

2016-10-31 Thread Karen Miller 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53331/
---

Review request for geode, Bruce Schuchardt, Dave Barnes, and Joey McAllister.


Repository: geode


Description
---

- This is a subtask of GEODE-762.
- The default value of property enable-network-partition-detection
changed from false to true, enabling partition detection by
default, so all documentation that discusses partition detection
also needs to change.
- Fixed a minor typo or two encountered in the files that were
being updated.


Diffs
-

  
geode-docs/managing/network_partitioning/handling_network_partitioning.html.md.erb
 61a25760265771ba3e53c271731af6e44f5e72ee 
  
geode-docs/managing/network_partitioning/how_network_partitioning_management_works.html.md.erb
 e97163401f967f672eea8e7889f8991d971b4145 
  
geode-docs/managing/troubleshooting/recovering_conflicting_data_exceptions.html.md.erb
 38375aea1e5742d878d1e7dbaf3c92d67320d17f 
  
geode-docs/managing/troubleshooting/recovering_from_network_outages.html.md.erb 
8c23beac365af0f8f917b13447c2ae6382ad2525 
  geode-docs/managing/troubleshooting/system_failure_and_recovery.html.md.erb 
d94ea604cdbe1f3ea1e41b8b7172bb825fdb7b38 
  geode-docs/reference/topics/gemfire_properties.html.md.erb 
988256840a084cac56a4e38723415a4c4ea2d99f 

Diff: https://reviews.apache.org/r/53331/diff/


Testing
---

gradle rat check passes


Thanks,

Karen Miller

Re: Review Request 53108: GEODE-2012: always write stat types to archive

2016-10-31 Thread Kirk Lund 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53108/
---

(Updated Oct. 31, 2016, 11:54 p.m.)


Review request for geode, Anthony Baker, Darrel Schneider, Jinmei Liao, Kevin 
Duling, Swapnil Bawaskar, and Dan Smith.


Changes
---

new diff: refactor code as recommended in previous review


Bugs: GEODE-2012
https://issues.apache.org/jira/browse/GEODE-2012


Repository: geode


Description
---

GEODE-2012: always write stat types to archive

* alter NanoTimer and its use to make testing easier
* remove extra spaces in localized string
* import SuppressWarnings to make use of annotation cleaner
* new test for rolling stat files: FileSizeLimitIntegrationTest
* new test for rolling and deleting old stat files: 
DiskSpaceLimitIntegrationTest
* new test to expose GEODE-2012 and confirm its fix: 
StatTypesAreRolledOverRegressionTest


Diffs (updated)
-

  geode-core/src/main/java/org/apache/geode/internal/NanoTimer.java 
12e91f8e05ee93370f56d0af171558e7741eb0f2 
  geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java 
210539bf33896259d56a41d05546101c996ac553 
  
geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java
 PRE-CREATION 
  geode-core/src/main/java/org/apache/geode/internal/io/RollingFileHandler.java 
PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/internal/logging/ManagerLogWriter.java
 a000d2c01008730dcf2a0faab0ae7f5ade5fcae1 
  
geode-core/src/main/java/org/apache/geode/internal/statistics/HostStatSampler.java
 6d7b9670385babdbe0f829e70b960dd379259d62 
  
geode-core/src/main/java/org/apache/geode/internal/statistics/SampleCollector.java
 610e848b3185baca0852efef085502e6d33ca2aa 
  
geode-core/src/main/java/org/apache/geode/internal/statistics/SimpleStatSampler.java
 7eaa1e0a914fd9ef01d1e7cfbd110329c43de493 
  
geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveHandler.java
 5520936ba9835354a4225ff52f3bdcaf0ccb616a 
  
geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveWriter.java
 a4c15d13401f20ca6717fdddff040cf29bc26bf5 
  
geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java
 a2b0ae4d5cf5c40bed392292180a8987952e80a9 
  
geode-core/src/main/java/org/apache/geode/internal/util/concurrent/StoppableCountDownLatch.java
 740fd7fdc98928de0054ca83d11716033225e373 
  
geode-core/src/test/java/org/apache/geode/internal/statistics/DiskSpaceLimitIntegrationTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/statistics/FileSizeLimitIntegrationTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/statistics/SampleCollectorTest.java
 ab84ea4355df17b93c75487fb01fbb59f943bafc 
  
geode-core/src/test/java/org/apache/geode/internal/statistics/StatMonitorHandlerTest.java
 85e6f6d4a943989a129d7a752fc70a5330a3428f 
  
geode-core/src/test/java/org/apache/geode/internal/statistics/StatMonitorHandlerWithEnabledMonitorThreadTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/statistics/StatTypesAreRolledOverRegressionTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/statistics/StatisticsMonitorTest.java
 b570db2e0094326f30dd47935a1558d9d1b01d48 
  
geode-core/src/test/java/org/apache/geode/internal/statistics/ValueMonitorIntegrationTest.java
 cef5977bfbc86e956e79e9d50b1a9b99fdab55e6 

Diff: https://reviews.apache.org/r/53108/diff/


Testing
---

precheckin passed everything!


Thanks,

Kirk Lund

Re: Review Request 53108: GEODE-2012: always write stat types to archive

2016-10-31 Thread Kirk Lund 


> On Oct. 31, 2016, 8:34 p.m., Darrel Schneider wrote:
> > geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java,
> >  line 93
> > 
> >
> > only the null check is needed here.
> > Shouldn't this block also null out "notifier" if it stops it?
> > Pull the code in lines 79-82 into a stopNotifier method and then call 
> > that method from here and there

These have been refactored but they still need to check monitors and notifier. 
Hopefully this is clearer in the newest changes.


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53108/#review154312
---


On Oct. 31, 2016, 7:56 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53108/
> ---
> 
> (Updated Oct. 31, 2016, 7:56 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Darrel Schneider, Jinmei Liao, Kevin 
> Duling, Swapnil Bawaskar, and Dan Smith.
> 
> 
> Bugs: GEODE-2012
> https://issues.apache.org/jira/browse/GEODE-2012
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2012: always write stat types to archive
> 
> * alter NanoTimer and its use to make testing easier
> * remove extra spaces in localized string
> * import SuppressWarnings to make use of annotation cleaner
> * new test for rolling stat files: FileSizeLimitIntegrationTest
> * new test for rolling and deleting old stat files: 
> DiskSpaceLimitIntegrationTest
> * new test to expose GEODE-2012 and confirm its fix: 
> StatTypesAreRolledOverRegressionTest
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/NanoTimer.java 
> 12e91f8e05ee93370f56d0af171558e7741eb0f2 
>   
> geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java 
> 210539bf33896259d56a41d05546101c996ac553 
>   
> geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/io/RollingFileHandler.java 
> PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/logging/ManagerLogWriter.java
>  a000d2c01008730dcf2a0faab0ae7f5ade5fcae1 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/HostStatSampler.java
>  6d7b9670385babdbe0f829e70b960dd379259d62 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/SampleCollector.java
>  610e848b3185baca0852efef085502e6d33ca2aa 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/SimpleStatSampler.java
>  7eaa1e0a914fd9ef01d1e7cfbd110329c43de493 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveHandler.java
>  5520936ba9835354a4225ff52f3bdcaf0ccb616a 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveWriter.java
>  a4c15d13401f20ca6717fdddff040cf29bc26bf5 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java
>  a2b0ae4d5cf5c40bed392292180a8987952e80a9 
>   
> geode-core/src/main/java/org/apache/geode/internal/util/concurrent/StoppableCountDownLatch.java
>  740fd7fdc98928de0054ca83d11716033225e373 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/DiskSpaceLimitIntegrationTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/FileSizeLimitIntegrationTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/SampleCollectorTest.java
>  ab84ea4355df17b93c75487fb01fbb59f943bafc 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/StatMonitorHandlerTest.java
>  85e6f6d4a943989a129d7a752fc70a5330a3428f 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/StatMonitorHandlerWIthEnabledMonitorThreadTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/StatSamplerUtils.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/StatTypesAreRolledOverRegressionTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/StatisticsMonitorTest.java
>  b570db2e0094326f30dd47935a1558d9d1b01d48 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/ValueMonitorIntegrationTest.java
>  cef5977bfbc86e956e79e9d50b1a9b99fdab55e6 
> 
> Diff: https://reviews.apache.org/r/53108/diff/
> 
> 
> Testing
> ---
> 
> precheckin passed everything!
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

[GitHub] incubator-geode pull request #277: GEODE-1098: Fix gfsh.bat error with defau...

2016-10-31 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/277


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Docker image for Geode 1.0.0-incubating - Please evaluate

2016-10-31 Thread William Markito Oliveira 
Done.  apachegeode/geode:latest

On Mon, Oct 31, 2016 at 12:42 PM, William Markito Oliveira <
william.mark...@gmail.com> wrote:

> Sounds cool. That's a great ideia!
>
> Sent from my iPhone
>
> > On Oct 31, 2016, at 12:41 PM, Anthony Baker  wrote:
> >
> > Nice!  What about tagging it with 'latest'?
> >
> > Anthony
> >
> >> On Oct 31, 2016, at 12:13 PM, William Markito Oliveira <
> william.mark...@gmail.com> wrote:
> >>
> >> I've just updated our Docker image with 1.0.0-incubating bits, please
> >> evaluate.
> >>
> >> There is also a pull request for review updating our Dockerfile to use
> >> 1.0.0-incubating and OpenJDK instead of Oracle.
> >>
> >> - https://hub.docker.com/r/apachegeode/geode/tags/
> >> - https://github.com/apache/incubator-geode/pull/275
> >>
> >> The following line gives you GFSH on a container:
> >>
> >> docker run -it apachegeode/geode:1.0.0-incubating
> >>
> >> But bash is also available:
> >>
> >> docker run -it apachegeode/geode:1.0.0-incubating bash
> >>
> >> I'm planning to contribute the compose and kubernetes scripts to Geode
> as
> >> well, if you guys think it's a good idea, but for now they're in my
> >> personal GitHub:
> >>
> >> - https://github.com/markito/geode-docker
> >> - https://github.com/markito/geode-kubernetes
> >>
> >> Thanks,
> >> --
>



-- 
__
William Markito Oliveira
http://blog.markito.info
*"...because architecture is more important than technology..."*

Re: [DISCUSS] Graduation

2016-10-31 Thread Jianxia Chen 
+1

On Mon, Oct 31, 2016 at 2:47 PM, Anilkumar Gingade 
wrote:

> +1
>
> On Fri, Oct 28, 2016 at 10:23 PM, Avinash Dongre 
> wrote:
>
> > +1
> >
> > On Sat, Oct 29, 2016 at 8:40 AM, yang theseus 
> > wrote:
> >
> > > +1!
> > >
> > > 2016-10-28 7:07 GMT+08:00 Nitin Lamba :
> > >
> > > > +1!
> > > >
> > > > On Wed, Oct 26, 2016 at 12:36 PM, Nabarun Nag 
> wrote:
> > > >
> > > > > +1
> > > > > On Wed, Oct 26, 2016 at 12:07 PM Mark Bretl 
> > > > wrote:
> > > > >
> > > > > > +1
> > > > > >
> > > > > > On Wed, Oct 26, 2016 at 12:04 PM, Ashvin A 
> > > wrote:
> > > > > >
> > > > > > > +1
> > > > > > >
> > > > > > > On Tue, Oct 25, 2016 at 5:25 PM, Roman Shaposhnik <
> > r...@apache.org>
> > > > > > wrote:
> > > > > > >
> > > > > > > >  inactive
> > > > > > > >   microsoft.com (Ashvin)
> > > > > > > >
> > > > > > >
> > > > > > > :-(
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: Review Request 53311: GEODE-2045 Improve docs of region shortcuts

2016-10-31 Thread Joey McAllister 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53311/#review154324
---


Ship it!




Ship It!

- Joey McAllister


On Oct. 31, 2016, 7:28 p.m., Karen Miller wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53311/
> ---
> 
> (Updated Oct. 31, 2016, 7:28 p.m.)
> 
> 
> Review request for geode, Dave Barnes and Joey McAllister.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - Make sure that partitioned regions do not say or imply
> that they have local scope.
> - Fix labels with anchors, such that links work.
> - Remove reference links to general descriptions of the
> attributes used by the shortcuts.
> 
> 
> Diffs
> -
> 
>   geode-docs/reference/topics/region_shortcuts_reference.html.md.erb 
> d5cb2fabdf8f8ce56b3bbf5dbf4706bb19e0742d 
>   geode-docs/reference/topics/region_shortcuts_table.html.md.erb 
> c0ead67b475742b05282b9f32df6e10296d94714 
> 
> Diff: https://reviews.apache.org/r/53311/diff/
> 
> 
> Testing
> ---
> 
> gradle rat check passes
> 
> 
> Thanks,
> 
> Karen Miller
> 
>

Re: [DISCUSS] Graduation

2016-10-31 Thread Anilkumar Gingade 
+1

On Fri, Oct 28, 2016 at 10:23 PM, Avinash Dongre  wrote:

> +1
>
> On Sat, Oct 29, 2016 at 8:40 AM, yang theseus 
> wrote:
>
> > +1!
> >
> > 2016-10-28 7:07 GMT+08:00 Nitin Lamba :
> >
> > > +1!
> > >
> > > On Wed, Oct 26, 2016 at 12:36 PM, Nabarun Nag  wrote:
> > >
> > > > +1
> > > > On Wed, Oct 26, 2016 at 12:07 PM Mark Bretl 
> > > wrote:
> > > >
> > > > > +1
> > > > >
> > > > > On Wed, Oct 26, 2016 at 12:04 PM, Ashvin A 
> > wrote:
> > > > >
> > > > > > +1
> > > > > >
> > > > > > On Tue, Oct 25, 2016 at 5:25 PM, Roman Shaposhnik <
> r...@apache.org>
> > > > > wrote:
> > > > > >
> > > > > > >  inactive
> > > > > > >   microsoft.com (Ashvin)
> > > > > > >
> > > > > >
> > > > > > :-(
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: Review Request 53108: GEODE-2012: always write stat types to archive

2016-10-31 Thread Darrel Schneider 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53108/#review154312
---




geode-core/src/main/java/org/apache/geode/internal/io/RollingFileHandler.java 
(line 27)


I think all three of these patterns can be moved to 
MainWithChildrenRollingFileHandler since it is the only one using them. So they 
can be static private finals on that class.



geode-core/src/main/java/org/apache/geode/internal/logging/ManagerLogWriter.java
 (line 42)


I don't see a reason for this being "static". The class being created has 
no state so the only reason I can think of is that the handler class might be 
expensive to create. I think many of the old methods that you refactored into 
the handler class were static just to show that they did not depend on the 
instance vars in ManagerLogWriter. Your refactoring makes that clear since they 
are in a seperate class now.



geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveHandler.java
 (line 659)


consider refactoring getArchivePattern and getLogPattern together and 
moving them to your new handler class



geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java
 (line 79)


For this code I think this condition is all that is needed: "if 
(this.notifier !=null)"



geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java
 (line 92)


only the null check is needed here.
Shouldn't this block also null out "notifier" if it stops it?
Pull the code in lines 79-82 into a stopNotifier method and then call that 
method from here and there


- Darrel Schneider


On Oct. 31, 2016, 12:56 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53108/
> ---
> 
> (Updated Oct. 31, 2016, 12:56 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Darrel Schneider, Jinmei Liao, Kevin 
> Duling, Swapnil Bawaskar, and Dan Smith.
> 
> 
> Bugs: GEODE-2012
> https://issues.apache.org/jira/browse/GEODE-2012
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2012: always write stat types to archive
> 
> * alter NanoTimer and its use to make testing easier
> * remove extra spaces in localized string
> * import SuppressWarnings to make use of annotation cleaner
> * new test for rolling stat files: FileSizeLimitIntegrationTest
> * new test for rolling and deleting old stat files: 
> DiskSpaceLimitIntegrationTest
> * new test to expose GEODE-2012 and confirm its fix: 
> StatTypesAreRolledOverRegressionTest
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/NanoTimer.java 
> 12e91f8e05ee93370f56d0af171558e7741eb0f2 
>   
> geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java 
> 210539bf33896259d56a41d05546101c996ac553 
>   
> geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/io/RollingFileHandler.java 
> PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/logging/ManagerLogWriter.java
>  a000d2c01008730dcf2a0faab0ae7f5ade5fcae1 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/HostStatSampler.java
>  6d7b9670385babdbe0f829e70b960dd379259d62 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/SampleCollector.java
>  610e848b3185baca0852efef085502e6d33ca2aa 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/SimpleStatSampler.java
>  7eaa1e0a914fd9ef01d1e7cfbd110329c43de493 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveHandler.java
>  5520936ba9835354a4225ff52f3bdcaf0ccb616a 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveWriter.java
>  a4c15d13401f20ca6717fdddff040cf29bc26bf5 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java
>  a2b0ae4d5cf5c40bed392292180a8987952e80a9 
>   
> geode-core/src/main/java/org/apache/geode/internal/util/concurrent/StoppableCountDownLatch.java
>  740fd7fdc98928de0054ca83d11716033225e373 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/DiskSpaceLimitIntegrationTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/FileSizeLimitIntegrationTest.java
>  PRE-CREATION 
>   
>

Re: Review Request 53108: GEODE-2012: always write stat types to archive

2016-10-31 Thread Kirk Lund 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53108/#review154307
---




geode-core/src/test/java/org/apache/geode/internal/statistics/StatMonitorHandlerWIthEnabledMonitorThreadTest.java
 (line 35)


Should be renamed from *WIth* to *With*



geode-core/src/test/java/org/apache/geode/internal/statistics/StatMonitorHandlerWIthEnabledMonitorThreadTest.java
 (line 57)


This should be assertTrue



geode-core/src/test/java/org/apache/geode/internal/statistics/StatSamplerUtils.java
 (line 17)


Delete this class


- Kirk Lund


On Oct. 31, 2016, 7:56 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53108/
> ---
> 
> (Updated Oct. 31, 2016, 7:56 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Darrel Schneider, Jinmei Liao, Kevin 
> Duling, Swapnil Bawaskar, and Dan Smith.
> 
> 
> Bugs: GEODE-2012
> https://issues.apache.org/jira/browse/GEODE-2012
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2012: always write stat types to archive
> 
> * alter NanoTimer and its use to make testing easier
> * remove extra spaces in localized string
> * import SuppressWarnings to make use of annotation cleaner
> * new test for rolling stat files: FileSizeLimitIntegrationTest
> * new test for rolling and deleting old stat files: 
> DiskSpaceLimitIntegrationTest
> * new test to expose GEODE-2012 and confirm its fix: 
> StatTypesAreRolledOverRegressionTest
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/NanoTimer.java 
> 12e91f8e05ee93370f56d0af171558e7741eb0f2 
>   
> geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java 
> 210539bf33896259d56a41d05546101c996ac553 
>   
> geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/io/RollingFileHandler.java 
> PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/logging/ManagerLogWriter.java
>  a000d2c01008730dcf2a0faab0ae7f5ade5fcae1 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/HostStatSampler.java
>  6d7b9670385babdbe0f829e70b960dd379259d62 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/SampleCollector.java
>  610e848b3185baca0852efef085502e6d33ca2aa 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/SimpleStatSampler.java
>  7eaa1e0a914fd9ef01d1e7cfbd110329c43de493 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveHandler.java
>  5520936ba9835354a4225ff52f3bdcaf0ccb616a 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveWriter.java
>  a4c15d13401f20ca6717fdddff040cf29bc26bf5 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java
>  a2b0ae4d5cf5c40bed392292180a8987952e80a9 
>   
> geode-core/src/main/java/org/apache/geode/internal/util/concurrent/StoppableCountDownLatch.java
>  740fd7fdc98928de0054ca83d11716033225e373 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/DiskSpaceLimitIntegrationTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/FileSizeLimitIntegrationTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/SampleCollectorTest.java
>  ab84ea4355df17b93c75487fb01fbb59f943bafc 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/StatMonitorHandlerTest.java
>  85e6f6d4a943989a129d7a752fc70a5330a3428f 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/StatMonitorHandlerWIthEnabledMonitorThreadTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/StatSamplerUtils.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/StatTypesAreRolledOverRegressionTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/StatisticsMonitorTest.java
>  b570db2e0094326f30dd47935a1558d9d1b01d48 
>   
> geode-core/src/test/java/org/apache/geode/internal/statistics/ValueMonitorIntegrationTest.java
>  cef5977bfbc86e956e79e9d50b1a9b99fdab55e6 
> 
> Diff: https://reviews.apache.org/r/53108/diff/
> 
> 
> Testing
> ---
> 
> precheckin passed everything!
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 53311: GEODE-2045 Improve docs of region shortcuts

2016-10-31 Thread Dave Barnes 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53311/#review154308
---


Ship it!




Ship It!

- Dave Barnes


On Oct. 31, 2016, 7:28 p.m., Karen Miller wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53311/
> ---
> 
> (Updated Oct. 31, 2016, 7:28 p.m.)
> 
> 
> Review request for geode, Dave Barnes and Joey McAllister.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - Make sure that partitioned regions do not say or imply
> that they have local scope.
> - Fix labels with anchors, such that links work.
> - Remove reference links to general descriptions of the
> attributes used by the shortcuts.
> 
> 
> Diffs
> -
> 
>   geode-docs/reference/topics/region_shortcuts_reference.html.md.erb 
> d5cb2fabdf8f8ce56b3bbf5dbf4706bb19e0742d 
>   geode-docs/reference/topics/region_shortcuts_table.html.md.erb 
> c0ead67b475742b05282b9f32df6e10296d94714 
> 
> Diff: https://reviews.apache.org/r/53311/diff/
> 
> 
> Testing
> ---
> 
> gradle rat check passes
> 
> 
> Thanks,
> 
> Karen Miller
> 
>

Re: Review Request 53108: GEODE-2012: always write stat types to archive

2016-10-31 Thread Kirk Lund 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53108/
---

(Updated Oct. 31, 2016, 7:56 p.m.)


Review request for geode, Anthony Baker, Darrel Schneider, Jinmei Liao, Kevin 
Duling, Swapnil Bawaskar, and Dan Smith.


Changes
---

New Diff. Extracted file rolling behavior to facilitate rewriting 
DiskSpaceLimitIntegrationTest.


Bugs: GEODE-2012
https://issues.apache.org/jira/browse/GEODE-2012


Repository: geode


Description
---

GEODE-2012: always write stat types to archive

* alter NanoTimer and its use to make testing easier
* remove extra spaces in localized string
* import SuppressWarnings to make use of annotation cleaner
* new test for rolling stat files: FileSizeLimitIntegrationTest
* new test for rolling and deleting old stat files: 
DiskSpaceLimitIntegrationTest
* new test to expose GEODE-2012 and confirm its fix: 
StatTypesAreRolledOverRegressionTest


Diffs (updated)
-

  geode-core/src/main/java/org/apache/geode/internal/NanoTimer.java 
12e91f8e05ee93370f56d0af171558e7741eb0f2 
  geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java 
210539bf33896259d56a41d05546101c996ac553 
  
geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java
 PRE-CREATION 
  geode-core/src/main/java/org/apache/geode/internal/io/RollingFileHandler.java 
PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/internal/logging/ManagerLogWriter.java
 a000d2c01008730dcf2a0faab0ae7f5ade5fcae1 
  
geode-core/src/main/java/org/apache/geode/internal/statistics/HostStatSampler.java
 6d7b9670385babdbe0f829e70b960dd379259d62 
  
geode-core/src/main/java/org/apache/geode/internal/statistics/SampleCollector.java
 610e848b3185baca0852efef085502e6d33ca2aa 
  
geode-core/src/main/java/org/apache/geode/internal/statistics/SimpleStatSampler.java
 7eaa1e0a914fd9ef01d1e7cfbd110329c43de493 
  
geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveHandler.java
 5520936ba9835354a4225ff52f3bdcaf0ccb616a 
  
geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveWriter.java
 a4c15d13401f20ca6717fdddff040cf29bc26bf5 
  
geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java
 a2b0ae4d5cf5c40bed392292180a8987952e80a9 
  
geode-core/src/main/java/org/apache/geode/internal/util/concurrent/StoppableCountDownLatch.java
 740fd7fdc98928de0054ca83d11716033225e373 
  
geode-core/src/test/java/org/apache/geode/internal/statistics/DiskSpaceLimitIntegrationTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/statistics/FileSizeLimitIntegrationTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/statistics/SampleCollectorTest.java
 ab84ea4355df17b93c75487fb01fbb59f943bafc 
  
geode-core/src/test/java/org/apache/geode/internal/statistics/StatMonitorHandlerTest.java
 85e6f6d4a943989a129d7a752fc70a5330a3428f 
  
geode-core/src/test/java/org/apache/geode/internal/statistics/StatMonitorHandlerWIthEnabledMonitorThreadTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/statistics/StatSamplerUtils.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/statistics/StatTypesAreRolledOverRegressionTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/statistics/StatisticsMonitorTest.java
 b570db2e0094326f30dd47935a1558d9d1b01d48 
  
geode-core/src/test/java/org/apache/geode/internal/statistics/ValueMonitorIntegrationTest.java
 cef5977bfbc86e956e79e9d50b1a9b99fdab55e6 

Diff: https://reviews.apache.org/r/53108/diff/


Testing
---

precheckin passed everything!


Thanks,

Kirk Lund

Re: Docker image for Geode 1.0.0-incubating - Please evaluate

2016-10-31 Thread William Markito Oliveira 
Sounds cool. That's a great ideia! 

Sent from my iPhone

> On Oct 31, 2016, at 12:41 PM, Anthony Baker  wrote:
> 
> Nice!  What about tagging it with 'latest'?
> 
> Anthony
> 
>> On Oct 31, 2016, at 12:13 PM, William Markito Oliveira 
>>  wrote:
>> 
>> I've just updated our Docker image with 1.0.0-incubating bits, please
>> evaluate.
>> 
>> There is also a pull request for review updating our Dockerfile to use
>> 1.0.0-incubating and OpenJDK instead of Oracle.
>> 
>> - https://hub.docker.com/r/apachegeode/geode/tags/
>> - https://github.com/apache/incubator-geode/pull/275
>> 
>> The following line gives you GFSH on a container:
>> 
>> docker run -it apachegeode/geode:1.0.0-incubating
>> 
>> But bash is also available:
>> 
>> docker run -it apachegeode/geode:1.0.0-incubating bash
>> 
>> I'm planning to contribute the compose and kubernetes scripts to Geode as
>> well, if you guys think it's a good idea, but for now they're in my
>> personal GitHub:
>> 
>> - https://github.com/markito/geode-docker
>> - https://github.com/markito/geode-kubernetes
>> 
>> Thanks,
>> --

Re: Docker image for Geode 1.0.0-incubating - Please evaluate

2016-10-31 Thread Anthony Baker 
Nice!  What about tagging it with 'latest'?

Anthony

> On Oct 31, 2016, at 12:13 PM, William Markito Oliveira 
>  wrote:
> 
> I've just updated our Docker image with 1.0.0-incubating bits, please
> evaluate.
> 
> There is also a pull request for review updating our Dockerfile to use
> 1.0.0-incubating and OpenJDK instead of Oracle.
> 
> - https://hub.docker.com/r/apachegeode/geode/tags/
> - https://github.com/apache/incubator-geode/pull/275
> 
> The following line gives you GFSH on a container:
> 
> docker run -it apachegeode/geode:1.0.0-incubating
> 
> But bash is also available:
> 
> docker run -it apachegeode/geode:1.0.0-incubating bash
> 
> I'm planning to contribute the compose and kubernetes scripts to Geode as
> well, if you guys think it's a good idea, but for now they're in my
> personal GitHub:
> 
> - https://github.com/markito/geode-docker
> - https://github.com/markito/geode-kubernetes
> 
> Thanks,
> --

Review Request 53311: GEODE-2045 Improve docs of region shortcuts

2016-10-31 Thread Karen Miller 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53311/
---

Review request for geode, Dave Barnes and Joey McAllister.


Repository: geode


Description
---

- Make sure that partitioned regions do not say or imply
that they have local scope.
- Fix labels with anchors, such that links work.
- Remove reference links to general descriptions of the
attributes used by the shortcuts.


Diffs
-

  geode-docs/reference/topics/region_shortcuts_reference.html.md.erb 
d5cb2fabdf8f8ce56b3bbf5dbf4706bb19e0742d 
  geode-docs/reference/topics/region_shortcuts_table.html.md.erb 
c0ead67b475742b05282b9f32df6e10296d94714 

Diff: https://reviews.apache.org/r/53311/diff/


Testing
---

gradle rat check passes


Thanks,

Karen Miller

Docker image for Geode 1.0.0-incubating - Please evaluate

2016-10-31 Thread William Markito Oliveira 
I've just updated our Docker image with 1.0.0-incubating bits, please
evaluate.

There is also a pull request for review updating our Dockerfile to use
1.0.0-incubating and OpenJDK instead of Oracle.

- https://hub.docker.com/r/apachegeode/geode/tags/
- https://github.com/apache/incubator-geode/pull/275

The following line gives you GFSH on a container:

docker run -it apachegeode/geode:1.0.0-incubating

But bash is also available:

docker run -it apachegeode/geode:1.0.0-incubating bash

I'm planning to contribute the compose and kubernetes scripts to Geode as
well, if you guys think it's a good idea, but for now they're in my
personal GitHub:

- https://github.com/markito/geode-docker
- https://github.com/markito/geode-kubernetes

Thanks,
--

Re: Review Request 53274: GEODE-1955: fix flaky tests by properly closing the gfsh instance in ConnectToLocatorSSLDUnitTest

2016-10-31 Thread Kirk Lund 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53274/#review154301
---




geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
 (line 34)


I really, really recommend not using the Java primitive wrappers as trinary 
variables.

A Boolean should be a true/false boolean as an object without this broken 
use of null. Boolean is by definition a binary. If you really have to have a 
tinary then please create a new enum or class:

public enum Source {
Locator, HTTP, RMI
}

Or whatever this is supposed to represent. The problem here is 
maintainability and clarity of purpose. I don't understand what you're doing or 
why without studying this code very closely. Everything should be very obvious 
and simple. GFSH and related code is already obfuscated well enough.


- Kirk Lund


On Oct. 28, 2016, 9:49 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53274/
> ---
> 
> (Updated Oct. 28, 2016, 9:49 p.m.)
> 
> 
> Review request for geode, Kevin Duling and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1955: fix flaky tests by properly closing the gfsh instance in 
> ConnectToLocatorSSLDUnitTest
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java
>  8426c6f52129472c9c0def172aeefd10f1491935 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsPostProcessorTest.java
>  d3390ba6ce2990d05516b701f82d5f176e6f4d49 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java
>  b2dc6fe334499456184e1d0cbc0297063d4c99ce 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
>  25780e67dd3f7920e53162ef9400d2845e4c958b 
> 
> Diff: https://reviews.apache.org/r/53274/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 53274: GEODE-1955: fix flaky tests by properly closing the gfsh instance in ConnectToLocatorSSLDUnitTest

2016-10-31 Thread Kirk Lund 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53274/#review154300
---



Use of the Rule should be cleaned up so everything is contained inside the 
Rule. Otherwise there's no value in trying to package this up as a Rule.


geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java
 (line 65)


This Rule isn't being used as a Rule so I'm confused?

This would be correct:

@Rule
public GfshShellConnectionRule gfshConnector = new 
GfshShellConnectionRule();

The before and after should be built into the Rule so lines #78-80 in 
after() wouldn't be necessary either.

If this is not being used as a Rule because some tests require different 
scaffolding from other tests, then the tests should be moved into a different 
test class.



geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java
 (line 84)


You should keep these as "throws Exception" -- if you're calling something 
that requires "throws Throwable" then we should change that class/method to 
"throws Exception"


- Kirk Lund


On Oct. 28, 2016, 9:49 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53274/
> ---
> 
> (Updated Oct. 28, 2016, 9:49 p.m.)
> 
> 
> Review request for geode, Kevin Duling and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1955: fix flaky tests by properly closing the gfsh instance in 
> ConnectToLocatorSSLDUnitTest
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java
>  8426c6f52129472c9c0def172aeefd10f1491935 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsPostProcessorTest.java
>  d3390ba6ce2990d05516b701f82d5f176e6f4d49 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java
>  b2dc6fe334499456184e1d0cbc0297063d4c99ce 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
>  25780e67dd3f7920e53162ef9400d2845e4c958b 
> 
> Diff: https://reviews.apache.org/r/53274/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

[GitHub] incubator-geode issue #275: [GEODE-1871] - Updating and cleaning up Dockerfi...

2016-10-31 Thread markito 
Github user markito commented on the issue:

https://github.com/apache/incubator-geode/pull/275
  
Done!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Build failed in Jenkins: Geode-nightly #639

2016-10-31 Thread Anthony Baker 
I updated the geode-examples dependency to 1.0.0-incubating.

Anthony

> On Oct 31, 2016, at 8:54 AM, Apache Jenkins Server 
>  wrote:
> 
> See 
> 
> --
> [...truncated 476 lines...]
> :geode-common:spotlessJavaCheck
> :geode-common:spotlessCheck
> :geode-common:test
> :geode-common:check
> :geode-common:build
> :geode-common:distributedTest
> :geode-common:flakyTest
> :geode-common:integrationTest
> :geode-core:assemble
> :geode-core:checkMissedTests
> :geode-core:spotlessJavaCheck
> :geode-core:spotlessCheck
> :geode-core:test
> :geode-core:check
> :geode-core:build
> :geode-core:distributedTest
> :geode-core:flakyTest
> :geode-core:integrationTest
> :geode-cq:assemble
> :geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
> API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 
> :geode-cq:processTestResources
> :geode-cq:testClasses
> :geode-cq:checkMissedTests
> :geode-cq:spotlessJavaCheck
> :geode-cq:spotlessCheck
> :geode-cq:test
> :geode-cq:check
> :geode-cq:build
> :geode-cq:distributedTest
> :geode-cq:flakyTest
> :geode-cq:integrationTest
> :geode-json:assemble
> :geode-json:compileTestJava UP-TO-DATE
> :geode-json:processTestResources UP-TO-DATE
> :geode-json:testClasses UP-TO-DATE
> :geode-json:checkMissedTests UP-TO-DATE
> :geode-json:spotlessJavaCheck
> :geode-json:spotlessCheck
> :geode-json:test UP-TO-DATE
> :geode-json:check
> :geode-json:build
> :geode-json:distributedTest UP-TO-DATE
> :geode-json:flakyTest UP-TO-DATE
> :geode-json:integrationTest UP-TO-DATE
> :geode-junit:javadoc
> :geode-junit:javadocJar
> :geode-junit:sourcesJar
> :geode-junit:signArchives SKIPPED
> :geode-junit:assemble
> :geode-junit:compileTestJava
> :geode-junit:processTestResources UP-TO-DATE
> :geode-junit:testClasses
> :geode-junit:checkMissedTests
> :geode-junit:spotlessJavaCheck
> :geode-junit:spotlessCheck
> :geode-junit:test
> :geode-junit:check
> :geode-junit:build
> :geode-junit:distributedTest
> :geode-junit:flakyTest
> :geode-junit:integrationTest
> :geode-lucene:assemble
> :geode-lucene:compileTestJavaNote: Some input files use or override a 
> deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 
> :geode-lucene:processTestResources
> :geode-lucene:testClasses
> :geode-lucene:checkMissedTests
> :geode-lucene:spotlessJavaCheck
> :geode-lucene:spotlessCheck
> :geode-lucene:test
> :geode-lucene:check
> :geode-lucene:build
> :geode-lucene:distributedTest
> :geode-lucene:flakyTest
> :geode-lucene:integrationTest
> :geode-old-client-support:assemble
> :geode-old-client-support:compileTestJava
> :geode-old-client-support:processTestResources UP-TO-DATE
> :geode-old-client-support:testClasses
> :geode-old-client-support:checkMissedTests
> :geode-old-client-support:spotlessJavaCheck
> :geode-old-client-support:spotlessCheck
> :geode-old-client-support:test
> :geode-old-client-support:check
> :geode-old-client-support:build
> :geode-old-client-support:distributedTest
> :geode-old-client-support:flakyTest
> :geode-old-client-support:integrationTest
> :geode-pulse:assemble
> :geode-pulse:compileTestJavaNote: 
> 
>  uses or overrides a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 
> :geode-pulse:processTestResources
> :geode-pulse:testClasses
> :geode-pulse:checkMissedTests
> :geode-pulse:spotlessJavaCheck
> :geode-pulse:spotlessCheck
> :geode-pulse:test
> :geode-pulse:check
> :geode-pulse:build
> :geode-pulse:distributedTest
> :geode-pulse:flakyTest
> :geode-pulse:integrationTest
> :geode-rebalancer:assemble
> :geode-rebalancer:compileTestJava
> :geode-rebalancer:processTestResources UP-TO-DATE
> :geode-rebalancer:testClasses
> :geode-rebalancer:checkMissedTests
> :geode-rebalancer:spotlessJavaCheck
> :geode-rebalancer:spotlessCheck
> :geode-rebalancer:test
> :geode-rebalancer:check
> :geode-rebalancer:build
> :geode-rebalancer:distributedTest
> :geode-rebalancer:flakyTest
> :geode-rebalancer:integrationTest
> :geode-wan:assemble
> :geode-wan:compileTestJavaNote: Some input files use or override a deprecated 
> API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 
> :geode-wan:processTestResources
> :geode-wan:testClasses
> :geode-wan:checkMissedTests
> :geode-wan:spotlessJavaCheck
> :geode-wan:spotlessCheck
> :geode-wan:test
>

Build failed in Jenkins: Geode-nightly #639

2016-10-31 Thread Apache Jenkins Server 
See 

--
[...truncated 476 lines...]
:geode-common:spotlessJavaCheck
:geode-common:spotlessCheck
:geode-common:test
:geode-common:check
:geode-common:build
:geode-common:distributedTest
:geode-common:flakyTest
:geode-common:integrationTest
:geode-core:assemble
:geode-core:checkMissedTests
:geode-core:spotlessJavaCheck
:geode-core:spotlessCheck
:geode-core:test
:geode-core:check
:geode-core:build
:geode-core:distributedTest
:geode-core:flakyTest
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources UP-TO-DATE
:geode-json:testClasses UP-TO-DATE
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJava
:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:flakyTest
:geode-old-client-support:integrationTest
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:flakyTest
:geode-pulse:integrationTest
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests
:geode-rebalancer:spotlessJavaCheck
:geode-rebalancer:spotlessCheck
:geode-rebalancer:test
:geode-rebalancer:check
:geode-rebalancer:build
:geode-rebalancer:distributedTest
:geode-rebalancer:flakyTest
:geode-rebalancer:integrationTest
:geode-wan:assemble
:geode-wan:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-wan:processTestResources
:geode-wan:testClasses
:geode-wan:checkMissedTests
:geode-wan:spotlessJavaCheck
:geode-wan:spotlessCheck
:geode-wan:test
:geode-wan:check
:geode-wan:build
:geode-wan:distributedTest
:geode-wan:flakyTest
:geode-wan:integrationTest
:geode-web:assemble
:geode-web:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-web:processTestResources UP-TO-DATE
:geode-web:testClasses

Badge for your apachegeode/geode image

2016-10-31 Thread Liz Rice 
We saw your image on Docker Hub at href="https://hub.docker.com/r/apachegeode/geode;>apachegeode/geode,  
and we thought you might

like this badge for your Docker Hub page showing the image contents.

The badge shows the number of layers and download size of your Docker
image, and links to our site where you can see the href="https://microbadger.com/images/apachegeode/geode?utm_source=dhmaintnonauto_medium=email_campaign=microbadgeril;>contents  
of each layer.


If you'd like to use our badge here's the markdown - you can simply paste
this into the full description for href="https://hub.docker.com/r/apachegeode/geode;>apachegeode/geode on  
Docker Hub.



[![](https://images.microbadger.com/badges/image/apachegeode/geode.svg)](https://microbadger.com/images/apachegeode/geode "Get  
your  
own image badge on microbadger.com")


If you have any questions, problems or feedback please just hit reply, or
let us know through our issues list.

Best regards,
Liz, Anne & Ross
Microscaling Systems

[GitHub] incubator-geode pull request #:

2016-10-31 Thread vectorijk 
Github user vectorijk commented on the pull request:


https://github.com/apache/incubator-geode/commit/c1216eb1817df3c6b20afbaff49ba30e76d34b44#commitcomment-19630739
  
@upthewaterspout Should we update version number to 
`1.1.0-incubating-SNAPSHOT`?
Also, I have a question about publishing the jars to local 
repository(mentioned in 
[building.md](https://github.com/apache/incubator-geode/blob/develop/geode-spark-connector/doc/1_building.md#building-artifacts)
 )? Do we need that?
Cause I can't build spark-connector use local jars, it said sbt can't find 
`org.apache.geode#geode-core;1.1.0-incubating-SNAPSHOT`
``` 
[warn]  ::
[warn]  ::  UNRESOLVED DEPENDENCIES ::
[warn]  ::
[warn]  :: org.apache.geode#geode-core;1.1.0-incubating-SNAPSHOT: 
java.lang.NullPointerException at 
sbt.ivyint.SbtChainResolver$$anonfun$9.apply(SbtChainResolver.scala:114)
[warn]  ::
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---