[GitHub] incubator-geode issue #183: GEODE-1615: gfsh unable to destroy region that h...

2016-07-01 Thread kjduling
Github user kjduling commented on the issue:

https://github.com/apache/incubator-geode/pull/183
  
Closing this.  The test worked the first time, but subsequent runs 
consistently fail.  I'll start a fresh pull request once I resolve it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-geode issue #183: GEODE-1615: gfsh unable to destroy region that h...

2016-07-01 Thread jinmeiliao
Github user jinmeiliao commented on the issue:

https://github.com/apache/incubator-geode/pull/183
  
For now, add at least a test that would cover deleting a region that has 
"-" and "_" in it. Later, you can expand your tests that would have all sorts 
of allowed characters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-geode issue #183: GEODE-1615: gfsh unable to destroy region that h...

2016-07-01 Thread kjduling
Github user kjduling commented on the issue:

https://github.com/apache/incubator-geode/pull/183
  
I'm doing the test in a separate checkin once I have a final decision on 
what characters are valid.  Right now, it appears only alphanumeric, an 
underscore, and a hyphen are the only valid characters allowed.  Yet we can 
create regions with all sorts of characters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-geode issue #183: GEODE-1615: gfsh unable to destroy region that h...

2016-06-30 Thread jinmeiliao
Github user jinmeiliao commented on the issue:

https://github.com/apache/incubator-geode/pull/183
  
the fix looks good. Where is the test?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---