Re: Review Request 36454: Typecast ambiguous logger arguments to allow JDK 8 compilation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36454/#review91534 --- Ship it! Looks good - thanks for taking care of this Kirk - Bruce Schuchardt On July 13, 2015, 8:44 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36454/ > --- > > (Updated July 13, 2015, 8:44 p.m.) > > > Review request for geode and Bruce Schuchardt. > > > Bugs: GEODE-94 > https://issues.apache.org/jira/browse/GEODE-94 > > > Repository: geode > > > Description > --- > > A small number of log statements have an ambiguous argument under JDK 1.8. > Casting these to (Object) fixes compilation. > > > Diffs > - > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/jgroup/JGroupMembershipManager.java > 9c2d9fd > gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/FRAG2.java > 0749859 > gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/SMACK.java > 95ca1f1 > > gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/UDP_NIO.java > 573d461 > > gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/VIEW_ENFORCER.java > 426b8b4 > > Diff: https://reviews.apache.org/r/36454/diff/ > > > Testing > --- > > Run existing UnitTest, IntegrationTest, DistributedTest suites > > > Thanks, > > Kirk Lund > >
Re: Review Request 36454: Typecast ambiguous logger arguments to allow JDK 8 compilation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36454/#review91524 --- Ship it! Ship It! - Dan Smith On July 13, 2015, 8:44 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36454/ > --- > > (Updated July 13, 2015, 8:44 p.m.) > > > Review request for geode and Bruce Schuchardt. > > > Bugs: GEODE-94 > https://issues.apache.org/jira/browse/GEODE-94 > > > Repository: geode > > > Description > --- > > A small number of log statements have an ambiguous argument under JDK 1.8. > Casting these to (Object) fixes compilation. > > > Diffs > - > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/jgroup/JGroupMembershipManager.java > 9c2d9fd > gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/FRAG2.java > 0749859 > gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/SMACK.java > 95ca1f1 > > gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/UDP_NIO.java > 573d461 > > gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/VIEW_ENFORCER.java > 426b8b4 > > Diff: https://reviews.apache.org/r/36454/diff/ > > > Testing > --- > > Run existing UnitTest, IntegrationTest, DistributedTest suites > > > Thanks, > > Kirk Lund > >
Review Request 36454: Typecast ambiguous logger arguments to allow JDK 8 compilation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36454/ --- Review request for geode. Bugs: GEODE-94 https://issues.apache.org/jira/browse/GEODE-94 Repository: geode Description --- A small number of log statements have an ambiguous argument under JDK 1.8. Casting these to (Object) fixes compilation. Diffs - gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/jgroup/JGroupMembershipManager.java 9c2d9fd gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/FRAG2.java 0749859 gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/SMACK.java 95ca1f1 gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/UDP_NIO.java 573d461 gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/VIEW_ENFORCER.java 426b8b4 Diff: https://reviews.apache.org/r/36454/diff/ Testing --- Run existing UnitTest, IntegrationTest, DistributedTest suites Thanks, Kirk Lund
