Re: Review Request 36950: [GEODE-177] Adding Dockerfile to Geode codebase

2015-08-03 Thread Kirk Lund 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36950/#review93916
---

Ship it!


Ship It!

- Kirk Lund


On July 31, 2015, 12:13 a.m., William Markito wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36950/
> ---
> 
> (Updated July 31, 2015, 12:13 a.m.)
> 
> 
> Review request for geode.
> 
> 
> Bugs: GEODE-177
> https://issues.apache.org/jira/browse/GEODE-177
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding Dockerfile to Geode codebase
> 
> 
> Diffs
> -
> 
>   docker/Dockerfile PRE-CREATION 
>   docker/README.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36950/diff/
> 
> 
> Testing
> ---
> 
> Build executed under Dockerhub
> 
> 
> Thanks,
> 
> William Markito
> 
>

Re: Review Request 36950: [GEODE-177] Adding Dockerfile to Geode codebase

2015-08-02 Thread Mark Bretl 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36950/#review93864
---

Ship it!


Ship It!

- Mark Bretl


On July 31, 2015, 12:13 a.m., William Markito wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36950/
> ---
> 
> (Updated July 31, 2015, 12:13 a.m.)
> 
> 
> Review request for geode.
> 
> 
> Bugs: GEODE-177
> https://issues.apache.org/jira/browse/GEODE-177
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding Dockerfile to Geode codebase
> 
> 
> Diffs
> -
> 
>   docker/Dockerfile PRE-CREATION 
>   docker/README.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36950/diff/
> 
> 
> Testing
> ---
> 
> Build executed under Dockerhub
> 
> 
> Thanks,
> 
> William Markito
> 
>

Re: Review Request 36950: [GEODE-177] Adding Dockerfile to Geode codebase

2015-07-30 Thread William Markito 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36950/
---

(Updated July 31, 2015, 12:13 a.m.)


Review request for geode.


Bugs: GEODE-177
https://issues.apache.org/jira/browse/GEODE-177


Repository: geode


Description
---

Adding Dockerfile to Geode codebase


Diffs (updated)
-

  docker/Dockerfile PRE-CREATION 
  docker/README.md PRE-CREATION 

Diff: https://reviews.apache.org/r/36950/diff/


Testing
---

Build executed under Dockerhub


Thanks,

William Markito

Re: Review Request 36950: [GEODE-177] Adding Dockerfile to Geode codebase

2015-07-30 Thread William Markito 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36950/
---

(Updated July 30, 2015, 11:25 p.m.)


Review request for geode.


Bugs: GEODE-177
https://issues.apache.org/jira/browse/GEODE-177


Repository: geode


Description
---

Adding Dockerfile to Geode codebase


Diffs (updated)
-

  docker/Dockerfile PRE-CREATION 
  docker/README.md PRE-CREATION 

Diff: https://reviews.apache.org/r/36950/diff/


Testing
---

Build executed under Dockerhub


Thanks,

William Markito

Re: Review Request 36950: [GEODE-177] Adding Dockerfile to Geode codebase

2015-07-30 Thread Kirk Lund 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36950/#review93662
---



docker/Dockerfile (line 20)


Is it possible to use $JAVA_HOME here instead of hardcoding references to 
/jdk1.8.0_51?


- Kirk Lund


On July 30, 2015, 8:52 p.m., William Markito wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36950/
> ---
> 
> (Updated July 30, 2015, 8:52 p.m.)
> 
> 
> Review request for geode.
> 
> 
> Bugs: GEODE-177
> https://issues.apache.org/jira/browse/GEODE-177
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding Dockerfile to Geode codebase
> 
> 
> Diffs
> -
> 
>   docker/Dockerfile PRE-CREATION 
>   docker/README.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36950/diff/
> 
> 
> Testing
> ---
> 
> Build executed under Dockerhub
> 
> 
> Thanks,
> 
> William Markito
> 
>

Re: Review Request 36950: [GEODE-177] Adding Dockerfile to Geode codebase

2015-07-30 Thread William Markito 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36950/
---

(Updated July 30, 2015, 8:52 p.m.)


Review request for geode.


Changes
---

Fixing docker tag in documentation


Bugs: GEODE-177
https://issues.apache.org/jira/browse/GEODE-177


Repository: geode


Description
---

Adding Dockerfile to Geode codebase


Diffs (updated)
-

  docker/Dockerfile PRE-CREATION 
  docker/README.md PRE-CREATION 

Diff: https://reviews.apache.org/r/36950/diff/


Testing
---

Build executed under Dockerhub


Thanks,

William Markito

Re: Review Request 36950: [GEODE-177] Adding Dockerfile to Geode codebase

2015-07-30 Thread Mark Bretl 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36950/#review93638
---



docker/README.md (line 6)


Should this be apachegeode/geode:unstable, since the DockerFile references 
'LABEL unstable'?



docker/README.md (line 16)


Same issue as above...

apachegeode/geode:nightly -> apachegeode/geode:unstable


- Mark Bretl


On July 30, 2015, 8:21 p.m., William Markito wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36950/
> ---
> 
> (Updated July 30, 2015, 8:21 p.m.)
> 
> 
> Review request for geode.
> 
> 
> Bugs: GEODE-177
> https://issues.apache.org/jira/browse/GEODE-177
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding Dockerfile to Geode codebase
> 
> 
> Diffs
> -
> 
>   docker/Dockerfile PRE-CREATION 
>   docker/README.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36950/diff/
> 
> 
> Testing
> ---
> 
> Build executed under Dockerhub
> 
> 
> Thanks,
> 
> William Markito
> 
>

Review Request 36950: [GEODE-177] Adding Dockerfile to Geode codebase

2015-07-30 Thread William Markito 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36950/
---

Review request for geode.


Bugs: GEODE-177
https://issues.apache.org/jira/browse/GEODE-177


Repository: geode


Description
---

Adding Dockerfile to Geode codebase


Diffs
-

  docker/Dockerfile PRE-CREATION 
  docker/README.md PRE-CREATION 

Diff: https://reviews.apache.org/r/36950/diff/


Testing
---

Build executed under Dockerhub


Thanks,

William Markito