Re: Review Request 53331: GEODE-2047 Document change to enable-network-partition-detection

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53331/#review154423
---


Ship it!




Ship It!

- Bruce Schuchardt


On Nov. 1, 2016, 4:02 p.m., Karen Miller wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53331/
> ---
> 
> (Updated Nov. 1, 2016, 4:02 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Dave Barnes, and Joey McAllister.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - This is a subtask of GEODE-762.
> - The default value of property enable-network-partition-detection
> changed from false to true, enabling partition detection by
> default, so all documentation that discusses partition detection
> also needs to change.
> - Fixed a minor typo or two encountered in the files that were
> being updated.
> 
> 
> Diffs
> -
> 
>   
> geode-docs/managing/troubleshooting/recovering_conflicting_data_exceptions.html.md.erb
>  38375aea1e5742d878d1e7dbaf3c92d67320d17f 
>   
> geode-docs/managing/troubleshooting/recovering_from_network_outages.html.md.erb
>  8c23beac365af0f8f917b13447c2ae6382ad2525 
>   geode-docs/reference/topics/gemfire_properties.html.md.erb 
> 988256840a084cac56a4e38723415a4c4ea2d99f 
> 
> Diff: https://reviews.apache.org/r/53331/diff/
> 
> 
> Testing
> ---
> 
> gradle rat check passes
> 
> 
> Thanks,
> 
> Karen Miller
> 
>

Re: Review Request 53331: GEODE-2047 Document change to enable-network-partition-detection

[Dave Barnes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53331/#review154415
---


Ship it!




Ship It!

- Dave Barnes


On Nov. 1, 2016, 4:02 p.m., Karen Miller wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53331/
> ---
> 
> (Updated Nov. 1, 2016, 4:02 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Dave Barnes, and Joey McAllister.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - This is a subtask of GEODE-762.
> - The default value of property enable-network-partition-detection
> changed from false to true, enabling partition detection by
> default, so all documentation that discusses partition detection
> also needs to change.
> - Fixed a minor typo or two encountered in the files that were
> being updated.
> 
> 
> Diffs
> -
> 
>   
> geode-docs/managing/troubleshooting/recovering_conflicting_data_exceptions.html.md.erb
>  38375aea1e5742d878d1e7dbaf3c92d67320d17f 
>   
> geode-docs/managing/troubleshooting/recovering_from_network_outages.html.md.erb
>  8c23beac365af0f8f917b13447c2ae6382ad2525 
>   geode-docs/reference/topics/gemfire_properties.html.md.erb 
> 988256840a084cac56a4e38723415a4c4ea2d99f 
> 
> Diff: https://reviews.apache.org/r/53331/diff/
> 
> 
> Testing
> ---
> 
> gradle rat check passes
> 
> 
> Thanks,
> 
> Karen Miller
> 
>

Re: Review Request 53331: GEODE-2047 Document change to enable-network-partition-detection

[Karen Miller]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53331/
---

(Updated Nov. 1, 2016, 4:02 p.m.)


Review request for geode, Bruce Schuchardt, Dave Barnes, and Joey McAllister.


Repository: geode


Description
---

- This is a subtask of GEODE-762.
- The default value of property enable-network-partition-detection
changed from false to true, enabling partition detection by
default, so all documentation that discusses partition detection
also needs to change.
- Fixed a minor typo or two encountered in the files that were
being updated.


Diffs (updated)
-

  
geode-docs/managing/troubleshooting/recovering_conflicting_data_exceptions.html.md.erb
 38375aea1e5742d878d1e7dbaf3c92d67320d17f 
  
geode-docs/managing/troubleshooting/recovering_from_network_outages.html.md.erb 
8c23beac365af0f8f917b13447c2ae6382ad2525 
  geode-docs/reference/topics/gemfire_properties.html.md.erb 
988256840a084cac56a4e38723415a4c4ea2d99f 

Diff: https://reviews.apache.org/r/53331/diff/


Testing
---

gradle rat check passes


Thanks,

Karen Miller

Re: Review Request 53331: GEODE-2047 Document change to enable-network-partition-detection

[Joey McAllister]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53331/#review154352
---




geode-docs/managing/troubleshooting/recovering_conflicting_data_exceptions.html.md.erb
 (line 49)


I recommend something like "is set to the default value of true" or "has 
the default value of true" here, to avoid conflating the definition of the 
property (what it is) and its value (what it is assigned).



geode-docs/managing/troubleshooting/recovering_from_network_outages.html.md.erb 
(line 58)


"must be set to true if"



geode-docs/reference/topics/gemfire_properties.html.md.erb (line 163)


"this property must be set to true if"


- Joey McAllister


On Oct. 31, 2016, 11:57 p.m., Karen Miller wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53331/
> ---
> 
> (Updated Oct. 31, 2016, 11:57 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Dave Barnes, and Joey McAllister.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - This is a subtask of GEODE-762.
> - The default value of property enable-network-partition-detection
> changed from false to true, enabling partition detection by
> default, so all documentation that discusses partition detection
> also needs to change.
> - Fixed a minor typo or two encountered in the files that were
> being updated.
> 
> 
> Diffs
> -
> 
>   
> geode-docs/managing/network_partitioning/handling_network_partitioning.html.md.erb
>  61a25760265771ba3e53c271731af6e44f5e72ee 
>   
> geode-docs/managing/network_partitioning/how_network_partitioning_management_works.html.md.erb
>  e97163401f967f672eea8e7889f8991d971b4145 
>   
> geode-docs/managing/troubleshooting/recovering_conflicting_data_exceptions.html.md.erb
>  38375aea1e5742d878d1e7dbaf3c92d67320d17f 
>   
> geode-docs/managing/troubleshooting/recovering_from_network_outages.html.md.erb
>  8c23beac365af0f8f917b13447c2ae6382ad2525 
>   geode-docs/managing/troubleshooting/system_failure_and_recovery.html.md.erb 
> d94ea604cdbe1f3ea1e41b8b7172bb825fdb7b38 
>   geode-docs/reference/topics/gemfire_properties.html.md.erb 
> 988256840a084cac56a4e38723415a4c4ea2d99f 
> 
> Diff: https://reviews.apache.org/r/53331/diff/
> 
> 
> Testing
> ---
> 
> gradle rat check passes
> 
> 
> Thanks,
> 
> Karen Miller
> 
>

Review Request 53331: GEODE-2047 Document change to enable-network-partition-detection

[Karen Miller]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53331/
---

Review request for geode, Bruce Schuchardt, Dave Barnes, and Joey McAllister.


Repository: geode


Description
---

- This is a subtask of GEODE-762.
- The default value of property enable-network-partition-detection
changed from false to true, enabling partition detection by
default, so all documentation that discusses partition detection
also needs to change.
- Fixed a minor typo or two encountered in the files that were
being updated.


Diffs
-

  
geode-docs/managing/network_partitioning/handling_network_partitioning.html.md.erb
 61a25760265771ba3e53c271731af6e44f5e72ee 
  
geode-docs/managing/network_partitioning/how_network_partitioning_management_works.html.md.erb
 e97163401f967f672eea8e7889f8991d971b4145 
  
geode-docs/managing/troubleshooting/recovering_conflicting_data_exceptions.html.md.erb
 38375aea1e5742d878d1e7dbaf3c92d67320d17f 
  
geode-docs/managing/troubleshooting/recovering_from_network_outages.html.md.erb 
8c23beac365af0f8f917b13447c2ae6382ad2525 
  geode-docs/managing/troubleshooting/system_failure_and_recovery.html.md.erb 
d94ea604cdbe1f3ea1e41b8b7172bb825fdb7b38 
  geode-docs/reference/topics/gemfire_properties.html.md.erb 
988256840a084cac56a4e38723415a4c4ea2d99f 

Diff: https://reviews.apache.org/r/53331/diff/


Testing
---

gradle rat check passes


Thanks,

Karen Miller