Re: Review Request 53661: GEODE-2094 Update admin/dev REST API documentation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53661/#review155747 --- Ship it! Ship It! - Jinmei Liao On Nov. 11, 2016, 5:37 p.m., Karen Miller wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53661/ > --- > > (Updated Nov. 11, 2016, 5:37 p.m.) > > > Review request for geode, Dave Barnes, Jinmei Liao, Joey McAllister, and > Kevin Duling. > > > Repository: geode > > > Description > --- > > - Add 3 missing gfsh start server options: > --http-service-port > --http-service-bind-address > --start-rest-api > > - Update examples to use these options, instead of using > the older --J=-gemfire. specification. > > > Diffs > - > > geode-docs/rest_apps/setup_config.html.md.erb > 604dd059290f8da41e2e05e0946e6a7eaa01e6ca > > Diff: https://reviews.apache.org/r/53661/diff/ > > > Testing > --- > > gradle rat check passes > > > Thanks, > > Karen Miller > >
Re: Review Request 53661: GEODE-2094 Update admin/dev REST API documentation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53661/#review155729 --- Ship it! Ship It! - Joey McAllister On Nov. 11, 2016, 5:37 p.m., Karen Miller wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53661/ > --- > > (Updated Nov. 11, 2016, 5:37 p.m.) > > > Review request for geode, Dave Barnes, Jinmei Liao, Joey McAllister, and > Kevin Duling. > > > Repository: geode > > > Description > --- > > - Add 3 missing gfsh start server options: > --http-service-port > --http-service-bind-address > --start-rest-api > > - Update examples to use these options, instead of using > the older --J=-gemfire. specification. > > > Diffs > - > > geode-docs/rest_apps/setup_config.html.md.erb > 604dd059290f8da41e2e05e0946e6a7eaa01e6ca > > Diff: https://reviews.apache.org/r/53661/diff/ > > > Testing > --- > > gradle rat check passes > > > Thanks, > > Karen Miller > >
Re: Review Request 53661: GEODE-2094 Update admin/dev REST API documentation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53661/ --- (Updated Nov. 11, 2016, 5:37 p.m.) Review request for geode, Dave Barnes, Jinmei Liao, Joey McAllister, and Kevin Duling. Changes --- Fixes error pointed out in a review, and corrects the name of the property (which still has the "-dev" in it) Repository: geode Description --- - Add 3 missing gfsh start server options: --http-service-port --http-service-bind-address --start-rest-api - Update examples to use these options, instead of using the older --J=-gemfire. specification. Diffs (updated) - geode-docs/rest_apps/setup_config.html.md.erb 604dd059290f8da41e2e05e0946e6a7eaa01e6ca Diff: https://reviews.apache.org/r/53661/diff/ Testing --- gradle rat check passes Thanks, Karen Miller
Re: Review Request 53661: GEODE-2094 Update admin/dev REST API documentation
> On Nov. 10, 2016, 11:48 p.m., Dave Barnes wrote: > > I noticed one variation to the pattern: In > > geode-docs/rest_apps/setup_config.html.md.erb at line 100, did you miss one > > conversion of start-dev-rest-api to start-rest-api, or was this intentional? Good catch. I'll append a fix for that to this review. - Karen --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53661/#review155668 --- On Nov. 10, 2016, 10:44 p.m., Karen Miller wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53661/ > --- > > (Updated Nov. 10, 2016, 10:44 p.m.) > > > Review request for geode, Dave Barnes, Jinmei Liao, Joey McAllister, and > Kevin Duling. > > > Repository: geode > > > Description > --- > > - Add 3 missing gfsh start server options: > --http-service-port > --http-service-bind-address > --start-rest-api > > - Update examples to use these options, instead of using > the older --J=-gemfire. specification. > > > Diffs > - > > geode-docs/configuring/cluster_config/gfsh_remote.html.md.erb > c8ea24096c76a5c03bd7a902d225ee4566932b29 > geode-docs/rest_apps/setup_config.html.md.erb > 604dd059290f8da41e2e05e0946e6a7eaa01e6ca > geode-docs/tools_modules/gfsh/command-pages/start.html.md.erb > ff703cb4a7fc49a1bffa92cf9cc2207a6cce2d32 > > Diff: https://reviews.apache.org/r/53661/diff/ > > > Testing > --- > > gradle rat check passes > > > Thanks, > > Karen Miller > >
Re: Review Request 53661: GEODE-2094 Update admin/dev REST API documentation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53661/#review155668 --- I noticed one variation to the pattern: In geode-docs/rest_apps/setup_config.html.md.erb at line 100, did you miss one conversion of start-dev-rest-api to start-rest-api, or was this intentional? - Dave Barnes On Nov. 10, 2016, 10:44 p.m., Karen Miller wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53661/ > --- > > (Updated Nov. 10, 2016, 10:44 p.m.) > > > Review request for geode, Dave Barnes, Jinmei Liao, Joey McAllister, and > Kevin Duling. > > > Repository: geode > > > Description > --- > > - Add 3 missing gfsh start server options: > --http-service-port > --http-service-bind-address > --start-rest-api > > - Update examples to use these options, instead of using > the older --J=-gemfire. specification. > > > Diffs > - > > geode-docs/configuring/cluster_config/gfsh_remote.html.md.erb > c8ea24096c76a5c03bd7a902d225ee4566932b29 > geode-docs/rest_apps/setup_config.html.md.erb > 604dd059290f8da41e2e05e0946e6a7eaa01e6ca > geode-docs/tools_modules/gfsh/command-pages/start.html.md.erb > ff703cb4a7fc49a1bffa92cf9cc2207a6cce2d32 > > Diff: https://reviews.apache.org/r/53661/diff/ > > > Testing > --- > > gradle rat check passes > > > Thanks, > > Karen Miller > >
Review Request 53661: GEODE-2094 Update admin/dev REST API documentation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53661/ --- Review request for geode, Dave Barnes, Jinmei Liao, Joey McAllister, and Kevin Duling. Repository: geode Description --- - Add 3 missing gfsh start server options: --http-service-port --http-service-bind-address --start-rest-api - Update examples to use these options, instead of using the older --J=-gemfire. specification. Diffs - geode-docs/configuring/cluster_config/gfsh_remote.html.md.erb c8ea24096c76a5c03bd7a902d225ee4566932b29 geode-docs/rest_apps/setup_config.html.md.erb 604dd059290f8da41e2e05e0946e6a7eaa01e6ca geode-docs/tools_modules/gfsh/command-pages/start.html.md.erb ff703cb4a7fc49a1bffa92cf9cc2207a6cce2d32 Diff: https://reviews.apache.org/r/53661/diff/ Testing --- gradle rat check passes Thanks, Karen Miller
