Re: Valid characters in region names?

2016-06-30 Thread William Markito
We already discussed this on the previous thread and got general consensus
on getting "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz12345678
90_-" for Geode...  Anything other than this can be problematic for JMX and
other components that will then require special treatment to handle unusual
chars.

If any user is coming from GemFire , they still can use snapshots to
export/import data into the new regions.

I'd also recommend enforcing the rules for region creation in all possible
APIs, for consistency...  (GFSH, cache.xml, RegionFactory...)

On Thu, Jun 30, 2016 at 4:49 PM, Anilkumar Gingade 
wrote:

> Here is what GemFire docs states about region names:
>
>
> http://gemfire.docs.pivotal.io/docs-gemfire/latest/basic_config/data_regions/region_naming.html
>
> But again, we have supported other chars as part of region names...
>
> The Query engine allows/detects region name with:  "_", “+”, “-“, “:”, “#”,
> “@“, “$”.
>
> -Anil.
>
>
>
>
> On Thu, Jun 30, 2016 at 11:03 AM, Kevin Duling  wrote:
>
> > I'm working on a bug where it is not possible to delete a region that
> has a
> > hyphen in it.  E.g., the region was created with:
> >
> > create region --name=not-good --type=REPLICATE
> >
> > I've a solution done, but see this as an opportunity to add a test for
> > other special characters.  Is there a list of valid and invalid
> characters
> > for a region name?
> >
>



-- 

~/William


Re: Valid characters in region names?

2016-06-30 Thread Anilkumar Gingade
Here is what GemFire docs states about region names:

http://gemfire.docs.pivotal.io/docs-gemfire/latest/basic_config/data_regions/region_naming.html

But again, we have supported other chars as part of region names...

The Query engine allows/detects region name with:  "_", “+”, “-“, “:”, “#”,
“@“, “$”.

-Anil.




On Thu, Jun 30, 2016 at 11:03 AM, Kevin Duling  wrote:

> I'm working on a bug where it is not possible to delete a region that has a
> hyphen in it.  E.g., the region was created with:
>
> create region --name=not-good --type=REPLICATE
>
> I've a solution done, but see this as an opportunity to add a test for
> other special characters.  Is there a list of valid and invalid characters
> for a region name?
>


Re: Valid characters in region names?

2016-06-30 Thread Karen Miller
Here is the page of the documentation on region naming:

http://docs-geode-develop.cfapps.io/docs/basic_config/data_regions/region_naming.html

I'm guessing that a JIRA for also including a dash was not implemented.
When you find the
JIRA number, please post it on this thread.


On Thu, Jun 30, 2016 at 12:57 PM, Kevin Duling  wrote:

> Do you know if a Jira ticket was opened on it?  I'm currently working on
> https://issues.apache.org/jira/browse/GEODE-1615 and would like to link to
> it.
>
> On Thu, Jun 30, 2016 at 12:38 PM, Michael Stolz  wrote:
>
> > Yes we did discuss adding hyphen in Geode, and we discussed actually
> > checking during create.
> >
> > --
> > Mike Stolz
> > Principal Engineer, GemFire Product Manager
> > Mobile: 631-835-4771
> >
> > On Thu, Jun 30, 2016 at 3:30 PM, Kevin Duling 
> wrote:
> >
> > > I found a thread from March of this year where this was discussed and
> '-'
> > > is also included in that list.
> > >
> > > Shouldn't the creation of a region with an invalid character raise an
> > > exception?  I'm finding that I can create and list regions with a
> variety
> > > of non-alphanumeric characters.  But I can only destroy a subset of
> > those.
> > >
> > >  It appears to be because some are created with quotes around the
> region
> > > name.
> > >
> > > E.g.,
> > >
> > > service=Region, name=/good, type=Member
> > > service=Region, name="/not*good", type=Member
> > >
> > > The name lookup fails in the Destroy call.  The rule that applied the
> > > quotes for /not*good during Create isn't applied in Destroy
> > >
> > > On Thu, Jun 30, 2016 at 12:06 PM, Michael Stolz 
> > wrote:
> > >
> > > > The only characters that should be used in Region names are
> > > > ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz1234567890_
> > > >
> > > > --
> > > > Mike Stolz
> > > > Principal Engineer, GemFire Product Manager
> > > > Mobile: 631-835-4771
> > > >
> > > > On Thu, Jun 30, 2016 at 2:03 PM, Kevin Duling 
> > > wrote:
> > > >
> > > > > I'm working on a bug where it is not possible to delete a region
> that
> > > > has a
> > > > > hyphen in it.  E.g., the region was created with:
> > > > >
> > > > > create region --name=not-good --type=REPLICATE
> > > > >
> > > > > I've a solution done, but see this as an opportunity to add a test
> > for
> > > > > other special characters.  Is there a list of valid and invalid
> > > > characters
> > > > > for a region name?
> > > > >
> > > >
> > >
> >
>


Re: Valid characters in region names?

2016-06-30 Thread Kevin Duling
Do you know if a Jira ticket was opened on it?  I'm currently working on
https://issues.apache.org/jira/browse/GEODE-1615 and would like to link to
it.

On Thu, Jun 30, 2016 at 12:38 PM, Michael Stolz  wrote:

> Yes we did discuss adding hyphen in Geode, and we discussed actually
> checking during create.
>
> --
> Mike Stolz
> Principal Engineer, GemFire Product Manager
> Mobile: 631-835-4771
>
> On Thu, Jun 30, 2016 at 3:30 PM, Kevin Duling  wrote:
>
> > I found a thread from March of this year where this was discussed and '-'
> > is also included in that list.
> >
> > Shouldn't the creation of a region with an invalid character raise an
> > exception?  I'm finding that I can create and list regions with a variety
> > of non-alphanumeric characters.  But I can only destroy a subset of
> those.
> >
> >  It appears to be because some are created with quotes around the region
> > name.
> >
> > E.g.,
> >
> > service=Region, name=/good, type=Member
> > service=Region, name="/not*good", type=Member
> >
> > The name lookup fails in the Destroy call.  The rule that applied the
> > quotes for /not*good during Create isn't applied in Destroy
> >
> > On Thu, Jun 30, 2016 at 12:06 PM, Michael Stolz 
> wrote:
> >
> > > The only characters that should be used in Region names are
> > > ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz1234567890_
> > >
> > > --
> > > Mike Stolz
> > > Principal Engineer, GemFire Product Manager
> > > Mobile: 631-835-4771
> > >
> > > On Thu, Jun 30, 2016 at 2:03 PM, Kevin Duling 
> > wrote:
> > >
> > > > I'm working on a bug where it is not possible to delete a region that
> > > has a
> > > > hyphen in it.  E.g., the region was created with:
> > > >
> > > > create region --name=not-good --type=REPLICATE
> > > >
> > > > I've a solution done, but see this as an opportunity to add a test
> for
> > > > other special characters.  Is there a list of valid and invalid
> > > characters
> > > > for a region name?
> > > >
> > >
> >
>


Re: Valid characters in region names?

2016-06-30 Thread Michael Stolz
Yes we did discuss adding hyphen in Geode, and we discussed actually
checking during create.

--
Mike Stolz
Principal Engineer, GemFire Product Manager
Mobile: 631-835-4771

On Thu, Jun 30, 2016 at 3:30 PM, Kevin Duling  wrote:

> I found a thread from March of this year where this was discussed and '-'
> is also included in that list.
>
> Shouldn't the creation of a region with an invalid character raise an
> exception?  I'm finding that I can create and list regions with a variety
> of non-alphanumeric characters.  But I can only destroy a subset of those.
>
>  It appears to be because some are created with quotes around the region
> name.
>
> E.g.,
>
> service=Region, name=/good, type=Member
> service=Region, name="/not*good", type=Member
>
> The name lookup fails in the Destroy call.  The rule that applied the
> quotes for /not*good during Create isn't applied in Destroy
>
> On Thu, Jun 30, 2016 at 12:06 PM, Michael Stolz  wrote:
>
> > The only characters that should be used in Region names are
> > ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz1234567890_
> >
> > --
> > Mike Stolz
> > Principal Engineer, GemFire Product Manager
> > Mobile: 631-835-4771
> >
> > On Thu, Jun 30, 2016 at 2:03 PM, Kevin Duling 
> wrote:
> >
> > > I'm working on a bug where it is not possible to delete a region that
> > has a
> > > hyphen in it.  E.g., the region was created with:
> > >
> > > create region --name=not-good --type=REPLICATE
> > >
> > > I've a solution done, but see this as an opportunity to add a test for
> > > other special characters.  Is there a list of valid and invalid
> > characters
> > > for a region name?
> > >
> >
>


Re: Valid characters in region names?

2016-06-30 Thread Kevin Duling
I found a thread from March of this year where this was discussed and '-'
is also included in that list.

Shouldn't the creation of a region with an invalid character raise an
exception?  I'm finding that I can create and list regions with a variety
of non-alphanumeric characters.  But I can only destroy a subset of those.

 It appears to be because some are created with quotes around the region
name.

E.g.,

service=Region, name=/good, type=Member
service=Region, name="/not*good", type=Member

The name lookup fails in the Destroy call.  The rule that applied the
quotes for /not*good during Create isn't applied in Destroy

On Thu, Jun 30, 2016 at 12:06 PM, Michael Stolz  wrote:

> The only characters that should be used in Region names are
> ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz1234567890_
>
> --
> Mike Stolz
> Principal Engineer, GemFire Product Manager
> Mobile: 631-835-4771
>
> On Thu, Jun 30, 2016 at 2:03 PM, Kevin Duling  wrote:
>
> > I'm working on a bug where it is not possible to delete a region that
> has a
> > hyphen in it.  E.g., the region was created with:
> >
> > create region --name=not-good --type=REPLICATE
> >
> > I've a solution done, but see this as an opportunity to add a test for
> > other special characters.  Is there a list of valid and invalid
> characters
> > for a region name?
> >
>


Re: Valid characters in Region names

2016-03-02 Thread kareem shabazz
+1

--
Kareem




On Wed, Mar 2, 2016 at 9:20 AM -0800, "Kirk Lund"  wrote:










+1


On Tue, Mar 1, 2016 at 2:35 PM, William Markito  wrote:

> Folks, it doesn't look like we have actually finished this thread...
>
> What do you guys think about the following pattern:
> "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz123456-_"  ?
>
> I'm not specifying a regexp to avoid problems with unicode and to keep it
> only ASCII-only...  Stackoveflow has some suggestions like "^\\p{ASCII}*$"
> but
> I'd be careful and try to keep it strict to the ones specified in the list
> above.
>
> Thanks
>
>
> On Thu, Feb 18, 2016 at 11:19 AM, Darrel Schneider 
> wrote:
>
> > The public javadocs on Region#getName say:
> > Returns the name of this region. A region's name
> >* can be any non-empty String providing it does not
> >* contain the name separator, a forward slash (/).
> >
> > Here is the code from LocalRegion that validates the name:
> >   static void validateRegionName(String name)
> >   {
> > if (name == null) {
> >   throw new
> >
> >
> IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_BE_NULL.toLocalizedString());
> > }
> > if (name.length() == 0) {
> >   throw new
> >
> >
> IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_BE_EMPTY.toLocalizedString());
> > }
> > if (name.indexOf(SEPARATOR) >= 0) {
> >   throw new
> >
> >
> IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_CONTAIN_THE_SEPARATOR_0.toLocalizedString(SEPARATOR));
> > }
> >   }
> >
> >
> > On Thu, Feb 18, 2016 at 11:09 AM, William Markito 
> > wrote:
> >
> > > I don't think we should allow non-alphanumeric region names...   And
> > would
> > > be really nice to have a list or a pattern documenting what's valid.
> > >
> > >
> > > On Thu, Feb 18, 2016 at 11:04 AM Kirk Lund  wrote:
> > >
> > > > I was just looking into a ticket filed because /= was used as the
> > Region
> > > > name and this caused problems in JMX ObjectNames. I have two
> questions:
> > > 1)
> > > > do we really want /= to be a valid Region name? 2) do we have a
> > complete
> > > > list somewhere of all the non-alphanumeric characters that are usable
> > in
> > > > Region names?
> > > >
> > > > -Kirk
> > > >
> > > --
> > > ~/William
> > >
> >
>
>
>
> --
>
> ~/William
>







Re: Valid characters in Region names

2016-03-02 Thread Kirk Lund
+1


On Tue, Mar 1, 2016 at 2:35 PM, William Markito  wrote:

> Folks, it doesn't look like we have actually finished this thread...
>
> What do you guys think about the following pattern:
> "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz123456-_"  ?
>
> I'm not specifying a regexp to avoid problems with unicode and to keep it
> only ASCII-only...  Stackoveflow has some suggestions like "^\\p{ASCII}*$"
> but
> I'd be careful and try to keep it strict to the ones specified in the list
> above.
>
> Thanks
>
>
> On Thu, Feb 18, 2016 at 11:19 AM, Darrel Schneider 
> wrote:
>
> > The public javadocs on Region#getName say:
> > Returns the name of this region. A region's name
> >* can be any non-empty String providing it does not
> >* contain the name separator, a forward slash (/).
> >
> > Here is the code from LocalRegion that validates the name:
> >   static void validateRegionName(String name)
> >   {
> > if (name == null) {
> >   throw new
> >
> >
> IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_BE_NULL.toLocalizedString());
> > }
> > if (name.length() == 0) {
> >   throw new
> >
> >
> IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_BE_EMPTY.toLocalizedString());
> > }
> > if (name.indexOf(SEPARATOR) >= 0) {
> >   throw new
> >
> >
> IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_CONTAIN_THE_SEPARATOR_0.toLocalizedString(SEPARATOR));
> > }
> >   }
> >
> >
> > On Thu, Feb 18, 2016 at 11:09 AM, William Markito 
> > wrote:
> >
> > > I don't think we should allow non-alphanumeric region names...   And
> > would
> > > be really nice to have a list or a pattern documenting what's valid.
> > >
> > >
> > > On Thu, Feb 18, 2016 at 11:04 AM Kirk Lund  wrote:
> > >
> > > > I was just looking into a ticket filed because /= was used as the
> > Region
> > > > name and this caused problems in JMX ObjectNames. I have two
> questions:
> > > 1)
> > > > do we really want /= to be a valid Region name? 2) do we have a
> > complete
> > > > list somewhere of all the non-alphanumeric characters that are usable
> > in
> > > > Region names?
> > > >
> > > > -Kirk
> > > >
> > > --
> > > ~/William
> > >
> >
>
>
>
> --
>
> ~/William
>


Re: Valid characters in Region names

2016-03-01 Thread William Markito
That would be changed from now on as it's too much open ended and
troublesome to support in other subsystems such as JMX beans... Note that
"-" is still in the list, other symbols would not be allowed like "+" or
"@" - Which are very odd and should be very rare.

On Tue, Mar 1, 2016 at 2:52 PM, Anilkumar Gingade 
wrote:

> From the existing javadoc it looks like, application can have any chars in
> region name except the "/".
>
> Changing this one may have implication on existing GemFire customers
>
> In the past we had to make changes in OQL to support chars like "+", "-",
> "@"...(since customers used this in their region names)...
>
> -Anil.
>
>
> On Tue, Mar 1, 2016 at 2:44 PM, Udo Kohlmeyer 
> wrote:
>
> > +1
> >
> > On 2/03/2016 9:35 am, William Markito wrote:
> >
> >> Folks, it doesn't look like we have actually finished this thread...
> >>
> >> What do you guys think about the following pattern:
> >> "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz123456-_"  ?
> >>
> >> I'm not specifying a regexp to avoid problems with unicode and to keep
> it
> >> only ASCII-only...  Stackoveflow has some suggestions like
> >> "^\\p{ASCII}*$" but
> >> I'd be careful and try to keep it strict to the ones specified in the
> list
> >> above.
> >>
> >> Thanks
> >>
> >>
> >> On Thu, Feb 18, 2016 at 11:19 AM, Darrel Schneider <
> dschnei...@pivotal.io
> >> >
> >> wrote:
> >>
> >> The public javadocs on Region#getName say:
> >>> Returns the name of this region. A region's name
> >>> * can be any non-empty String providing it does not
> >>> * contain the name separator, a forward slash (/).
> >>>
> >>> Here is the code from LocalRegion that validates the name:
> >>>static void validateRegionName(String name)
> >>>{
> >>>  if (name == null) {
> >>>throw new
> >>>
> >>>
> >>>
> IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_BE_NULL.toLocalizedString());
> >>>  }
> >>>  if (name.length() == 0) {
> >>>throw new
> >>>
> >>>
> >>>
> IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_BE_EMPTY.toLocalizedString());
> >>>  }
> >>>  if (name.indexOf(SEPARATOR) >= 0) {
> >>>throw new
> >>>
> >>>
> >>>
> IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_CONTAIN_THE_SEPARATOR_0.toLocalizedString(SEPARATOR));
> >>>  }
> >>>}
> >>>
> >>>
> >>> On Thu, Feb 18, 2016 at 11:09 AM, William Markito  >
> >>> wrote:
> >>>
> >>> I don't think we should allow non-alphanumeric region names...   And
> 
> >>> would
> >>>
>  be really nice to have a list or a pattern documenting what's valid.
> 
> 
>  On Thu, Feb 18, 2016 at 11:04 AM Kirk Lund  wrote:
> 
>  I was just looking into a ticket filed because /= was used as the
> >
>  Region
> >>>
>  name and this caused problems in JMX ObjectNames. I have two
> questions:
> >
>  1)
> 
> > do we really want /= to be a valid Region name? 2) do we have a
> >
>  complete
> >>>
>  list somewhere of all the non-alphanumeric characters that are usable
> >
>  in
> >>>
>  Region names?
> >
> > -Kirk
> >
> > --
>  ~/William
> 
> 
> >>
> >>
> >
>



-- 

~/William


Re: Valid characters in Region names

2016-03-01 Thread Anilkumar Gingade
>From the existing javadoc it looks like, application can have any chars in
region name except the "/".

Changing this one may have implication on existing GemFire customers

In the past we had to make changes in OQL to support chars like "+", "-",
"@"...(since customers used this in their region names)...

-Anil.


On Tue, Mar 1, 2016 at 2:44 PM, Udo Kohlmeyer  wrote:

> +1
>
> On 2/03/2016 9:35 am, William Markito wrote:
>
>> Folks, it doesn't look like we have actually finished this thread...
>>
>> What do you guys think about the following pattern:
>> "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz123456-_"  ?
>>
>> I'm not specifying a regexp to avoid problems with unicode and to keep it
>> only ASCII-only...  Stackoveflow has some suggestions like
>> "^\\p{ASCII}*$" but
>> I'd be careful and try to keep it strict to the ones specified in the list
>> above.
>>
>> Thanks
>>
>>
>> On Thu, Feb 18, 2016 at 11:19 AM, Darrel Schneider > >
>> wrote:
>>
>> The public javadocs on Region#getName say:
>>> Returns the name of this region. A region's name
>>> * can be any non-empty String providing it does not
>>> * contain the name separator, a forward slash (/).
>>>
>>> Here is the code from LocalRegion that validates the name:
>>>static void validateRegionName(String name)
>>>{
>>>  if (name == null) {
>>>throw new
>>>
>>>
>>> IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_BE_NULL.toLocalizedString());
>>>  }
>>>  if (name.length() == 0) {
>>>throw new
>>>
>>>
>>> IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_BE_EMPTY.toLocalizedString());
>>>  }
>>>  if (name.indexOf(SEPARATOR) >= 0) {
>>>throw new
>>>
>>>
>>> IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_CONTAIN_THE_SEPARATOR_0.toLocalizedString(SEPARATOR));
>>>  }
>>>}
>>>
>>>
>>> On Thu, Feb 18, 2016 at 11:09 AM, William Markito 
>>> wrote:
>>>
>>> I don't think we should allow non-alphanumeric region names...   And

>>> would
>>>
 be really nice to have a list or a pattern documenting what's valid.


 On Thu, Feb 18, 2016 at 11:04 AM Kirk Lund  wrote:

 I was just looking into a ticket filed because /= was used as the
>
 Region
>>>
 name and this caused problems in JMX ObjectNames. I have two questions:
>
 1)

> do we really want /= to be a valid Region name? 2) do we have a
>
 complete
>>>
 list somewhere of all the non-alphanumeric characters that are usable
>
 in
>>>
 Region names?
>
> -Kirk
>
> --
 ~/William


>>
>>
>


Re: Valid characters in Region names

2016-03-01 Thread Udo Kohlmeyer

+1

On 2/03/2016 9:35 am, William Markito wrote:

Folks, it doesn't look like we have actually finished this thread...

What do you guys think about the following pattern:
"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz123456-_"  ?

I'm not specifying a regexp to avoid problems with unicode and to keep it
only ASCII-only...  Stackoveflow has some suggestions like "^\\p{ASCII}*$" but
I'd be careful and try to keep it strict to the ones specified in the list
above.

Thanks


On Thu, Feb 18, 2016 at 11:19 AM, Darrel Schneider 
wrote:


The public javadocs on Region#getName say:
Returns the name of this region. A region's name
* can be any non-empty String providing it does not
* contain the name separator, a forward slash (/).

Here is the code from LocalRegion that validates the name:
   static void validateRegionName(String name)
   {
 if (name == null) {
   throw new

IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_BE_NULL.toLocalizedString());
 }
 if (name.length() == 0) {
   throw new

IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_BE_EMPTY.toLocalizedString());
 }
 if (name.indexOf(SEPARATOR) >= 0) {
   throw new

IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_CONTAIN_THE_SEPARATOR_0.toLocalizedString(SEPARATOR));
 }
   }


On Thu, Feb 18, 2016 at 11:09 AM, William Markito 
wrote:


I don't think we should allow non-alphanumeric region names...   And

would

be really nice to have a list or a pattern documenting what's valid.


On Thu, Feb 18, 2016 at 11:04 AM Kirk Lund  wrote:


I was just looking into a ticket filed because /= was used as the

Region

name and this caused problems in JMX ObjectNames. I have two questions:

1)

do we really want /= to be a valid Region name? 2) do we have a

complete

list somewhere of all the non-alphanumeric characters that are usable

in

Region names?

-Kirk


--
~/William








Re: Valid characters in Region names

2016-03-01 Thread William Markito
Folks, it doesn't look like we have actually finished this thread...

What do you guys think about the following pattern:
"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz123456-_"  ?

I'm not specifying a regexp to avoid problems with unicode and to keep it
only ASCII-only...  Stackoveflow has some suggestions like "^\\p{ASCII}*$" but
I'd be careful and try to keep it strict to the ones specified in the list
above.

Thanks


On Thu, Feb 18, 2016 at 11:19 AM, Darrel Schneider 
wrote:

> The public javadocs on Region#getName say:
> Returns the name of this region. A region's name
>* can be any non-empty String providing it does not
>* contain the name separator, a forward slash (/).
>
> Here is the code from LocalRegion that validates the name:
>   static void validateRegionName(String name)
>   {
> if (name == null) {
>   throw new
>
> IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_BE_NULL.toLocalizedString());
> }
> if (name.length() == 0) {
>   throw new
>
> IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_BE_EMPTY.toLocalizedString());
> }
> if (name.indexOf(SEPARATOR) >= 0) {
>   throw new
>
> IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_CONTAIN_THE_SEPARATOR_0.toLocalizedString(SEPARATOR));
> }
>   }
>
>
> On Thu, Feb 18, 2016 at 11:09 AM, William Markito 
> wrote:
>
> > I don't think we should allow non-alphanumeric region names...   And
> would
> > be really nice to have a list or a pattern documenting what's valid.
> >
> >
> > On Thu, Feb 18, 2016 at 11:04 AM Kirk Lund  wrote:
> >
> > > I was just looking into a ticket filed because /= was used as the
> Region
> > > name and this caused problems in JMX ObjectNames. I have two questions:
> > 1)
> > > do we really want /= to be a valid Region name? 2) do we have a
> complete
> > > list somewhere of all the non-alphanumeric characters that are usable
> in
> > > Region names?
> > >
> > > -Kirk
> > >
> > --
> > ~/William
> >
>



-- 

~/William


Re: Valid characters in Region names

2016-02-18 Thread Darrel Schneider
The public javadocs on Region#getName say:
Returns the name of this region. A region's name
   * can be any non-empty String providing it does not
   * contain the name separator, a forward slash (/).

Here is the code from LocalRegion that validates the name:
  static void validateRegionName(String name)
  {
if (name == null) {
  throw new
IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_BE_NULL.toLocalizedString());
}
if (name.length() == 0) {
  throw new
IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_BE_EMPTY.toLocalizedString());
}
if (name.indexOf(SEPARATOR) >= 0) {
  throw new
IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_CONTAIN_THE_SEPARATOR_0.toLocalizedString(SEPARATOR));
}
  }


On Thu, Feb 18, 2016 at 11:09 AM, William Markito 
wrote:

> I don't think we should allow non-alphanumeric region names...   And would
> be really nice to have a list or a pattern documenting what's valid.
>
>
> On Thu, Feb 18, 2016 at 11:04 AM Kirk Lund  wrote:
>
> > I was just looking into a ticket filed because /= was used as the Region
> > name and this caused problems in JMX ObjectNames. I have two questions:
> 1)
> > do we really want /= to be a valid Region name? 2) do we have a complete
> > list somewhere of all the non-alphanumeric characters that are usable in
> > Region names?
> >
> > -Kirk
> >
> --
> ~/William
>


Re: Valid characters in Region names

2016-02-18 Thread Michael Stolz
There is a stated position in the commercial GemFire documentation as
follows:

To get the full range of Pivotal GemFire capabilities for your cached data
regions, follow GemFire's region naming guidelines:
The safest approach when naming your regions is to use only alphanumeric
characters and the underscore character and to keep your region names
short.
This permits you the full range of GemFire region configurations and allow
you to perform all available GemFire operations on the region.
Follow these guidelines for naming regions:
• Do not use the separator slash character ‘ / ’.
• Do not begin region names with two underscore characters "__" as this is
reserved for internal GemFire use.
• To run queries against your data, restrict your region names to
alphanumeric characters and the underscore character.


For Geode we should probably tighten that up just a bit further by changing
the last bullet to:
• Restrict your region names to alphanumeric characters and the underscore
character.



--
Mike Stolz
Principal Engineer, GemFire Product Manager
Mobile: 631-835-4771

On Thu, Feb 18, 2016 at 2:09 PM, William Markito 
wrote:

> I don't think we should allow non-alphanumeric region names...   And would
> be really nice to have a list or a pattern documenting what's valid.
>
>
> On Thu, Feb 18, 2016 at 11:04 AM Kirk Lund  wrote:
>
> > I was just looking into a ticket filed because /= was used as the Region
> > name and this caused problems in JMX ObjectNames. I have two questions:
> 1)
> > do we really want /= to be a valid Region name? 2) do we have a complete
> > list somewhere of all the non-alphanumeric characters that are usable in
> > Region names?
> >
> > -Kirk
> >
> --
> ~/William
>


Valid characters in Region names

2016-02-18 Thread Kirk Lund
I was just looking into a ticket filed because /= was used as the Region
name and this caused problems in JMX ObjectNames. I have two questions: 1)
do we really want /= to be a valid Region name? 2) do we have a complete
list somewhere of all the non-alphanumeric characters that are usable in
Region names?

-Kirk