Re: Pending patches

2021-03-22 Thread Florent Guillaume 
Hi,

I can drop the private constructor if you want.
I'm surprised it's needed though, as the default instance is already used
by the code if no value is provided for the timeProvider parameter of
TransactionImpl.

Florent


On Mon, Mar 22, 2021 at 5:49 PM Romain Manni-Bucau 
wrote:

> Hi Richard,
>
> I still think SystemCurrentTime should have a public noarg constructor
> (or just drop the private one) since it will enable tomee to fully
> configure dynamically the tx mgr with this new feature but otherwise +1 to
> apply them all.
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github
>  | LinkedIn
>  | Book
> 
>
>
> Le lun. 22 mars 2021 à 17:03, Zowalla, Richard <
> richard.zowa...@hs-heilbronn.de> a écrit :
>
>> Hi all,
>>
>> wanted to raise attention on this again. 6792 would be very nice as we
>> should allow TLS/SSL protocol versions for a given mail server instead
>> of falling back to some hard-coded default.
>>
>> Gruss
>> Richard
>>
>> Am Mittwoch, den 24.02.2021, 09:33 +0100 schrieb Romain Manni-Bucau:
>> > Hi all,
>> >
>> > AFAIK we have a few pending patches to apply/issue to close:
>> >
>> > - [mail] https://issues.apache.org/jira/browse/GERONIMO-6792: update
>> > some defaults and config capacity
>> > - [mail] https://issues.apache.org/jira/browse/GERONIMO-6801 and
>> > https://issues.apache.org/jira/browse/GERONIMO-6800 (setText)
>> > - [transaction-manager]
>> > https://issues.apache.org/jira/browse/GERONIMO-6805: enable to change
>> > the time evaluator impl
>> >
>> > If someone else can have a review it would be great (feel free to
>> > apply the patch or I can do it after).
>> >
>> > note: some of the patches are waiting for some feedback - in
>> > particular txmgr one, wonder about tomee  usage which can
>> > need to remove the private constructor of the default impl to enable
>> > to configure the impl completely.
>> >
>> > Thanks,
>> > Romain Manni-Bucau
>> > @rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book
>>
>>

-- 
[image: Nuxeo Logo] 

Florent Guillaume  Head of R  [image: LinkedIn]
 [image: Twitter]
 [image: Github] 

Nuxeo Content Services Platform. Stay ahead.

Re: Pending patches

2021-03-22 Thread Romain Manni-Bucau 
Hi Richard,

I still think SystemCurrentTime should have a public noarg constructor (or
just drop the private one) since it will enable tomee to fully configure
dynamically the tx mgr with this new feature but otherwise +1 to apply them
all.

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le lun. 22 mars 2021 à 17:03, Zowalla, Richard <
richard.zowa...@hs-heilbronn.de> a écrit :

> Hi all,
>
> wanted to raise attention on this again. 6792 would be very nice as we
> should allow TLS/SSL protocol versions for a given mail server instead
> of falling back to some hard-coded default.
>
> Gruss
> Richard
>
> Am Mittwoch, den 24.02.2021, 09:33 +0100 schrieb Romain Manni-Bucau:
> > Hi all,
> >
> > AFAIK we have a few pending patches to apply/issue to close:
> >
> > - [mail] https://issues.apache.org/jira/browse/GERONIMO-6792: update
> > some defaults and config capacity
> > - [mail] https://issues.apache.org/jira/browse/GERONIMO-6801 and
> > https://issues.apache.org/jira/browse/GERONIMO-6800 (setText)
> > - [transaction-manager]
> > https://issues.apache.org/jira/browse/GERONIMO-6805: enable to change
> > the time evaluator impl
> >
> > If someone else can have a review it would be great (feel free to
> > apply the patch or I can do it after).
> >
> > note: some of the patches are waiting for some feedback - in
> > particular txmgr one, wonder about tomee  usage which can
> > need to remove the private constructor of the default impl to enable
> > to configure the impl completely.
> >
> > Thanks,
> > Romain Manni-Bucau
> > @rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book
>
>

Re: Pending patches

2021-03-22 Thread Zowalla, Richard 
Hi all,

wanted to raise attention on this again. 6792 would be very nice as we
should allow TLS/SSL protocol versions for a given mail server instead
of falling back to some hard-coded default.

Gruss
Richard

Am Mittwoch, den 24.02.2021, 09:33 +0100 schrieb Romain Manni-Bucau:
> Hi all,
> 
> AFAIK we have a few pending patches to apply/issue to close:
> 
> - [mail] https://issues.apache.org/jira/browse/GERONIMO-6792: update
> some defaults and config capacity
> - [mail] https://issues.apache.org/jira/browse/GERONIMO-6801 and 
> https://issues.apache.org/jira/browse/GERONIMO-6800 (setText)
> - [transaction-manager] 
> https://issues.apache.org/jira/browse/GERONIMO-6805: enable to change
> the time evaluator impl
> 
> If someone else can have a review it would be great (feel free to
> apply the patch or I can do it after).
> 
> note: some of the patches are waiting for some feedback - in
> particular txmgr one, wonder about tomee  usage which can
> need to remove the private constructor of the default impl to enable
> to configure the impl completely.
> 
> Thanks,
> Romain Manni-Bucau
> @rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book



smime.p7s
Description: S/MIME cryptographic signature

[GitHub] [geronimo-txmanager] jgallimore commented on pull request #6: GERONIMO-6805: Use a time SPI abstraction to provide time to the transaction manager

2021-03-22 Thread GitBox 


jgallimore commented on pull request #6:
URL: https://github.com/apache/geronimo-txmanager/pull/6#issuecomment-804116206


   It looks ok - I'll run some tests with this change this afternoon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [geronimo-txmanager] efge commented on pull request #6: GERONIMO-6805: Use a time SPI abstraction to provide time to the transaction manager

2021-03-22 Thread GitBox 


efge commented on pull request #6:
URL: https://github.com/apache/geronimo-txmanager/pull/6#issuecomment-804076758


   Hi. Is there anything more I should do before this can be merged?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (GERONIMO-6811) Support Meecrowave

2021-03-22 Thread Francois Papon (Jira) 
Francois Papon created GERONIMO-6811:


 Summary: Support Meecrowave
 Key: GERONIMO-6811
 URL: https://issues.apache.org/jira/browse/GERONIMO-6811
 Project: Geronimo
  Issue Type: Task
  Security Level: public (Regular issues)
Reporter: Francois Papon
Assignee: Francois Papon
 Fix For: Arthur-1.0.3


Add Meecrowave extension



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (GERONIMO-6810) Sort ArthurExtension by order

2021-03-22 Thread Romain Manni-Bucau (Jira) 


 [ 
https://issues.apache.org/jira/browse/GERONIMO-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau resolved GERONIMO-6810.
--
Resolution: Fixed

> Sort ArthurExtension by order
> -
>
> Key: GERONIMO-6810
> URL: https://issues.apache.org/jira/browse/GERONIMO-6810
> Project: Geronimo
>  Issue Type: Task
>  Security Level: public(Regular issues) 
>Reporter: Romain Manni-Bucau
>Assignee: Romain Manni-Bucau
>Priority: Major
> Fix For: Arthur-1.0.3
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (GERONIMO-6810) Sort ArthurExtension by order

2021-03-22 Thread Romain Manni-Bucau (Jira) 
Romain Manni-Bucau created GERONIMO-6810:


 Summary: Sort ArthurExtension by order
 Key: GERONIMO-6810
 URL: https://issues.apache.org/jira/browse/GERONIMO-6810
 Project: Geronimo
  Issue Type: Task
  Security Level: public (Regular issues)
Reporter: Romain Manni-Bucau
Assignee: Romain Manni-Bucau
 Fix For: Arthur-1.0.3






--
This message was sent by Atlassian Jira
(v8.3.4#803005)