Re: BATCHEE release?

2021-04-28 Thread Mark Struberg 
 while coming along, I'd also update BATCHEE to fit EE8 and update to 
1.0.0-SNAPSHOT.Any objections?
LieGrue,strub

On Wednesday, 28 April 2021, 08:44:08 CEST, Francois Papon 
 wrote:  
 
 Hi Mark,

Sounds good to me :)

Thanks!

regards,

François
fpa...@apache.org

Le 28/04/2021 à 07:13, Mark Struberg a écrit :
> hi folks!
>
> I'd like to do a BATCHEE release soon. 
> Anything you want to work on then ping me.
>
> txs and LieGrue,
> strub
>

BATCHEE release?

2021-04-28 Thread Mark Struberg 
hi folks!

I'd like to do a BATCHEE release soon. 
Anything you want to work on then ping me.

txs and LieGrue,
strub

Re: Pending patches

2021-04-28 Thread Zowalla, Richard 
Just to follow up on this thread:

Do we have any plans for moving forward with the mail-related patches?
The hard-coded TLS config in mail is a bit "pain" ;)

Gruss
Richard

Am Dienstag, den 23.03.2021, 08:50 +0100 schrieb Romain Manni-Bucau:
> Well it can use a singleton but from a factory method. So immediate
> solution is to add a public static X getInstance();.
> But as mentionned it means, to keep the pluggability we should target
> with such a spi, you will enforce all other impl to use such a
> pattern (you cant' just switch with -D easily since adding is easy
> but dropping system props is almost impossible).
> A noarg public constructor is trivial and more natural with resources
> IMHO - but once again tomee can does all the work to makes it
> equivalent, just requires to duplicate/wrap the impls of the SPI in
> tomee codebase which sounds weird to me ("we have an impl but you
> need to use another one").
> 
> On a more personal note I think this pattern is no more relevant and
> has more pitfalls since you enforce a static instance as soon as the
> class is loaded whereas it is not needed depending the lifecycle of
> your main - it is not much but still, I see it as a leak in terms of
> design (indeed this one is not important and not a blocker but all
> implies to move to the noarg public constructor on my side).
> Maybe a habit and personal choice so would be great to have another
> opinion to move forward :).
> 
> Le mar. 23 mars 2021 à 08:38, Zowalla, Richard <
> richard.zowa...@hs-heilbronn.de> a écrit :
> > Hi,
> > 
> > I think, it is about the configuration flexibility in tomee's
> >  definitions, which wouldn't allow the use of a singleton
> > instance. Hence, the consuming project would need to implement the
> > interface to make it possible. But I am not that deep as Romain in
> > the
> > TomEE codebase, so it is still a guess from my side.
> > 
> > Gruss
> > Richard
> > 
> > Am Montag, den 22.03.2021, 23:14 +0100 schrieb Florent Guillaume:
> > > Hi,
> > > 
> > > I can drop the private constructor if you want.
> > > I'm surprised it's needed though, as the default instance is
> > already
> > > used by the code if no value is provided for the timeProvider
> > > parameter of TransactionImpl. 
> > > 
> > > Florent
> > > 
> > > 
> > > On Mon, Mar 22, 2021 at 5:49 PM Romain Manni-Bucau <
> > > rmannibu...@gmail.com> wrote:
> > > > Hi Richard,
> > > > 
> > > > I still think SystemCurrentTime should have a public noarg
> > > > constructor (or just drop the private one) since it will enable
> > > > tomee to fully configure dynamically the tx mgr with this new
> > > > feature but otherwise +1 to apply them all.
> > > > 
> > > > Romain Manni-Bucau
> > > > @rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book
> > > > 
> > > > 
> > > > Le lun. 22 mars 2021 à 17:03, Zowalla, Richard <
> > > > richard.zowa...@hs-heilbronn.de> a écrit :
> > > > > Hi all,
> > > > > 
> > > > > wanted to raise attention on this again. 6792 would be very
> > nice
> > > > > as we
> > > > > should allow TLS/SSL protocol versions for a given mail
> > server
> > > > > instead
> > > > > of falling back to some hard-coded default.
> > > > > 
> > > > > Gruss
> > > > > Richard
> > > > > 
> > > > > Am Mittwoch, den 24.02.2021, 09:33 +0100 schrieb Romain
> > Manni-
> > > > > Bucau:
> > > > > > Hi all,
> > > > > > 
> > > > > > AFAIK we have a few pending patches to apply/issue to
> > close:
> > > > > > 
> > > > > > - [mail] 
> > https://issues.apache.org/jira/browse/GERONIMO-6792:
> > > > > update
> > > > > > some defaults and config capacity
> > > > > > - [mail] 
> > https://issues.apache.org/jira/browse/GERONIMO-6801
> > > > > and 
> > > > > > https://issues.apache.org/jira/browse/GERONIMO-6800
> > (setText)
> > > > > > - [transaction-manager] 
> > > > > > https://issues.apache.org/jira/browse/GERONIMO-6805: enable
> > to
> > > > > change
> > > > > > the time evaluator impl
> > > > > > 
> > > > > > If someone else can have a review it would be great (feel
> > free
> > > > > to
> > > > > > apply the patch or I can do it after).
> > > > > > 
> > > > > > note: some of the patches are waiting for some feedback -
> > in
> > > > > > particular txmgr one, wonder about tomee  usage
> > which
> > > > > can
> > > > > > need to remove the private constructor of the default impl
> > to
> > > > > enable
> > > > > > to configure the impl completely.
> > > > > > 
> > > > > > Thanks,
> > > > > > Romain Manni-Bucau
> > > > > > @rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book
> > > > > 
> > > 
> > > 


smime.p7s
Description: S/MIME cryptographic signature

Re: BATCHEE release?

2021-04-28 Thread Romain Manni-Bucau 
+1 to release (btw we are already on tomee 8 so should fit EE 8 and we even
have the jakarta delivery too ;))

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le mer. 28 avr. 2021 à 09:08, Jean-Baptiste Onofre  a
écrit :

> No problem for me.
>
> Regards
> JB
>
> Le 28 avr. 2021 à 08:54, Mark Struberg  a écrit :
>
> while coming along, I'd also update BATCHEE to fit EE8 and update to
> 1.0.0-SNAPSHOT.
> Any objections?
>
> LieGrue,
> strub
>
>
> On Wednesday, 28 April 2021, 08:44:08 CEST, Francois Papon <
> francois.pa...@openobject.fr> wrote:
>
>
> Hi Mark,
>
> Sounds good to me :)
>
> Thanks!
>
> regards,
>
> François
> fpa...@apache.org
>
> Le 28/04/2021 à 07:13, Mark Struberg a écrit :
> > hi folks!
> >
> > I'd like to do a BATCHEE release soon.
> > Anything you want to work on then ping me.
> >
> > txs and LieGrue,
> > strub
> >
>
>
>

Re: BATCHEE release?

2021-04-28 Thread Jean-Baptiste Onofre 
No problem for me.

Regards
JB

> Le 28 avr. 2021 à 08:54, Mark Struberg  a écrit :
> 
> while coming along, I'd also update BATCHEE to fit EE8 and update to 
> 1.0.0-SNAPSHOT.
> Any objections?
> 
> LieGrue,
> strub
> 
> 
> On Wednesday, 28 April 2021, 08:44:08 CEST, Francois Papon 
>  wrote:
> 
> 
> Hi Mark,
> 
> Sounds good to me :)
> 
> Thanks!
> 
> regards,
> 
> François
> fpa...@apache.org 
> 
> Le 28/04/2021 à 07:13, Mark Struberg a écrit :
> > hi folks!
> >
> > I'd like to do a BATCHEE release soon. 
> > Anything you want to work on then ping me.
> >
> > txs and LieGrue,
> > strub
> >

Re: BATCHEE release?

2021-04-28 Thread Francois Papon 
+1

François
fpa...@apache.org

Le 28/04/2021 à 08:54, Mark Struberg a écrit :
> while coming along, I'd also update BATCHEE to fit EE8 and update to
> 1.0.0-SNAPSHOT.
> Any objections?
>
> LieGrue,
> strub
>
>
> On Wednesday, 28 April 2021, 08:44:08 CEST, Francois Papon
>  wrote:
>
>
> Hi Mark,
>
> Sounds good to me :)
>
> Thanks!
>
> regards,
>
> François
> fpa...@apache.org 
>
> Le 28/04/2021 à 07:13, Mark Struberg a écrit :
> > hi folks!
> >
> > I'd like to do a BATCHEE release soon.
> > Anything you want to work on then ping me.
> >
> > txs and LieGrue,
> > strub
> >

Re: BATCHEE release?

2021-04-28 Thread Francois Papon 
Hi Mark,

Sounds good to me :)

Thanks!

regards,

François
fpa...@apache.org

Le 28/04/2021 à 07:13, Mark Struberg a écrit :
> hi folks!
>
> I'd like to do a BATCHEE release soon. 
> Anything you want to work on then ping me.
>
> txs and LieGrue,
> strub
>

[jira] [Commented] (GERONIMO-6813) [mvn-plugin/Knights] Will not work with jakarta Namespace

2021-04-28 Thread Romain Manni-Bucau (Jira) 


[ 
https://issues.apache.org/jira/browse/GERONIMO-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17334478#comment-17334478
 ] 

Romain Manni-Bucau commented on GERONIMO-6813:
--

Hi [~bmarwell],

 

We can do the same as for most ASF project and just have a shade of the 
extension with jakarta classifier since extensions are just maven dependencies 
at the end .

> [mvn-plugin/Knights] Will not work with jakarta Namespace
> -
>
> Key: GERONIMO-6813
> URL: https://issues.apache.org/jira/browse/GERONIMO-6813
> Project: Geronimo
>  Issue Type: Bug
>  Security Level: public(Regular issues) 
>Affects Versions: Arthur-1.0.2
>Reporter: Benjamin Marwell
>Priority: Major
>
> The arthur-maven-plugin will not work when using the jakarta classifiers from 
> meecrowave.
> It is a little hard to reproduce unless MEECROWAVE-289 is merged, but you can 
> install it locally and then see the same output.
> The output:
> {code:java}
> Exception in thread "main" java.util.ServiceConfigurationError: 
> javax.enterprise.inject.se.SeContainerInitializer: 
> org.apache.openwebbeans.se.SeInitializerFacade not a subtype
> at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:588)
> at 
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1236)
> at 
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1264)
> at 
> java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1299)
> at 
> java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1384)
> at 
> javax.enterprise.inject.se.SeContainerInitializer.newInstance(SeContainerInitializer.java:51)
> at 
> org.apache.geronimo.arthur.knight.openwebbeans.OpenWebBeansExtension.execute(OpenWebBeansExtension.java:114)
> at 
> org.apache.geronimo.arthur.impl.nativeimage.generator.ConfigurationGenerator.run(ConfigurationGenerator.java:95)
> at 
> org.apache.geronimo.arthur.impl.nativeimage.ArthurNativeImageExecutor.run(ArthurNativeImageExecutor.java:54)
> at 
> org.apache.geronimo.arthur.maven.mojo.NativeImageMojo.lambda$execute$6(NativeImageMojo.java:484)
> at 
> org.apache.geronimo.arthur.maven.extension.MavenArthurExtension.with(MavenArthurExtension.java:69)
> at 
> org.apache.geronimo.arthur.maven.mojo.NativeImageMojo.execute(NativeImageMojo.java:446)
> at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:957)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:289)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:193)
> {code}
> [Arthur relies on javax 
> packages|https://github.com/apache/geronimo-arthur/blob/master/knights/openwebbeans-knight/src/main/java/org/apache/geronimo/arthur/knight/openwebbeans/OpenWebBeansExtension.java],
>  but there would need to be a jakarta version.
> "Problem" is that plugins cannot have a classifier. So maybe a copy of this 
> extension is needed?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)