Re: Pending patches

2021-07-23 Thread Francois Papon 
Thanks!

I will take a look.

regards,

François
fpa...@apache.org

Le 23/07/2021 à 08:53, Zowalla, Richard a écrit :
> Done.
>
> - https://github.com/apache/geronimo-javamail/pull/2
> - https://github.com/apache/geronimo-javamail/pull/3
>
> Gruss
> Richard
>
> Am Mittwoch, den 21.07.2021, 09:59 + schrieb Zowalla, Richard:
>> Ok. Will do!
>>
>> Am Mittwoch, den 21.07.2021, 11:58 +0200 schrieb Francois Papon:
>>> Hi,
>>>
>>> I think it's better if you can push a PR via github.
>>>
>>> regards,
>>>
>>> François
>>> fpa...@apache.org
>>>
>>> Le 21/07/2021 à 11:01, Zowalla, Richard a écrit :
 Hi François,

 thanks for the update.

 Shall I migrate my SVN patch files towards GitHub Pull Requests
 or
 is
 the plan to apply them directly?

 Gruss
 Richard


 Am Mittwoch, den 21.07.2021, 10:58 +0200 schrieb Francois Papon:
> Hi all,
>
> This 3 repo has moved successfuly to gitbox:
>
>   https://github.com/apache/geronimo-xbean
>   https://github.com/apache/geronimo-javamail
>   https://github.com/apache/geronimo-txmanager
>
> We can now merge the pending PRs.
>
> regards,
>
> François
> fpa...@apache.org
>
> Le 08/06/2021 à 14:15, Richard Zowalla a écrit :
>> Thx for the ticket id !
>>
>> Am Dienstag, den 08.06.2021, 14:07 +0200 schrieb Francois
>> Papon:
>>> Hi,
>>>
>>> Migration is still pending, waiting for infra:
>>>
>>> https://issues.apache.org/jira/browse/INFRA-21908
>>> 
>>>
>>> regards,
>>>
>>> François
>>> fpa...@apache.org
>>>
>>> Le 08/06/2021 à 13:56, Richard Zowalla a écrit :
 Hi François,

 any updates from INFRA on this? Couldnt find the ticket
 id
 anymore,
 sry.

 Gruss
 Richard

 Am Mittwoch, den 19.05.2021, 09:38 +0200 schrieb Francois
 Papon:
> Hi,
>
> Yes, we plan to do this just after the migration to git
> ;)
>
> regards,
>
> François
> fpa...@apache.org
>
> Le 19/05/2021 à 09:09, Zowalla, Richard a écrit :
>> Hi,
>>
>> thanks for your response! I think, that [1] might
>> also
>> affect
>> the
>> hard-
>> coded TLS1.0 in GERONIMO-6792 [2], so the pending
>> patch
>> would
>> be
>> very
>> appreciated.
>>
>> Maybe after the migration to git? ;)
>>
>> Gruss
>> Richard
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8202343
>> [2] 
>> https://issues.apache.org/jira/browse/GERONIMO-6792
>>
>> Am Samstag, den 01.05.2021, 08:20 +0200 schrieb 
>> fpa...@apache.org:
>>> Hi,
>>>
>>> I think I can take a look to the Jira and merge the
>>> PRs.
>>>
>>> regards,
>>>
>>> François
>>> fpa...@apache.org
>>>
>>> Le 28/04/2021 à 11:09, Zowalla, Richard a écrit :
 Just to follow up on this thread:

 Do we have any plans for moving forward with the
 mail-
 related
 patches?
 The hard-coded TLS config in mail is a bit "pain"
 ;)

 Gruss
 Richard

 Am Dienstag, den 23.03.2021, 08:50 +0100 schrieb
 Romain
 Manni-
 Bucau:
> Well it can use a singleton but from a factory
> method. So
> immediate
> solution is to add a public static X
> getInstance();.
> But as mentionned it means, to keep the
> pluggability
> we
> should
> target
> with such a spi, you will enforce all other
> impl
> to
> use
> such
> a
> pattern (you cant' just switch with -D easily
> since
> adding is
> easy
> but dropping system props is almost
> impossible).
> A noarg public constructor is trivial and more
> natural
> with
> resources
> IMHO - but once again tomee can does all the
> work
> to
> makes it
> equivalent, just requires to duplicate/wrap the
> impls
> of
> the
> SPI
> in
> tomee codebase which sounds weird to me ("we
> have
> an
> impl
> but
> you
> need to use another one").
>
> On a more personal note I

Re: Pending patches

2021-07-23 Thread Zowalla, Richard 
Done.

- https://github.com/apache/geronimo-javamail/pull/2
- https://github.com/apache/geronimo-javamail/pull/3

Gruss
Richard

Am Mittwoch, den 21.07.2021, 09:59 + schrieb Zowalla, Richard:
> Ok. Will do!
> 
> Am Mittwoch, den 21.07.2021, 11:58 +0200 schrieb Francois Papon:
> > Hi,
> > 
> > I think it's better if you can push a PR via github.
> > 
> > regards,
> > 
> > François
> > fpa...@apache.org
> > 
> > Le 21/07/2021 à 11:01, Zowalla, Richard a écrit :
> > > Hi François,
> > > 
> > > thanks for the update.
> > > 
> > > Shall I migrate my SVN patch files towards GitHub Pull Requests
> > > or
> > > is
> > > the plan to apply them directly?
> > > 
> > > Gruss
> > > Richard
> > > 
> > > 
> > > Am Mittwoch, den 21.07.2021, 10:58 +0200 schrieb Francois Papon:
> > > > Hi all,
> > > > 
> > > > This 3 repo has moved successfuly to gitbox:
> > > > 
> > > >   https://github.com/apache/geronimo-xbean
> > > >   https://github.com/apache/geronimo-javamail
> > > >   https://github.com/apache/geronimo-txmanager
> > > > 
> > > > We can now merge the pending PRs.
> > > > 
> > > > regards,
> > > > 
> > > > François
> > > > fpa...@apache.org
> > > > 
> > > > Le 08/06/2021 à 14:15, Richard Zowalla a écrit :
> > > > > Thx for the ticket id !
> > > > > 
> > > > > Am Dienstag, den 08.06.2021, 14:07 +0200 schrieb Francois
> > > > > Papon:
> > > > > > Hi,
> > > > > > 
> > > > > > Migration is still pending, waiting for infra:
> > > > > > 
> > > > > > https://issues.apache.org/jira/browse/INFRA-21908
> > > > > > 
> > > > > > 
> > > > > > regards,
> > > > > > 
> > > > > > François
> > > > > > fpa...@apache.org
> > > > > > 
> > > > > > Le 08/06/2021 à 13:56, Richard Zowalla a écrit :
> > > > > > > Hi François,
> > > > > > > 
> > > > > > > any updates from INFRA on this? Couldnt find the ticket
> > > > > > > id
> > > > > > > anymore,
> > > > > > > sry.
> > > > > > > 
> > > > > > > Gruss
> > > > > > > Richard
> > > > > > > 
> > > > > > > Am Mittwoch, den 19.05.2021, 09:38 +0200 schrieb Francois
> > > > > > > Papon:
> > > > > > > > Hi,
> > > > > > > > 
> > > > > > > > Yes, we plan to do this just after the migration to git
> > > > > > > > ;)
> > > > > > > > 
> > > > > > > > regards,
> > > > > > > > 
> > > > > > > > François
> > > > > > > > fpa...@apache.org
> > > > > > > > 
> > > > > > > > Le 19/05/2021 à 09:09, Zowalla, Richard a écrit :
> > > > > > > > > Hi,
> > > > > > > > > 
> > > > > > > > > thanks for your response! I think, that [1] might
> > > > > > > > > also
> > > > > > > > > affect
> > > > > > > > > the
> > > > > > > > > hard-
> > > > > > > > > coded TLS1.0 in GERONIMO-6792 [2], so the pending
> > > > > > > > > patch
> > > > > > > > > would
> > > > > > > > > be
> > > > > > > > > very
> > > > > > > > > appreciated.
> > > > > > > > > 
> > > > > > > > > Maybe after the migration to git? ;)
> > > > > > > > > 
> > > > > > > > > Gruss
> > > > > > > > > Richard
> > > > > > > > > 
> > > > > > > > > [1] https://bugs.openjdk.java.net/browse/JDK-8202343
> > > > > > > > > [2] 
> > > > > > > > > https://issues.apache.org/jira/browse/GERONIMO-6792
> > > > > > > > > 
> > > > > > > > > Am Samstag, den 01.05.2021, 08:20 +0200 schrieb 
> > > > > > > > > fpa...@apache.org:
> > > > > > > > > > Hi,
> > > > > > > > > > 
> > > > > > > > > > I think I can take a look to the Jira and merge the
> > > > > > > > > > PRs.
> > > > > > > > > > 
> > > > > > > > > > regards,
> > > > > > > > > > 
> > > > > > > > > > François
> > > > > > > > > > fpa...@apache.org
> > > > > > > > > > 
> > > > > > > > > > Le 28/04/2021 à 11:09, Zowalla, Richard a écrit :
> > > > > > > > > > > Just to follow up on this thread:
> > > > > > > > > > > 
> > > > > > > > > > > Do we have any plans for moving forward with the
> > > > > > > > > > > mail-
> > > > > > > > > > > related
> > > > > > > > > > > patches?
> > > > > > > > > > > The hard-coded TLS config in mail is a bit "pain"
> > > > > > > > > > > ;)
> > > > > > > > > > > 
> > > > > > > > > > > Gruss
> > > > > > > > > > > Richard
> > > > > > > > > > > 
> > > > > > > > > > > Am Dienstag, den 23.03.2021, 08:50 +0100 schrieb
> > > > > > > > > > > Romain
> > > > > > > > > > > Manni-
> > > > > > > > > > > Bucau:
> > > > > > > > > > > > Well it can use a singleton but from a factory
> > > > > > > > > > > > method. So
> > > > > > > > > > > > immediate
> > > > > > > > > > > > solution is to add a public static X
> > > > > > > > > > > > getInstance();.
> > > > > > > > > > > > But as mentionned it means, to keep the
> > > > > > > > > > > > pluggability
> > > > > > > > > > > > we
> > > > > > > > > > > > should
> > > > > > > > > > > > target
> > > > > > > > > > > > with such a spi, you will enforce all other
> > > > > > > > > > > > impl
> > > > > > > > > > > > to
> > > > > > > > > > > > use
> > > > > > > > > > > > such
> > > > > > > > > > > > a
> > > > > > > > > > > > pattern (you cant' just switch with -D easily
> > > > > > > > > > > > since
> > > > > > > > > > > > adding is
> >