[jira] Commented: (GERONIMO-1642) Deployment plan namespace validation
[ https://issues.apache.org/jira/browse/GERONIMO-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496412 ] Donald Woods commented on GERONIMO-1642: H - this patch is causing a build time failure in client-security. Will have to look into it more before committing [INFO] - --- [INFO] Building Geronimo Configs :: J2EE Client Security [INFO]task-segment: [install] [INFO] - --- [INFO] [enforcer:enforce {execution: default}] [INFO] [tools:copy-legal-files {execution: install-legal-files}] [INFO] Created dir: E:\g20\g20\configs\client-security\target\classes\META-INF [INFO] Copying 2 files to E:\g20\g20\configs\client-security\target\classes\META -INF [INFO] [resources:resources] [INFO] Using default encoding to copy filtered resources. [INFO] [car:prepare-plan] [INFO] Generated: E:\g20\g20\configs\client-security\target\plan\plan.xml [INFO] [car:package] [INFO] Packaging module configuration: E:\g20\g20\configs\client-security\target \plan\plan.xml [INFO] [ERROR] BUILD ERROR [INFO] [INFO] org.apache.xmlbeans.XmlException: Cannot find desiredElement application with namespace={http://geronimo.apache.org/xml/ns/j2ee/application-1.2} in plan= !--Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the License); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.-- !--$Rev: 480572 $ $Date: 2006-11-29 09:01:50 -0500 (Wed, 29 Nov 2006) $-- module xmlns=http://geronimo.apache.org/xml/ns/deployment-1.2; !--required-- environment moduleId groupIdorg.apache.geronimo.configs/groupId artifactIdclient-security/artifactId version2.0-SNAPSHOT/version typecar/type /moduleId dependencies dependency groupIdorg.apache.geronimo.configs/groupId artifactIdclient/artifactId typecar/type /dependency dependency groupIdorg.apache.geronimo.modules/groupId artifactIdgeronimo-security/artifactId version2.0-SNAPSHOT/version typejar/type importclasses/import /dependency /dependencies hidden-classes/ non-overridable-classes/ /environment gbean name=SecurityService class=org.apache.geronimo.security.SecurityServ iceImpl reference name=ServerInfo nameServerInfo/name /reference attribute name=policyConfigurationFactoryorg.apache.geronimo.security.ja cc.GeronimoPolicyConfigurationFactory/attribute attribute name=policyProviderorg.apache.geronimo.security.jacc.GeronimoP olicy/attribute attribute name=keyStorevar/security/clientcert.jks/attribute attribute name=keyStorePasswordchangeit/attribute attribute name=trustStorevar/security/clientcert.jks/attribute attribute name=trustStorePasswordchangeit/attribute /gbean !--required-- gbean name=LoginConfiguration class=org.apache.geronimo.security.jaas.Gero nimoLoginConfiguration references name=Configurations pattern typeSecurityRealm/type /pattern pattern typeConfigurationEntry/type /pattern /references /gbean !--use for app client: logs into server remotely-- gbean name=ServerLoginStubDCE class=org.apache.geronimo.security.jaas.Dire ctConfigurationEntry attribute name=applicationConfigNameserver-login/attribute attribute name=controlFlagREQUIRED/attribute reference name=Module nameServerLoginCoordinator/name /reference /gbean gbean name=ServerLoginCoordinator class=org.apache.geronimo.security.jaas. LoginModuleGBean attribute name=loginModuleClassorg.apache.geronimo.security.jaas.client. JaasLoginCoordinator/attribute attribute name=serverSidefalse/attribute attribute name=optionshost=localhost port=4242 realm=geronimo-admin/attribute attribute name=loginDomainNamegeronimo-admin/attribute /gbean !--useful for corba: logs into a local realm, and server must reauthenticate each call-- gbean name=client-properties-realm
[jira] Commented: (GERONIMO-1642) Deployment plan namespace validation
[ http://issues.apache.org/jira/browse/GERONIMO-1642?page=comments#action_12459220 ] David Jencks commented on GERONIMO-1642: I'm really not sure this is still a problem. For instance JettyModuleBuilder AFAICT throws an exception explaining the xml problem if it finds a geronimo-web or geronimo-jetty.xml file that it can't interpret. When looking for examples that fail keep in mind that XmlBeansUtil.parse does a lot of namespace substitution and many builders have code to upgrade documents valid for earlier versions of geronimo plan schemas to the latest versions. So, wrong namespace should mean namespace we have never used rather than not the current namespace Deployment plan namespace validation Key: GERONIMO-1642 URL: http://issues.apache.org/jira/browse/GERONIMO-1642 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: deployment, OpenEJB, web Affects Versions: 1.1 Reporter: Aaron Mulder Assigned To: Rakesh Midha Priority: Critical Fix For: 1.1.x When you deploy with a geronimo deployment plan packaged in the archive, but it has the wrong namespace, the file is ignored. If anything, you get a message saying the plan is required, or that the archive is not a WAR/JAR/etc. We should have special detection for geronimo-application.xml, geronimo-ra.xml, geronimo-web.xml, and openejb-jar.xml that notices if the file is present but has the wrong namespace, and prints a suggestive WARN or ERROR message to the console. Probably for the application.xml, web.xml, ra.xml, and ejb-jar.xml too. People have asked for help on the mailing list several times recently when they had this (bad namespace) problem. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira