[jira] Commented: (GERONIMO-2333) Add JMX Portlet
[ http://issues.apache.org/jira/browse/GERONIMO-2333?page=comments#action_12438822 ] Paul McMahan commented on GERONIMO-2333: Thanks Vamsi, I believe that was an accidental holdover from the patch created for GERONIMO-1823. Fixed in r451486. > Add JMX Portlet > --- > > Key: GERONIMO-2333 > URL: http://issues.apache.org/jira/browse/GERONIMO-2333 > Project: Geronimo > Issue Type: New Feature > Security Level: public(Regular issues) > Components: console >Affects Versions: 1.2 >Reporter: Christopher M. Cardona > Assigned To: Paul McMahan > Fix For: 1.2 > > Attachments: dojo-0.3.1-bin.zip, GERONIMO-2333-trunk.patch, > GERONIMO-2333-trunk2.patch, GERONIMO-2333-trunk3.patch, > jmxMgrPortlet-G1.1.1-1.jpg, jmxMgrPortlet-G1.1.1-2.jpg, > jmxMgrPortlet-G1.1.1-3.jpg, jmxMgrPortlet-G1.1.1-New.patch, > jmxMgrPortlet-G1.1.1.patch > > > Add a JMX portlet with the following minimum capabilities: > 1. Be able to list all the MBeans > 2. Predefined searches for the different J2EE types: J2EEApplication, > EJBModule, WebModule, Sertlet, JCAConnectionFactory, etc. > 3. Be able to query MBeans (if possible with autocomplete feature) > 4. View the attributes and operations of MBeans > The plan is to use Ajax (Dojo and DWR) to make this portlet a little bit > responsive. Any thoughts and suggestions are welcome. > cheers, > chris -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2333) Add JMX Portlet
[ http://issues.apache.org/jira/browse/GERONIMO-2333?page=comments#action_12438786 ] Christopher M. Cardona commented on GERONIMO-2333: -- Hi Vamsavardhana, Good catch. The JMX Viewer has nothing to do with the internal LDAP Server. This should be updated. You can file a jira if you want and I'll create a patch for it. I'll be sending a patch containing some changes for this portlet which was discussed on the devlist with Anita. Thanks. > Add JMX Portlet > --- > > Key: GERONIMO-2333 > URL: http://issues.apache.org/jira/browse/GERONIMO-2333 > Project: Geronimo > Issue Type: New Feature > Security Level: public(Regular issues) > Components: console >Affects Versions: 1.2 >Reporter: Christopher M. Cardona > Assigned To: Paul McMahan > Fix For: 1.2 > > Attachments: dojo-0.3.1-bin.zip, GERONIMO-2333-trunk.patch, > GERONIMO-2333-trunk2.patch, GERONIMO-2333-trunk3.patch, > jmxMgrPortlet-G1.1.1-1.jpg, jmxMgrPortlet-G1.1.1-2.jpg, > jmxMgrPortlet-G1.1.1-3.jpg, jmxMgrPortlet-G1.1.1-New.patch, > jmxMgrPortlet-G1.1.1.patch > > > Add a JMX portlet with the following minimum capabilities: > 1. Be able to list all the MBeans > 2. Predefined searches for the different J2EE types: J2EEApplication, > EJBModule, WebModule, Sertlet, JCAConnectionFactory, etc. > 3. Be able to query MBeans (if possible with autocomplete feature) > 4. View the attributes and operations of MBeans > The plan is to use Ajax (Dojo and DWR) to make this portlet a little bit > responsive. Any thoughts and suggestions are welcome. > cheers, > chris -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2333) Add JMX Portlet
[ http://issues.apache.org/jira/browse/GERONIMO-2333?page=comments#action_12438741 ] Vamsavardhana Reddy commented on GERONIMO-2333: --- I find the following chunk in pageregistry.xml JMX Viewer ico_filetree_16x16.gif Manage the internal LDAP server Has JMX Viewer got something to do with internal LDAP Server? > Add JMX Portlet > --- > > Key: GERONIMO-2333 > URL: http://issues.apache.org/jira/browse/GERONIMO-2333 > Project: Geronimo > Issue Type: New Feature > Security Level: public(Regular issues) > Components: console >Affects Versions: 1.2 >Reporter: Christopher M. Cardona > Assigned To: Paul McMahan > Fix For: 1.2 > > Attachments: dojo-0.3.1-bin.zip, GERONIMO-2333-trunk.patch, > GERONIMO-2333-trunk2.patch, GERONIMO-2333-trunk3.patch, > jmxMgrPortlet-G1.1.1-1.jpg, jmxMgrPortlet-G1.1.1-2.jpg, > jmxMgrPortlet-G1.1.1-3.jpg, jmxMgrPortlet-G1.1.1-New.patch, > jmxMgrPortlet-G1.1.1.patch > > > Add a JMX portlet with the following minimum capabilities: > 1. Be able to list all the MBeans > 2. Predefined searches for the different J2EE types: J2EEApplication, > EJBModule, WebModule, Sertlet, JCAConnectionFactory, etc. > 3. Be able to query MBeans (if possible with autocomplete feature) > 4. View the attributes and operations of MBeans > The plan is to use Ajax (Dojo and DWR) to make this portlet a little bit > responsive. Any thoughts and suggestions are welcome. > cheers, > chris -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2333) Add JMX Portlet
[ http://issues.apache.org/jira/browse/GERONIMO-2333?page=comments#action_12437580 ] Paul McMahan commented on GERONIMO-2333: Chris, great job on this! I checked in the files and will go ahead and mark this JIRA resoloved. As I recall there were a few additional items you were investigating. If you have any subsequent changes then feel free to reopen this JIRA or open a new one. > Add JMX Portlet > --- > > Key: GERONIMO-2333 > URL: http://issues.apache.org/jira/browse/GERONIMO-2333 > Project: Geronimo > Issue Type: New Feature > Security Level: public(Regular issues) > Components: console >Affects Versions: 1.2 >Reporter: Christopher M. Cardona > Assigned To: Christopher M. Cardona > Attachments: dojo-0.3.1-bin.zip, GERONIMO-2333-trunk.patch, > GERONIMO-2333-trunk2.patch, GERONIMO-2333-trunk3.patch, > jmxMgrPortlet-G1.1.1-1.jpg, jmxMgrPortlet-G1.1.1-2.jpg, > jmxMgrPortlet-G1.1.1-3.jpg, jmxMgrPortlet-G1.1.1-New.patch, > jmxMgrPortlet-G1.1.1.patch > > > Add a JMX portlet with the following minimum capabilities: > 1. Be able to list all the MBeans > 2. Predefined searches for the different J2EE types: J2EEApplication, > EJBModule, WebModule, Sertlet, JCAConnectionFactory, etc. > 3. Be able to query MBeans (if possible with autocomplete feature) > 4. View the attributes and operations of MBeans > The plan is to use Ajax (Dojo and DWR) to make this portlet a little bit > responsive. Any thoughts and suggestions are welcome. > cheers, > chris -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2333) Add JMX Portlet
[ http://issues.apache.org/jira/browse/GERONIMO-2333?page=comments#action_12437575 ] Paul McMahan commented on GERONIMO-2333: Thanks for the nudge Gianny :-) Sending applications\console\geronimo-console-framework\src\main\webapp\WEB-INF\data\pageregistry.xml Sending applications\console\geronimo-console-framework\src\main\webapp\WEB-INF\data\portletentityregistry.xml Adding applications\console\geronimo-console-standard\src\main\java\org\apache\geronimo\console\jmxmanager Adding applications\console\geronimo-console-standard\src\main\java\org\apache\geronimo\console\jmxmanager\JMXManagerHelper.java Adding applications\console\geronimo-console-standard\src\main\java\org\apache\geronimo\console\jmxmanager\JMXManagerPortlet.java Sending applications\console\geronimo-console-standard\src\main\webapp\WEB-INF\dwr.xml Sending applications\console\geronimo-console-standard\src\main\webapp\WEB-INF\portlet.xml Adding applications\console\geronimo-console-standard\src\main\webapp\WEB-INF\view\jmxmanager Adding applications\console\geronimo-console-standard\src\main\webapp\WEB-INF\view\jmxmanager\help.jsp Adding applications\console\geronimo-console-standard\src\main\webapp\WEB-INF\view\jmxmanager\viewJMXServer.jsp Sending applications\console\geronimo-console-standard\src\main\webapp\WEB-INF\web.xml Transmitting file data .. Committed revision 449693. > Add JMX Portlet > --- > > Key: GERONIMO-2333 > URL: http://issues.apache.org/jira/browse/GERONIMO-2333 > Project: Geronimo > Issue Type: New Feature > Security Level: public(Regular issues) > Components: console >Affects Versions: 1.2 >Reporter: Christopher M. Cardona > Assigned To: Christopher M. Cardona > Attachments: dojo-0.3.1-bin.zip, GERONIMO-2333-trunk.patch, > GERONIMO-2333-trunk2.patch, GERONIMO-2333-trunk3.patch, > jmxMgrPortlet-G1.1.1-1.jpg, jmxMgrPortlet-G1.1.1-2.jpg, > jmxMgrPortlet-G1.1.1-3.jpg, jmxMgrPortlet-G1.1.1-New.patch, > jmxMgrPortlet-G1.1.1.patch > > > Add a JMX portlet with the following minimum capabilities: > 1. Be able to list all the MBeans > 2. Predefined searches for the different J2EE types: J2EEApplication, > EJBModule, WebModule, Sertlet, JCAConnectionFactory, etc. > 3. Be able to query MBeans (if possible with autocomplete feature) > 4. View the attributes and operations of MBeans > The plan is to use Ajax (Dojo and DWR) to make this portlet a little bit > responsive. Any thoughts and suggestions are welcome. > cheers, > chris -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2333) Add JMX Portlet
[ http://issues.apache.org/jira/browse/GERONIMO-2333?page=comments#action_12437541 ] Gianny Damour commented on GERONIMO-2333: - Paul, do you want to progress further this patch, i.e. ci it? > Add JMX Portlet > --- > > Key: GERONIMO-2333 > URL: http://issues.apache.org/jira/browse/GERONIMO-2333 > Project: Geronimo > Issue Type: New Feature > Security Level: public(Regular issues) > Components: console >Affects Versions: 1.2 >Reporter: Christopher M. Cardona > Assigned To: Christopher M. Cardona > Attachments: dojo-0.3.1-bin.zip, GERONIMO-2333-trunk.patch, > GERONIMO-2333-trunk2.patch, GERONIMO-2333-trunk3.patch, > jmxMgrPortlet-G1.1.1-1.jpg, jmxMgrPortlet-G1.1.1-2.jpg, > jmxMgrPortlet-G1.1.1-3.jpg, jmxMgrPortlet-G1.1.1-New.patch, > jmxMgrPortlet-G1.1.1.patch > > > Add a JMX portlet with the following minimum capabilities: > 1. Be able to list all the MBeans > 2. Predefined searches for the different J2EE types: J2EEApplication, > EJBModule, WebModule, Sertlet, JCAConnectionFactory, etc. > 3. Be able to query MBeans (if possible with autocomplete feature) > 4. View the attributes and operations of MBeans > The plan is to use Ajax (Dojo and DWR) to make this portlet a little bit > responsive. Any thoughts and suggestions are welcome. > cheers, > chris -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2333) Add JMX Portlet
[ http://issues.apache.org/jira/browse/GERONIMO-2333?page=comments#action_12434823 ] Christopher M. Cardona commented on GERONIMO-2333: -- Thanks David for checking out the patch. Dojo needs to be unpacked since the browser needs to load those javascript files including some bitmap files used by the widgets. I also agree that a separate plugin/module will be a cleaner solution. Regarding horizontal versus vertical splitter, switching from one to the other is a simple change to the code. The reason why I decided to go with the horizontal orientation is because it's a common practice for GUIs to have the tree navigation on the leftmost area but I'm open to changing it if that's what we want. You made a very good point about data readability issues. We definitely need to address them as we go along. Thanks again for your help. > Add JMX Portlet > --- > > Key: GERONIMO-2333 > URL: http://issues.apache.org/jira/browse/GERONIMO-2333 > Project: Geronimo > Issue Type: New Feature > Security Level: public(Regular issues) > Components: console >Affects Versions: 1.2 >Reporter: Christopher M. Cardona > Assigned To: Christopher M. Cardona > Attachments: dojo-0.3.1-bin.zip, GERONIMO-2333-trunk.patch, > jmxMgrPortlet-G1.1.1-1.jpg, jmxMgrPortlet-G1.1.1-2.jpg, > jmxMgrPortlet-G1.1.1-3.jpg, jmxMgrPortlet-G1.1.1-New.patch, > jmxMgrPortlet-G1.1.1.patch > > > Add a JMX portlet with the following minimum capabilities: > 1. Be able to list all the MBeans > 2. Predefined searches for the different J2EE types: J2EEApplication, > EJBModule, WebModule, Sertlet, JCAConnectionFactory, etc. > 3. Be able to query MBeans (if possible with autocomplete feature) > 4. View the attributes and operations of MBeans > The plan is to use Ajax (Dojo and DWR) to make this portlet a little bit > responsive. Any thoughts and suggestions are welcome. > cheers, > chris -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2333) Add JMX Portlet
[ http://issues.apache.org/jira/browse/GERONIMO-2333?page=comments#action_12434786 ] Paul McMahan commented on GERONIMO-2333: David, the trunk version of the patch didn't work for me. I may not have applied it correctly. I can see where the new portlet is registered in the console but when I try to start it I get a javascript error: Error: dojo.require is not a function Source File: http://localhost:8080/console/portal/JMXViewer Line: 22 followed by some more errors. BTW, I just created GERONIMO-2406 for separating the Dojo library into a separate webapp. If the JMX portlet goes in first then I can work with Chris to retrofit when GERONIMO-2406 is ready, or he may want to wait on it. > Add JMX Portlet > --- > > Key: GERONIMO-2333 > URL: http://issues.apache.org/jira/browse/GERONIMO-2333 > Project: Geronimo > Issue Type: New Feature > Security Level: public(Regular issues) > Components: console >Affects Versions: 1.2 >Reporter: Christopher M. Cardona > Assigned To: Christopher M. Cardona > Attachments: dojo-0.3.1-bin.zip, GERONIMO-2333-trunk.patch, > jmxMgrPortlet-G1.1.1-1.jpg, jmxMgrPortlet-G1.1.1-2.jpg, > jmxMgrPortlet-G1.1.1-3.jpg, jmxMgrPortlet-G1.1.1-New.patch, > jmxMgrPortlet-G1.1.1.patch > > > Add a JMX portlet with the following minimum capabilities: > 1. Be able to list all the MBeans > 2. Predefined searches for the different J2EE types: J2EEApplication, > EJBModule, WebModule, Sertlet, JCAConnectionFactory, etc. > 3. Be able to query MBeans (if possible with autocomplete feature) > 4. View the attributes and operations of MBeans > The plan is to use Ajax (Dojo and DWR) to make this portlet a little bit > responsive. Any thoughts and suggestions are welcome. > cheers, > chris -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2333) Add JMX Portlet
[ http://issues.apache.org/jira/browse/GERONIMO-2333?page=comments#action_12434757 ] David Jencks commented on GERONIMO-2333: This is very nice. +1 from me, wherever the dojo files end up. I think a separate plugin would be better. Do they need to be unpacked or can we just include them in a packed jar in the classpath? What would people think of a top-bottom split rather than the side to side split? On my 17" mac I cant see that much of either the names in the tree or the stuff in the tables on the right. I'm not sure this is enough of a bug-fix to apply to the 1.1.x branch but I certainly want it in trunk ASAP. I'll attach a patch with the paths modified to trunk, and including the dojo stuff unpacked according to Chris' instructions > Add JMX Portlet > --- > > Key: GERONIMO-2333 > URL: http://issues.apache.org/jira/browse/GERONIMO-2333 > Project: Geronimo > Issue Type: New Feature > Security Level: public(Regular issues) > Components: console >Affects Versions: 1.2 >Reporter: Christopher M. Cardona > Assigned To: Christopher M. Cardona > Attachments: dojo-0.3.1-bin.zip, jmxMgrPortlet-G1.1.1-1.jpg, > jmxMgrPortlet-G1.1.1-2.jpg, jmxMgrPortlet-G1.1.1-3.jpg, > jmxMgrPortlet-G1.1.1-New.patch, jmxMgrPortlet-G1.1.1.patch > > > Add a JMX portlet with the following minimum capabilities: > 1. Be able to list all the MBeans > 2. Predefined searches for the different J2EE types: J2EEApplication, > EJBModule, WebModule, Sertlet, JCAConnectionFactory, etc. > 3. Be able to query MBeans (if possible with autocomplete feature) > 4. View the attributes and operations of MBeans > The plan is to use Ajax (Dojo and DWR) to make this portlet a little bit > responsive. Any thoughts and suggestions are welcome. > cheers, > chris -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2333) Add JMX Portlet
[ http://issues.apache.org/jira/browse/GERONIMO-2333?page=comments#action_12434713 ] Paul McMahan commented on GERONIMO-2333: Like Gianny I had problems using Safari 2.0.4. I also had problems with Konqueror 3.5.2, it displayed the message: FATAL: symbol 'dojo.widget' is not defined after loading __package__.js These two browsers are based on the same rendering engine so that's not surprising. Creating a sophisticated web UI that works in all browsers is extremely difficult. Since the UI works in firefox which is available in most environments IMHO its OK to keep moving forward and work with the dojo project to get a fix for those problems later. > Add JMX Portlet > --- > > Key: GERONIMO-2333 > URL: http://issues.apache.org/jira/browse/GERONIMO-2333 > Project: Geronimo > Issue Type: New Feature > Security Level: public(Regular issues) > Components: console >Affects Versions: 1.2 >Reporter: Chris Cardona > Assigned To: Chris Cardona > Attachments: dojo-0.3.1-bin.zip, jmxMgrPortlet-G1.1.1-1.jpg, > jmxMgrPortlet-G1.1.1-2.jpg, jmxMgrPortlet-G1.1.1-3.jpg, > jmxMgrPortlet-G1.1.1-New.patch, jmxMgrPortlet-G1.1.1.patch > > > Add a JMX portlet with the following minimum capabilities: > 1. Be able to list all the MBeans > 2. Predefined searches for the different J2EE types: J2EEApplication, > EJBModule, WebModule, Sertlet, JCAConnectionFactory, etc. > 3. Be able to query MBeans (if possible with autocomplete feature) > 4. View the attributes and operations of MBeans > The plan is to use Ajax (Dojo and DWR) to make this portlet a little bit > responsive. Any thoughts and suggestions are welcome. > cheers, > chris -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2333) Add JMX Portlet
[ http://issues.apache.org/jira/browse/GERONIMO-2333?page=comments#action_12434603 ] Chris Cardona commented on GERONIMO-2333: - Gianny, I appreciate all your help on checking out this patch too bad it didn't work out in Safari otherwise it would have been sweet. :-) I would love to know if you guys have additional comments to make the patch better. I'm currently recreating the patch to make it work on trunk and include some changes suggested by Paul. Also, if we made a final decision on how to include Dojo source in G I would change the patch accordingly. Thanks again. > Add JMX Portlet > --- > > Key: GERONIMO-2333 > URL: http://issues.apache.org/jira/browse/GERONIMO-2333 > Project: Geronimo > Issue Type: New Feature > Security Level: public(Regular issues) > Components: console >Affects Versions: 1.2 >Reporter: Chris Cardona > Assigned To: Chris Cardona > Attachments: dojo-0.3.1-bin.zip, jmxMgrPortlet-G1.1.1-1.jpg, > jmxMgrPortlet-G1.1.1-2.jpg, jmxMgrPortlet-G1.1.1-3.jpg, > jmxMgrPortlet-G1.1.1-New.patch, jmxMgrPortlet-G1.1.1.patch > > > Add a JMX portlet with the following minimum capabilities: > 1. Be able to list all the MBeans > 2. Predefined searches for the different J2EE types: J2EEApplication, > EJBModule, WebModule, Sertlet, JCAConnectionFactory, etc. > 3. Be able to query MBeans (if possible with autocomplete feature) > 4. View the attributes and operations of MBeans > The plan is to use Ajax (Dojo and DWR) to make this portlet a little bit > responsive. Any thoughts and suggestions are welcome. > cheers, > chris -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2333) Add JMX Portlet
[ http://issues.apache.org/jira/browse/GERONIMO-2333?page=comments#action_12434461 ] Gianny Damour commented on GERONIMO-2333: - This is a VERY VERY VERY nice work!!! At least, I have been able to get it working and I think that this represents a huge amount of work. I now need to review the implementation; yet I already vote +1 to apply it. Althought, it is worth to note that this portlet does not work with Safari. Safari returns a "Maximum call stack size exceeded." JavaScript error message and it seems to be a known Dojo problem. See this thread http://dojotoolkit.org/pipermail/dojo-checkins/2006-July/008159.html for a user reporting such a problem. Having said that, it works great with IE. Many thanks for your hard work Chris! > Add JMX Portlet > --- > > Key: GERONIMO-2333 > URL: http://issues.apache.org/jira/browse/GERONIMO-2333 > Project: Geronimo > Issue Type: New Feature > Security Level: public(Regular issues) > Components: console >Affects Versions: 1.2 >Reporter: Chris Cardona > Assigned To: Chris Cardona > Attachments: dojo-0.3.1-bin.zip, jmxMgrPortlet-G1.1.1-1.jpg, > jmxMgrPortlet-G1.1.1-2.jpg, jmxMgrPortlet-G1.1.1-3.jpg, > jmxMgrPortlet-G1.1.1-New.patch, jmxMgrPortlet-G1.1.1.patch > > > Add a JMX portlet with the following minimum capabilities: > 1. Be able to list all the MBeans > 2. Predefined searches for the different J2EE types: J2EEApplication, > EJBModule, WebModule, Sertlet, JCAConnectionFactory, etc. > 3. Be able to query MBeans (if possible with autocomplete feature) > 4. View the attributes and operations of MBeans > The plan is to use Ajax (Dojo and DWR) to make this portlet a little bit > responsive. Any thoughts and suggestions are welcome. > cheers, > chris -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2333) Add JMX Portlet
[ http://issues.apache.org/jira/browse/GERONIMO-2333?page=comments#action_12434280 ] Chris Cardona commented on GERONIMO-2333: - > Chris the new portlet looks fantastic!! It will be a huge help for > administrators and developers needing to explore the server. I > especially like the well designed use of ajax controls. > Paul, thanks for finding time to check this patch. Your comments and suggestions are very helpful. Please see my comments below: > A few comments to consider before this is committed. I would be > happy to help follow up on any of these items, just let me know: > - I think that the dojo license is compatible with ASL but before > embedding it in the server I think the Geronimo PMC should be > notified and allowed to make an "official" decision on its inclusion I agree. I will send out an email to the devlist regarding this. > - At one time there was an attempt to convert all use of ObjectName > over > to AbstractName so certain deprecated methods could be removed > from the kernel, but I don't know where that stands now. If > replacing ObjectNames with AbstractNames is not simple then can you > check > on the dev list to see if introducing more of use of it creates > any concern? I'm already using AbstractNames in my patch when possible. The only part where I used ObjectNames is for objectname patterns when searching MBeans. I haven't found a solution to use AbstractNames for cases where the search pattern specifies only domain names - e.g. geronimo.config:*. Hopefully somebody with a solution can comment on this. > - A few new files need copyright headers (e.g. viewJMXServer.jsp) I intentionally didn't add copyright headers on the jsp files because we never did in our console code. No biggie, I'll include these changes in a new patch. > - Since this is a new feature can you provide a patch for trunk > instead of the 1.1.x branch? I think the only real difference in > trunk is that the console directories were moved. I'm working on this right now. I'll update this jira when the patch is done. > - The "JMX Viewer" link in the Console Navigation area should maybe > go in > the Server folder instead of a new top level item. But I can > go either way if there are strong opinions otherwise. That works for me too but I'm also open to other suggestions. This is easy to change so I would love to know what others think about this. > - Need to test on safari, konqueror, and opera. I'll do this > tonight if possible and update the JIRA with results. Thanks for helping on this. I'll also try testing it on Opera and Konqueror. > - Later we may want to separate the dojo library into a plugin like > was discussed on the dev list. I think the way you've implemented > this portlet will facilitate that approach, is that true? > AFAIK, if we finally agree to do this I don't see any potential problem with my current implementation. > Here are a few suggestions for if /when you or someone else want to > make some improvements. IMO these changes are not required before > commiting. > - When a user clicks on a leaf node it loads data into the notebook > area. > To avoid confusion I recommend clearing that data when they > click on a group node. No problem with this. I think I can squeeze this in the new patch. > - At first it wasn't obvious to me that there's a lot more data in > the notebook area if you scroll right. If the dojo table widget can > do > resizable columns then that would help. We can include this next time. > - It would be nice if the mouse pointer glyph changed to an hour > glass while data was loading from the server. For example, some > actions like initial bringup, loading data into the notebook area, or > > expanding the "All MBeans-->geronimo" node take several seconds. > Providing an indication that the UI was processing their request > would keep them from re-clicking or wondering if the UI is hung. > I agree. Actually, I got stuck looking for a solution to this so I decided to save this under my todo bucket. > Again, nice work! Thanks again for your comments and suggestions. Best wishes, chris > Add JMX Portlet > --- > > Key: GERONIMO-2333 > URL: http://issues.apache.org/jira/browse/GERONIMO-2333 > Project: Geronimo > Issue Type: New Feature > Security Level: public(Regular issues) > Components: console >Affects Versions: 1.2 >Reporter: Chris Cardona > Assigned To: Chris Cardona > Attachments: dojo-0.3.1-bin.zip, jmxMgrPortlet-G1.1.1-1.jpg, > jmxMgrPortlet-G1.1.1-2.jpg, jmxMgrPortlet-G1.1.1-3.jpg, > jmxMgrPortlet-G1.1.1-New.patch, jmxMgrPortlet-G1.1.1.patch > > > Add a JMX portlet with the following minimum capabilities: > 1. Be able to list all the MBeans > 2. Predefined searches for the different J2EE types: J2EEApplication, > E
[jira] Commented: (GERONIMO-2333) Add JMX Portlet
[ http://issues.apache.org/jira/browse/GERONIMO-2333?page=comments#action_12433923 ] Paul McMahan commented on GERONIMO-2333: Chris the new portlet looks fantastic!! It will be a huge help for administrators and developers needing to explore the server. I especially like the well designed use of ajax controls. A few comments to consider before this is committed. I would be happy to help follow up on any of these items, just let me know: - I think that the dojo license is compatible with ASL but before embedding it in the server I think the Geronimo PMC should be notified and allowed to make an "official" decision on its inclusion - At one time there was an attempt to convert all use of ObjectName over to AbstractName so certain deprecated methods could be removed from the kernel, but I don't know where that stands now. If replacing ObjectNames with AbstractNames is not simple then can you check on the dev list to see if introducing more of use of it creates any concern? - A few new files need copyright headers (e.g. viewJMXServer.jsp) - Since this is a new feature can you provide a patch for trunk instead of the 1.1.x branch? I think the only real difference in trunk is that the console directories were moved. - The "JMX Viewer" link in the Console Navigation area should maybe go in the Server folder instead of a new top level item. But I can go either way if there are strong opinions otherwise. - Need to test on safari, konqueror, and opera. I'll do this tonight if possible and update the JIRA with results. - Later we may want to separate the dojo library into a plugin like was discussed on the dev list. I think the way you've implemented this portlet will facilitate that approach, is that true? Here are a few suggestions for if /when you or someone else want to make some improvements. IMO these changes are not required before commiting. - When a user clicks on a leaf node it loads data into the notebook area. To avoid confusion I recommend clearing that data when they click on a group node. - At first it wasn't obvious to me that there's a lot more data in the notebook area if you scroll right. If the dojo table widget can do resizable columns then that would help. - It would be nice if the mouse pointer glyph changed to an hour glass while data was loading from the server. For example, some actions like initial bringup, loading data into the notebook area, or expanding the "All MBeans-->geronimo" node take several seconds. Providing an indication that the UI was processing their request would keep them from re-clicking or wondering if the UI is hung. Again, nice work! > Add JMX Portlet > --- > > Key: GERONIMO-2333 > URL: http://issues.apache.org/jira/browse/GERONIMO-2333 > Project: Geronimo > Issue Type: New Feature > Security Level: public(Regular issues) > Components: console >Affects Versions: 1.2 >Reporter: Chris Cardona > Assigned To: Chris Cardona > Attachments: dojo-0.3.1-bin.zip, jmxMgrPortlet-G1.1.1-1.jpg, > jmxMgrPortlet-G1.1.1-2.jpg, jmxMgrPortlet-G1.1.1-3.jpg, > jmxMgrPortlet-G1.1.1-New.patch, jmxMgrPortlet-G1.1.1.patch > > > Add a JMX portlet with the following minimum capabilities: > 1. Be able to list all the MBeans > 2. Predefined searches for the different J2EE types: J2EEApplication, > EJBModule, WebModule, Sertlet, JCAConnectionFactory, etc. > 3. Be able to query MBeans (if possible with autocomplete feature) > 4. View the attributes and operations of MBeans > The plan is to use Ajax (Dojo and DWR) to make this portlet a little bit > responsive. Any thoughts and suggestions are welcome. > cheers, > chris -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2333) Add JMX Portlet
[ http://issues.apache.org/jira/browse/GERONIMO-2333?page=comments#action_12433675 ] Chris Cardona commented on GERONIMO-2333: - Gianny, Good thing you tried out the patch otherwise I wouldn't know that I forgot to include the dojo related files in the patch. My bad... I attached a new patch. After applying the patch you need to unzip dojo-0.3.1-bin.zip under \applications\console-framework\src\webapp\js folder. This zip contains the image files used by dojo widgets. After this you can rebuild the console again. This should fix your problem. It would be nice to know if the JMX portlet also works in Safari (I don't have a mac to play with). I only tested on IE and Firefox but Dojo claims to support the following browsers: - Latest Safari (2.0.x today) - Latest Opera (8.5 today, 9.0 soon) - IE 5.5+ - Firefox 1.0+ - Latest Konqueror (3.5 today) Please let me know if you encounter any problems. Thanks! > Add JMX Portlet > --- > > Key: GERONIMO-2333 > URL: http://issues.apache.org/jira/browse/GERONIMO-2333 > Project: Geronimo > Issue Type: New Feature > Security Level: public(Regular issues) > Components: console >Affects Versions: 1.2 >Reporter: Chris Cardona > Assigned To: Chris Cardona > Attachments: dojo-0.3.1-bin.zip, jmxMgrPortlet-G1.1.1-1.jpg, > jmxMgrPortlet-G1.1.1-2.jpg, jmxMgrPortlet-G1.1.1-3.jpg, > jmxMgrPortlet-G1.1.1-New.patch, jmxMgrPortlet-G1.1.1.patch > > > Add a JMX portlet with the following minimum capabilities: > 1. Be able to list all the MBeans > 2. Predefined searches for the different J2EE types: J2EEApplication, > EJBModule, WebModule, Sertlet, JCAConnectionFactory, etc. > 3. Be able to query MBeans (if possible with autocomplete feature) > 4. View the attributes and operations of MBeans > The plan is to use Ajax (Dojo and DWR) to make this portlet a little bit > responsive. Any thoughts and suggestions are welcome. > cheers, > chris -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2333) Add JMX Portlet
[ http://issues.apache.org/jira/browse/GERONIMO-2333?page=comments#action_12433655 ] Gianny Damour commented on GERONIMO-2333: - Sorry for that Chris; my bad, I reverted some changes to console-framework (I was testing other patches) hence my comment. This looks slightly better as I can now see the JMX Viewer link at the bottom of the page. Unfortunately, it seems that dojo.js and iframe_history.html are not in dojo-0.3.1-bin.zip (I double checked). So, I downloaded these files from dojo. Now, I have this error message: "FATAL: symbol 'dojo.lang' is not defined after loading '__package__.js'". I will try to investigate during the day. My browser is Safari if this helps. Thanks. > Add JMX Portlet > --- > > Key: GERONIMO-2333 > URL: http://issues.apache.org/jira/browse/GERONIMO-2333 > Project: Geronimo > Issue Type: New Feature > Security Level: public(Regular issues) > Components: console >Affects Versions: 1.2 >Reporter: Chris Cardona > Assigned To: Chris Cardona > Attachments: dojo-0.3.1-bin.zip, jmxMgrPortlet-G1.1.1-1.jpg, > jmxMgrPortlet-G1.1.1-2.jpg, jmxMgrPortlet-G1.1.1-3.jpg, > jmxMgrPortlet-G1.1.1.patch > > > Add a JMX portlet with the following minimum capabilities: > 1. Be able to list all the MBeans > 2. Predefined searches for the different J2EE types: J2EEApplication, > EJBModule, WebModule, Sertlet, JCAConnectionFactory, etc. > 3. Be able to query MBeans (if possible with autocomplete feature) > 4. View the attributes and operations of MBeans > The plan is to use Ajax (Dojo and DWR) to make this portlet a little bit > responsive. Any thoughts and suggestions are welcome. > cheers, > chris -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2333) Add JMX Portlet
[ http://issues.apache.org/jira/browse/GERONIMO-2333?page=comments#action_12433618 ] Chris Cardona commented on GERONIMO-2333: - Hi Gianny, Thanks for checking out the patch. FYI, here's a list of the modified and added files included in the patch: A 1. applications\console-standard\src\java\org\apache\geronimo\console\jmxmanager\JMXManagerHelper.java A 2. applications\console-standard\src\java\org\apache\geronimo\console\jmxmanager\JMXManagerPortlet.java M 3. applications\console-standard\src\webapp\WEB-INF\dwr.xml M 4. applications\console-standard\src\webapp\WEB-INF\portlet.xml M 5. applications\console-standard\src\webapp\WEB-INF\web.xml A 6. applications\console-standard\src\webapp\WEB-INF\view\jmxmanager\viewJMXServer.jsp A 7. applications\console-standard\src\webapp\WEB-INF\view\jmxmanager\help.jsp M 8. applications\console-framework\src\webapp\WEB-INF\aggregation\Head.jsp M 9. applications\console-framework\src\webapp\WEB-INF\data\pageregistry.xml M 10. applications\console-framework\src\webapp\WEB-INF\data\portletentityregistry.xml A 11. applications\console-framework\src\webapp\js\* - iframe_history.html - dojo.js - src\* Are you having build problems or did you build successfully but running the admin console doesn't show up the JMX manager portlet? There should be a 'JMX Viewer' link at the bottom of the left navigation tree of the admin console. Cheers, chris > Add JMX Portlet > --- > > Key: GERONIMO-2333 > URL: http://issues.apache.org/jira/browse/GERONIMO-2333 > Project: Geronimo > Issue Type: New Feature > Security Level: public(Regular issues) > Components: console >Affects Versions: 1.2 >Reporter: Chris Cardona > Assigned To: Chris Cardona > Attachments: dojo-0.3.1-bin.zip, jmxMgrPortlet-G1.1.1-1.jpg, > jmxMgrPortlet-G1.1.1-2.jpg, jmxMgrPortlet-G1.1.1-3.jpg, > jmxMgrPortlet-G1.1.1.patch > > > Add a JMX portlet with the following minimum capabilities: > 1. Be able to list all the MBeans > 2. Predefined searches for the different J2EE types: J2EEApplication, > EJBModule, WebModule, Sertlet, JCAConnectionFactory, etc. > 3. Be able to query MBeans (if possible with autocomplete feature) > 4. View the attributes and operations of MBeans > The plan is to use Ajax (Dojo and DWR) to make this portlet a little bit > responsive. Any thoughts and suggestions are welcome. > cheers, > chris -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2333) Add JMX Portlet
[ http://issues.apache.org/jira/browse/GERONIMO-2333?page=comments#action_12433579 ] Gianny Damour commented on GERONIMO-2333: - Chris, I think that this patch is incomplete: the portlet configuration is missing. The pictures look great :) > Add JMX Portlet > --- > > Key: GERONIMO-2333 > URL: http://issues.apache.org/jira/browse/GERONIMO-2333 > Project: Geronimo > Issue Type: New Feature > Security Level: public(Regular issues) > Components: console >Affects Versions: 1.2 >Reporter: Chris Cardona > Assigned To: Chris Cardona > Attachments: dojo-0.3.1-bin.zip, jmxMgrPortlet-G1.1.1-1.jpg, > jmxMgrPortlet-G1.1.1-2.jpg, jmxMgrPortlet-G1.1.1-3.jpg, > jmxMgrPortlet-G1.1.1.patch > > > Add a JMX portlet with the following minimum capabilities: > 1. Be able to list all the MBeans > 2. Predefined searches for the different J2EE types: J2EEApplication, > EJBModule, WebModule, Sertlet, JCAConnectionFactory, etc. > 3. Be able to query MBeans (if possible with autocomplete feature) > 4. View the attributes and operations of MBeans > The plan is to use Ajax (Dojo and DWR) to make this portlet a little bit > responsive. Any thoughts and suggestions are welcome. > cheers, > chris -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
