[jira] Commented: (GERONIMO-2352) j2ee-builder test deployment modules won't actually deploy
[
http://issues.apache.org/jira/browse/GERONIMO-2352?page=comments#action_12431875
]
Bill Dudney commented on GERONIMO-2352:
---
Hi Jason,
Thanks for taking the time to review and apply the patch!
One quick comment: the lack of inheritance from parent was because of a problem
with the jspc-maven-plugin configuration. I kept getting errors
('...geronimo/test-deployables/test-ear-j2ee-1.3/war/target/jspweb.xml' does
not exist). I tried messing with the configuration but could not quickly get
the build to work so I dropped the parent reference. I forgot to circle back
around and work through that. Is it possible to remove or block a build plugin
that was inherited from a parent pom? There are no jsp's in these war files, as
a workaround though I could add one to each and make the war look like what the
jspc plugin expects.
Thanks again!
j2ee-builder test deployment modules won't actually deploy
--
Key: GERONIMO-2352
URL: http://issues.apache.org/jira/browse/GERONIMO-2352
Project: Geronimo
Issue Type: Bug
Security Level: public(Regular issues)
Reporter: Bill Dudney
Assigned To: Jason Dillon
Attachments: GERONIMO-2352.bdudney.patch
The ear/war/ejb-jar/rar files wont actually deploy to the server.
I have a partial patch avalible but I'd like to get some discussion going on
how to fix some of the problems, that is happening in the dev list.
I will post the complete patch here when that discussion is wrapped up.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2352) j2ee-builder test deployment modules won't actually deploy
[
http://issues.apache.org/jira/browse/GERONIMO-2352?page=comments#action_12431882
]
Jeff Genender commented on GERONIMO-2352:
-
I wouldn't remove parent references. You have a couple of options. Either A)
open a JIRA on the jspc over at Mojo as that is a relatively easy fix, and/or
B) create an emply jspcweb.xml file in src/test/jspc/ and add the following to
your configuration:
webXml${basedir}/src/test/jspc/jspweb.xml/webXml
and be sure there is a !-- [INSERT FRAGMENT HERE] -- in the web.xml.
This will pick up the empty file. However if you use any JSPs for that war,
you will need to remove that configuration.
In any case...open up a JIRA at http://jira.codehaus.org/browse/MJSPC.
j2ee-builder test deployment modules won't actually deploy
--
Key: GERONIMO-2352
URL: http://issues.apache.org/jira/browse/GERONIMO-2352
Project: Geronimo
Issue Type: Bug
Security Level: public(Regular issues)
Reporter: Bill Dudney
Assigned To: Jason Dillon
Attachments: GERONIMO-2352.bdudney.patch
The ear/war/ejb-jar/rar files wont actually deploy to the server.
I have a partial patch avalible but I'd like to get some discussion going on
how to fix some of the problems, that is happening in the dev list.
I will post the complete patch here when that discussion is wrapped up.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2352) j2ee-builder test deployment modules won't actually deploy
[ http://issues.apache.org/jira/browse/GERONIMO-2352?page=comments#action_12431892 ] Bill Dudney commented on GERONIMO-2352: --- Hi Jeff, Thanks for helping with this. If I don't have a reference to the plugin in my war's pom.xml file the build fails with the lack of jspweb.xml file, if I put in a reference the build works, i.e. if I put this; build plugins plugin groupIdorg.codehaus.mojo/groupId artifactIdjspc-maven-plugin/artifactId /plugin /plugins /build into the war module's pom file it builds fine, without that it fails. Shouldn't this be there by default once the parent reference is in place? Thanks again! j2ee-builder test deployment modules won't actually deploy -- Key: GERONIMO-2352 URL: http://issues.apache.org/jira/browse/GERONIMO-2352 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Reporter: Bill Dudney Assigned To: Jason Dillon Attachments: GERONIMO-2352.bdudney.patch The ear/war/ejb-jar/rar files wont actually deploy to the server. I have a partial patch avalible but I'd like to get some discussion going on how to fix some of the problems, that is happening in the dev list. I will post the complete patch here when that discussion is wrapped up. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2352) j2ee-builder test deployment modules won't actually deploy
[ http://issues.apache.org/jira/browse/GERONIMO-2352?page=comments#action_12431896 ] Jeff Genender commented on GERONIMO-2352: - No...you need that there if you are going to override the configution which I explained earlier in this JIRA. You are overriding *only* for that WAR. j2ee-builder test deployment modules won't actually deploy -- Key: GERONIMO-2352 URL: http://issues.apache.org/jira/browse/GERONIMO-2352 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Reporter: Bill Dudney Assigned To: Jason Dillon Attachments: GERONIMO-2352.bdudney.patch The ear/war/ejb-jar/rar files wont actually deploy to the server. I have a partial patch avalible but I'd like to get some discussion going on how to fix some of the problems, that is happening in the dev list. I will post the complete patch here when that discussion is wrapped up. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2352) j2ee-builder test deployment modules won't actually deploy
[ http://issues.apache.org/jira/browse/GERONIMO-2352?page=comments#action_12431897 ] Bill Dudney commented on GERONIMO-2352: --- AFAIK I'm not overiding the configuration. There is no intent to overide it. If I copy the whole config out of the root pom the build works fine as well. j2ee-builder test deployment modules won't actually deploy -- Key: GERONIMO-2352 URL: http://issues.apache.org/jira/browse/GERONIMO-2352 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Reporter: Bill Dudney Assigned To: Jason Dillon Attachments: GERONIMO-2352.bdudney.patch The ear/war/ejb-jar/rar files wont actually deploy to the server. I have a partial patch avalible but I'd like to get some discussion going on how to fix some of the problems, that is happening in the dev list. I will post the complete patch here when that discussion is wrapped up. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2352) j2ee-builder test deployment modules won't actually deploy
[
http://issues.apache.org/jira/browse/GERONIMO-2352?page=comments#action_12431957
]
Jason Dillon commented on GERONIMO-2352:
These war's don't need jspc... the problem you saw was because the root pom
configures war's to assume that they are to be used with jspc by default... and
I even have some comments to remove that.
The fix is simiple though...
{code:xml}
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-war-plugin/artifactId
configuration
webXml${pom.basedir}/src/main/webapp/WEB-INF/web.xml/webXml
/configuration
/plugin
{code}
I will eventually reconfigure the default war plugin to not assume its being
used with jspc.
j2ee-builder test deployment modules won't actually deploy
--
Key: GERONIMO-2352
URL: http://issues.apache.org/jira/browse/GERONIMO-2352
Project: Geronimo
Issue Type: Bug
Security Level: public(Regular issues)
Reporter: Bill Dudney
Assigned To: Jason Dillon
Attachments: GERONIMO-2352.bdudney.patch
The ear/war/ejb-jar/rar files wont actually deploy to the server.
I have a partial patch avalible but I'd like to get some discussion going on
how to fix some of the problems, that is happening in the dev list.
I will post the complete patch here when that discussion is wrapped up.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2352) j2ee-builder test deployment modules won't actually deploy
[
http://issues.apache.org/jira/browse/GERONIMO-2352?page=comments#action_12431988
]
Jason Dillon commented on GERONIMO-2352:
What is up with the comments in {{geronimo-j2e-builder/pom.xml}}:
{quote}
need to remove the geronimo-application.xml file from this ear
{quote}
j2ee-builder test deployment modules won't actually deploy
--
Key: GERONIMO-2352
URL: http://issues.apache.org/jira/browse/GERONIMO-2352
Project: Geronimo
Issue Type: Bug
Security Level: public(Regular issues)
Reporter: Bill Dudney
Assigned To: Jason Dillon
Attachments: GERONIMO-2352.bdudney.patch
The ear/war/ejb-jar/rar files wont actually deploy to the server.
I have a partial patch avalible but I'd like to get some discussion going on
how to fix some of the problems, that is happening in the dev list.
I will post the complete patch here when that discussion is wrapped up.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2352) j2ee-builder test deployment modules won't actually deploy
[ http://issues.apache.org/jira/browse/GERONIMO-2352?page=comments#action_12431991 ] Bill Dudney commented on GERONIMO-2352: --- Hi Jason, That is the question I was asking about in question 2 here; http://www.nabble.com/j2ee-builder-tests--tf2155494.html#a6032026 Basically the tests expect an ear without a geronimo-application.xml I did not know of an easy way to get maven to strip a file from a jar. The ant build file took the content, jar'd it once with geronimo-application.xml and once with out. j2ee-builder test deployment modules won't actually deploy -- Key: GERONIMO-2352 URL: http://issues.apache.org/jira/browse/GERONIMO-2352 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Reporter: Bill Dudney Assigned To: Jason Dillon Attachments: GERONIMO-2352.bdudney.patch The ear/war/ejb-jar/rar files wont actually deploy to the server. I have a partial patch avalible but I'd like to get some discussion going on how to fix some of the problems, that is happening in the dev list. I will post the complete patch here when that discussion is wrapped up. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2352) j2ee-builder test deployment modules won't actually deploy
[ http://issues.apache.org/jira/browse/GERONIMO-2352?page=comments#action_12432001 ] Jason Dillon commented on GERONIMO-2352: Okay, the test deployments are now hooked up to the main build. I'm going to apply the remaining changes from your patch to geronimo-j2ee-builder with some modifications to apply the m2 std layout, and to use the updated artifactIds for the deployment modules. j2ee-builder test deployment modules won't actually deploy -- Key: GERONIMO-2352 URL: http://issues.apache.org/jira/browse/GERONIMO-2352 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: buildsystem Affects Versions: 1.2 Reporter: Bill Dudney Assigned To: Jason Dillon Fix For: 1.2 Attachments: GERONIMO-2352.bdudney.patch The ear/war/ejb-jar/rar files wont actually deploy to the server. I have a partial patch avalible but I'd like to get some discussion going on how to fix some of the problems, that is happening in the dev list. I will post the complete patch here when that discussion is wrapped up. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2352) j2ee-builder test deployment modules won't actually deploy
[ http://issues.apache.org/jira/browse/GERONIMO-2352?page=comments#action_12432057 ] Jason Dillon commented on GERONIMO-2352: This is mostly done... we still need a few more deployments for alt dd, and modules that build up full unpacked deployments... looks like we only tested those for 1.4, so can probably ignore 1.3 for these tests. I'm using the existing unpacked (which are semi-unpacked) at the moment... need to clean that up tot actually test the scenarios. j2ee-builder test deployment modules won't actually deploy -- Key: GERONIMO-2352 URL: http://issues.apache.org/jira/browse/GERONIMO-2352 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: buildsystem Affects Versions: 1.2 Reporter: Bill Dudney Assigned To: Jason Dillon Fix For: 1.2 Attachments: GERONIMO-2352.bdudney.patch The ear/war/ejb-jar/rar files wont actually deploy to the server. I have a partial patch avalible but I'd like to get some discussion going on how to fix some of the problems, that is happening in the dev list. I will post the complete patch here when that discussion is wrapped up. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2352) j2ee-builder test deployment modules won't actually deploy
[ http://issues.apache.org/jira/browse/GERONIMO-2352?page=comments#action_12432059 ] Jason Dillon commented on GERONIMO-2352: Bill, if you can will you craft patches to add the naked modules, as well as the alt-dd modules and the fully unpacked modules... only for 1.4. Let me know, if you can't I will cook them up. Thanks :-) j2ee-builder test deployment modules won't actually deploy -- Key: GERONIMO-2352 URL: http://issues.apache.org/jira/browse/GERONIMO-2352 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: buildsystem Affects Versions: 1.2 Reporter: Bill Dudney Assigned To: Jason Dillon Fix For: 1.2 Attachments: GERONIMO-2352.bdudney.patch The ear/war/ejb-jar/rar files wont actually deploy to the server. I have a partial patch avalible but I'd like to get some discussion going on how to fix some of the problems, that is happening in the dev list. I will post the complete patch here when that discussion is wrapped up. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2352) j2ee-builder test deployment modules won't actually deploy
[ http://issues.apache.org/jira/browse/GERONIMO-2352?page=comments#action_12431784 ] Jason Dillon commented on GERONIMO-2352: So far looks good. A few issues... * indent of xml files was not consistent * new test-deployables module did not inherit from its parent, which added some additional unneeded config to children * some file shave openejb license and not ASL v2 * groupid/artifactid might not be optimal I've fixed the formatting and setup the pom to inherit and dropped the unneeded bits. I think we should change the artifactId's and directory names for the war/ear/ejb/rar bits... still pending what those will be, but I don't this we want to have files like war-1.2.war and ear-1.2.ear. And, I think we don't need to drop each group (1.3 1.4) deployables into a separate groupId. You also do not need to nor, should, specify the version of the dependency plugin in child usage, that will get picked up from the parent's pom. Anyways, all of this is minor... and I only point it out to you for future reference. I'm going to massage this patch slightly as mentioned above and then commit. Can fix up the licenses afterwards, not sure exactly what to do about this. j2ee-builder test deployment modules won't actually deploy -- Key: GERONIMO-2352 URL: http://issues.apache.org/jira/browse/GERONIMO-2352 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Reporter: Bill Dudney Attachments: GERONIMO-2352.bdudney.patch The ear/war/ejb-jar/rar files wont actually deploy to the server. I have a partial patch avalible but I'd like to get some discussion going on how to fix some of the problems, that is happening in the dev list. I will post the complete patch here when that discussion is wrapped up. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
