[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12682934#action_12682934 ] Kan Ogawa commented on GERONIMO-4507: - Gang, To resolve this issue for V2.1, is it necessary to port both G-4484 and G-4517 patches at the same time? Admin console should honor the priority of user agent's language setting Key: GERONIMO-4507 URL: https://issues.apache.org/jira/browse/GERONIMO-4507 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: console Affects Versions: 2.1.3, 2.2 Environment: All Reporter: Jack Cai Assignee: Joe Bohn Priority: Minor Fix For: 2.1.4, 2.2 Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2_v22.patch, locale-priority_V21.patch See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
Hi Kan Currently for 2.1 branch, everything is all right, the patch you had submitted in this JIRA is enough. 2009/3/18 Kan Ogawa (JIRA) j...@apache.org [ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12682934#action_12682934] Kan Ogawa commented on GERONIMO-4507: - Gang, To resolve this issue for V2.1, is it necessary to port both G-4484 and G-4517 patches at the same time? Admin console should honor the priority of user agent's language setting Key: GERONIMO-4507 URL: https://issues.apache.org/jira/browse/GERONIMO-4507 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: console Affects Versions: 2.1.3, 2.2 Environment: All Reporter: Jack Cai Assignee: Joe Bohn Priority: Minor Fix For: 2.1.4, 2.2 Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2_v22.patch, locale-priority_V21.patch See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12682733#action_12682733 ] Joe Bohn commented on GERONIMO-4507: We need a patch for this in the next day or two or it will not make it into Geronimo 2.1.4. Admin console should honor the priority of user agent's language setting Key: GERONIMO-4507 URL: https://issues.apache.org/jira/browse/GERONIMO-4507 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: console Affects Versions: 2.1.3, 2.2 Environment: All Reporter: Jack Cai Assignee: Joe Bohn Priority: Minor Fix For: 2.1.4, 2.2 Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2_v22.patch, locale-priority_V21.patch See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12682923#action_12682923 ] Gang Yin commented on GERONIMO-4507: As Kan Ogawa hadn't finished porting G-4484(back-end message display and localization) and G-4517(front-end message display and localization) to branch 2.1, so there is no need to provide a patch for branch 2.1.4 at all. Thanks Joe. Admin console should honor the priority of user agent's language setting Key: GERONIMO-4507 URL: https://issues.apache.org/jira/browse/GERONIMO-4507 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: console Affects Versions: 2.1.3, 2.2 Environment: All Reporter: Jack Cai Assignee: Joe Bohn Priority: Minor Fix For: 2.1.4, 2.2 Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2_v22.patch, locale-priority_V21.patch See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679627#action_12679627 ] Joe Bohn commented on GERONIMO-4507: Applied locale-priority_fix2_v22.patch to trunk in rev 750949. Please verify and provide a patch for branches/2.1. Thanks! Admin console should honor the priority of user agent's language setting Key: GERONIMO-4507 URL: https://issues.apache.org/jira/browse/GERONIMO-4507 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: console Affects Versions: 2.1.3, 2.2 Environment: All Reporter: Jack Cai Assignee: Joe Bohn Priority: Minor Fix For: 2.1.4, 2.2 Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2_v22.patch, locale-priority_V21.patch See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679828#action_12679828 ] Gang Yin commented on GERONIMO-4507: Thanks Joe, I will provide a patch for 2.1 branch soon. Admin console should honor the priority of user agent's language setting Key: GERONIMO-4507 URL: https://issues.apache.org/jira/browse/GERONIMO-4507 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: console Affects Versions: 2.1.3, 2.2 Environment: All Reporter: Jack Cai Assignee: Joe Bohn Priority: Minor Fix For: 2.1.4, 2.2 Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2_v22.patch, locale-priority_V21.patch See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679211#action_12679211 ] Donald Woods commented on GERONIMO-4507: Is this for both 2.1 and 2.2? Admin console should honor the priority of user agent's language setting Key: GERONIMO-4507 URL: https://issues.apache.org/jira/browse/GERONIMO-4507 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: console Affects Versions: 2.1.3, 2.2 Environment: All Reporter: Jack Cai Assignee: Donald Woods Priority: Minor Fix For: 2.1.4, 2.2 Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2.patch, locale-priority_V21.patch See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679229#action_12679229 ] Joe Bohn commented on GERONIMO-4507: I suspect we need unique patches for trunk and branches/2.1. Also, please create patches from the root directory for the appropriate branch. Thank you. Admin console should honor the priority of user agent's language setting Key: GERONIMO-4507 URL: https://issues.apache.org/jira/browse/GERONIMO-4507 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: console Affects Versions: 2.1.3, 2.2 Environment: All Reporter: Jack Cai Assignee: Joe Bohn Priority: Minor Fix For: 2.1.4, 2.2 Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2.patch, locale-priority_V21.patch See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679467#action_12679467 ] Gang Yin commented on GERONIMO-4507: BTW, geronimo-4507 and geronimo-4517 is patch ready for commit, please help to review and commit them, many thanks. Admin console should honor the priority of user agent's language setting Key: GERONIMO-4507 URL: https://issues.apache.org/jira/browse/GERONIMO-4507 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: console Affects Versions: 2.1.3, 2.2 Environment: All Reporter: Jack Cai Assignee: Joe Bohn Priority: Minor Fix For: 2.1.4, 2.2 Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2_v22.patch, locale-priority_V21.patch See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671783#action_12671783 ] caiwenjing commented on GERONIMO-4507: -- I give the priority of my language setting to English, but the admin console still displays chinese. Environment: windows xp professional 2002 sp3 + IE7 Admin console should honor the priority of user agent's language setting Key: GERONIMO-4507 URL: https://issues.apache.org/jira/browse/GERONIMO-4507 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: console Affects Versions: 2.1.3, 2.2 Environment: All Reporter: Jack Cai Assignee: Donald Woods Priority: Minor Fix For: 2.1.4, 2.2 Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_V21.patch See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12663355#action_12663355 ] Jack Cai commented on GERONIMO-4507: I don't quite understand why only the language part of the locale is used ... Admin console should honor the priority of user agent's language setting Key: GERONIMO-4507 URL: https://issues.apache.org/jira/browse/GERONIMO-4507 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: console Affects Versions: 2.1.3, 2.2 Environment: All Reporter: Jack Cai Assignee: Donald Woods Priority: Minor Fix For: 2.2 Attachments: locale-priority.patch, locale-priority_fix.patch See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12663357#action_12663357 ] Gang Yin commented on GERONIMO-4507: Updated patch on the basis of Rev734145 Admin console should honor the priority of user agent's language setting Key: GERONIMO-4507 URL: https://issues.apache.org/jira/browse/GERONIMO-4507 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: console Affects Versions: 2.1.3, 2.2 Environment: All Reporter: Jack Cai Assignee: Donald Woods Priority: Minor Fix For: 2.2 Attachments: locale-priority.patch, locale-priority_fix.patch See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
Of course we can use both language and country parts, but now we only provide property files like *.zh.properties rather than *.zh-CN.properties, I'm not sure if locale like zh-CN will match *.zh.properties. I will test it, and If getLanguage() is not necessary I will remove it. On Tue, Jan 13, 2009 at 11:15 PM, Jack Cai (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12663355#action_12663355] Jack Cai commented on GERONIMO-4507: I don't quite understand why only the language part of the locale is used ... Admin console should honor the priority of user agent's language setting Key: GERONIMO-4507 URL: https://issues.apache.org/jira/browse/GERONIMO-4507 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: console Affects Versions: 2.1.3, 2.2 Environment: All Reporter: Jack Cai Assignee: Donald Woods Priority: Minor Fix For: 2.2 Attachments: locale-priority.patch, locale-priority_fix.patch See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
It will. You can read the javadoc of ResourceBundle to see how it searches the bundles for a given locale. -Jack 2009/1/13 Gang Yin yg020...@gmail.com Of course we can use both language and country parts, but now we only provide property files like *.zh.properties rather than *.zh-CN.properties, I'm not sure if locale like zh-CN will match *.zh.properties. I will test it, and If getLanguage() is not necessary I will remove it. On Tue, Jan 13, 2009 at 11:15 PM, Jack Cai (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12663355#action_12663355] Jack Cai commented on GERONIMO-4507: I don't quite understand why only the language part of the locale is used ... Admin console should honor the priority of user agent's language setting Key: GERONIMO-4507 URL: https://issues.apache.org/jira/browse/GERONIMO-4507 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: console Affects Versions: 2.1.3, 2.2 Environment: All Reporter: Jack Cai Assignee: Donald Woods Priority: Minor Fix For: 2.2 Attachments: locale-priority.patch, locale-priority_fix.patch See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
yes, it's redundant code, I will remove it. On Tue, Jan 13, 2009 at 11:30 PM, Jack Cai greensi...@gmail.com wrote: It will. You can read the javadoc of ResourceBundle to see how it searches the bundles for a given locale. -Jack 2009/1/13 Gang Yin yg020...@gmail.com Of course we can use both language and country parts, but now we only provide property files like *.zh.properties rather than *.zh-CN.properties, I'm not sure if locale like zh-CN will match *.zh.properties. I will test it, and If getLanguage() is not necessary I will remove it. On Tue, Jan 13, 2009 at 11:15 PM, Jack Cai (JIRA) j...@apache.orgwrote: [ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12663355#action_12663355] Jack Cai commented on GERONIMO-4507: I don't quite understand why only the language part of the locale is used ... Admin console should honor the priority of user agent's language setting Key: GERONIMO-4507 URL: https://issues.apache.org/jira/browse/GERONIMO-4507 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: console Affects Versions: 2.1.3, 2.2 Environment: All Reporter: Jack Cai Assignee: Donald Woods Priority: Minor Fix For: 2.2 Attachments: locale-priority.patch, locale-priority_fix.patch See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12662994#action_12662994 ] Donald Woods commented on GERONIMO-4507: Is the attached patch for 2.1 or 2.2? Admin console should honor the priority of user agent's language setting Key: GERONIMO-4507 URL: https://issues.apache.org/jira/browse/GERONIMO-4507 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: console Affects Versions: 2.1.3, 2.2 Environment: All Reporter: Jack Cai Assignee: Gang Yin Priority: Minor Attachments: locale-priority.patch See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12663174#action_12663174 ] Gang Yin commented on GERONIMO-4507: My patch is going to rename all *.properties to *_en.properties. Definitely we don't want to keep two copies of the same property file. Admin console should honor the priority of user agent's language setting Key: GERONIMO-4507 URL: https://issues.apache.org/jira/browse/GERONIMO-4507 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: console Affects Versions: 2.1.3, 2.2 Environment: All Reporter: Jack Cai Assignee: Gang Yin Priority: Minor Fix For: 2.2 Attachments: locale-priority.patch See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12663175#action_12663175 ] Gang Yin commented on GERONIMO-4507: I have no idea why all *.properties files are restored, It's weird because I already deleted them. I will attach a new patch to delete them again. Admin console should honor the priority of user agent's language setting Key: GERONIMO-4507 URL: https://issues.apache.org/jira/browse/GERONIMO-4507 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: console Affects Versions: 2.1.3, 2.2 Environment: All Reporter: Jack Cai Assignee: Gang Yin Priority: Minor Fix For: 2.2 Attachments: locale-priority.patch See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12663233#action_12663233 ] Jack Cai commented on GERONIMO-4507: I'm not sure whether it's correct to only include the *_en.properties. If the browser's locale is set to something that's not in Geronimo's supported locale (en, zh), then there's no language to fall back? Admin console should honor the priority of user agent's language setting Key: GERONIMO-4507 URL: https://issues.apache.org/jira/browse/GERONIMO-4507 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: console Affects Versions: 2.1.3, 2.2 Environment: All Reporter: Jack Cai Assignee: Gang Yin Priority: Minor Fix For: 2.2 Attachments: locale-priority.patch, locale-priority_fix.patch See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12663235#action_12663235 ] Gang Yin commented on GERONIMO-4507: Hi, Jack. I had tested your concern and english will be displayed even if there is no *.properties. Because the fmt tag in jsp pages which is responsible for localization will ignore the property file that has no language suffix, So I renamed all *.properties to *_en.properties. Admin console should honor the priority of user agent's language setting Key: GERONIMO-4507 URL: https://issues.apache.org/jira/browse/GERONIMO-4507 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: console Affects Versions: 2.1.3, 2.2 Environment: All Reporter: Jack Cai Assignee: Gang Yin Priority: Minor Fix For: 2.2 Attachments: locale-priority.patch, locale-priority_fix.patch See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12663237#action_12663237 ] Jarek Gawor commented on GERONIMO-4507: --- If the code is using standard ResourceBundles then as described in the JavaDoc we should provide the *.properties files. They are used as the last resort. Admin console should honor the priority of user agent's language setting Key: GERONIMO-4507 URL: https://issues.apache.org/jira/browse/GERONIMO-4507 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: console Affects Versions: 2.1.3, 2.2 Environment: All Reporter: Jack Cai Assignee: Gang Yin Priority: Minor Fix For: 2.2 Attachments: locale-priority.patch, locale-priority_fix.patch See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
