[jira] Commented: (GERONIMO-4554) Cant deploy an ejb web service as a plugin using car-maven-plugin
[ https://issues.apache.org/jira/browse/GERONIMO-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12678776#action_12678776 ] Forrest Xia commented on GERONIMO-4554: --- I think these changes will make built server plugins which uses tomcat6-deployer failed to install on server. For details, please see http://www.nabble.com/Why-change-tomcatContainerName-from-%22-name%3DTomcatWebContainer%22-to-%22-name%3DWebContainer%22-in-tomcat6-deployer-plugin-of-2.1.4-snapshot--td22333212s134.html. Forrest Cant deploy an ejb web service as a plugin using car-maven-plugin - Key: GERONIMO-4554 URL: https://issues.apache.org/jira/browse/GERONIMO-4554 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: car-maven-plugin Affects Versions: 2.1.3 Reporter: David Jencks Assignee: David Jencks Fix For: 2.1.4, 2.2 I tried to deploy an ejb web service using the car-maven-plugin. The cxf and axis2 ejb deployers set up the wslink gbean with a reference to the web container. This is set in the plan for the deployers as WebContainer but the geronimo-plugin.xml overrides this to ${webContainer}. The jetty and tomcat plugins use a config-substitutions entry to e.g. set webContainer=JettyWebContainer So, this all works on a server where all the plugins are installed. However it doesn't work when using the car-maven-plugin since the config.xml overrides and config-substitutions are not applied. We need to either make the config modifications work for the car-maven-plugin or make sure none of the deployers the car-maven-plugin might use depend on these customizations to work. For instance, we could change all the names to WebContainer. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4554) Cant deploy an ejb web service as a plugin using car-maven-plugin
[ https://issues.apache.org/jira/browse/GERONIMO-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12678780#action_12678780 ] Joe Bohn commented on GERONIMO-4554: I agree with Forrest. This breaks backward compatibility and as such is not an acceptable change. Cant deploy an ejb web service as a plugin using car-maven-plugin - Key: GERONIMO-4554 URL: https://issues.apache.org/jira/browse/GERONIMO-4554 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: car-maven-plugin Affects Versions: 2.1.3 Reporter: David Jencks Assignee: David Jencks Fix For: 2.1.4, 2.2 I tried to deploy an ejb web service using the car-maven-plugin. The cxf and axis2 ejb deployers set up the wslink gbean with a reference to the web container. This is set in the plan for the deployers as WebContainer but the geronimo-plugin.xml overrides this to ${webContainer}. The jetty and tomcat plugins use a config-substitutions entry to e.g. set webContainer=JettyWebContainer So, this all works on a server where all the plugins are installed. However it doesn't work when using the car-maven-plugin since the config.xml overrides and config-substitutions are not applied. We need to either make the config modifications work for the car-maven-plugin or make sure none of the deployers the car-maven-plugin might use depend on these customizations to work. For instance, we could change all the names to WebContainer. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4554) Cant deploy an ejb web service as a plugin using car-maven-plugin
[ https://issues.apache.org/jira/browse/GERONIMO-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12678799#action_12678799 ] David Jencks commented on GERONIMO-4554: Reverted changes from rev 748420 and 748924 in rev 750081 My next idea to fix this is to give the ejb web service deployers sets of abstract name queries so they can find either the jetty or tomcat web container. You won't be able to run both jetty and tomcat on the same server if you have ejb web services, but I dont think that is a major limitation. Cant deploy an ejb web service as a plugin using car-maven-plugin - Key: GERONIMO-4554 URL: https://issues.apache.org/jira/browse/GERONIMO-4554 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: car-maven-plugin Affects Versions: 2.1.3 Reporter: David Jencks Assignee: David Jencks Fix For: 2.1.4, 2.2 I tried to deploy an ejb web service using the car-maven-plugin. The cxf and axis2 ejb deployers set up the wslink gbean with a reference to the web container. This is set in the plan for the deployers as WebContainer but the geronimo-plugin.xml overrides this to ${webContainer}. The jetty and tomcat plugins use a config-substitutions entry to e.g. set webContainer=JettyWebContainer So, this all works on a server where all the plugins are installed. However it doesn't work when using the car-maven-plugin since the config.xml overrides and config-substitutions are not applied. We need to either make the config modifications work for the car-maven-plugin or make sure none of the deployers the car-maven-plugin might use depend on these customizations to work. For instance, we could change all the names to WebContainer. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4554) Cant deploy an ejb web service as a plugin using car-maven-plugin
[ https://issues.apache.org/jira/browse/GERONIMO-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12677273#action_12677273 ] David Jencks commented on GERONIMO-4554: branches/2.1 rev 748420 implements the simplest possible (?) solution for this by naming both the jetty and tomcat web containers WebContainer. Further simplification is possible but maybe not for 2.1.4. For trunk we can think about actually setting up the config.xml overrides and substitutions although I'm not sure it's essential. Cant deploy an ejb web service as a plugin using car-maven-plugin - Key: GERONIMO-4554 URL: https://issues.apache.org/jira/browse/GERONIMO-4554 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: car-maven-plugin Affects Versions: 2.1.3 Reporter: David Jencks Assignee: David Jencks Fix For: 2.1.4, 2.2 I tried to deploy an ejb web service using the car-maven-plugin. The cxf and axis2 ejb deployers set up the wslink gbean with a reference to the web container. This is set in the plan for the deployers as WebContainer but the geronimo-plugin.xml overrides this to ${webContainer}. The jetty and tomcat plugins use a config-substitutions entry to e.g. set webContainer=JettyWebContainer So, this all works on a server where all the plugins are installed. However it doesn't work when using the car-maven-plugin since the config.xml overrides and config-substitutions are not applied. We need to either make the config modifications work for the car-maven-plugin or make sure none of the deployers the car-maven-plugin might use depend on these customizations to work. For instance, we could change all the names to WebContainer. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.