[jira] Commented: (GERONIMO-5216) CLONE -getContextRoot() returns forward slash rather than empty string for apps deployed to root context

2010-06-10 Thread Matthias Koch (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMO-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12877403#action_12877403
 ] 

Matthias Koch commented on GERONIMO-5216:
-

are there any news about this ?

kr Matthias

 CLONE -getContextRoot() returns forward slash rather than empty string for 
 apps deployed to root context
 

 Key: GERONIMO-5216
 URL: https://issues.apache.org/jira/browse/GERONIMO-5216
 Project: Geronimo
  Issue Type: Bug
  Security Level: public(Regular issues) 
  Components: Tomcat
Affects Versions: 2.2
Reporter: Matthias Koch
Assignee: Jay D. McHugh

 An app deployed to the root context should have  returned by 
 getContextRoot() - On Tomcat, we are returning /.
 dcherk wrote:
  I am deploying my war file into the root context with the following
  deployment plan:
  --
  web-app xmlns=http://geronimo.apache.org/xml/ns/j2ee/web-2.0;
  xmlns:dep=http://geronimo.apache.org/xml/ns/deployment-1.2;
  xmlns:naming=http://geronimo.apache.org/xml/ns/naming-1.2;
  xmlns:security=http://geronimo.apache.org/xml/ns/security-1.2;
...
context-root/context-root
...
  /web-app
  --
  
  The application starts up properly, and responds on http://localhost, as
  expected.
  
  However, when I examine request.getContextPath(), I get a forward slash:
  /.
  
  This is incorrect, as far as I can tell.  According to the API
  (http://java.sun.com/javaee/5/docs/api/javax/servlet/http/HttpServletRequest.html#getContextPath()):
  --
  For servlets in the default (root) context, this method
  [HttpServletRequest.html.getContextPath()] returns .
  --
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMO-5216) CLONE -getContextRoot() returns forward slash rather than empty string for apps deployed to root context

2010-03-30 Thread Jay D. McHugh (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMO-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12851427#action_12851427
 ] 

Jay D. McHugh commented on GERONIMO-5216:
-

Hey Matthias,

It looks like this must be a problem with how the tag library is processing the 
c:url tag.

I will try to take a look as soon as I have some time.

Jay

 CLONE -getContextRoot() returns forward slash rather than empty string for 
 apps deployed to root context
 

 Key: GERONIMO-5216
 URL: https://issues.apache.org/jira/browse/GERONIMO-5216
 Project: Geronimo
  Issue Type: Bug
  Security Level: public(Regular issues) 
  Components: Tomcat
Affects Versions: 2.2
Reporter: Matthias Koch
Assignee: Jay D. McHugh

 An app deployed to the root context should have  returned by 
 getContextRoot() - On Tomcat, we are returning /.
 dcherk wrote:
  I am deploying my war file into the root context with the following
  deployment plan:
  --
  web-app xmlns=http://geronimo.apache.org/xml/ns/j2ee/web-2.0;
  xmlns:dep=http://geronimo.apache.org/xml/ns/deployment-1.2;
  xmlns:naming=http://geronimo.apache.org/xml/ns/naming-1.2;
  xmlns:security=http://geronimo.apache.org/xml/ns/security-1.2;
...
context-root/context-root
...
  /web-app
  --
  
  The application starts up properly, and responds on http://localhost, as
  expected.
  
  However, when I examine request.getContextPath(), I get a forward slash:
  /.
  
  This is incorrect, as far as I can tell.  According to the API
  (http://java.sun.com/javaee/5/docs/api/javax/servlet/http/HttpServletRequest.html#getContextPath()):
  --
  For servlets in the default (root) context, this method
  [HttpServletRequest.html.getContextPath()] returns .
  --
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMO-5216) CLONE -getContextRoot() returns forward slash rather than empty string for apps deployed to root context

2010-03-30 Thread Matthias Koch (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMO-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12851573#action_12851573
 ] 

Matthias Koch commented on GERONIMO-5216:
-

Hi Jay,

yes the problem can be fixed when changing all jstl libs to prevent //
in jakarta taglibs 1.1.2 they will do this, if you enter a context value in the 
tag. but they won't check for // if context value is not defined in tag.
for this i already build have a patch, but this is not the only jstl lib who 
did this way. as for me i also use the spring taglibs which will produce the 
same problem.

the problem is that tomcat only returns a empty string when webapp dir is 
called ROOT
but for geronimo ROOT is not possible 
i have tried to look into the code of tomcat and geronimo to find the place 
where this could be fixed, but i haven't found it yet (first look into those 
source code)

maybe its possible to patch the Request class from tomcat
in method: setContextPath
there is a check if path is null, this can be extended to also check if its 
only / 
but i think this would be a ugly hack.

kr Matthias 

 CLONE -getContextRoot() returns forward slash rather than empty string for 
 apps deployed to root context
 

 Key: GERONIMO-5216
 URL: https://issues.apache.org/jira/browse/GERONIMO-5216
 Project: Geronimo
  Issue Type: Bug
  Security Level: public(Regular issues) 
  Components: Tomcat
Affects Versions: 2.2
Reporter: Matthias Koch
Assignee: Jay D. McHugh

 An app deployed to the root context should have  returned by 
 getContextRoot() - On Tomcat, we are returning /.
 dcherk wrote:
  I am deploying my war file into the root context with the following
  deployment plan:
  --
  web-app xmlns=http://geronimo.apache.org/xml/ns/j2ee/web-2.0;
  xmlns:dep=http://geronimo.apache.org/xml/ns/deployment-1.2;
  xmlns:naming=http://geronimo.apache.org/xml/ns/naming-1.2;
  xmlns:security=http://geronimo.apache.org/xml/ns/security-1.2;
...
context-root/context-root
...
  /web-app
  --
  
  The application starts up properly, and responds on http://localhost, as
  expected.
  
  However, when I examine request.getContextPath(), I get a forward slash:
  /.
  
  This is incorrect, as far as I can tell.  According to the API
  (http://java.sun.com/javaee/5/docs/api/javax/servlet/http/HttpServletRequest.html#getContextPath()):
  --
  For servlets in the default (root) context, this method
  [HttpServletRequest.html.getContextPath()] returns .
  --
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.