[jira] Commented: (GERONIMO-5325) iframe causes some portlets display incorrectly
[ https://issues.apache.org/jira/browse/GERONIMO-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12880047#action_12880047 ] Ben Liang commented on GERONIMO-5325: - Attach a new patch to fix the problem. Rex, would you kindly help me review this patch? Thanks a lot. Ben iframe causes some portlets display incorrectly --- Key: GERONIMO-5325 URL: https://issues.apache.org/jira/browse/GERONIMO-5325 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Affects Versions: 2.2 Reporter: Rex Wang Assignee: Ben Liang Fix For: 2.2.1 Attachments: 5325-Ben_2_new.patch, 5325_Ben.patch, 5325_huge_blank.patch, screenshot-1-assembly-portlet.jpg, screenshot-debug-views.jpg, screenshot-huge-blank.jpg, screenshot-timeout.jpg, timeout.bmp, Two scroll bars.jpg #1. The assemble server page is not formatting properly in 2.2.1-SNAPSHOT. Go to assemble server page, click expert user and try to scroll down. Unless I make the font type very small, I can't see the system plugins and can't scroll down to them. #2, This also cause the debugviews portlet displays incorrectly. #3, Go to repository portlet first, and then go to JMS Resources portlet. The scroll bar is pretty long and when you scroll down, you can see there is a huge blank at the bottom of the page. See the attachment. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-5325) iframe causes some portlets display incorrectly
[ https://issues.apache.org/jira/browse/GERONIMO-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12877725#action_12877725 ] Rex Wang commented on GERONIMO-5325: I think it's pretty hard to replace the iframe with div, and also make our console code more complex, and more bugs will be involved. My intent is to make our console's structure more clear and easy to maintain. It is just an admin console with the specified user and not a widely-used web application by the people all-over the world(like GMail), so I think it make sense to do such changes.. iframe causes some portlets display incorrectly --- Key: GERONIMO-5325 URL: https://issues.apache.org/jira/browse/GERONIMO-5325 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Affects Versions: 2.2 Reporter: Rex Wang Assignee: Ben Liang Fix For: 2.2.1 Attachments: 5325-Ben_2_new.patch, 5325_Ben.patch, screenshot-1-assembly-portlet.jpg, screenshot-debug-views.jpg, screenshot-huge-blank.jpg #1. The assemble server page is not formatting properly in 2.2.1-SNAPSHOT. Go to assemble server page, click expert user and try to scroll down. Unless I make the font type very small, I can't see the system plugins and can't scroll down to them. #2, This also cause the debugviews portlet displays incorrectly. #3, Go to repository portlet first, and then go to JMS Resources portlet. The scroll bar is pretty long and when you scroll down, you can see there is a huge blank at the bottom of the page. See the attachment. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (GERONIMO-5325) iframe causes some portlets display incorrectly
Actuall, now every time reload the page the navagation tree node will open according to the url. I think the user may want to check a portlet and those portlets in the same group. So if we have made a good category then the user will feel it easy to find the related portlets. On Fri, Jun 11, 2010 at 2:37 PM, Shawn Jiang genspr...@gmail.com wrote: To revert the iframe. Each click will result in a whole dojo tree reload. The most important thing is that the user context will lost. In addition, the problems described in this JIRA is easy to fix. Including the timeout bug. I'll find a time to get them done. Please hold on this patch. On Fri, Jun 11, 2010 at 2:08 PM, Rex Wang (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/GERONIMO-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12877725#action_12877725] Rex Wang commented on GERONIMO-5325: I think it's pretty hard to replace the iframe with div, and also make our console code more complex, and more bugs will be involved. My intent is to make our console's structure more clear and easy to maintain. It is just an admin console with the specified user and not a widely-used web application by the people all-over the world(like GMail), so I think it make sense to do such changes.. iframe causes some portlets display incorrectly --- Key: GERONIMO-5325 URL: https://issues.apache.org/jira/browse/GERONIMO-5325 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Affects Versions: 2.2 Reporter: Rex Wang Assignee: Ben Liang Fix For: 2.2.1 Attachments: 5325-Ben_2_new.patch, 5325_Ben.patch, screenshot-1-assembly-portlet.jpg, screenshot-debug-views.jpg, screenshot-huge-blank.jpg #1. The assemble server page is not formatting properly in 2.2.1-SNAPSHOT. Go to assemble server page, click expert user and try to scroll down. Unless I make the font type very small, I can't see the system plugins and can't scroll down to them. #2, This also cause the debugviews portlet displays incorrectly. #3, Go to repository portlet first, and then go to JMS Resources portlet. The scroll bar is pretty long and when you scroll down, you can see there is a huge blank at the bottom of the page. See the attachment. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. -- Shawn -- Best Regards Ben Liang
Re: [jira] Commented: (GERONIMO-5325) iframe causes some portlets display incorrectly
Yes, Ben and I have noticed the context problem of the dojo tree, and IMHO the current solution is acceptable :-) It's really boring in fixing such small bugs in console after pulling in the iframe, That should not be the focus of our geronimo. Besides the issues we list in the jira, I also found a lot of other small problems, so let's get rid of it one time. 2010/6/11 Ben Liang ben.liang.j...@gmail.com Actuall, now every time reload the page the navagation tree node will open according to the url. I think the user may want to check a portlet and those portlets in the same group. So if we have made a good category then the user will feel it easy to find the related portlets. On Fri, Jun 11, 2010 at 2:37 PM, Shawn Jiang genspr...@gmail.com wrote: To revert the iframe. Each click will result in a whole dojo tree reload. The most important thing is that the user context will lost. In addition, the problems described in this JIRA is easy to fix. Including the timeout bug. I'll find a time to get them done. Please hold on this patch. On Fri, Jun 11, 2010 at 2:08 PM, Rex Wang (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/GERONIMO-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12877725#action_12877725] Rex Wang commented on GERONIMO-5325: I think it's pretty hard to replace the iframe with div, and also make our console code more complex, and more bugs will be involved. My intent is to make our console's structure more clear and easy to maintain. It is just an admin console with the specified user and not a widely-used web application by the people all-over the world(like GMail), so I think it make sense to do such changes.. iframe causes some portlets display incorrectly --- Key: GERONIMO-5325 URL: https://issues.apache.org/jira/browse/GERONIMO-5325 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Affects Versions: 2.2 Reporter: Rex Wang Assignee: Ben Liang Fix For: 2.2.1 Attachments: 5325-Ben_2_new.patch, 5325_Ben.patch, screenshot-1-assembly-portlet.jpg, screenshot-debug-views.jpg, screenshot-huge-blank.jpg #1. The assemble server page is not formatting properly in 2.2.1-SNAPSHOT. Go to assemble server page, click expert user and try to scroll down. Unless I make the font type very small, I can't see the system plugins and can't scroll down to them. #2, This also cause the debugviews portlet displays incorrectly. #3, Go to repository portlet first, and then go to JMS Resources portlet. The scroll bar is pretty long and when you scroll down, you can see there is a huge blank at the bottom of the page. See the attachment. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. -- Shawn -- Best Regards Ben Liang -- Lei Wang (Rex) rwonly AT apache.org
[jira] Commented: (GERONIMO-5325) iframe causes some portlets display incorrectly
[ https://issues.apache.org/jira/browse/GERONIMO-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1280#action_1280 ] Shawn Jiang commented on GERONIMO-5325: --- Fixed the problems described in this JIRA. Thanks Ben and Rex for the help ! Repository RevisionDateUserMessage ASF #953636 Fri Jun 11 05:57:49 EDT 2010genspring GERONIMO-5325 iframe causes some portlets display incorrectly Files Changed MODIFY /geronimo/server/branches/2.2/plugins/debugviews/debugviews-portlets/src/main/webapp/WEB-INF/view/classloaderview/view.jsp MODIFY /geronimo/server/branches/2.2/plugins/debugviews/debugviews-portlets/src/main/webapp/WEB-INF/view/dependencyview/view.jsp MODIFY /geronimo/server/branches/2.2/plugins/debugviews/debugviews-portlets/src/main/webapp/WEB-INF/view/jndiview/view.jsp MODIFY /geronimo/server/branches/2.2/plugins/console/console-portal-driver/src/main/webapp/WEB-INF/themes/portlets-with-tree.jsp MODIFY /geronimo/server/branches/2.2/plugins/console/console-portal-driver/src/main/webapp/WEB-INF/themes/navigation.jsp Repository RevisionDateUserMessage ASF #953642 Fri Jun 11 06:28:59 EDT 2010genspring GERONIMO-5325 iframe causes some portlets display incorrectly Files Changed MODIFY /geronimo/server/trunk/plugins/console/console-portal-driver/src/main/webapp/WEB-INF/themes/navigation.jsp MODIFY /geronimo/server/trunk/plugins/debugviews/debugviews-portlets/src/main/webapp/WEB-INF/view/dependencyview/view.jsp MODIFY /geronimo/server/trunk/plugins/debugviews/debugviews-portlets/src/main/webapp/WEB-INF/view/jndiview/view.jsp MODIFY /geronimo/server/trunk/plugins/debugviews/debugviews-portlets/src/main/webapp/WEB-INF/view/classloaderview/view.jsp MODIFY /geronimo/server/trunk/plugins/console/console-portal-driver/src/main/webapp/WEB-INF/themes/portlets-with-tree.jsp iframe causes some portlets display incorrectly --- Key: GERONIMO-5325 URL: https://issues.apache.org/jira/browse/GERONIMO-5325 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Affects Versions: 2.2 Reporter: Rex Wang Assignee: Ben Liang Fix For: 2.2.1 Attachments: 5325-Ben_2_new.patch, 5325_Ben.patch, screenshot-1-assembly-portlet.jpg, screenshot-debug-views.jpg, screenshot-huge-blank.jpg, screenshot-timeout.jpg, timeout.bmp, Two scroll bars.jpg #1. The assemble server page is not formatting properly in 2.2.1-SNAPSHOT. Go to assemble server page, click expert user and try to scroll down. Unless I make the font type very small, I can't see the system plugins and can't scroll down to them. #2, This also cause the debugviews portlet displays incorrectly. #3, Go to repository portlet first, and then go to JMS Resources portlet. The scroll bar is pretty long and when you scroll down, you can see there is a huge blank at the bottom of the page. See the attachment. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-5325) iframe causes some portlets display incorrectly
[ https://issues.apache.org/jira/browse/GERONIMO-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12877690#action_12877690 ] Ben Liang commented on GERONIMO-5325: - Hi all, I have attache a screenshot for the problem when re-log in the system. In my opinion, I think iframe will cause many problem to those portlets and these problems could not be easy to solve. I believe that at first we use the iframe to bring 2 benefits: (1)support AJAX (2)save time when load dojo style navigation tree, which is the more important reason. To solve the problems I believe we should be back to the old style which load the whole page every time, and in this way we will not supprt ajax but we could still enhance the usability because of the dojo style navigation tree. For the time consuming, I believe it is endurable. So I attach a patch to fix these problems. iframe causes some portlets display incorrectly --- Key: GERONIMO-5325 URL: https://issues.apache.org/jira/browse/GERONIMO-5325 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Affects Versions: 2.2 Reporter: Rex Wang Assignee: Ben Liang Fix For: 2.2.1 Attachments: Log in after long time.bmp, screenshot-1-assembly-portlet.jpg, screenshot-debug-views.jpg, screenshot-huge-blank.jpg #1. The assemble server page is not formatting properly in 2.2.1-SNAPSHOT. Go to assemble server page, click expert user and try to scroll down. Unless I make the font type very small, I can't see the system plugins and can't scroll down to them. #2, This also cause the debugviews portlet displays incorrectly. #3, Go to repository portlet first, and then go to JMS Resources portlet. The scroll bar is pretty long and when you scroll down, you can see there is a huge blank at the bottom of the page. See the attachment. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-5325) iframe causes some portlets display incorrectly
[ https://issues.apache.org/jira/browse/GERONIMO-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12877691#action_12877691 ] Ben Liang commented on GERONIMO-5325: - Hi all, I have attach a patch which may cause some changes: (1) remove iframe, which means the page will load as a whole page. (2) modify some portlets' css which cause some dojo style problems Rex could you help me review this patch? Thanks a lot Ben iframe causes some portlets display incorrectly --- Key: GERONIMO-5325 URL: https://issues.apache.org/jira/browse/GERONIMO-5325 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Affects Versions: 2.2 Reporter: Rex Wang Assignee: Ben Liang Fix For: 2.2.1 Attachments: 5325_Ben.patch, Log in after long time.bmp, screenshot-1-assembly-portlet.jpg, screenshot-debug-views.jpg, screenshot-huge-blank.jpg #1. The assemble server page is not formatting properly in 2.2.1-SNAPSHOT. Go to assemble server page, click expert user and try to scroll down. Unless I make the font type very small, I can't see the system plugins and can't scroll down to them. #2, This also cause the debugviews portlet displays incorrectly. #3, Go to repository portlet first, and then go to JMS Resources portlet. The scroll bar is pretty long and when you scroll down, you can see there is a huge blank at the bottom of the page. See the attachment. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-5325) iframe causes some portlets display incorrectly
[ https://issues.apache.org/jira/browse/GERONIMO-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12877698#action_12877698 ] Ben Liang commented on GERONIMO-5325: - Hi all, Sorry for attaching the wrong patch (5325-Ben_2.patch) , a new substitute patch (5325-Ben_2_new.patch) will be attached. This patch mainly removes and modifies some filters whihc are designed for the ajax style. Ben iframe causes some portlets display incorrectly --- Key: GERONIMO-5325 URL: https://issues.apache.org/jira/browse/GERONIMO-5325 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Affects Versions: 2.2 Reporter: Rex Wang Assignee: Ben Liang Fix For: 2.2.1 Attachments: 5325-Ben_2.patch, 5325-Ben_2_new.patch, 5325_Ben.patch, Log in after long time.bmp, screenshot-1-assembly-portlet.jpg, screenshot-debug-views.jpg, screenshot-huge-blank.jpg #1. The assemble server page is not formatting properly in 2.2.1-SNAPSHOT. Go to assemble server page, click expert user and try to scroll down. Unless I make the font type very small, I can't see the system plugins and can't scroll down to them. #2, This also cause the debugviews portlet displays incorrectly. #3, Go to repository portlet first, and then go to JMS Resources portlet. The scroll bar is pretty long and when you scroll down, you can see there is a huge blank at the bottom of the page. See the attachment. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-5325) iframe causes some portlets display incorrectly
[ https://issues.apache.org/jira/browse/GERONIMO-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12877712#action_12877712 ] Shawn Jiang commented on GERONIMO-5325: --- It's not a right direction. As I said before, the right direction is to replace the iframe with a div in the future. The existing problems are low severity ones that we can fix in another ways for now. iframe causes some portlets display incorrectly --- Key: GERONIMO-5325 URL: https://issues.apache.org/jira/browse/GERONIMO-5325 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Affects Versions: 2.2 Reporter: Rex Wang Assignee: Ben Liang Fix For: 2.2.1 Attachments: 5325-Ben_2.patch, 5325-Ben_2_new.patch, 5325_Ben.patch, Log in after long time.bmp, screenshot-1-assembly-portlet.jpg, screenshot-debug-views.jpg, screenshot-huge-blank.jpg #1. The assemble server page is not formatting properly in 2.2.1-SNAPSHOT. Go to assemble server page, click expert user and try to scroll down. Unless I make the font type very small, I can't see the system plugins and can't scroll down to them. #2, This also cause the debugviews portlet displays incorrectly. #3, Go to repository portlet first, and then go to JMS Resources portlet. The scroll bar is pretty long and when you scroll down, you can see there is a huge blank at the bottom of the page. See the attachment. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-5325) iframe causes some portlets display incorrectly
[ https://issues.apache.org/jira/browse/GERONIMO-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12873516#action_12873516 ] Ben Liang commented on GERONIMO-5325: - I found another page problem is that if you do nothing on the server after a long time then you should check the authority again. The problem is that the left navigation is still there but only the portlet iframe refresh to the login page which I do not think it is proper. iframe causes some portlets display incorrectly --- Key: GERONIMO-5325 URL: https://issues.apache.org/jira/browse/GERONIMO-5325 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Affects Versions: 2.2 Reporter: Rex Wang Assignee: Ben Liang Fix For: 2.2.1 Attachments: screenshot-1-assembly-portlet.jpg, screenshot-debug-views.jpg, screenshot-huge-blank.jpg #1. The assemble server page is not formatting properly in 2.2.1-SNAPSHOT. Go to assemble server page, click expert user and try to scroll down. Unless I make the font type very small, I can't see the system plugins and can't scroll down to them. #2, This also cause the debugviews portlet displays incorrectly. #3, Go to repository portlet first, and then go to JMS Resources portlet. The scroll bar is pretty long and when you scroll down, you can see there is a huge blank at the bottom of the page. See the attachment. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-5325) iframe causes some portlets display incorrectly
[ https://issues.apache.org/jira/browse/GERONIMO-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12869065#action_12869065 ] Shawn Jiang commented on GERONIMO-5325: --- The reason of this JIRA is the same with https://issues.apache.org/jira/browse/GERONIMO-5218 I believe the fix could be the same. I also plan to move iframe to div in the future to fix this kind of problems completely. But I would not do it in 2.2.1 release. iframe causes some portlets display incorrectly --- Key: GERONIMO-5325 URL: https://issues.apache.org/jira/browse/GERONIMO-5325 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Affects Versions: 2.2 Reporter: Rex Wang Fix For: 2.2.1 Attachments: screenshot-1-assembly-portlet.jpg, screenshot-debug-views.jpg #1. The assemble server page is not formatting properly in 2.2.1-SNAPSHOT. Go to assemble server page, click expert user and try to scroll down. Unless I make the font type very small, I can't see the system plugins and can't scroll down to them. #2, This also cause the debugviews portlet displays incorrectly. See the attachment. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
