[jira] Commented: (GERONIMO-720) server should give client more feedback on deployment and starting configurations.
[ https://issues.apache.org/jira/browse/GERONIMO-720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463464 ] Rakesh Midha commented on GERONIMO-720: --- Hello David I was trying to work on your suggestions in this JIRA, but after looking at code and from my understanding, I hit the point where I am thinking the above information may not be valid for individual components. I hope I am not missing some critical factor, if so help me understand. - when a configuration is started, it would be useful to list the gbeans that are not started. This is currently done when you start up the server and has proved very useful in detecting problems early. - When a configuration is started, all its dependencies and child configurations and coorsponding gbeans are started and if any of those fail to start, the configuration start up fails. Unlike server startup where few gbeans may fail to start and even than server can be decalred started. For this case my understanding is ther won't be any failed gbean if the component is deployed/Started. - when an app is deployed, there are usually lots of gbean names resolved. Listing these for the client could provide an easy way to check that things got hooked up the way you expected. To some extent this is done in https://issues.apache.org/jira/browse/GERONIMO-1285, which list all the modules/gbeans started with startup of configuration. What other gbeans are resolved with this, can you give an example. If there are other gbean names resolve I am not sure if we can send it to client (we can log them as information in logs), but sending them back to client may be difficult. The reason why I say that is the implementation of ConfigurationManger, say if we want to start a configuration we use LifecycleResults startConfiguration(Artifact configurationId), now only data which can be returned back to client is data available in LifecycleResults, and the only info it cna contain is list of configurations/gbeans started. (I think thats how it should be according to protocol) Thanks Rakesh server should give client more feedback on deployment and starting configurations. -- Key: GERONIMO-720 URL: https://issues.apache.org/jira/browse/GERONIMO-720 Project: Geronimo Issue Type: New Feature Components: deployment Affects Versions: 1.0-M3 Reporter: David Jencks Fix For: 1.x The server should give the client more information when you deploy a package or start a module. Examples of useful information are: -- when an app is deployed, there are usually lots of gbean names resolved. Listing these for the client could provide an easy way to check that things got hooked up the way you expected. -- when a configuration is started, it would be useful to list the gbeans that are not started. This is currently done when you start up the server and has proved very useful in detecting problems early. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-720) server should give client more feedback on deployment and starting configurations.
[ https://issues.apache.org/jira/browse/GERONIMO-720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463469 ] David Jencks commented on GERONIMO-720: --- This is an extremely old issue and I'm not very enthusiastic about any of it any more. - when a configuration is started, it would be useful to list the gbeans that are not started. This is currently done when you start up the server and has proved very useful in detecting problems early. -- as you note, this is completely obsolete and should be removed/ignored. If a module starts, all its gbeans have started, otherwise starting fails. - when an app is deployed, there are usually lots of gbean names resolved. Listing these for the client could provide an easy way to check that things got hooked up the way you expected. -- At the moment the only plausible thing I can think of is to put logging statements in the Configuration code that finds gbeans/gbeandatas. I guess debug level would be appropriate. Then if someone wants to see this they can enable that logging category (or whatever it's called now). The trick would be to make sure each AbstractNameQuery resolution got logged exactly once. This is definitely something you want to be able to turn off :-) And as you say sending this back to a remote client is really hard and probably not something they want. I think now that you can really only resolve ANQ in the tree of ancestors of your module what the resolved gbean is is easier to guess. The logging might still be nice to have, but I don't think this is very high priority. server should give client more feedback on deployment and starting configurations. -- Key: GERONIMO-720 URL: https://issues.apache.org/jira/browse/GERONIMO-720 Project: Geronimo Issue Type: New Feature Components: deployment Affects Versions: 1.0-M3 Reporter: David Jencks Fix For: 1.x The server should give the client more information when you deploy a package or start a module. Examples of useful information are: -- when an app is deployed, there are usually lots of gbean names resolved. Listing these for the client could provide an easy way to check that things got hooked up the way you expected. -- when a configuration is started, it would be useful to list the gbeans that are not started. This is currently done when you start up the server and has proved very useful in detecting problems early. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-720) server should give client more feedback on deployment and starting configurations.
[ https://issues.apache.org/jira/browse/GERONIMO-720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463479 ] Rakesh Midha commented on GERONIMO-720: --- Thanks David for Quick response. I agree with what you said. About the logging, I think we need to have logging code in whole kernel, deployment and jsr88 modules, and I think we should open another JIRA for missing logging ( this is just a small part of missing logging), I would like this JIRA to be closed. Agreed? server should give client more feedback on deployment and starting configurations. -- Key: GERONIMO-720 URL: https://issues.apache.org/jira/browse/GERONIMO-720 Project: Geronimo Issue Type: New Feature Components: deployment Affects Versions: 1.0-M3 Reporter: David Jencks Fix For: 1.x The server should give the client more information when you deploy a package or start a module. Examples of useful information are: -- when an app is deployed, there are usually lots of gbean names resolved. Listing these for the client could provide an easy way to check that things got hooked up the way you expected. -- when a configuration is started, it would be useful to list the gbeans that are not started. This is currently done when you start up the server and has proved very useful in detecting problems early. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
