SnapshotDBHelper in the monitoring agent should not have static methods
-----------------------------------------------------------------------

                 Key: GERONIMO-3739
                 URL: https://issues.apache.org/jira/browse/GERONIMO-3739
             Project: Geronimo
          Issue Type: Improvement
      Security Level: public (Regular issues)
          Components: monitoring
    Affects Versions: 2.1
         Environment: windows
            Reporter: Viet Hung Nguyen
            Assignee: Viet Hung Nguyen
         Attachments: geronimo.patch

The SnapshotDBHelper in the monitoring agent is a utility class right now. 
Other pieces of code can just use it by statically accessing its methods. 
However, this is a dangerous practice if the DataSources are not set properly 
before using it. So I suggest to force other pieces of code to instantiate the 
SnapshotDBHelper object first before using it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to