Re: [VOTE] Release XBean 2.8
+1 -dain On Dec 18, 2006, at 2:47 PM, Guillaume Nodet wrote: Done :) On 12/18/06, Kevan Miller [EMAIL PROTECTED] wrote: On Dec 18, 2006, at 3:44 PM, Guillaume Nodet wrote: I've fixed the missing / bad ASF headers and use the new maven plugin to generate LICENSE/NOTICE file. Looks like the following still needs some attention: xbean-spring-v1/pom.xml These all have old style license headers. Sorry, I didn't spot them last scan. xbean-spring-v2/src/site/site.xml xbean-spring-v2a/src/site/site.xml xbean-spring-v2b/src/site/site.xml xbean-spring-v2c/src/site/site.xml I'm done, after that... ;-) --kevan -- Cheers, Guillaume Nodet
Re: [VOTE] Release XBean 2.8
+1 On 12/18/06, Guillaume Nodet [EMAIL PROTECTED] wrote: I'm starting a vote to release XBean 2.8. There has not been much changes since 2.7, but a few bugs fixed, and the addition of the xbean-finder module. Anyway, the bugs are important enough to deserver a new release (the generated schemas can not be validated). [ ] +1 Start xbean 2.8 release process [ ] +/- 0 [ ] -1 Don't release xbean 2.8 now Here's my +1. -- Cheers, Guillaume Nodet -- James --- http://radio.weblogs.com/0112098/
Re: [VOTE] Release XBean 2.8
+1 On 12/18/06, Guillaume Nodet [EMAIL PROTECTED] wrote: I'm starting a vote to release XBean 2.8. There has not been much changes since 2.7, but a few bugs fixed, and the addition of the xbean-finder module. Anyway, the bugs are important enough to deserver a new release (the generated schemas can not be validated). [ ] +1 Start xbean 2.8 release process [ ] +/- 0 [ ] -1 Don't release xbean 2.8 now Here's my +1. -- Cheers, Guillaume Nodet -- Regards, Hiram Blog: http://hiramchirino.com
Re: [VOTE] Release XBean 2.8
On Dec 18, 2006, at 11:25 AM, Guillaume Nodet wrote: I'm starting a vote to release XBean 2.8. There has not been much changes since 2.7, but a few bugs fixed, and the addition of the xbean-finder module. Anyway, the bugs are important enough to deserver a new release (the generated schemas can not be validated). [ ] +1 Start xbean 2.8 release process [ ] +/- 0 [ ] -1 Don't release xbean 2.8 now Here's my +1. Not sure what you mean by release process. But here are the issues which look like they would block a release: 1. NOTICE files do not conform to current ASF standards 2. The following files either do not contain a valid license header (not all files will require one, but many of these need one) or have an out-of-date license header (all need to be updated). ==resource (./xbean-classloader/src/test-data/resourceFinderTest/jar1/ resource) ==resource (./xbean-classloader/src/test-data/resourceFinderTest/jar2/ resource) ==package-info.java (./xbean-finder/src/test/java/org/acme/foo/ package-info.java) ==java.io.InputStream (./xbean-finder/src/test/resources/META-INF/ java.io.InputStream) ==java.io.OutputStream (./xbean-finder/src/test/resources/META-INF/ java.io.OutputStream) ==java.io.Serializable (./xbean-finder/src/test/resources/META-INF/ java.io.Serializable) ==one (./xbean-finder/src/test/resources/META-INF/externalizables/one) ==three (./xbean-finder/src/test/resources/META-INF/externalizables/ three) ==two (./xbean-finder/src/test/resources/META-INF/externalizables/two) ==bar (./xbean-finder/src/test/resources/META-INF/ java.net.URLStreamHandler/bar) ==baz (./xbean-finder/src/test/resources/META-INF/ java.net.URLStreamHandler/baz) ==foo (./xbean-finder/src/test/resources/META-INF/ java.net.URLStreamHandler/foo) ==kernel (./xbean-finder/src/test/resources/META-INF/ javax.naming.spi.ObjectFactory/kernel) ==ldap (./xbean-finder/src/test/resources/META-INF/ javax.naming.spi.ObjectFactory/ldap) ==ishtar.properties (./xbean-finder/src/test/resources/META-INF/ movies/ishtar.properties) ==kingkong.properties (./xbean-finder/src/test/resources/META-INF/ movies/kingkong.properties) ==serentity.properties (./xbean-finder/src/test/resources/META-INF/ movies/serentity.properties) ==one (./xbean-finder/src/test/resources/META-INF/serializables/one) ==three (./xbean-finder/src/test/resources/META-INF/serializables/three) ==two (./xbean-finder/src/test/resources/META-INF/serializables/two) ==familyguy.properties (./xbean-finder/src/test/resources/META-INF/ tvshows/familyguy.properties) ==simpsons.properties (./xbean-finder/src/test/resources/META-INF/ tvshows/simpsons.properties) ==package.html (./xbean-kernel/src/main/java/org/apache/xbean/kernel/ package.html) ==package.html (./xbean-kernel/src/main/java/org/apache/xbean/kernel/ standard/package.html) ==pom.xml (./xbean-naming/pom.xml) ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ AbstractContext.java ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ AbstractFederatedContext.java ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ ContextAccess.java ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ ContextAccessControlList.java ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ ContextFederation.java ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ ContextFlyweight.java ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ ContextUtil.java ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ ImmutableContext.java ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ NestedContextFactory.java ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ VirtualSubcontext.java ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ WritableContext.java ==xbean-naming/src/main/java/org/apache/xbean/naming/global/ GlobalContextManager.java ==xbean-naming/src/main/java/org/apache/xbean/naming/java/ javaURLContextFactory.java ==xbean-naming/src/main/java/org/apache/xbean/naming/reference/ CachingReference.java ==xbean-naming/src/main/java/org/apache/xbean/naming/reference/ SimpleReference.java ==xbean-naming/src/test/java/org/apache/xbean/naming/context/ AbstractContextTest.java ==xbean-naming/src/test/java/org/apache/xbean/naming/context/ ContextAccessControlListTest.java ==xbean-naming/src/test/java/org/apache/xbean/naming/context/ FederationTest.java ==xbean-naming/src/test/java/org/apache/xbean/naming/context/ ImmutableContextTest.java ==xbean-naming/src/test/java/org/apache/xbean/naming/context/ UnmodifiableContextTest.java ==xbean-naming/src/test/java/org/apache/xbean/naming/context/ WritableContextTest.java ==xbean-naming/src/test/java/org/apache/xbean/naming/global/ GlobalContextManagerTest.java ==spring-beans.xsd (./xbean-spring-common/src/main/resources/org/ apache/xbean/spring/spring-beans.xsd) ==pom.xml (./xbean-spring-itests/2.0/pom.xml) ==pom.xml (./xbean-spring-itests/2.0-rc3/pom.xml)
Re: [VOTE] Release XBean 2.8
On 12/18/06, Kevan Miller [EMAIL PROTECTED] wrote: On Dec 18, 2006, at 11:25 AM, Guillaume Nodet wrote: I'm starting a vote to release XBean 2.8. There has not been much changes since 2.7, but a few bugs fixed, and the addition of the xbean-finder module. Anyway, the bugs are important enough to deserver a new release (the generated schemas can not be validated). [ ] +1 Start xbean 2.8 release process [ ] +/- 0 [ ] -1 Don't release xbean 2.8 now Here's my +1. Not sure what you mean by release process. Running mvn release:prepare release:perform ;) But here are the issues which look like they would block a release: 1. NOTICE files do not conform to current ASF standards What do you mean exactly ? They have the same content that the ones I've always seen. Could you point me to a better template for these ? 2. The following files either do not contain a valid license header (not all files will require one, but many of these need one) or have an out-of-date license header (all need to be updated). Thanks. I'll fix these asap. You run rat for that, right ? ==resource (./xbean-classloader/src/test-data/resourceFinderTest/jar1/ resource) ==resource (./xbean-classloader/src/test-data/resourceFinderTest/jar2/ resource) ==package-info.java (./xbean-finder/src/test/java/org/acme/foo/ package-info.java) ==java.io.InputStream (./xbean-finder/src/test/resources/META-INF/ java.io.InputStream) ==java.io.OutputStream (./xbean-finder/src/test/resources/META-INF/ java.io.OutputStream) ==java.io.Serializable (./xbean-finder/src/test/resources/META-INF/ java.io.Serializable) ==one (./xbean-finder/src/test/resources/META-INF/externalizables/one) ==three (./xbean-finder/src/test/resources/META-INF/externalizables/ three) ==two (./xbean-finder/src/test/resources/META-INF/externalizables/two) ==bar (./xbean-finder/src/test/resources/META-INF/ java.net.URLStreamHandler/bar) ==baz (./xbean-finder/src/test/resources/META-INF/ java.net.URLStreamHandler/baz) ==foo (./xbean-finder/src/test/resources/META-INF/ java.net.URLStreamHandler/foo) ==kernel (./xbean-finder/src/test/resources/META-INF/ javax.naming.spi.ObjectFactory/kernel) ==ldap (./xbean-finder/src/test/resources/META-INF/ javax.naming.spi.ObjectFactory/ldap) ==ishtar.properties (./xbean-finder/src/test/resources/META-INF/ movies/ishtar.properties) ==kingkong.properties (./xbean-finder/src/test/resources/META-INF/ movies/kingkong.properties) ==serentity.properties (./xbean-finder/src/test/resources/META-INF/ movies/serentity.properties) ==one (./xbean-finder/src/test/resources/META-INF/serializables/one) ==three (./xbean-finder/src/test/resources/META-INF/serializables/three) ==two (./xbean-finder/src/test/resources/META-INF/serializables/two) ==familyguy.properties (./xbean-finder/src/test/resources/META-INF/ tvshows/familyguy.properties) ==simpsons.properties (./xbean-finder/src/test/resources/META-INF/ tvshows/simpsons.properties) ==package.html (./xbean-kernel/src/main/java/org/apache/xbean/kernel/ package.html) ==package.html (./xbean-kernel/src/main/java/org/apache/xbean/kernel/ standard/package.html) ==pom.xml (./xbean-naming/pom.xml) ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ AbstractContext.java ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ AbstractFederatedContext.java ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ ContextAccess.java ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ ContextAccessControlList.java ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ ContextFederation.java ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ ContextFlyweight.java ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ ContextUtil.java ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ ImmutableContext.java ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ NestedContextFactory.java ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ VirtualSubcontext.java ==xbean-naming/src/main/java/org/apache/xbean/naming/context/ WritableContext.java ==xbean-naming/src/main/java/org/apache/xbean/naming/global/ GlobalContextManager.java ==xbean-naming/src/main/java/org/apache/xbean/naming/java/ javaURLContextFactory.java ==xbean-naming/src/main/java/org/apache/xbean/naming/reference/ CachingReference.java ==xbean-naming/src/main/java/org/apache/xbean/naming/reference/ SimpleReference.java ==xbean-naming/src/test/java/org/apache/xbean/naming/context/ AbstractContextTest.java ==xbean-naming/src/test/java/org/apache/xbean/naming/context/ ContextAccessControlListTest.java ==xbean-naming/src/test/java/org/apache/xbean/naming/context/ FederationTest.java ==xbean-naming/src/test/java/org/apache/xbean/naming/context/ ImmutableContextTest.java ==xbean-naming/src/test/java/org/apache/xbean/naming/context/ UnmodifiableContextTest.java ==xbean-naming/src/test/java/org/apache/xbean/naming/context/ WritableContextTest.java
Re: [VOTE] Release XBean 2.8
On Dec 18, 2006, at 1:31 PM, Guillaume Nodet wrote: On 12/18/06, Kevan Miller [EMAIL PROTECTED] wrote: On Dec 18, 2006, at 11:25 AM, Guillaume Nodet wrote: I'm starting a vote to release XBean 2.8. There has not been much changes since 2.7, but a few bugs fixed, and the addition of the xbean-finder module. Anyway, the bugs are important enough to deserver a new release (the generated schemas can not be validated). [ ] +1 Start xbean 2.8 release process [ ] +/- 0 [ ] -1 Don't release xbean 2.8 now Here's my +1. Not sure what you mean by release process. Running mvn release:prepare release:perform ;) But here are the issues which look like they would block a release: 1. NOTICE files do not conform to current ASF standards What do you mean exactly ? They have the same content that the ones I've always seen. Could you point me to a better template for these ? Hi Guillaume, Yes, they've changed slightly... Source files no longer contain a copyright statement. Copyright is now in the notice file. Here's a pointer to the current standards -- http://www.apache.org/legal/src- headers.html Notice files take the following form: Apache [PRODUCT_NAME] Copyright [] The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). I don't see any external projects being included in xbean binaries. So, it would seem that's the only content that the NOTICE files would require. I took a peak at the generated jar files. Looks like license/notice files are missing from at least the following jar file: xbean-naming Genesis will automatically check for these during a build. Dain (I think) had a one line command to scan for missing notice/license files, but I can't remember how it went... 2. The following files either do not contain a valid license header (not all files will require one, but many of these need one) or have an out-of-date license header (all need to be updated). Thanks. I'll fix these asap. You run rat for that, right ? Yes, but rat doesn't identify old-style license headers. For these, I've found the following grep command to be useful: grep -RL --include=*.java Licensed to the Apache Software Foundation (ASF) * --kevan
Re: [VOTE] Release XBean 2.8
I've fixed the missing / bad ASF headers and use the new maven plugin to generate LICENSE/NOTICE file. On 12/18/06, Kevan Miller [EMAIL PROTECTED] wrote: On Dec 18, 2006, at 1:31 PM, Guillaume Nodet wrote: On 12/18/06, Kevan Miller [EMAIL PROTECTED] wrote: On Dec 18, 2006, at 11:25 AM, Guillaume Nodet wrote: I'm starting a vote to release XBean 2.8. There has not been much changes since 2.7, but a few bugs fixed, and the addition of the xbean-finder module. Anyway, the bugs are important enough to deserver a new release (the generated schemas can not be validated). [ ] +1 Start xbean 2.8 release process [ ] +/- 0 [ ] -1 Don't release xbean 2.8 now Here's my +1. Not sure what you mean by release process. Running mvn release:prepare release:perform ;) But here are the issues which look like they would block a release: 1. NOTICE files do not conform to current ASF standards What do you mean exactly ? They have the same content that the ones I've always seen. Could you point me to a better template for these ? Hi Guillaume, Yes, they've changed slightly... Source files no longer contain a copyright statement. Copyright is now in the notice file. Here's a pointer to the current standards -- http://www.apache.org/legal/src- headers.html Notice files take the following form: Apache [PRODUCT_NAME] Copyright [] The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). I don't see any external projects being included in xbean binaries. So, it would seem that's the only content that the NOTICE files would require. I took a peak at the generated jar files. Looks like license/notice files are missing from at least the following jar file: xbean-naming Genesis will automatically check for these during a build. Dain (I think) had a one line command to scan for missing notice/license files, but I can't remember how it went... 2. The following files either do not contain a valid license header (not all files will require one, but many of these need one) or have an out-of-date license header (all need to be updated). Thanks. I'll fix these asap. You run rat for that, right ? Yes, but rat doesn't identify old-style license headers. For these, I've found the following grep command to be useful: grep -RL --include=*.java Licensed to the Apache Software Foundation (ASF) * --kevan -- Cheers, Guillaume Nodet
Re: [VOTE] Release XBean 2.8
On Dec 18, 2006, at 3:44 PM, Guillaume Nodet wrote: I've fixed the missing / bad ASF headers and use the new maven plugin to generate LICENSE/NOTICE file. Looks like the following still needs some attention: xbean-spring-v1/pom.xml These all have old style license headers. Sorry, I didn't spot them last scan. xbean-spring-v2/src/site/site.xml xbean-spring-v2a/src/site/site.xml xbean-spring-v2b/src/site/site.xml xbean-spring-v2c/src/site/site.xml I'm done, after that... ;-) --kevan
Re: [VOTE] Release XBean 2.8
Done :) On 12/18/06, Kevan Miller [EMAIL PROTECTED] wrote: On Dec 18, 2006, at 3:44 PM, Guillaume Nodet wrote: I've fixed the missing / bad ASF headers and use the new maven plugin to generate LICENSE/NOTICE file. Looks like the following still needs some attention: xbean-spring-v1/pom.xml These all have old style license headers. Sorry, I didn't spot them last scan. xbean-spring-v2/src/site/site.xml xbean-spring-v2a/src/site/site.xml xbean-spring-v2b/src/site/site.xml xbean-spring-v2c/src/site/site.xml I'm done, after that... ;-) --kevan -- Cheers, Guillaume Nodet
Re: [VOTE] Release XBean 2.8
A note, please do not add headers to the following: ==package-info.java (./xbean-finder/src/test/java/org/acme/foo/ package-info.java) ==java.io.InputStream (./xbean-finder/src/test/resources/META-INF/ java.io.InputStream) ==java.io.OutputStream (./xbean-finder/src/test/resources/META-INF/ java.io.OutputStream) ==java.io.Serializable (./xbean-finder/src/test/resources/META-INF/ java.io.Serializable) ==one (./xbean-finder/src/test/resources/META-INF/externalizables/one) ==three (./xbean-finder/src/test/resources/META-INF/externalizables/ three) ==two (./xbean-finder/src/test/resources/META-INF/externalizables/two) ==bar (./xbean-finder/src/test/resources/META-INF/ java.net.URLStreamHandler/bar) ==baz (./xbean-finder/src/test/resources/META-INF/ java.net.URLStreamHandler/baz) ==foo (./xbean-finder/src/test/resources/META-INF/ java.net.URLStreamHandler/foo) ==kernel (./xbean-finder/src/test/resources/META-INF/ javax.naming.spi.ObjectFactory/kernel) ==ldap (./xbean-finder/src/test/resources/META-INF/ javax.naming.spi.ObjectFactory/ldap) ==ishtar.properties (./xbean-finder/src/test/resources/META-INF/ movies/ishtar.properties) ==kingkong.properties (./xbean-finder/src/test/resources/META-INF/ movies/kingkong.properties) ==serentity.properties (./xbean-finder/src/test/resources/META-INF/ movies/serentity.properties) ==one (./xbean-finder/src/test/resources/META-INF/serializables/one) ==three (./xbean-finder/src/test/resources/META-INF/serializables/ three) ==two (./xbean-finder/src/test/resources/META-INF/serializables/two) ==familyguy.properties (./xbean-finder/src/test/resources/META-INF/ tvshows/familyguy.properties) ==simpsons.properties (./xbean-finder/src/test/resources/META-INF/ tvshows/simpsons.properties) -David
