Re: Simpler config-substitutions.properties keys?
I fixed this as part of https://issues.apache.org/jira/browse/GERONIMO-2735 and documented some stuff at http://cwiki.apache.org/confluence/ display/GMOxDOC20/Multiple+Repositories PLEASE NOTE that I added a prefix for command line and system properties that you want to get into the substitution map. By default, you have to prefix substitution properties in the system environment or in system properties with org.apache.geronimo.config.substitution. so that we won't get accidental resetting of our ports or whatever from other programs settings. IIRC (which I may not) I proposed this when the feature was originally discussed and only realized it wasn't implemented when I came to examine the code again. thanks david jencks On Jul 22, 2007, at 3:29 PM, Matt Hogstrom wrote: go for it On Jul 22, 2007, at 1:48 PM, David Jencks wrote: I noticed all the keys (except portOffset) in config- substitions.properties start with Plan which seems redundant obvious and confusing. Anyone object if I remove this prefix? e.g. instead of PlanServerHostname=0.0.0.0 PlanNamingPort=1099 PlanOpenEJBPort=4201 PlanClientAddresses=127.0.0.1 ServerHostname=0.0.0.0 NamingPort=1099 OpenEJBPort=4201 ClientAddresses=127.0.0.1 thanks david jencks
Simpler config-substitutions.properties keys?
I noticed all the keys (except portOffset) in config- substitions.properties start with Plan which seems redundant obvious and confusing. Anyone object if I remove this prefix? e.g. instead of PlanServerHostname=0.0.0.0 PlanNamingPort=1099 PlanOpenEJBPort=4201 PlanClientAddresses=127.0.0.1 ServerHostname=0.0.0.0 NamingPort=1099 OpenEJBPort=4201 ClientAddresses=127.0.0.1 thanks david jencks
Re: Simpler config-substitutions.properties keys?
No objection. Vamsi On 7/22/07, David Jencks [EMAIL PROTECTED] wrote: I noticed all the keys (except portOffset) in config- substitions.properties start with Plan which seems redundant obvious and confusing. Anyone object if I remove this prefix? e.g. instead of PlanServerHostname=0.0.0.0 PlanNamingPort=1099 PlanOpenEJBPort=4201 PlanClientAddresses=127.0.0.1 ServerHostname=0.0.0.0 NamingPort=1099 OpenEJBPort=4201 ClientAddresses=127.0.0.1 thanks david jencks
Re: Simpler config-substitutions.properties keys?
+1 Jacek On 7/22/07, David Jencks [EMAIL PROTECTED] wrote: I noticed all the keys (except portOffset) in config- substitions.properties start with Plan which seems redundant obvious and confusing. Anyone object if I remove this prefix? e.g. instead of PlanServerHostname=0.0.0.0 PlanNamingPort=1099 PlanOpenEJBPort=4201 PlanClientAddresses=127.0.0.1 ServerHostname=0.0.0.0 NamingPort=1099 OpenEJBPort=4201 ClientAddresses=127.0.0.1 thanks david jencks -- Jacek Laskowski http://www.JacekLaskowski.pl
Re: Simpler config-substitutions.properties keys?
go for it On Jul 22, 2007, at 1:48 PM, David Jencks wrote: I noticed all the keys (except portOffset) in config- substitions.properties start with Plan which seems redundant obvious and confusing. Anyone object if I remove this prefix? e.g. instead of PlanServerHostname=0.0.0.0 PlanNamingPort=1099 PlanOpenEJBPort=4201 PlanClientAddresses=127.0.0.1 ServerHostname=0.0.0.0 NamingPort=1099 OpenEJBPort=4201 ClientAddresses=127.0.0.1 thanks david jencks
