Re: svn commit: r421991 - /geronimo/sandbox/svkmerge/m2migration/modules/system/src/java/org/apache/geronimo/system/repository/AbstractRepository.java

2006-07-15 Thread Jason Dillon 
Agreed... though this affects the output of the m2 build... and hence  
why I wanted to know where the output came from.


--jason


On Jul 14, 2006, at 7:43 PM, Alan D. Cabrera wrote:

IMO, I think that the m2migration branch should focus solely on m2  
migration and leave the cruft cleaning for another effort.



Regards,
Alan

Dain Sundstrom wrote:
That is my code and it should be removed.  I only added it for  
debugging when working on configId branch.


-dain

On Jul 14, 2006, at 12:18 PM, [EMAIL PROTECTED] wrote:


Author: jdillon
Date: Fri Jul 14 12:18:04 2006
New Revision: 421991

URL: http://svn.apache.org/viewvc?rev=421991view=rev
Log:
Comment about crummy usage of System.out

Modified:
geronimo/sandbox/svkmerge/m2migration/modules/system/src/java/ 
org/apache/geronimo/system/repository/AbstractRepository.java


Modified: geronimo/sandbox/svkmerge/m2migration/modules/system/ 
src/java/org/apache/geronimo/system/repository/ 
AbstractRepository.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/svkmerge/ 
m2migration/modules/system/src/java/org/apache/geronimo/system/ 
repository/AbstractRepository.java? 
rev=421991r1=421990r2=421991view=diff
 
==
--- geronimo/sandbox/svkmerge/m2migration/modules/system/src/java/ 
org/apache/geronimo/system/repository/AbstractRepository.java  
(original)
+++ geronimo/sandbox/svkmerge/m2migration/modules/system/src/java/ 
org/apache/geronimo/system/repository/AbstractRepository.java Fri  
Jul 14 12:18:04 2006

@@ -217,7 +217,11 @@
 ArtifactTypeHandler typeHandler = (ArtifactTypeHandler)  
typeHandlers.get(destination.getType());
 if (typeHandler == null) typeHandler =  
DEFAULT_TYPE_HANDLER;
 typeHandler.install(source, size, destination, monitor,  
location);

-
+
+//
+// FIXME: This should not be here... if you need this  
intel then add logging

+//
+
 if (destination.getType().equalsIgnoreCase(car)) {
 System.out.println 
();

 System.out.println(# Installed configuration);

Re: svn commit: r421991 - /geronimo/sandbox/svkmerge/m2migration/modules/system/src/java/org/apache/geronimo/system/repository/AbstractRepository.java

2006-07-14 Thread Dain Sundstrom 
That is my code and it should be removed.  I only added it for  
debugging when working on configId branch.


-dain

On Jul 14, 2006, at 12:18 PM, [EMAIL PROTECTED] wrote:


Author: jdillon
Date: Fri Jul 14 12:18:04 2006
New Revision: 421991

URL: http://svn.apache.org/viewvc?rev=421991view=rev
Log:
Comment about crummy usage of System.out

Modified:
geronimo/sandbox/svkmerge/m2migration/modules/system/src/java/ 
org/apache/geronimo/system/repository/AbstractRepository.java


Modified: geronimo/sandbox/svkmerge/m2migration/modules/system/src/ 
java/org/apache/geronimo/system/repository/AbstractRepository.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/svkmerge/ 
m2migration/modules/system/src/java/org/apache/geronimo/system/ 
repository/AbstractRepository.java? 
rev=421991r1=421990r2=421991view=diff
== 

--- geronimo/sandbox/svkmerge/m2migration/modules/system/src/java/ 
org/apache/geronimo/system/repository/AbstractRepository.java  
(original)
+++ geronimo/sandbox/svkmerge/m2migration/modules/system/src/java/ 
org/apache/geronimo/system/repository/AbstractRepository.java Fri  
Jul 14 12:18:04 2006

@@ -217,7 +217,11 @@
 ArtifactTypeHandler typeHandler = (ArtifactTypeHandler)  
typeHandlers.get(destination.getType());

 if (typeHandler == null) typeHandler = DEFAULT_TYPE_HANDLER;
 typeHandler.install(source, size, destination, monitor,  
location);

-
+
+//
+// FIXME: This should not be here... if you need this  
intel then add logging

+//
+
 if (destination.getType().equalsIgnoreCase(car)) {
 System.out.println 
();

 System.out.println(# Installed configuration);

Re: svn commit: r421991 - /geronimo/sandbox/svkmerge/m2migration/modules/system/src/java/org/apache/geronimo/system/repository/AbstractRepository.java

2006-07-14 Thread Alan D. Cabrera 
IMO, I think that the m2migration branch should focus solely on m2 
migration and leave the cruft cleaning for another effort.



Regards,
Alan

Dain Sundstrom wrote:
That is my code and it should be removed.  I only added it for 
debugging when working on configId branch.


-dain

On Jul 14, 2006, at 12:18 PM, [EMAIL PROTECTED] wrote:


Author: jdillon
Date: Fri Jul 14 12:18:04 2006
New Revision: 421991

URL: http://svn.apache.org/viewvc?rev=421991view=rev
Log:
Comment about crummy usage of System.out

Modified:

geronimo/sandbox/svkmerge/m2migration/modules/system/src/java/org/apache/geronimo/system/repository/AbstractRepository.java 



Modified: 
geronimo/sandbox/svkmerge/m2migration/modules/system/src/java/org/apache/geronimo/system/repository/AbstractRepository.java 

URL: 
http://svn.apache.org/viewvc/geronimo/sandbox/svkmerge/m2migration/modules/system/src/java/org/apache/geronimo/system/repository/AbstractRepository.java?rev=421991r1=421990r2=421991view=diff 

== 

--- 
geronimo/sandbox/svkmerge/m2migration/modules/system/src/java/org/apache/geronimo/system/repository/AbstractRepository.java 
(original)
+++ 
geronimo/sandbox/svkmerge/m2migration/modules/system/src/java/org/apache/geronimo/system/repository/AbstractRepository.java 
Fri Jul 14 12:18:04 2006

@@ -217,7 +217,11 @@
 ArtifactTypeHandler typeHandler = (ArtifactTypeHandler) 
typeHandlers.get(destination.getType());

 if (typeHandler == null) typeHandler = DEFAULT_TYPE_HANDLER;
 typeHandler.install(source, size, destination, monitor, 
location);

-
+
+//
+// FIXME: This should not be here... if you need this intel 
then add logging

+//
+
 if (destination.getType().equalsIgnoreCase(car)) {
 
System.out.println(); 


 System.out.println(# Installed configuration);