[jira] [Commented] (GIRAPH-1205) Separate Giraph counters for different causes of network request resends
[ https://issues.apache.org/jira/browse/GIRAPH-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655925#comment-16655925 ] Hudson commented on GIRAPH-1205: FAILURE: Integrated in Jenkins build Giraph-trunk-Commit #1760 (See [https://builds.apache.org/job/Giraph-trunk-Commit/1760/]) GIRAPH-1205 (majakabiljo: [http://git-wip-us.apache.org/repos/asf?p=giraph.git=commit=5e44c4e4be97e93f5d13cdc7bd52b7374635398c]) * (edit) giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyClient.java > Separate Giraph counters for different causes of network request resends > > > Key: GIRAPH-1205 > URL: https://issues.apache.org/jira/browse/GIRAPH-1205 > Project: Giraph > Issue Type: Improvement >Reporter: Atanu Ghosh >Priority: Minor > Original Estimate: 24h > Remaining Estimate: 24h > > In > [https://issues.apache.org/jira/browse/GIRAPH-1200|https://l.facebook.com/l.php?u=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FGIRAPH-1200=AT0QcRraYr63snHpZlSQ0PxkTc7wY3aucSzdquAnmVSBxVA5AsPAK5m3YEzR7CndOtcjRhHC0vJc8z1ZFmCnJCnH5vyyboH5_zu_pWfC_BxBji3f6JwogLv7xX4tIXQ166Tzise5MUcFYPkP6Jsj7VZV] > we added counters for network requests resends, but "network resends for > timeout" actually cover various reasons for why request can get resent. We > suspect that resending requests after maxRequestMilliseconds timeout is what > is always fatal, so separating this counter from the other causes will help > us verify that. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GIRAPH-1205) Separate Giraph counters for different causes of network request resends
[ https://issues.apache.org/jira/browse/GIRAPH-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655911#comment-16655911 ] ASF GitHub Bot commented on GIRAPH-1205: Github user asfgit closed the pull request at: https://github.com/apache/giraph/pull/88 > Separate Giraph counters for different causes of network request resends > > > Key: GIRAPH-1205 > URL: https://issues.apache.org/jira/browse/GIRAPH-1205 > Project: Giraph > Issue Type: Improvement >Reporter: Atanu Ghosh >Priority: Minor > Original Estimate: 24h > Remaining Estimate: 24h > > In > [https://issues.apache.org/jira/browse/GIRAPH-1200|https://l.facebook.com/l.php?u=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FGIRAPH-1200=AT0QcRraYr63snHpZlSQ0PxkTc7wY3aucSzdquAnmVSBxVA5AsPAK5m3YEzR7CndOtcjRhHC0vJc8z1ZFmCnJCnH5vyyboH5_zu_pWfC_BxBji3f6JwogLv7xX4tIXQ166Tzise5MUcFYPkP6Jsj7VZV] > we added counters for network requests resends, but "network resends for > timeout" actually cover various reasons for why request can get resent. We > suspect that resending requests after maxRequestMilliseconds timeout is what > is always fatal, so separating this counter from the other causes will help > us verify that. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GIRAPH-1205) Separate Giraph counters for different causes of network request resends
[ https://issues.apache.org/jira/browse/GIRAPH-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653833#comment-16653833 ] ASF GitHub Bot commented on GIRAPH-1205: Github user majakabiljo commented on a diff in the pull request: https://github.com/apache/giraph/pull/88#discussion_r226012078 --- Diff: giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyClient.java --- @@ -141,6 +141,9 @@ /** How many network requests were resent because channel failed */ public static final String NETWORK_REQUESTS_RESENT_FOR_CHANNEL_FAILURE_NAME = "Network requests resent for channel failure"; + /** How many network requests were resent because connection failed */ + public static final String NETWORK_REQUESTS_RESENT_FOR_CONNECTION_FAILURE = --- End diff -- Nit: NETWORK_REQUESTS_RESENT_FOR_CONNECTION_FAILURE_NAME > Separate Giraph counters for different causes of network request resends > > > Key: GIRAPH-1205 > URL: https://issues.apache.org/jira/browse/GIRAPH-1205 > Project: Giraph > Issue Type: Improvement >Reporter: Atanu Ghosh >Priority: Minor > Original Estimate: 24h > Remaining Estimate: 24h > > In > [https://issues.apache.org/jira/browse/GIRAPH-1200|https://l.facebook.com/l.php?u=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FGIRAPH-1200=AT0QcRraYr63snHpZlSQ0PxkTc7wY3aucSzdquAnmVSBxVA5AsPAK5m3YEzR7CndOtcjRhHC0vJc8z1ZFmCnJCnH5vyyboH5_zu_pWfC_BxBji3f6JwogLv7xX4tIXQ166Tzise5MUcFYPkP6Jsj7VZV] > we added counters for network requests resends, but "network resends for > timeout" actually cover various reasons for why request can get resent. We > suspect that resending requests after maxRequestMilliseconds timeout is what > is always fatal, so separating this counter from the other causes will help > us verify that. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GIRAPH-1205) Separate Giraph counters for different causes of network request resends
[ https://issues.apache.org/jira/browse/GIRAPH-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650557#comment-16650557 ] ASF GitHub Bot commented on GIRAPH-1205: Github user atanu1991 commented on the issue: https://github.com/apache/giraph/pull/88 Test plan: Tested internally by running hello page rank drop=true ./hellopagerank.sh -DhelloPageRank.iterations=5000 -Dgiraph.maxRequestMilliseconds=1 -Dgiraph.waitingRequestMsecs=1 The new counters are seen  > Separate Giraph counters for different causes of network request resends > > > Key: GIRAPH-1205 > URL: https://issues.apache.org/jira/browse/GIRAPH-1205 > Project: Giraph > Issue Type: Improvement >Reporter: Atanu Ghosh >Priority: Minor > Original Estimate: 24h > Remaining Estimate: 24h > > In > [https://issues.apache.org/jira/browse/GIRAPH-1200|https://l.facebook.com/l.php?u=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FGIRAPH-1200=AT0QcRraYr63snHpZlSQ0PxkTc7wY3aucSzdquAnmVSBxVA5AsPAK5m3YEzR7CndOtcjRhHC0vJc8z1ZFmCnJCnH5vyyboH5_zu_pWfC_BxBji3f6JwogLv7xX4tIXQ166Tzise5MUcFYPkP6Jsj7VZV] > we added counters for network requests resends, but "network resends for > timeout" actually cover various reasons for why request can get resent. We > suspect that resending requests after maxRequestMilliseconds timeout is what > is always fatal, so separating this counter from the other causes will help > us verify that. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GIRAPH-1205) Separate Giraph counters for different causes of network request resends
[ https://issues.apache.org/jira/browse/GIRAPH-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650550#comment-16650550 ] ASF GitHub Bot commented on GIRAPH-1205: GitHub user atanu1991 opened a pull request: https://github.com/apache/giraph/pull/88 GIRAPH-1205: Separate Giraph counters for different causes of network… In https://issues.apache.org/jira/browse/GIRAPH-1200 we added counters for network requests resends, but "network resends for timeout" actually cover various reasons for why request can get resent. We suspect that resending requests after maxRequestMilliseconds timeout is what is always fatal, so separating this counter from the other causes will help us verify that. You can merge this pull request into a Git repository by running: $ git pull https://github.com/atanu1991/giraph counter Alternatively you can review and apply these changes as the patch at: https://github.com/apache/giraph/pull/88.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #88 commit 4d17b964c3486a1f5ec84b3df0e478bf3f912d08 Author: Atanu Ghosh Date: 2018-10-15T17:57:39Z GIRAPH-1205: Separate Giraph counters for different causes of network request resends > Separate Giraph counters for different causes of network request resends > > > Key: GIRAPH-1205 > URL: https://issues.apache.org/jira/browse/GIRAPH-1205 > Project: Giraph > Issue Type: Improvement >Reporter: Atanu Ghosh >Priority: Minor > Original Estimate: 24h > Remaining Estimate: 24h > > In > [https://issues.apache.org/jira/browse/GIRAPH-1200|https://l.facebook.com/l.php?u=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FGIRAPH-1200=AT0QcRraYr63snHpZlSQ0PxkTc7wY3aucSzdquAnmVSBxVA5AsPAK5m3YEzR7CndOtcjRhHC0vJc8z1ZFmCnJCnH5vyyboH5_zu_pWfC_BxBji3f6JwogLv7xX4tIXQ166Tzise5MUcFYPkP6Jsj7VZV] > we added counters for network requests resends, but "network resends for > timeout" actually cover various reasons for why request can get resent. We > suspect that resending requests after maxRequestMilliseconds timeout is what > is always fatal, so separating this counter from the other causes will help > us verify that. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
