[jira] [Commented] (GIRAPH-915) With BigDataIO some messages can get ignored
[ https://issues.apache.org/jira/browse/GIRAPH-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036524#comment-14036524 ] Pavan Kumar commented on GIRAPH-915: +1 lgtm With BigDataIO some messages can get ignored Key: GIRAPH-915 URL: https://issues.apache.org/jira/browse/GIRAPH-915 Project: Giraph Issue Type: Bug Reporter: Maja Kabiljo Assignee: Maja Kabiljo Attachments: GIRAPH-915.patch, GIRAPH-915.patch, GIRAPH-915.patch ExtendedDataInput has int available() method, and when iterating through messages we check if it's grater then zero. For BigDataIO we can get an overflow here, returning a negative values and ignoring the rest of messages. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (GIRAPH-915) With BigDataIO some messages can get ignored
[ https://issues.apache.org/jira/browse/GIRAPH-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036630#comment-14036630 ] Hudson commented on GIRAPH-915: --- ABORTED: Integrated in Giraph-trunk-Commit #1453 (See [https://builds.apache.org/job/Giraph-trunk-Commit/1453/]) GIRAPH-915: With BigDataIO some messages can get ignored (majakabiljo via pavanka) (pavanka: http://git-wip-us.apache.org/repos/asf?p=giraph.gita=commith=58576c81fed9f4eccb03366151c1cf280765d237) * giraph-core/src/main/java/org/apache/giraph/utils/VertexIterator.java * giraph-core/src/main/java/org/apache/giraph/utils/ExtendedByteArrayDataInput.java * giraph-core/src/main/java/org/apache/giraph/utils/ExtendedDataInput.java * giraph-core/src/main/java/org/apache/giraph/utils/UnsafeArrayReads.java * giraph-core/src/main/java/org/apache/giraph/edge/ByteArrayEdges.java * giraph-core/src/main/java/org/apache/giraph/comm/requests/SendWorkerOneToAllMessagesRequest.java * giraph-core/src/main/java/org/apache/giraph/utils/ByteStructVertexIdIterator.java * giraph-core/src/main/java/org/apache/giraph/utils/ByteStructIterator.java * CHANGELOG * giraph-core/src/main/java/org/apache/giraph/utils/io/BigDataInput.java With BigDataIO some messages can get ignored Key: GIRAPH-915 URL: https://issues.apache.org/jira/browse/GIRAPH-915 Project: Giraph Issue Type: Bug Reporter: Maja Kabiljo Assignee: Maja Kabiljo Attachments: GIRAPH-915.patch, GIRAPH-915.patch, GIRAPH-915.patch ExtendedDataInput has int available() method, and when iterating through messages we check if it's grater then zero. For BigDataIO we can get an overflow here, returning a negative values and ignoring the rest of messages. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (GIRAPH-915) With BigDataIO some messages can get ignored
[ https://issues.apache.org/jira/browse/GIRAPH-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14026786#comment-14026786 ] Pavan Kumar commented on GIRAPH-915: can't u just leave available as is, and define the other another method. otherwise lgtm With BigDataIO some messages can get ignored Key: GIRAPH-915 URL: https://issues.apache.org/jira/browse/GIRAPH-915 Project: Giraph Issue Type: Bug Reporter: Maja Kabiljo Assignee: Maja Kabiljo Attachments: GIRAPH-915.patch ExtendedDataInput has int available() method, and when iterating through messages we check if it's grater then zero. For BigDataIO we can get an overflow here, returning a negative values and ignoring the rest of messages. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (GIRAPH-915) With BigDataIO some messages can get ignored
[ https://issues.apache.org/jira/browse/GIRAPH-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14026846#comment-14026846 ] Maja Kabiljo commented on GIRAPH-915: - But available can't be implemented correctly in BigDataIO. I could throw an exception there if it sounds better. And available() is not going to be used anywhere. What do you think? With BigDataIO some messages can get ignored Key: GIRAPH-915 URL: https://issues.apache.org/jira/browse/GIRAPH-915 Project: Giraph Issue Type: Bug Reporter: Maja Kabiljo Assignee: Maja Kabiljo Attachments: GIRAPH-915.patch ExtendedDataInput has int available() method, and when iterating through messages we check if it's grater then zero. For BigDataIO we can get an overflow here, returning a negative values and ignoring the rest of messages. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (GIRAPH-915) With BigDataIO some messages can get ignored
[ https://issues.apache.org/jira/browse/GIRAPH-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14026857#comment-14026857 ] Pavan Kumar commented on GIRAPH-915: throwing an exception sounds better. this is because we can have future implementations of bytedatastructs and available is really needed (for example in bytebufdatainput, etc.) With BigDataIO some messages can get ignored Key: GIRAPH-915 URL: https://issues.apache.org/jira/browse/GIRAPH-915 Project: Giraph Issue Type: Bug Reporter: Maja Kabiljo Assignee: Maja Kabiljo Attachments: GIRAPH-915.patch ExtendedDataInput has int available() method, and when iterating through messages we check if it's grater then zero. For BigDataIO we can get an overflow here, returning a negative values and ignoring the rest of messages. -- This message was sent by Atlassian JIRA (v6.2#6252)
