[jira] [Created] (GOBBLIN-776) Add a utility method to return Helix WorflowId given a Gobblin job name

2019-05-20 Thread Sudarshan Vasudevan (JIRA)
Sudarshan Vasudevan created GOBBLIN-776:
---

 Summary: Add a utility method to return Helix WorflowId given a 
Gobblin job name 
 Key: GOBBLIN-776
 URL: https://issues.apache.org/jira/browse/GOBBLIN-776
 Project: Apache Gobblin
  Issue Type: Improvement
  Components: gobblin-cluster
Affects Versions: 0.15.0
Reporter: Sudarshan Vasudevan
Assignee: Hung Tran
 Fix For: 0.15.0


This task adds a utility method to return Helix WorflowId given a Gobblin job 
name. This allows cancelling Gobblin jobs running on a Gobblin Helix cluster 
using a Spec containing the job name, instead of requiring the spec to provide 
the Helix Workflow Id.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Work logged] (GOBBLIN-774) Send nack when a control message handler fails in Fork

2019-05-20 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-774?focusedWorklogId=245751=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-245751
 ]

ASF GitHub Bot logged work on GOBBLIN-774:
--

Author: ASF GitHub Bot
Created on: 21/May/19 03:56
Start Date: 21/May/19 03:56
Worklog Time Spent: 10m 
  Work Description: asfgit commented on pull request #2639: [GOBBLIN-774] 
Send nack when a control message handler fails in Fork
URL: https://github.com/apache/incubator-gobblin/pull/2639
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 245751)
Time Spent: 20m  (was: 10m)

> Send nack when a control message handler fails in Fork
> --
>
> Key: GOBBLIN-774
> URL: https://issues.apache.org/jira/browse/GOBBLIN-774
> Project: Apache Gobblin
>  Issue Type: Task
>Reporter: Hung Tran
>Assignee: Hung Tran
>Priority: Major
> Fix For: 0.15.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Fork will raise an error without ack/nacking if the control message handler 
> raises an error. This can result in another thread waiting indefinitely for a 
> control message ack. Fork.
> consumeRecordStream() should handle control message exceptions by calling 
> nack() with the exception before reraising the error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (GOBBLIN-774) Send nack when a control message handler fails in Fork

2019-05-20 Thread Hung Tran (JIRA)


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hung Tran resolved GOBBLIN-774.
---
   Resolution: Fixed
Fix Version/s: 0.15.0

Issue resolved by pull request #2639
[https://github.com/apache/incubator-gobblin/pull/2639]

> Send nack when a control message handler fails in Fork
> --
>
> Key: GOBBLIN-774
> URL: https://issues.apache.org/jira/browse/GOBBLIN-774
> Project: Apache Gobblin
>  Issue Type: Task
>Reporter: Hung Tran
>Assignee: Hung Tran
>Priority: Major
> Fix For: 0.15.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Fork will raise an error without ack/nacking if the control message handler 
> raises an error. This can result in another thread waiting indefinitely for a 
> control message ack. Fork.
> consumeRecordStream() should handle control message exceptions by calling 
> nack() with the exception before reraising the error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [incubator-gobblin] asfgit closed pull request #2639: [GOBBLIN-774] Send nack when a control message handler fails in Fork

2019-05-20 Thread GitBox
asfgit closed pull request #2639: [GOBBLIN-774] Send nack when a control 
message handler fails in Fork
URL: https://github.com/apache/incubator-gobblin/pull/2639
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Work logged] (GOBBLIN-775) Add job level retry for gobblin service

2019-05-20 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-775?focusedWorklogId=245639=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-245639
 ]

ASF GitHub Bot logged work on GOBBLIN-775:
--

Author: ASF GitHub Bot
Created on: 21/May/19 00:28
Start Date: 21/May/19 00:28
Worklog Time Spent: 10m 
  Work Description: jack-moseley commented on issue #2640: [GOBBLIN-775] 
Add job level retries for gobblin service
URL: 
https://github.com/apache/incubator-gobblin/pull/2640#issuecomment-494195630
 
 
   @sv2000 please review
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 245639)
Time Spent: 20m  (was: 10m)

> Add job level retry for gobblin service
> ---
>
> Key: GOBBLIN-775
> URL: https://issues.apache.org/jira/browse/GOBBLIN-775
> Project: Apache Gobblin
>  Issue Type: New Feature
>  Components: gobblin-service
>Reporter: Jack Moseley
>Assignee: Abhishek Tiwari
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [incubator-gobblin] jack-moseley commented on issue #2640: [GOBBLIN-775] Add job level retries for gobblin service

2019-05-20 Thread GitBox
jack-moseley commented on issue #2640: [GOBBLIN-775] Add job level retries for 
gobblin service
URL: 
https://github.com/apache/incubator-gobblin/pull/2640#issuecomment-494195630
 
 
   @sv2000 please review


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Work logged] (GOBBLIN-775) Add job level retry for gobblin service

2019-05-20 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-775?focusedWorklogId=245638=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-245638
 ]

ASF GitHub Bot logged work on GOBBLIN-775:
--

Author: ASF GitHub Bot
Created on: 21/May/19 00:27
Start Date: 21/May/19 00:27
Worklog Time Spent: 10m 
  Work Description: jack-moseley commented on pull request #2640: 
[GOBBLIN-775] Add job level retries for gobblin service
URL: https://github.com/apache/incubator-gobblin/pull/2640
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
   - https://issues.apache.org/jira/browse/GOBBLIN-775
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if 
applicable):
   
   - Add option `job.maxRetries` to retry a job in gobblin service.
   - Refactor `DagManager` to use a string identifier as the key in `jobToDag` 
map, since having a `dagNode` as the key causes problems if the underlying 
object is modified
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   Added tests in `DagManagerTest`
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
   1. Subject is separated from body by a blank line
   2. Subject is limited to 50 characters
   3. Subject does not end with a period
   4. Subject uses the imperative mood ("add", not "adding")
   5. Body wraps at 72 characters
   6. Body explains "what" and "why", not "how"
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 245638)
Time Spent: 10m
Remaining Estimate: 0h

> Add job level retry for gobblin service
> ---
>
> Key: GOBBLIN-775
> URL: https://issues.apache.org/jira/browse/GOBBLIN-775
> Project: Apache Gobblin
>  Issue Type: New Feature
>  Components: gobblin-service
>Reporter: Jack Moseley
>Assignee: Abhishek Tiwari
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [incubator-gobblin] jack-moseley opened a new pull request #2640: [GOBBLIN-775] Add job level retries for gobblin service

2019-05-20 Thread GitBox
jack-moseley opened a new pull request #2640: [GOBBLIN-775] Add job level 
retries for gobblin service
URL: https://github.com/apache/incubator-gobblin/pull/2640
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
   - https://issues.apache.org/jira/browse/GOBBLIN-775
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if 
applicable):
   
   - Add option `job.maxRetries` to retry a job in gobblin service.
   - Refactor `DagManager` to use a string identifier as the key in `jobToDag` 
map, since having a `dagNode` as the key causes problems if the underlying 
object is modified
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   Added tests in `DagManagerTest`
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
   1. Subject is separated from body by a blank line
   2. Subject is limited to 50 characters
   3. Subject does not end with a period
   4. Subject uses the imperative mood ("add", not "adding")
   5. Body wraps at 72 characters
   6. Body explains "what" and "why", not "how"
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (GOBBLIN-775) Add job level retry for gobblin service

2019-05-20 Thread Jack Moseley (JIRA)
Jack Moseley created GOBBLIN-775:


 Summary: Add job level retry for gobblin service
 Key: GOBBLIN-775
 URL: https://issues.apache.org/jira/browse/GOBBLIN-775
 Project: Apache Gobblin
  Issue Type: New Feature
  Components: gobblin-service
Reporter: Jack Moseley
Assignee: Abhishek Tiwari






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Work logged] (GOBBLIN-774) Send nack when a control message handler fails in Fork

2019-05-20 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-774?focusedWorklogId=245612=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-245612
 ]

ASF GitHub Bot logged work on GOBBLIN-774:
--

Author: ASF GitHub Bot
Created on: 20/May/19 22:46
Start Date: 20/May/19 22:46
Worklog Time Spent: 10m 
  Work Description: htran1 commented on pull request #2639: [GOBBLIN-774] 
Send nack when a control message handler fails in Fork
URL: https://github.com/apache/incubator-gobblin/pull/2639
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [X] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
   - https://issues.apache.org/jira/browse/GOBBLIN-774
   
   ### Description
   - [X] Here are some details about my PR, including screenshots (if 
applicable):
   Fork will raise an error without ack/nacking if the control message handler 
raises an error. This can result in another thread waiting indefinitely for a 
control message ack. Fork.
   
   consumeRecordStream() should handle control message exceptions by calling 
nack() with the exception before reraising the error.
   
   ### Tests
   - [X] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   
   ### Commits
   - [X] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
   1. Subject is separated from body by a blank line
   2. Subject is limited to 50 characters
   3. Subject does not end with a period
   4. Subject uses the imperative mood ("add", not "adding")
   5. Body wraps at 72 characters
   6. Body explains "what" and "why", not "how"
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 245612)
Time Spent: 10m
Remaining Estimate: 0h

> Send nack when a control message handler fails in Fork
> --
>
> Key: GOBBLIN-774
> URL: https://issues.apache.org/jira/browse/GOBBLIN-774
> Project: Apache Gobblin
>  Issue Type: Task
>Reporter: Hung Tran
>Assignee: Hung Tran
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Fork will raise an error without ack/nacking if the control message handler 
> raises an error. This can result in another thread waiting indefinitely for a 
> control message ack. Fork.
> consumeRecordStream() should handle control message exceptions by calling 
> nack() with the exception before reraising the error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [incubator-gobblin] htran1 opened a new pull request #2639: [GOBBLIN-774] Send nack when a control message handler fails in Fork

2019-05-20 Thread GitBox
htran1 opened a new pull request #2639: [GOBBLIN-774] Send nack when a control 
message handler fails in Fork
URL: https://github.com/apache/incubator-gobblin/pull/2639
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [X] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
   - https://issues.apache.org/jira/browse/GOBBLIN-774
   
   ### Description
   - [X] Here are some details about my PR, including screenshots (if 
applicable):
   Fork will raise an error without ack/nacking if the control message handler 
raises an error. This can result in another thread waiting indefinitely for a 
control message ack. Fork.
   
   consumeRecordStream() should handle control message exceptions by calling 
nack() with the exception before reraising the error.
   
   ### Tests
   - [X] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   
   ### Commits
   - [X] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
   1. Subject is separated from body by a blank line
   2. Subject is limited to 50 characters
   3. Subject does not end with a period
   4. Subject uses the imperative mood ("add", not "adding")
   5. Body wraps at 72 characters
   6. Body explains "what" and "why", not "how"
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (GOBBLIN-774) Send nack when a control message handler fails in Fork

2019-05-20 Thread Hung Tran (JIRA)
Hung Tran created GOBBLIN-774:
-

 Summary: Send nack when a control message handler fails in Fork
 Key: GOBBLIN-774
 URL: https://issues.apache.org/jira/browse/GOBBLIN-774
 Project: Apache Gobblin
  Issue Type: Task
Reporter: Hung Tran
Assignee: Hung Tran


Fork will raise an error without ack/nacking if the control message handler 
raises an error. This can result in another thread waiting indefinitely for a 
control message ack. Fork.

consumeRecordStream() should handle control message exceptions by calling 
nack() with the exception before reraising the error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Work logged] (GOBBLIN-768) Add MySQL implementation of SpecStore

2019-05-20 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-768?focusedWorklogId=245453=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-245453
 ]

ASF GitHub Bot logged work on GOBBLIN-768:
--

Author: ASF GitHub Bot
Created on: 20/May/19 18:50
Start Date: 20/May/19 18:50
Worklog Time Spent: 10m 
  Work Description: asfgit commented on pull request #2631: [GOBBLIN-768] 
Add MySQL implementation of SpecStore
URL: https://github.com/apache/incubator-gobblin/pull/2631
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 245453)
Time Spent: 3h 50m  (was: 3h 40m)

> Add MySQL implementation of SpecStore
> -
>
> Key: GOBBLIN-768
> URL: https://issues.apache.org/jira/browse/GOBBLIN-768
> Project: Apache Gobblin
>  Issue Type: New Feature
>Reporter: Jack Moseley
>Priority: Major
>  Time Spent: 3h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [incubator-gobblin] asfgit closed pull request #2631: [GOBBLIN-768] Add MySQL implementation of SpecStore

2019-05-20 Thread GitBox
asfgit closed pull request #2631: [GOBBLIN-768] Add MySQL implementation of 
SpecStore
URL: https://github.com/apache/incubator-gobblin/pull/2631
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Work logged] (GOBBLIN-768) Add MySQL implementation of SpecStore

2019-05-20 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-768?focusedWorklogId=245419=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-245419
 ]

ASF GitHub Bot logged work on GOBBLIN-768:
--

Author: ASF GitHub Bot
Created on: 20/May/19 18:29
Start Date: 20/May/19 18:29
Worklog Time Spent: 10m 
  Work Description: autumnust commented on issue #2631: [GOBBLIN-768] Add 
MySQL implementation of SpecStore
URL: 
https://github.com/apache/incubator-gobblin/pull/2631#issuecomment-494100188
 
 
   +1 LGTM. 
   @sv2000  Plz merge, thx
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 245419)
Time Spent: 3h 40m  (was: 3.5h)

> Add MySQL implementation of SpecStore
> -
>
> Key: GOBBLIN-768
> URL: https://issues.apache.org/jira/browse/GOBBLIN-768
> Project: Apache Gobblin
>  Issue Type: New Feature
>Reporter: Jack Moseley
>Priority: Major
>  Time Spent: 3h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [incubator-gobblin] autumnust commented on issue #2631: [GOBBLIN-768] Add MySQL implementation of SpecStore

2019-05-20 Thread GitBox
autumnust commented on issue #2631: [GOBBLIN-768] Add MySQL implementation of 
SpecStore
URL: 
https://github.com/apache/incubator-gobblin/pull/2631#issuecomment-494100188
 
 
   +1 LGTM. 
   @sv2000  Plz merge, thx


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services