[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2578: [GOBBLIN-707] rewrite gobblin script to combine all modes and command
autumnust commented on a change in pull request #2578: [GOBBLIN-707] rewrite gobblin script to combine all modes and command URL: https://github.com/apache/incubator-gobblin/pull/2578#discussion_r271922811 ## File path: conf/yarn/reference.conf ## @@ -38,6 +38,6 @@ gobblin.yarn.work.dir=/gobblin gobblin.cluster.helix.cluster.name=GobblinYarn gobblin.cluster.zk.connection.string="localhost:2181" -fs.uri="hdfs://localhost:9000" Review comment: Just curious, why port number needs to be changed here? Seems both 8020/9000 can be default port number for IPC of Namenode This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2578: [GOBBLIN-707] rewrite gobblin script to combine all modes and command
autumnust commented on a change in pull request #2578: [GOBBLIN-707] rewrite gobblin script to combine all modes and command URL: https://github.com/apache/incubator-gobblin/pull/2578#discussion_r271925108 ## File path: gobblin-docs/user-guide/Gobblin-CLI.md ## @@ -28,29 +28,29 @@ Gobblin ingestion applications Gobblin ingestion applications can be accessed through the command `run`: ```bash -bin/gobblin run [listQuickApps] [] -jobName [OPTIONS] +bin/gobblin cli run [listQuickApps] [] -jobName [OPTIONS] Review comment: Sorry for getting back to this late. Yes that makes sense to me. I see them in `gobblin.sh` printUsage() method. Can you add/edit documentation to mention the existence of `gobblin.sh` so that newer users will be aware of it ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2578: [GOBBLIN-707] rewrite gobblin script to combine all modes and command
autumnust commented on a change in pull request #2578: [GOBBLIN-707] rewrite
gobblin script to combine all modes and command
URL: https://github.com/apache/incubator-gobblin/pull/2578#discussion_r271923038
##
File path: conf/yarn/application.conf
##
@@ -22,15 +22,18 @@ gobblin.yarn.app.name=GobblinYarn
gobblin.yarn.app.master.memory.mbs=256
gobblin.yarn.initial.containers=2
gobblin.yarn.container.memory.mbs=512
-gobblin.yarn.conf.dir=
-gobblin.yarn.lib.jars.dir=
-gobblin.yarn.app.master.files.local=${gobblin.yarn.conf.dir}"/log4j-yarn.properties,"${gobblin.yarn.conf.dir}"/application.conf,"${gobblin.yarn.conf.dir}"/reference.conf"
+gobblin.yarn.conf.dir=/tools/gobblin-dist/conf/yarn/
Review comment:
Why this is being hard coded ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2578: [GOBBLIN-707] rewrite gobblin script to combine all modes and command
autumnust commented on a change in pull request #2578: [GOBBLIN-707] rewrite gobblin script to combine all modes and command URL: https://github.com/apache/incubator-gobblin/pull/2578#discussion_r268778696 ## File path: gobblin-docs/user-guide/Gobblin-CLI.md ## @@ -28,29 +28,29 @@ Gobblin ingestion applications Gobblin ingestion applications can be accessed through the command `run`: ```bash -bin/gobblin run [listQuickApps] [] -jobName [OPTIONS] +bin/gobblin cli run [listQuickApps] [] -jobName [OPTIONS] Review comment: Changes here seems incorrect since `gobblin cli run` is not a valid command. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
