[jira] [Work logged] (GOBBLIN-725) add a mysql based job-status store
[
https://issues.apache.org/jira/browse/GOBBLIN-725?focusedWorklogId=224161=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-224161
]
ASF GitHub Bot logged work on GOBBLIN-725:
--
Author: ASF GitHub Bot
Created on: 07/Apr/19 22:18
Start Date: 07/Apr/19 22:18
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on pull request #2592:
[GOBBLIN-725] add a mysql based job status retriever
URL: https://github.com/apache/incubator-gobblin/pull/2592#discussion_r272854573
##
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/FsJobStatusRetriever.java
##
@@ -135,32 +135,6 @@ public FsJobStatusRetriever(Config config) {
}
}
- /**
- *
- * @param jobState instance of {@link State}
- * @return deserialize {@link State} into a {@link JobStatus}.
- */
- private JobStatus getJobStatus(State jobState) {
Review comment:
I moved it back to the parent class, because I need it in other child class
of its parent class.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 224161)
Time Spent: 40m (was: 0.5h)
> add a mysql based job-status store
> --
>
> Key: GOBBLIN-725
> URL: https://issues.apache.org/jira/browse/GOBBLIN-725
> Project: Apache Gobblin
> Issue Type: Improvement
>Reporter: Arjun Singh Bora
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (GOBBLIN-725) add a mysql based job-status store
[
https://issues.apache.org/jira/browse/GOBBLIN-725?focusedWorklogId=224160=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-224160
]
ASF GitHub Bot logged work on GOBBLIN-725:
--
Author: ASF GitHub Bot
Created on: 07/Apr/19 22:17
Start Date: 07/Apr/19 22:17
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on pull request #2592:
[GOBBLIN-725] add a mysql based job status retriever
URL: https://github.com/apache/incubator-gobblin/pull/2592#discussion_r272854535
##
File path:
gobblin-metastore/src/main/java/org/apache/gobblin/metastore/MysqlJobStatusStateStore.java
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.metastore;
+
+import java.io.IOException;
+import java.util.List;
+
+import javax.sql.DataSource;
+
+import org.apache.gobblin.configuration.State;
+
+
+public class MysqlJobStatusStateStore extends MysqlStateStore
{
Review comment:
Had to write this just to override one method. I did not want to change the
current MysqlStateStore...
In future, we may need more specialized sql queries; that's another reason I
did not change MysqlStateStore
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 224160)
Time Spent: 0.5h (was: 20m)
> add a mysql based job-status store
> --
>
> Key: GOBBLIN-725
> URL: https://issues.apache.org/jira/browse/GOBBLIN-725
> Project: Apache Gobblin
> Issue Type: Improvement
>Reporter: Arjun Singh Bora
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (GOBBLIN-725) add a mysql based job-status store
[
https://issues.apache.org/jira/browse/GOBBLIN-725?focusedWorklogId=224026=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-224026
]
ASF GitHub Bot logged work on GOBBLIN-725:
--
Author: ASF GitHub Bot
Created on: 06/Apr/19 08:26
Start Date: 06/Apr/19 08:26
Worklog Time Spent: 10m
Work Description: jhsenjaliya commented on pull request #2592:
[GOBBLIN-725] add a mysql based job status retriever
URL: https://github.com/apache/incubator-gobblin/pull/2592#discussion_r272788508
##
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/FsJobStatusRetriever.java
##
@@ -135,32 +135,6 @@ public FsJobStatusRetriever(Config config) {
}
}
- /**
- *
- * @param jobState instance of {@link State}
- * @return deserialize {@link State} into a {@link JobStatus}.
- */
- private JobStatus getJobStatus(State jobState) {
Review comment:
did u mean to remove this method? its still being used in same class.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 224026)
Time Spent: 20m (was: 10m)
> add a mysql based job-status store
> --
>
> Key: GOBBLIN-725
> URL: https://issues.apache.org/jira/browse/GOBBLIN-725
> Project: Apache Gobblin
> Issue Type: Improvement
>Reporter: Arjun Singh Bora
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
