[jira] [Commented] (GORA-698) Add GEODE Support
[ https://issues.apache.org/jira/browse/GORA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600526#comment-17600526 ] ASF GitHub Bot commented on GORA-698: - himanshuacharya95 commented on code in PR #273: URL: https://github.com/apache/gora/pull/273#discussion_r963144285 ## gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java: ## @@ -0,0 +1,190 @@ +package org.apache.gora.geode.store; + +import org.apache.geode.cache.*; +import org.apache.geode.cache.client.ClientCache; +import org.apache.geode.cache.client.ClientCacheFactory; +import org.apache.gora.geode.query.GeodeQuery; +import org.apache.gora.geode.query.GeodeResult; +import org.apache.gora.persistency.impl.PersistentBase; +import org.apache.gora.query.PartitionQuery; +import org.apache.gora.query.Query; +import org.apache.gora.query.Result; +import org.apache.gora.query.impl.PartitionQueryImpl; +import org.apache.gora.store.impl.DataStoreBase; +import org.apache.gora.util.GoraException; + +import java.io.IOException; +import java.util.*; +import java.util.concurrent.ConcurrentSkipListSet; + +import static org.apache.geode.cache.RegionShortcut.REPLICATE; +import static org.apache.gora.geode.store.GeodeStoreParameters.*; + + +public class GeodeStore extends DataStoreBase { + +private ClientCache clientCache; +private Region region; +private Properties geodeProperties; + + +private CacheFactory cacheFactory; + +@Override +public void initialize(Class keyClass, Class persistentClass, Properties properties) throws GoraException { +super.initialize(keyClass, persistentClass, properties); +String geodeHostName = (String) properties.get(GEODE_SERVER_HOST); +int portNumber = Integer.parseInt((String) properties.get(GEODE_SERVER_PORT)); +clientCache = new ClientCacheFactory().addPoolLocator(geodeHostName, portNumber).create(); +String userName = properties.getProperty(GEODE_USERNAME); +String password = properties.getProperty(GEODE_PASSWORD); +geodeProperties = properties; + +Properties clientProperties = clientCache.getDistributedSystem().getProperties(); +if (userName != null) { +clientProperties.setProperty("security-username", userName); +clientProperties.setProperty("security-password", password); +} +cacheFactory = new CacheFactory(clientProperties); +} + +@Override +/* + Schema Name can be assigned via Property file using @PREFERRED_SCHEMA_NAME, or else PersistentClass name is used as the default schema name. + */ +public String getSchemaName() { +String preferredSchemaName = properties.getProperty(PREFERRED_SCHEMA_NAME); +if (preferredSchemaName == null) { +return persistentClass.getSimpleName(); +} +return preferredSchemaName; +} + +@Override +public void createSchema() throws GoraException { +try { +Cache cache = cacheFactory.create(); +String regionShortCut = geodeProperties.getProperty(GEODE_REGION_SHORTCUT); +RegionFactory regionFactory; +if (regionShortCut != null) { +regionFactory = cache.createRegionFactory(RegionShortcut.valueOf(regionShortCut)); +} else { +regionFactory = cache.createRegionFactory(REPLICATE); +} +region = regionFactory.create(getSchemaName()); +} catch (Exception e) { +throw new GoraException(e); +} +} + +@Override +public void deleteSchema() { +region.destroyRegion(); +} + +@Override +public boolean schemaExists() { +Properties properties = clientCache.getDistributedSystem().getProperties(); +CacheFactory factory = new CacheFactory(properties); +Cache cache = factory.create(); +Region rf = cache.getRegion(getSchemaName()); +return rf != null; +} + +@Override +public boolean exists(K key) { +for (K existingKey : region.getInterestList()) { +if (existingKey.equals(key)) { +return true; +} +} +return false; +} + +@Override +public T get(K key, String[] fields) { +return region.get(key); +} + +@Override +public void put(K key, T obj) { +region.put(key, obj); +} + +@Override +public boolean delete(K key) { +region.destroy(key); +return true; +} + +@Override +public long deleteByQuery(Query query) throws GoraException { +try { +long deletedRows = 0; +Result result = query.execute(); +while (result.next()) { +if (delete(result.getKey())) { +deletedRows++; +} +} +LOG.info("Geode datastore deleted {} rows from
[jira] [Commented] (GORA-698) Add GEODE Support
[ https://issues.apache.org/jira/browse/GORA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600525#comment-17600525 ] ASF GitHub Bot commented on GORA-698: - himanshuacharya95 commented on code in PR #273: URL: https://github.com/apache/gora/pull/273#discussion_r963144223 ## gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java: ## @@ -0,0 +1,190 @@ +package org.apache.gora.geode.store; + +import org.apache.geode.cache.*; +import org.apache.geode.cache.client.ClientCache; +import org.apache.geode.cache.client.ClientCacheFactory; +import org.apache.gora.geode.query.GeodeQuery; +import org.apache.gora.geode.query.GeodeResult; +import org.apache.gora.persistency.impl.PersistentBase; +import org.apache.gora.query.PartitionQuery; +import org.apache.gora.query.Query; +import org.apache.gora.query.Result; +import org.apache.gora.query.impl.PartitionQueryImpl; +import org.apache.gora.store.impl.DataStoreBase; +import org.apache.gora.util.GoraException; + +import java.io.IOException; +import java.util.*; +import java.util.concurrent.ConcurrentSkipListSet; + +import static org.apache.geode.cache.RegionShortcut.REPLICATE; +import static org.apache.gora.geode.store.GeodeStoreParameters.*; + + +public class GeodeStore extends DataStoreBase { + +private ClientCache clientCache; +private Region region; +private Properties geodeProperties; + + +private CacheFactory cacheFactory; + +@Override +public void initialize(Class keyClass, Class persistentClass, Properties properties) throws GoraException { +super.initialize(keyClass, persistentClass, properties); +String geodeHostName = (String) properties.get(GEODE_SERVER_HOST); +int portNumber = Integer.parseInt((String) properties.get(GEODE_SERVER_PORT)); +clientCache = new ClientCacheFactory().addPoolLocator(geodeHostName, portNumber).create(); +String userName = properties.getProperty(GEODE_USERNAME); +String password = properties.getProperty(GEODE_PASSWORD); +geodeProperties = properties; + +Properties clientProperties = clientCache.getDistributedSystem().getProperties(); +if (userName != null) { Review Comment: Added some code to throw exception > Add GEODE Support > - > > Key: GORA-698 > URL: https://issues.apache.org/jira/browse/GORA-698 > Project: Apache Gora > Issue Type: New Feature >Reporter: Himanshu >Priority: Major > > [1]https://geode.apache.org/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [gora] himanshuacharya95 commented on a diff in pull request #273: [IN-PROGRESS] GORA-698 Geode DataStore
himanshuacharya95 commented on code in PR #273: URL: https://github.com/apache/gora/pull/273#discussion_r963144285 ## gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java: ## @@ -0,0 +1,190 @@ +package org.apache.gora.geode.store; + +import org.apache.geode.cache.*; +import org.apache.geode.cache.client.ClientCache; +import org.apache.geode.cache.client.ClientCacheFactory; +import org.apache.gora.geode.query.GeodeQuery; +import org.apache.gora.geode.query.GeodeResult; +import org.apache.gora.persistency.impl.PersistentBase; +import org.apache.gora.query.PartitionQuery; +import org.apache.gora.query.Query; +import org.apache.gora.query.Result; +import org.apache.gora.query.impl.PartitionQueryImpl; +import org.apache.gora.store.impl.DataStoreBase; +import org.apache.gora.util.GoraException; + +import java.io.IOException; +import java.util.*; +import java.util.concurrent.ConcurrentSkipListSet; + +import static org.apache.geode.cache.RegionShortcut.REPLICATE; +import static org.apache.gora.geode.store.GeodeStoreParameters.*; + + +public class GeodeStore extends DataStoreBase { + +private ClientCache clientCache; +private Region region; +private Properties geodeProperties; + + +private CacheFactory cacheFactory; + +@Override +public void initialize(Class keyClass, Class persistentClass, Properties properties) throws GoraException { +super.initialize(keyClass, persistentClass, properties); +String geodeHostName = (String) properties.get(GEODE_SERVER_HOST); +int portNumber = Integer.parseInt((String) properties.get(GEODE_SERVER_PORT)); +clientCache = new ClientCacheFactory().addPoolLocator(geodeHostName, portNumber).create(); +String userName = properties.getProperty(GEODE_USERNAME); +String password = properties.getProperty(GEODE_PASSWORD); +geodeProperties = properties; + +Properties clientProperties = clientCache.getDistributedSystem().getProperties(); +if (userName != null) { +clientProperties.setProperty("security-username", userName); +clientProperties.setProperty("security-password", password); +} +cacheFactory = new CacheFactory(clientProperties); +} + +@Override +/* + Schema Name can be assigned via Property file using @PREFERRED_SCHEMA_NAME, or else PersistentClass name is used as the default schema name. + */ +public String getSchemaName() { +String preferredSchemaName = properties.getProperty(PREFERRED_SCHEMA_NAME); +if (preferredSchemaName == null) { +return persistentClass.getSimpleName(); +} +return preferredSchemaName; +} + +@Override +public void createSchema() throws GoraException { +try { +Cache cache = cacheFactory.create(); +String regionShortCut = geodeProperties.getProperty(GEODE_REGION_SHORTCUT); +RegionFactory regionFactory; +if (regionShortCut != null) { +regionFactory = cache.createRegionFactory(RegionShortcut.valueOf(regionShortCut)); +} else { +regionFactory = cache.createRegionFactory(REPLICATE); +} +region = regionFactory.create(getSchemaName()); +} catch (Exception e) { +throw new GoraException(e); +} +} + +@Override +public void deleteSchema() { +region.destroyRegion(); +} + +@Override +public boolean schemaExists() { +Properties properties = clientCache.getDistributedSystem().getProperties(); +CacheFactory factory = new CacheFactory(properties); +Cache cache = factory.create(); +Region rf = cache.getRegion(getSchemaName()); +return rf != null; +} + +@Override +public boolean exists(K key) { +for (K existingKey : region.getInterestList()) { +if (existingKey.equals(key)) { +return true; +} +} +return false; +} + +@Override +public T get(K key, String[] fields) { +return region.get(key); +} + +@Override +public void put(K key, T obj) { +region.put(key, obj); +} + +@Override +public boolean delete(K key) { +region.destroy(key); +return true; +} + +@Override +public long deleteByQuery(Query query) throws GoraException { +try { +long deletedRows = 0; +Result result = query.execute(); +while (result.next()) { +if (delete(result.getKey())) { +deletedRows++; +} +} +LOG.info("Geode datastore deleted {} rows from Persistent datastore.", deletedRows); +return deletedRows; +} catch (Exception e) { +throw new GoraException(e); +} +} + +@Override +public Result execute(Query query) { + Review
[GitHub] [gora] himanshuacharya95 commented on a diff in pull request #273: [IN-PROGRESS] GORA-698 Geode DataStore
himanshuacharya95 commented on code in PR #273: URL: https://github.com/apache/gora/pull/273#discussion_r963144223 ## gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java: ## @@ -0,0 +1,190 @@ +package org.apache.gora.geode.store; + +import org.apache.geode.cache.*; +import org.apache.geode.cache.client.ClientCache; +import org.apache.geode.cache.client.ClientCacheFactory; +import org.apache.gora.geode.query.GeodeQuery; +import org.apache.gora.geode.query.GeodeResult; +import org.apache.gora.persistency.impl.PersistentBase; +import org.apache.gora.query.PartitionQuery; +import org.apache.gora.query.Query; +import org.apache.gora.query.Result; +import org.apache.gora.query.impl.PartitionQueryImpl; +import org.apache.gora.store.impl.DataStoreBase; +import org.apache.gora.util.GoraException; + +import java.io.IOException; +import java.util.*; +import java.util.concurrent.ConcurrentSkipListSet; + +import static org.apache.geode.cache.RegionShortcut.REPLICATE; +import static org.apache.gora.geode.store.GeodeStoreParameters.*; + + +public class GeodeStore extends DataStoreBase { + +private ClientCache clientCache; +private Region region; +private Properties geodeProperties; + + +private CacheFactory cacheFactory; + +@Override +public void initialize(Class keyClass, Class persistentClass, Properties properties) throws GoraException { +super.initialize(keyClass, persistentClass, properties); +String geodeHostName = (String) properties.get(GEODE_SERVER_HOST); +int portNumber = Integer.parseInt((String) properties.get(GEODE_SERVER_PORT)); +clientCache = new ClientCacheFactory().addPoolLocator(geodeHostName, portNumber).create(); +String userName = properties.getProperty(GEODE_USERNAME); +String password = properties.getProperty(GEODE_PASSWORD); +geodeProperties = properties; + +Properties clientProperties = clientCache.getDistributedSystem().getProperties(); +if (userName != null) { Review Comment: Added some code to throw exception -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (GORA-698) Add GEODE Support
[ https://issues.apache.org/jira/browse/GORA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600524#comment-17600524 ] ASF GitHub Bot commented on GORA-698: - himanshuacharya95 commented on code in PR #273: URL: https://github.com/apache/gora/pull/273#discussion_r963143973 ## gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java: ## @@ -0,0 +1,190 @@ +package org.apache.gora.geode.store; + +import org.apache.geode.cache.*; +import org.apache.geode.cache.client.ClientCache; +import org.apache.geode.cache.client.ClientCacheFactory; +import org.apache.gora.geode.query.GeodeQuery; +import org.apache.gora.geode.query.GeodeResult; +import org.apache.gora.persistency.impl.PersistentBase; +import org.apache.gora.query.PartitionQuery; +import org.apache.gora.query.Query; +import org.apache.gora.query.Result; +import org.apache.gora.query.impl.PartitionQueryImpl; +import org.apache.gora.store.impl.DataStoreBase; +import org.apache.gora.util.GoraException; + +import java.io.IOException; +import java.util.*; +import java.util.concurrent.ConcurrentSkipListSet; + +import static org.apache.geode.cache.RegionShortcut.REPLICATE; +import static org.apache.gora.geode.store.GeodeStoreParameters.*; + + +public class GeodeStore extends DataStoreBase { + +private ClientCache clientCache; +private Region region; +private Properties geodeProperties; + + Review Comment: Extra spaces removed > Add GEODE Support > - > > Key: GORA-698 > URL: https://issues.apache.org/jira/browse/GORA-698 > Project: Apache Gora > Issue Type: New Feature >Reporter: Himanshu >Priority: Major > > [1]https://geode.apache.org/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [gora] himanshuacharya95 commented on a diff in pull request #273: [IN-PROGRESS] GORA-698 Geode DataStore
himanshuacharya95 commented on code in PR #273: URL: https://github.com/apache/gora/pull/273#discussion_r963143973 ## gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java: ## @@ -0,0 +1,190 @@ +package org.apache.gora.geode.store; + +import org.apache.geode.cache.*; +import org.apache.geode.cache.client.ClientCache; +import org.apache.geode.cache.client.ClientCacheFactory; +import org.apache.gora.geode.query.GeodeQuery; +import org.apache.gora.geode.query.GeodeResult; +import org.apache.gora.persistency.impl.PersistentBase; +import org.apache.gora.query.PartitionQuery; +import org.apache.gora.query.Query; +import org.apache.gora.query.Result; +import org.apache.gora.query.impl.PartitionQueryImpl; +import org.apache.gora.store.impl.DataStoreBase; +import org.apache.gora.util.GoraException; + +import java.io.IOException; +import java.util.*; +import java.util.concurrent.ConcurrentSkipListSet; + +import static org.apache.geode.cache.RegionShortcut.REPLICATE; +import static org.apache.gora.geode.store.GeodeStoreParameters.*; + + +public class GeodeStore extends DataStoreBase { + +private ClientCache clientCache; +private Region region; +private Properties geodeProperties; + + Review Comment: Extra spaces removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org