[GitHub] [gora] alfonsonishikawa commented on pull request #170: GORA-271 Make consistent across datastores the way of getting the mapping filename

2020-10-20 Thread GitBox 


alfonsonishikawa commented on pull request #170:
URL: https://github.com/apache/gora/pull/170#issuecomment-713051564


   https://issues.apache.org/jira/browse/GORA-667



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] alfonsonishikawa commented on pull request #170: GORA-271 Make consistent across datastores the way of getting the mapping filename

2020-10-20 Thread GitBox 


alfonsonishikawa commented on pull request #170:
URL: https://github.com/apache/gora/pull/170#issuecomment-713051074


   The changes on this pull request disabled the desired feature to load 
mappings from configuration that allows to compile entities, functionality 
needed for gora-pig.
   The changes on this issue were not about reverting the changes made in the 
meantime between the creation of this issue and Gora 0.9, but to have the same 
methods naming and procedures to get the mapping (not just reverting the idea 
of using an InputStream instead of a File - better to use an InputStream by the 
way).
   I will create another issue to reinstate the functionality.
   
   Thank you and sorry for not having time on it's day to review it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org