[GitHub] [gora] djkevincr commented on a change in pull request #172: GORA-615: Add gora-mongodb settings to gora-tutorial
djkevincr commented on a change in pull request #172: GORA-615: Add gora-mongodb settings to gora-tutorial URL: https://github.com/apache/gora/pull/172#discussion_r286347291 ## File path: gora-tutorial/conf/gora.properties ## @@ -34,18 +34,18 @@ gora.datastore.autocreateschema=true #gora.cassandrastore.servers=localhost:9160 ##JDBC properties for gora-sql module using HSQL -gora.sqlstore.jdbc.driver=org.hsqldb.jdbcDriver +#gora.sqlstore.jdbc.driver=org.hsqldb.jdbcDriver Review comment: Shall we remove these changes? I dont think we need them as part of fix. And this is not related to issue we address with this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on a change in pull request #172: GORA-615: Add gora-mongodb settings to gora-tutorial
djkevincr commented on a change in pull request #172: GORA-615: Add gora-mongodb settings to gora-tutorial URL: https://github.com/apache/gora/pull/172#discussion_r286337341 ## File path: gora-tutorial/conf/gora.properties ## @@ -34,18 +34,18 @@ gora.datastore.autocreateschema=true #gora.cassandrastore.servers=localhost:9160 ##JDBC properties for gora-sql module using HSQL -gora.sqlstore.jdbc.driver=org.hsqldb.jdbcDriver +#gora.sqlstore.jdbc.driver=org.hsqldb.jdbcDriver ##HSQL jdbc connection as persistent in-process database -gora.sqlstore.jdbc.url=jdbc:hsqldb:file:./hsql-data +#gora.sqlstore.jdbc.url=jdbc:hsqldb:file:./hsql-data ##HSQL jdbc connection as network server #gora.sqlstore.jdbc.url=jdbc:hsqldb:hsql://localhost/goratest ##JDBC properties for gora-sql module using MySQL -#gora.sqlstore.jdbc.driver=com.mysql.jdbc.Driver -#gora.sqlstore.jdbc.url=jdbc:mysql://localhost:3306/goratest -#gora.sqlstore.jdbc.user=root -#gora.sqlstore.jdbc.password= +gora.sqlstore.jdbc.driver=com.mysql.jdbc.Driver Review comment: Shall we leave this as commented? Why do we need to change these? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on a change in pull request #172: GORA-615: Add gora-mongodb settings to gora-tutorial
djkevincr commented on a change in pull request #172: GORA-615: Add gora-mongodb settings to gora-tutorial URL: https://github.com/apache/gora/pull/172#discussion_r286337091 ## File path: gora-tutorial/conf/gora-mongodb-mapping.xml ## @@ -0,0 +1,38 @@ + + + + + + + + + + + + + + + + + + + + + Review comment: Can remove this unnecessary new lines? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
