Hi John,
Thank you for the feedback. I will work on your comments.
Regards,
Maria
On Thu, 11 Feb 2021 at 03:10, John Mora wrote:
> Hi Maria
>
> Thanks for the update.
>
> Some comments:
>
> Please use an Enum instead of literal strings for the Authentication
> Method parameter.
>
> https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/main/java/org/apache/gora/elasticsearch/store/ElasticsearchStore.java#L126
>
> Use Parameterized logging instead of string concatenation
>
> https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/main/java/org/apache/gora/elasticsearch/mapping/ElasticsearchMappingBuilder.java#L186
>
>
> Use the 'scalingFactor' attribute in the XML parsing, schema creation,
> XSD, etc.
>
> https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/main/java/org/apache/gora/elasticsearch/mapping/ElasticsearchMappingBuilder.java#L200
>
> https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/main/java/org/apache/gora/elasticsearch/mapping/Field.java#L133
>
> regards,
> John
>
> El vie, 5 feb 2021 a las 22:45, Maria Podorvanova (<
> podorvanova.ma...@gmail.com>) escribió:
>
>> Hi,
>>
>> Report #9
>> Period: January, 31 - February, 6
>> Activities:
>> - Fixed NPE when getting a non-existing Elasticsearch document
>> - Implemented serialization/deserialization for MAP Avro data type
>> - Refactored serialization/deserialization to have better javadocs and
>> arguments
>> - Implemented serialization/deserialization for RECORD Avro data type
>> - Implemented serialization/deserialization for UNION Avro data type
>> - Fixed passed Schema argument for ARRAY deserialization
>> - Fixed BYTES deserialization for Base64 encoded String
>> - Ignored testGet3UnionField test
>> - Added javadoc descriptions to serialization and deserialization methods
>> - The following tests are passing now:
>>
>>1. testPutNested
>>2. testPutArray
>>3. testPutBytes
>>4. tetsPutMap
>>5. testPutMixedMaps
>>6. testUpdate
>>7. testGetRecursive
>>8. testGetDoubleRecursive
>>9. testGetNested
>>10. testGetWithFields
>>11. testGetWebPage
>>12. testGetWebPageDefaultFields
>>13. testGetNonExisting
>>
>> - Wrote a blog post #5
>>
>> Here is the link to my code:
>> https://github.com/apache/gora/compare/master...podorvanova:gora-664.
>> Relevant commits are from February 4.
>>
>> Regards,
>> Maria
>>
>>