[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[
https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=220551=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-220551
]
ASF GitHub Bot logged work on GRIFFIN-244:
--
Author: ASF GitHub Bot
Created on: 29/Mar/19 14:27
Start Date: 29/Mar/19 14:27
Worklog Time Spent: 10m
Work Description: dershovGD commented on pull request #491: GRIFFIN-244
Get metrics by instance
URL: https://github.com/apache/griffin/pull/491#discussion_r270432048
##
File path: service/pom.xml
##
@@ -110,11 +110,11 @@ under the License.
postgresql
${postgresql.version}
-
Review comment:
I've commented it back.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 220551)
Time Spent: 0.5h (was: 20m)
> [Service, Metric]Implement possibility to get metrics for certain Job
> Instance Id
> -
>
> Key: GRIFFIN-244
> URL: https://issues.apache.org/jira/browse/GRIFFIN-244
> Project: Griffin (Incubating)
> Issue Type: New Feature
>Reporter: Dmitry Ershov
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In addition to functionality described in tasks
> https://issues.apache.org/jira/browse/GRIFFIN-240,
> https://issues.apache.org/jira/browse/GRIFFIN-233 and
> https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient
> to have a possibility to obtain the metrics for given Job Instance Id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [griffin] dershovGD commented on a change in pull request #491: GRIFFIN-244 Get metrics by instance
dershovGD commented on a change in pull request #491: GRIFFIN-244 Get metrics
by instance
URL: https://github.com/apache/griffin/pull/491#discussion_r270432048
##
File path: service/pom.xml
##
@@ -110,11 +110,11 @@ under the License.
postgresql
${postgresql.version}
-
Review comment:
I've commented it back.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[ https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=220550=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-220550 ] ASF GitHub Bot logged work on GRIFFIN-244: -- Author: ASF GitHub Bot Created on: 29/Mar/19 14:26 Start Date: 29/Mar/19 14:26 Worklog Time Spent: 10m Work Description: dershovGD commented on pull request #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#discussion_r270431694 ## File path: service/src/main/java/org/apache/griffin/core/exception/GriffinExceptionMessage.java ## @@ -72,7 +72,9 @@ Licensed to the Apache Software Foundation (ASF) under one HDFS_FILE_NOT_EXIST(40407, "Hadoop data file not exist"), -PREDICATE_TYPE_NOT_FOUND(40408, "Unknown predicate type"), +JOB_INSTANCE_NOT_FOUND(40408, "No job instances with given job instance id found"), + +PREDICATE_TYPE_NOT_FOUND(40409, "Unknown predicate type"), Review comment: Done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 220550) Time Spent: 20m (was: 10m) > [Service, Metric]Implement possibility to get metrics for certain Job > Instance Id > - > > Key: GRIFFIN-244 > URL: https://issues.apache.org/jira/browse/GRIFFIN-244 > Project: Griffin (Incubating) > Issue Type: New Feature >Reporter: Dmitry Ershov >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > In addition to functionality described in tasks > https://issues.apache.org/jira/browse/GRIFFIN-240, > https://issues.apache.org/jira/browse/GRIFFIN-233 and > https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient > to have a possibility to obtain the metrics for given Job Instance Id. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [griffin] dershovGD commented on a change in pull request #491: GRIFFIN-244 Get metrics by instance
dershovGD commented on a change in pull request #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#discussion_r270431694 ## File path: service/src/main/java/org/apache/griffin/core/exception/GriffinExceptionMessage.java ## @@ -72,7 +72,9 @@ Licensed to the Apache Software Foundation (ASF) under one HDFS_FILE_NOT_EXIST(40407, "Hadoop data file not exist"), -PREDICATE_TYPE_NOT_FOUND(40408, "Unknown predicate type"), +JOB_INSTANCE_NOT_FOUND(40408, "No job instances with given job instance id found"), + +PREDICATE_TYPE_NOT_FOUND(40409, "Unknown predicate type"), Review comment: Done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[ https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=220527=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-220527 ] ASF GitHub Bot logged work on GRIFFIN-244: -- Author: ASF GitHub Bot Created on: 29/Mar/19 13:35 Start Date: 29/Mar/19 13:35 Worklog Time Spent: 10m Work Description: RodionGork commented on pull request #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#discussion_r270405608 ## File path: service/src/main/java/org/apache/griffin/core/exception/GriffinExceptionMessage.java ## @@ -72,7 +72,9 @@ Licensed to the Apache Software Foundation (ASF) under one HDFS_FILE_NOT_EXIST(40407, "Hadoop data file not exist"), -PREDICATE_TYPE_NOT_FOUND(40408, "Unknown predicate type"), +JOB_INSTANCE_NOT_FOUND(40408, "No job instances with given job instance id found"), + +PREDICATE_TYPE_NOT_FOUND(40409, "Unknown predicate type"), Review comment: This probably makes duplication with the next one. At least when requesting non-existing instance, I got `Unknown predicate type` in response :o This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 220527) Time Spent: 10m Remaining Estimate: 0h > [Service, Metric]Implement possibility to get metrics for certain Job > Instance Id > - > > Key: GRIFFIN-244 > URL: https://issues.apache.org/jira/browse/GRIFFIN-244 > Project: Griffin (Incubating) > Issue Type: New Feature >Reporter: Dmitry Ershov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > In addition to functionality described in tasks > https://issues.apache.org/jira/browse/GRIFFIN-240, > https://issues.apache.org/jira/browse/GRIFFIN-233 and > https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient > to have a possibility to obtain the metrics for given Job Instance Id. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[
https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=220528=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-220528
]
ASF GitHub Bot logged work on GRIFFIN-244:
--
Author: ASF GitHub Bot
Created on: 29/Mar/19 13:35
Start Date: 29/Mar/19 13:35
Worklog Time Spent: 10m
Work Description: RodionGork commented on pull request #491: GRIFFIN-244
Get metrics by instance
URL: https://github.com/apache/griffin/pull/491#discussion_r270409323
##
File path: service/pom.xml
##
@@ -110,11 +110,11 @@ under the License.
postgresql
${postgresql.version}
-
Review comment:
let's revert it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 220528)
Time Spent: 10m
Remaining Estimate: 0h
> [Service, Metric]Implement possibility to get metrics for certain Job
> Instance Id
> -
>
> Key: GRIFFIN-244
> URL: https://issues.apache.org/jira/browse/GRIFFIN-244
> Project: Griffin (Incubating)
> Issue Type: New Feature
>Reporter: Dmitry Ershov
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In addition to functionality described in tasks
> https://issues.apache.org/jira/browse/GRIFFIN-240,
> https://issues.apache.org/jira/browse/GRIFFIN-233 and
> https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient
> to have a possibility to obtain the metrics for given Job Instance Id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [griffin] RodionGork commented on a change in pull request #491: GRIFFIN-244 Get metrics by instance
RodionGork commented on a change in pull request #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#discussion_r270405608 ## File path: service/src/main/java/org/apache/griffin/core/exception/GriffinExceptionMessage.java ## @@ -72,7 +72,9 @@ Licensed to the Apache Software Foundation (ASF) under one HDFS_FILE_NOT_EXIST(40407, "Hadoop data file not exist"), -PREDICATE_TYPE_NOT_FOUND(40408, "Unknown predicate type"), +JOB_INSTANCE_NOT_FOUND(40408, "No job instances with given job instance id found"), + +PREDICATE_TYPE_NOT_FOUND(40409, "Unknown predicate type"), Review comment: This probably makes duplication with the next one. At least when requesting non-existing instance, I got `Unknown predicate type` in response :o This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [griffin] RodionGork commented on a change in pull request #491: GRIFFIN-244 Get metrics by instance
RodionGork commented on a change in pull request #491: GRIFFIN-244 Get metrics
by instance
URL: https://github.com/apache/griffin/pull/491#discussion_r270409323
##
File path: service/pom.xml
##
@@ -110,11 +110,11 @@ under the License.
postgresql
${postgresql.version}
-
Review comment:
let's revert it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [griffin] dershovGD opened a new pull request #491: Get metrics by instance
dershovGD opened a new pull request #491: Get metrics by instance URL: https://github.com/apache/griffin/pull/491 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
