[
https://issues.apache.org/jira/browse/GRIFFIN-240?focusedWorklogId=224250=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-224250
]
ASF GitHub Bot logged work on GRIFFIN-240:
--
Author: ASF GitHub Bot
Created on: 08/Apr/19 08:59
Start Date: 08/Apr/19 08:59
Worklog Time Spent: 10m
Work Description: RodionGork commented on pull request #494: GRIFFIN-240
trigger returns triggerkey
URL: https://github.com/apache/griffin/pull/494#discussion_r272945748
##
File path:
service/src/main/java/org/apache/griffin/core/job/repo/JobInstanceRepo.java
##
@@ -53,4 +53,6 @@ Licensed to the Apache Software Foundation (ASF) under one
@Query("select DISTINCT s from JobInstanceBean s where s.state in ?1")
List findByActiveState(State[] states);
+
+List findByTriggerKey(String triggerKey);
Review comment:
@chemikadze I've added `@Index` annotation, however it will only create
index when the table is created - not when it is just modified by adding
column. This should be ok, though.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 224250)
Time Spent: 4h 20m (was: 4h 10m)
> [Service] Return JobInstance in response to a call Trigger job by id
> -
>
> Key: GRIFFIN-240
> URL: https://issues.apache.org/jira/browse/GRIFFIN-240
> Project: Griffin
> Issue Type: Improvement
>Reporter: Aleksandr Borgatin
>Priority: Major
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> The proposal is following: in response of method "/jobs/trigger/\{id}" to
> return JobInstance
> {code:java}
> @RequestMapping(value = "/jobs/trigger/{id}", method = RequestMethod.POST)
> @ResponseStatus(HttpStatus.OK)
> public JobInstanceBean triggerJob(@PathVariable("id") Long id) throws
> SchedulerException
> { return jobService.triggerJobById(id); }{code}
> Now this method looks like this
> {code:java}
> @RequestMapping(value = "/jobs/trigger/{id}", method = RequestMethod.POST)
> @ResponseStatus(HttpStatus.NO_CONTENT)
> public void triggerJob(@PathVariable("id") Long id) throws
> SchedulerException {
> jobService.triggerJobById(id);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
