[jira] [Updated] (GRIFFIN-187) Support Empty String in Profiling Measure

2018-08-01 Thread Spencer Hivert (JIRA)


 [ 
https://issues.apache.org/jira/browse/GRIFFIN-187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Spencer Hivert updated GRIFFIN-187:
---
Priority: Minor  (was: Major)

> Support Empty String in Profiling Measure
> -
>
> Key: GRIFFIN-187
> URL: https://issues.apache.org/jira/browse/GRIFFIN-187
> Project: Griffin (Incubating)
>  Issue Type: New Feature
>Reporter: Spencer Hivert
>Priority: Minor
>
> Here at Credit Karma, we've discovered that it's also useful to check if the 
> string is empty. We were originally using the null count functionality 
> however we were mislead as the field was not null, but rather empty.
> Add the ability to check for empty strings!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GRIFFIN-140) [Measure] Support validity as a new feature

2018-08-01 Thread Spencer Hivert (JIRA)


[ 
https://issues.apache.org/jira/browse/GRIFFIN-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566038#comment-16566038
 ] 

Spencer Hivert commented on GRIFFIN-140:


[~Lionel_3L] Is there any update on this?

We're looking to implement this feature at Credit Karma and would love to know 
what your plans for it were!

Thanks,
Spencer!

> [Measure] Support validity as a new feature
> ---
>
> Key: GRIFFIN-140
> URL: https://issues.apache.org/jira/browse/GRIFFIN-140
> Project: Griffin (Incubating)
>  Issue Type: New Feature
>Reporter: Lionel Liu
>Assignee: Lionel Liu
>Priority: Major
> Fix For: 1.0.0-incubating
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> Validity measures the percentage of items match the rules user defined from a 
> data source itself.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GRIFFIN-187) Support Empty String in Profiling Measure

2018-08-01 Thread Spencer Hivert (JIRA)
Spencer Hivert created GRIFFIN-187:
--

 Summary: Support Empty String in Profiling Measure
 Key: GRIFFIN-187
 URL: https://issues.apache.org/jira/browse/GRIFFIN-187
 Project: Griffin (Incubating)
  Issue Type: New Feature
Reporter: Spencer Hivert


Here at Credit Karma, we've discovered that it's also useful to check if the 
string is empty. We were originally using the null count functionality however 
we were mislead as the field was not null, but rather empty.

Add the ability to check for empty strings!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GRIFFIN-164) Make 'Regular expression detection count' available in UI

2018-08-01 Thread Spencer Hivert (JIRA)


[ 
https://issues.apache.org/jira/browse/GRIFFIN-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565721#comment-16565721
 ] 

Spencer Hivert commented on GRIFFIN-164:


I agree, this feature would be quite useful!

I'm working on this right now!



> Make 'Regular expression detection count' available in UI
> -
>
> Key: GRIFFIN-164
> URL: https://issues.apache.org/jira/browse/GRIFFIN-164
> Project: Griffin (Incubating)
>  Issue Type: Improvement
>Affects Versions: 0.1.6-incubating
>Reporter: Enrico D'Urso
>Priority: Minor
> Fix For: 1.0.0-incubating
>
>
> Hi,
> I have been playing for one month now with Griffin.
> Given my experience, some companies (included the one am working for as a 
> consultant) prefer doing stuff using UI.
> Personally, I find very useful the following feature:
>  
>  * Regular expression detection count
> which is, I have a column which should contain just numbers so I want to 
> check if my ETL process, wrongly, has populated my table with non-numeric 
> values.
> I have been able to run such a job creating my self the right config.json, in 
> particular, using spark-sql as dialect:
> {code:java}
> select count(*) from src where account_id rlike [^0-9]  
> {code}
> I saw that in pr.component.ts there is a commented line of code:
> {code:java}
> // {"id":10,"itemName":"Regular Expression Detection Count","category": 
> "Advanced Statistics"}
> {code}
> which I think is what I am talking about.
> Also, I can read:
> {code:java}
> // case 'Regular Expression Detection Count': // return 
> 'count(source.`'+col.name+'`) where source.`'+col.name+'` LIKE ';
> {code}
> which should be the griffin-dsl dialect, even if, probably, the regex should 
> be added just after LIKE.
> Then, once that the above griffin-dsl statement is available in the backend, 
> ProfilingRulePlanTrans class
> should map that into 'rlike' Spark-sql clause.
> Am not sure where (and if) ProfilingRulePlanTrans should be modified as 
> preGroupbyClause should contains everything, but I do not have enough 
> knowledge about it.
>  
> Please judge yourself the priority of such a feature, which knowing well the 
> code, should not be too hard to make.
> Thanks,
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GRIFFIN-186) [UI] Re-Factor Profiling Measure Creation

2018-08-01 Thread Spencer Hivert (JIRA)
Spencer Hivert created GRIFFIN-186:
--

 Summary: [UI] Re-Factor Profiling Measure Creation
 Key: GRIFFIN-186
 URL: https://issues.apache.org/jira/browse/GRIFFIN-186
 Project: Griffin (Incubating)
  Issue Type: Improvement
Reporter: Spencer Hivert


The current code structure contained in 
"/incubator-griffin/ui/angular/src/app/measure/create-measure/pr" is confusing 
and difficult to work with.

Each step should have a separate component rather than combining all into a 
single component.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)