[jira] [Commented] (GRIFFIN-202) Allow viewing of raw measure details from UI

2018-10-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/GRIFFIN-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649934#comment-16649934
 ] 

ASF GitHub Bot commented on GRIFFIN-202:


Github user asfgit closed the pull request at:

https://github.com/apache/incubator-griffin/pull/437


> Allow viewing of raw measure details from UI
> 
>
> Key: GRIFFIN-202
> URL: https://issues.apache.org/jira/browse/GRIFFIN-202
> Project: Griffin (Incubating)
>  Issue Type: Improvement
>Reporter: Nikolay Sokolov
>Assignee: Nikolay Sokolov
>Priority: Minor
> Fix For: 0.3.1-incubating
>
>
> Sometimes it's desirable to see raw JSON of specific measure. This is 
> especially useful when custom measurements are created from API.
> Two implementations are possible (one or even both can be implemented):
> * show link with URL of measure details API on UI
> * add section under "Mapping Rules", showing formatted plain text of API 
> response on UI



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GRIFFIN-202) Allow viewing of raw measure details from UI

2018-10-14 Thread Nikolay Sokolov (JIRA)


[ 
https://issues.apache.org/jira/browse/GRIFFIN-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649480#comment-16649480
 ] 

Nikolay Sokolov commented on GRIFFIN-202:
-

Went with second approach, exposed to UI: 
https://github.com/apache/incubator-griffin/pull/437

[~Lionel_3L] sometimes full text is required, for example when creating custom 
profiling with multiple input datasets (not just src). I've made a switch on 
that screen, with only rules shown by default, to accommodate both cases.

[~guoyp] thank you, that's important clarification. Went with simple HTML for 
now.

> Allow viewing of raw measure details from UI
> 
>
> Key: GRIFFIN-202
> URL: https://issues.apache.org/jira/browse/GRIFFIN-202
> Project: Griffin (Incubating)
>  Issue Type: Improvement
>Reporter: Nikolay Sokolov
>Assignee: Nikolay Sokolov
>Priority: Minor
>
> Sometimes it's desirable to see raw JSON of specific measure. This is 
> especially useful when custom measurements are created from API.
> Two implementations are possible (one or even both can be implemented):
> * show link with URL of measure details API on UI
> * add section under "Mapping Rules", showing formatted plain text of API 
> response on UI



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GRIFFIN-202) Allow viewing of raw measure details from UI

2018-10-09 Thread William Guo (JIRA)


[ 
https://issues.apache.org/jira/browse/GRIFFIN-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642931#comment-16642931
 ] 

William Guo commented on GRIFFIN-202:
-

we can leverage some open source widgets, but we need to pay attention to their 
license.

if you have some candidates, please discuss in dev mailing list, or we need to 
ensure its compliance with apache license 2.0.

please check this document for license segment.

https://cwiki.apache.org/confluence/display/GRIFFIN/5.+How+to+Verify+Release+Package

Thanks,
William 

> Allow viewing of raw measure details from UI
> 
>
> Key: GRIFFIN-202
> URL: https://issues.apache.org/jira/browse/GRIFFIN-202
> Project: Griffin (Incubating)
>  Issue Type: Improvement
>Reporter: Nikolay Sokolov
>Priority: Minor
>
> Sometimes it's desirable to see raw JSON of specific measure. This is 
> especially useful when custom measurements are created from API.
> Two implementations are possible (one or even both can be implemented):
> * show link with URL of measure details API on UI
> * add section under "Mapping Rules", showing formatted plain text of API 
> response on UI



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GRIFFIN-202) Allow viewing of raw measure details from UI

2018-10-07 Thread Lionel Liu (JIRA)


[ 
https://issues.apache.org/jira/browse/GRIFFIN-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641359#comment-16641359
 ] 

Lionel Liu commented on GRIFFIN-202:


This could be useful for users, I agree on it. The textual format of measure 
details just describes the measure, which is something like a template of its 
jobs. 
The textual format might not provide any more information than current table 
format, no matter in JSON or YAML, but in this way, we can consider to enable 
users create customized measurements in textual format. That would be a great 
enhancement.
Considering this, in the textual format, I prefer only showing the necessary 
fields of measure, just the same as the measure creation.

> Allow viewing of raw measure details from UI
> 
>
> Key: GRIFFIN-202
> URL: https://issues.apache.org/jira/browse/GRIFFIN-202
> Project: Griffin (Incubating)
>  Issue Type: Improvement
>Reporter: Nikolay Sokolov
>Priority: Minor
>
> Sometimes it's desirable to see raw JSON of specific measure. This is 
> especially useful when custom measurements are created from API.
> Two implementations are possible (one or even both can be implemented):
> * show link with URL of measure details API on UI
> * add section under "Mapping Rules", showing formatted plain text of API 
> response on UI



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GRIFFIN-202) Allow viewing of raw measure details from UI

2018-10-07 Thread Nikolay Sokolov (JIRA)


[ 
https://issues.apache.org/jira/browse/GRIFFIN-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641323#comment-16641323
 ] 

Nikolay Sokolov commented on GRIFFIN-202:
-

Probably showing rules as YAML rather than JSON might be even better. That's 
not a true "plain text of API response", however should make it more readable. 
Probably we could have json/yaml switch on UI.

> Allow viewing of raw measure details from UI
> 
>
> Key: GRIFFIN-202
> URL: https://issues.apache.org/jira/browse/GRIFFIN-202
> Project: Griffin (Incubating)
>  Issue Type: Improvement
>Reporter: Nikolay Sokolov
>Priority: Minor
>
> Sometimes it's desirable to see raw JSON of specific measure. This is 
> especially useful when custom measurements are created from API.
> Two implementations are possible (one or even both can be implemented):
> * show link with URL of measure details API on UI
> * add section under "Mapping Rules", showing formatted plain text of API 
> response on UI



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)