HTTP header authentication logout page
Hello Guys, Trying to link Guacamole with an OpenID server, I finally moved to a http header solution. Filtering the appropriate header, it works quite well compared to OpenID that was failing or not behaving properly. However, there is still an problem that is : Guacamole/Logout. The default action is to DELE Guacamole tokens, which is not applicable with auth header authentification. Would it be possible to simply have another parameter permitting to change the logout URL ? Possible based on other field (token_id in headers/environnements) ? Thanks in advance Brgrds
Re: Guacamole extensión MongoDB
On Mon, Nov 26, 2018 at 5:59 PM Daniel Quirant Rico < daniel.quirant.r...@gmail.com> wrote: > Hello, > > I have been absent for a while and I am going to resume this project. > I would like to know if any progress has been made in this regard and > I need to document beforehand. > The Jira were GUACAMOLE-605 and GUACAMOLE-617. > I hope to be active soon and continue with this great project. > > I haven't personally worked on these, and have not seen anything from anyone else indicating progress on these, so I think it's all up to you! :-D -Nick
Change the loglevel to DEBUG
Hi all, I am running Guacamole in docker containers: guacamole container and guacd. Can you please let me know how I can change the Loglevel to DEBUG? I checked the documentation and looks like the we will have to edit this file on the docker host:Which the file doesn't exist on the docker host. Can you please advise how this can be done? Thanks /etc/docker/daemon.json
[GitHub] guacamole-server pull request #205: GUACAMOLE-667: Enable loading configurat...
Github user andrzejdoro commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/205#discussion_r236648814
--- Diff: src/guacd/conf-args.c ---
@@ -122,3 +128,15 @@ int guacd_conf_parse_args(guacd_config* config, int
argc, char** argv) {
}
+const char* guacd_conf_get_path(int argc, char** argv) {
+
+/* Find -c option */
+int i;
+for(i=1; i Why not parse within `guacd_conf_parse_args()` fully leveraging
`getopt()`?
We need to find out what is the path to the configuration file before we
parse command line arguments, since we have to apply any settings from config
file before we apply any settings from command line (the latter overrides the
former).
Running `while(getopt(...)...)` may cause permutation of arguments, that's
why I've decided to manually parse arguments list.
> Couldn't this setting live on the `guacd_config` struct like the others?
I believe that `guacd_config` struct should store contents of a guacd
configuration file so storing path to the configuration file is not needed
inside it. We use it only once - when loading configuration file.
---
[GitHub] guacamole-server pull request #205: GUACAMOLE-667: Enable loading configurat...
Github user andrzejdoro commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/205#discussion_r236644989
--- Diff: src/guacd/conf-file.c ---
@@ -188,15 +188,21 @@ guacd_config* guacd_conf_load() {
conf->key_file = NULL;
#endif
+/* Determine path of configuration file */
+if(conf_file_path == NULL) {
--- End diff --
I agree that this process could be improved.
Should it be done in separate pull-request or can I just add a new commit?
---
[GitHub] guacamole-server pull request #205: GUACAMOLE-667: Enable loading configurat...
Github user andrzejdoro commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/205#discussion_r236634682
--- Diff: src/guacd/conf-file.c ---
@@ -188,15 +188,21 @@ guacd_config* guacd_conf_load() {
conf->key_file = NULL;
#endif
+/* Determine path of configuration file */
+if(conf_file_path == NULL) {
+conf_file_path = getenv("GUACD_CONF_FILE");
--- End diff --
This is extension - one can define `"GUACD_CONF_FILE"` environment
variable, and if it is not present there, then `GUACD_CONF_FILE` constant is
used (as it was done before) - see one line below.
This enables specifying path to config file by "-c" argument or by
environment variable (both approaches are quite common, we can discard one of
them).
---
[GitHub] guacamole-server pull request #205: GUACAMOLE-667: Enable loading configurat...
Github user andrzejdoro commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/205#discussion_r236626064
--- Diff: src/guacd/conf-args.c ---
@@ -122,3 +128,15 @@ int guacd_conf_parse_args(guacd_config* config, int
argc, char** argv) {
}
+const char* guacd_conf_get_path(int argc, char** argv) {
+
+/* Find -c option */
+int i;
+for(i=1; i
[GitHub] guacamole-server pull request #205: GUACAMOLE-667: Enable loading configurat...
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/205#discussion_r23656
--- Diff: src/guacd/conf-file.c ---
@@ -188,15 +188,21 @@ guacd_config* guacd_conf_load() {
conf->key_file = NULL;
#endif
+/* Determine path of configuration file */
+if(conf_file_path == NULL) {
--- End diff --
> Why do this particular check, here? Why not always make sure this
function is fed a path, and then upstream feed either the provided location or
the constant `GUACD_CONF_FILE`?
I agree with this. This doesn't seem the place for a `NULL` check and
additional semantics. It would be far better if the default value for the
config file path were handled like other defaults.
I'd argue that it's the current handling of defaults that should be
restructured - bringing that out of `guacd_conf_load()` such that the process
becomes:
1. Populate `guacd_config` with defaults.
2. Apply any settings from config file to that `guacd_config`, overriding
default values.
3. Apply any settings from command line to that `guacd_config`, overriding
default values and those from the config file.
See:
https://github.com/apache/guacamole-server/blob/bbb6afaf462f6930a589f962302806c52f350c0b/src/guacd/conf-file.c#L178-L184
---
[GitHub] guacamole-server pull request #205: GUACAMOLE-667: Enable loading configurat...
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/205#discussion_r236553937
--- Diff: src/guacd/conf-args.c ---
@@ -122,3 +128,15 @@ int guacd_conf_parse_args(guacd_config* config, int
argc, char** argv) {
}
+const char* guacd_conf_get_path(int argc, char** argv) {
+
+/* Find -c option */
+int i;
+for(i=1; i
